30858 2009-10-28 05:55:11 -0700 Allow custom memory allocation control for WebCore's RareData 2009-10-29 08:46:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned oldest_to_newest 158543 0 zoltan 2009-10-28 05:55:11 -0700 Inherits RareData struct from FastAllocBase because it has been instantiated by 'new' in WebCore/css/CSSSelector.h:259. 158544 1 42023 zoltan 2009-10-28 05:56:34 -0700 Created attachment 42023 proposed patch 158557 2 42023 darin 2009-10-28 07:47:02 -0700 Comment on attachment 42023 proposed patch For any of these there is no need to be copyable, it may be more appropriate to inherit from Noncopyable than from FastAllocBase. This is one of those examples. 158852 3 42086 zoltan 2009-10-29 03:16:24 -0700 Created attachment 42086 updated to Noncopyable 158913 4 zoltan 2009-10-29 08:46:33 -0700 Landed in 50274. https://trac.webkit.org/changeset/50274 42023 2009-10-28 05:56:34 -0700 2009-10-29 03:16:24 -0700 proposed patch RareData.patch text/plain 1151 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDIxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMjggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYkNvcmUncyBSYXJl RGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA4 NTgKKworICAgICAgICBJbmhlcml0cyBSYXJlRGF0YSBzdHJ1Y3QgZnJvbSBGYXN0QWxsb2NCYXNl IGJlY2F1c2UgaXQgaGFzIGJlZW4KKyAgICAgICAgaW5zdGFudGlhdGVkIGJ5ICduZXcnIGluIFdl YkNvcmUvY3NzL0NTU1NlbGVjdG9yLmg6MjU5LgorCisgICAgICAgICogY3NzL0NTU1NlbGVjdG9y Lmg6CisKIDIwMDktMTAtMjYgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2Vs ZmlzaC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL2Nzcy9DU1NTZWxlY3Rvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU1NlbGVj dG9yLmgJKHJldmlzaW9uIDUwMjEzKQorKysgV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAkod29y a2luZyBjb3B5KQpAQCAtMjMwLDcgKzIzMCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAg ICAgICB2b2lkIGV4dHJhY3RQc2V1ZG9UeXBlKCkgY29uc3Q7CiAKLSAgICAgICAgc3RydWN0IFJh cmVEYXRhIHsKKyAgICAgICAgc3RydWN0IFJhcmVEYXRhIDogRmFzdEFsbG9jQmFzZSB7CiAgICAg ICAgICAgICBSYXJlRGF0YShDU1NTZWxlY3RvciogdGFnSGlzdG9yeSkKICAgICAgICAgICAgICAg ICA6IG1fdGFnSGlzdG9yeSh0YWdIaXN0b3J5KQogICAgICAgICAgICAgICAgICwgbV9zaW1wbGVT ZWxlY3RvcigwKQo= 42086 2009-10-29 03:16:24 -0700 2009-10-29 08:19:38 -0700 updated to Noncopyable RareData.patch text/plain 1169 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWxs b3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYkNvcmUncyBSYXJlRGF0 YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA4NTgK KworICAgICAgICBJbmhlcml0cyBSYXJlRGF0YSBzdHJ1Y3QgZnJvbSBOb25jb3B5YWJsZSBiZWNh dXNlIGl0IGlzCisgICAgICAgIGluc3RhbnRpYXRlZCBieSAnbmV3JyBpbiBXZWJDb3JlL2Nzcy9D U1NTZWxlY3Rvci5oOjI1OSBhbmQgCisgICAgICAgIGl0IGlzIG5vIG5lZWQgdG8gYmUgY29weWFi bGUuCisKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3IuaDoKKwogMjAwOS0xMC0yOSAgRGFuIEJl cm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFRpZ2VyIGJ1aWxkIGZpeCBhZnRl ciByNTAyNTkKSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAkocmV2aXNpb24gNTAyNjUpCisrKyBXZWJDb3JlL2Nz cy9DU1NTZWxlY3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzAsNyArMjMwLDcgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgZXh0cmFjdFBzZXVkb1R5cGUoKSBjb25zdDsK IAotICAgICAgICBzdHJ1Y3QgUmFyZURhdGEgeworICAgICAgICBzdHJ1Y3QgUmFyZURhdGEgOiBO b25jb3B5YWJsZSB7CiAgICAgICAgICAgICBSYXJlRGF0YShDU1NTZWxlY3RvciogdGFnSGlzdG9y eSkKICAgICAgICAgICAgICAgICA6IG1fdGFnSGlzdG9yeSh0YWdIaXN0b3J5KQogICAgICAgICAg ICAgICAgICwgbV9zaW1wbGVTZWxlY3RvcigwKQo=