30844 2009-10-27 23:31:23 -0700 Web Inspector: Move runAfterPendingDispatches to TestController for Clarity 2009-10-27 23:46:07 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned bweinstein joepeck pfeldman rik timothy oldest_to_newest 158472 0 joepeck 2009-10-27 23:31:23 -0700 runAfterPendingDispatches is currently only used in tests and makes sense in that context. There doesn't seem to be a use case outside of tests. Therefore moving it to TestController seems to make more sense. 158473 1 42003 joepeck 2009-10-27 23:38:03 -0700 Created attachment 42003 [PATCH] Moved to TestController as an Instance Method 158475 2 joepeck 2009-10-27 23:46:07 -0700 Landed in http://trac.webkit.org/changeset/50199 r50199 = 1596738e84c303189be7072b3828a11340612074 Also update my documentation: http://bogojoker.com/inspector/inspector_tests/#_testcontroller_object 42003 2009-10-27 23:38:03 -0700 2009-10-27 23:40:37 -0700 [PATCH] Moved to TestController as an Instance Method move.patch text/plain 3324 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYjlkZjFhLi44NzZhMGU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MjcgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBNb3ZlIHJ1 bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMgdG8gVGVzdENvbnRyb2xsZXIgZm9yIENsYXJpdHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODQ0CisKKyAg ICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS1mb3JtYXQtY29sbGVjdGlvbnMuaHRtbDogdXBkYXRl ZCB0byByZWZsZWN0IFRlc3RDb250cm9sbGVyIGNoYW5nZQorCiAyMDA5LTEwLTI3ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgTm8gcmV2aWV3LgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtZm9ybWF0LWNvbGxlY3Rpb25z Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS1mb3JtYXQtY29sbGVjdGlvbnMu aHRtbAppbmRleCAzNWE5NmRmLi45MzE1NGI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvY29uc29sZS1mb3JtYXQtY29sbGVjdGlvbnMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvY29uc29sZS1mb3JtYXQtY29sbGVjdGlvbnMuaHRtbApAQCAtNjIsNyArNjIsNyBA QCBUZXN0cyB0aGF0IGNvbnNvbGUgbmljZWx5IGZvcm1hdHMgSFRNTCBDb2xsZWN0aW9ucyBhbmQg Tm9kZUxpc3RzLgogZnVuY3Rpb24gZHVtcE1lc3NhZ2VzKHRlc3RDb250cm9sbGVyKQogewogICAg IHRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKLSAgICBXZWJJbnNwZWN0b3IucnVuQWZ0 ZXJQZW5kaW5nRGlzcGF0Y2hlcyhmdW5jdGlvbigpIHsKKyAgICB0ZXN0Q29udHJvbGxlci5ydW5B ZnRlclBlbmRpbmdEaXNwYXRjaGVzKGZ1bmN0aW9uKCkgewogICAgICAgICB2YXIgcmVzdWx0ID0g W107CiAgICAgICAgIHZhciBtZXNzYWdlcyA9IFdlYkluc3BlY3Rvci5jb25zb2xlLm1lc3NhZ2Vz OwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IG1lc3NhZ2VzLmxlbmd0aDsgKytpKQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ODQ4 NTU1Li41MTFiM2MyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTEwLTI3ICBKb3NlcGggUGVjb3Jhcm8g IDxqb2VwZWNrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTW92ZSBydW5BZnRlclBlbmRpbmdEaXNwYXRj aGVzIHRvIFRlc3RDb250cm9sbGVyIGZvciBDbGFyaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDg0NAorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9UZXN0Q29udHJvbGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXN0Q29u dHJvbGxlci5wcm90b3R5cGUucnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyk6CisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6IG1vdmVkIHJ1bkFmdGVyUGVuZGluZ0Rp c3BhdGNoZXMKKwogMjAwOS0xMC0yNyAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXN0Q29udHJvbGxlci5qcyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UZXN0Q29udHJvbGxlci5qcwppbmRleCA4ZGE1OWU3Li4xMmUxYWM3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGVzdENvbnRyb2xsZXIu anMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rlc3RDb250cm9sbGVyLmpzCkBA IC00NCw2ICs0NCwxNiBAQCBXZWJJbnNwZWN0b3IuVGVzdENvbnRyb2xsZXIucHJvdG90eXBlID0g ewogICAgIHsKICAgICAgICAgdmFyIG1lc3NhZ2UgPSB0eXBlb2YgcmVzdWx0ID09PSAidW5kZWZp bmVkIiA/ICI8dW5kZWZpbmVkPiIgOiBKU09OLnN0cmluZ2lmeShyZXN1bHQpOwogICAgICAgICBJ bnNwZWN0b3JDb250cm9sbGVyLmRpZEV2YWx1YXRlRm9yVGVzdEluRnJvbnRlbmQodGhpcy5fY2Fs bElkLCBtZXNzYWdlKTsKKyAgICB9LAorCisgICAgcnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlczog ZnVuY3Rpb24oY2FsbGJhY2spCisgICAgeworICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLnBlbmRp bmdEaXNwYXRjaGVzID09PSAwKSB7CisgICAgICAgICAgICBjYWxsYmFjaygpOworICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgc2V0VGltZW91dCh0aGlzLnJ1bkFmdGVy UGVuZGluZ0Rpc3BhdGNoZXMuYmluZCh0aGlzKSwgMCwgY2FsbGJhY2spOwogICAgIH0KIH0KIApk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKaW5kZXggZGE2Njk3Yy4uNDI0 MTM5ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC01MDQs MTYgKzUwNCw2IEBAIFdlYkluc3BlY3Rvci5kaXNwYXRjaCA9IGZ1bmN0aW9uKCkgewogICAgIHNl dFRpbWVvdXQoZGVsYXlEaXNwYXRjaCwgMCk7CiB9CiAKLVdlYkluc3BlY3Rvci5ydW5BZnRlclBl bmRpbmdEaXNwYXRjaGVzID0gZnVuY3Rpb24oY2FsbGJhY2spCi17Ci0gICAgaWYgKFdlYkluc3Bl Y3Rvci5wZW5kaW5nRGlzcGF0Y2hlcyA9PT0gMCkgewotICAgICAgICBjYWxsYmFjaygpOwotICAg ICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgc2V0VGltZW91dChXZWJJbnNwZWN0b3IucnVuQWZ0 ZXJQZW5kaW5nRGlzcGF0Y2hlcywgMCwgY2FsbGJhY2spOwotfQotCiBXZWJJbnNwZWN0b3Iud2lu ZG93VW5sb2FkID0gZnVuY3Rpb24oZXZlbnQpCiB7CiAgICAgSW5zcGVjdG9yQ29udHJvbGxlci53 aW5kb3dVbmxvYWRpbmcoKTsK