30843 2009-10-27 20:48:59 -0700 WAI-ARIA: add support for 'option' role 2009-10-29 13:39:02 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach eric oldest_to_newest 158464 0 cfleizach 2009-10-27 20:48:59 -0700 WAI-ARIA: add support for 'option' role * NOTES http://www.w3.org/TR/wai-aria/#option Equivalent semantics to HTML option 158471 1 42002 cfleizach 2009-10-27 23:23:59 -0700 Created attachment 42002 patch 158474 2 42002 darin 2009-10-27 23:45:21 -0700 Comment on attachment 42002 patch Does the test case test the "canHaveChildren = false" aspect of this patch? By the way, for an override like AccessibilityListBoxOption’s canHaveChildren, which always returns a constant, I suggest private visibility rather than public. Anyone who has an AccessibilityListOption* already won't want to call the function, so it can be private. And anyone who has a pointer to the base class will still be able to call the function and get the override version. r=me 158815 3 cfleizach 2009-10-28 19:24:06 -0700 i will modify the test to also test the canHaveChildren feature 158817 4 cfleizach 2009-10-28 19:49:28 -0700 http://trac.webkit.org/changeset/50256 159049 5 eric 2009-10-29 13:39:02 -0700 Looks like this was landed. Closing. 42002 2009-10-27 23:23:59 -0700 2009-10-27 23:45:20 -0700 patch patch.txt text/plain 6344 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDE5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMjcgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXQUktQVJJQTogYWRkIHN1cHBvcnQgZm9yICdvcHRpb24nIHJvbGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODQzCisKKyAgICAgICAgVGVzdDog YWNjZXNzaWJpbGl0eS9hcmlhLW9wdGlvbi1yb2xlLmh0bWwKKworICAgICAgICAqIGFjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRpb24uaDoKKyAgICAgICAgKFdlYkNvcmU6OkFj Y2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uOjpjYW5IYXZlQ2hpbGRyZW4pOgorICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSb2xlRW50cnk6Oik6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVy T2JqZWN0OjpjYW5IYXZlQ2hpbGRyZW4pOgorCiAyMDA5LTEwLTI3ICBEYXJpbiBGaXNoZXIgIDxk YXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292 LgpJbmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9u LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0 Qm94T3B0aW9uLmgJKHJldmlzaW9uIDUwMTk0KQorKysgV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDcgKzU5LDgg QEAgcHVibGljOgogICAgIAogICAgIHZpcnR1YWwgdm9pZCBzZXRTZWxlY3RlZChib29sKTsKICAg ICB2aXJ0dWFsIGJvb2wgY2FuU2V0U2VsZWN0ZWRBdHRyaWJ1dGUoKSBjb25zdDsKLQorICAgIHZp cnR1YWwgYm9vbCBjYW5IYXZlQ2hpbGRyZW4oKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorICAg IAogICAgIHZpcnR1YWwgSW50UmVjdCBlbGVtZW50UmVjdCgpIGNvbnN0OwogICAgIHZpcnR1YWwg SW50U2l6ZSBzaXplKCkgY29uc3Q7CiAgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBw YXJlbnRPYmplY3QoKSBjb25zdDsKSW5kZXg6IFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDUwMTk2KQorKysgV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMjg1LDYgKzIyODUsNyBAQCBzdGF0aWMgY29uc3QgQVJJQVJvbGVNYXAmIGNy ZWF0ZUFSSUFSb2xlCiAgICAgICAgIHsgIm1lbnVpdGVtcmFkaW8iLCBNZW51SXRlbVJvbGUgfSwK ICAgICAgICAgeyAibm90ZSIsIERvY3VtZW50Tm90ZVJvbGUgfSwKICAgICAgICAgeyAibmF2aWdh dGlvbiIsIExhbmRtYXJrTmF2aWdhdGlvblJvbGUgfSwKKyAgICAgICAgeyAib3B0aW9uIiwgTGlz dEJveE9wdGlvblJvbGUgfSwKICAgICAgICAgeyAicHJlc2VudGF0aW9uIiwgSWdub3JlZFJvbGUg fSwKICAgICAgICAgeyAicHJvZ3Jlc3NiYXIiLCBQcm9ncmVzc0luZGljYXRvclJvbGUgfSwKICAg ICAgICAgeyAicmFkaW8iLCBSYWRpb0J1dHRvblJvbGUgfSwKQEAgLTI1MzEsNiArMjUzMiw4IEBA IGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6Y2FuSGF2ZUMKICAgICAgICAgY2FzZSBQ b3BVcEJ1dHRvblJvbGU6CiAgICAgICAgIGNhc2UgQ2hlY2tCb3hSb2xlOgogICAgICAgICBjYXNl IFJhZGlvQnV0dG9uUm9sZToKKyAgICAgICAgY2FzZSBTdGF0aWNUZXh0Um9sZToKKyAgICAgICAg Y2FzZSBMaXN0Qm94T3B0aW9uUm9sZToKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAg ICAgZGVmYXVsdDoKICAgICAgICAgICAgIHJldHVybiB0cnVlOwpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g NTAxOTgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAwOS0xMC0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBSS1B UklBOiBhZGQgc3VwcG9ydCBmb3IgJ29wdGlvbicgcm9sZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA4NDMKKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvYXJpYS1vcHRpb24tcm9sZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv U2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLW9wdGlv bi1yb2xlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vd2luL1NraXBw ZWQ6CisKIDIwMDktMTAtMjcgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4K IAogICAgICAgICBObyByZXZpZXcuCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2Fy aWEtb3B0aW9uLXJvbGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L2FyaWEtb3B0aW9uLXJvbGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Fj Y2Vzc2liaWxpdHkvYXJpYS1vcHRpb24tcm9sZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDQ0IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8 aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0PgordmFyIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IGZhbHNlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgor Cis8ZGl2IHJvbGU9Imxpc3Rib3giPgorPGRpdiByb2xlPSJvcHRpb24iPm9wdGlvbiAxPC9kaXY+ Cis8ZGl2IHJvbGU9Im9wdGlvbiIgdGl0bGU9ImxhYmVsIDIiPm9wdGlvbiAyPC9kaXY+Cis8L2Rp dj4KKworPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4K KworPHNjcmlwdD4KKworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgdGhlIGFyaWEg J29wdGlvbicgcm9sZSB3b3JrcyBhcyBleHBlY3RlZC4iKTsKKworICAgIGlmICh3aW5kb3cuYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKworICAgICAgICAgIHZhciBib2R5ID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImJvZHkiKTsKKyAgICAgICAgICBib2R5LmZvY3VzKCk7CisKKyAgICAg ICAgICB2YXIgbGlzdEJveCA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50 LmNoaWxkQXRJbmRleCgwKTsKKyAgICAgICAgICB2YXIgZmlyc3RDaGlsZCA9IGxpc3RCb3guY2hp bGRBdEluZGV4KDApOworICAgICAgICAgIHZhciBzZWNvbmRDaGlsZCA9IGxpc3RCb3guY2hpbGRB dEluZGV4KDEpOworICAgICAgICAgIHNob3VsZEJlKCJmaXJzdENoaWxkLnJvbGUiLCAiJ0FYUm9s ZTogQVhTdGF0aWNUZXh0JyIpOworICAgICAgICAgIHNob3VsZEJlKCJmaXJzdENoaWxkLnRpdGxl IiwgIidBWFRpdGxlOiBvcHRpb24gMSciKTsKKworICAgICAgICAgIHNob3VsZEJlKCJzZWNvbmRD aGlsZC5yb2xlIiwgIidBWFJvbGU6IEFYU3RhdGljVGV4dCciKTsKKyAgICAgICAgICBzaG91bGRC ZSgic2Vjb25kQ2hpbGQudGl0bGUiLCAiJ0FYVGl0bGU6IGxhYmVsIDInIik7CisgICAgfQorCisg ICAgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0i Li4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCShyZXZpc2lvbiA1MDE5NCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC01 OSw2ICs1OSw3IEBAIGFjY2Vzc2liaWxpdHkvaW5wdXQtc2xpZGVyLmh0bWwKIGFjY2Vzc2liaWxp dHkvbGFuZ3VhZ2UtYXR0cmlidXRlLmh0bWwKIGFjY2Vzc2liaWxpdHkvbWVkaWEtZWxlbWVudC5o dG1sCiBhY2Nlc3NpYmlsaXR5L29uY2xpY2staGFuZGxlcnMuaHRtbAorYWNjZXNzaWJpbGl0eS9h cmlhLW9wdGlvbi1yb2xlLmh0bWwgIAogYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci5odG1sCiBh Y2Nlc3NpYmlsaXR5L3JhZGlvLWJ1dHRvbi10aXRsZS1sYWJlbC5odG1sCiBhY2Nlc3NpYmlsaXR5 L3NlY3VyZS10ZXh0ZmllbGQtdGl0bGUtdWkuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1vcHRpb24tcm9sZS1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1vcHRp b24tcm9sZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLW9wdGlvbi1yb2xlLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwxNSBAQAorb3B0aW9uIDEKK29wdGlvbiAyCitUaGlzIHRlc3RzIHRo YXQgdGhlIGFyaWEgJ29wdGlvbicgcm9sZSB3b3JrcyBhcyBleHBlY3RlZC4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZmlyc3RDaGlsZC5yb2xlIGlzICdBWFJvbGU6IEFY U3RhdGljVGV4dCcKK1BBU1MgZmlyc3RDaGlsZC50aXRsZSBpcyAnQVhUaXRsZTogb3B0aW9uIDEn CitQQVNTIHNlY29uZENoaWxkLnJvbGUgaXMgJ0FYUm9sZTogQVhTdGF0aWNUZXh0JworUEFTUyBz ZWNvbmRDaGlsZC50aXRsZSBpcyAnQVhUaXRsZTogbGFiZWwgMicKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS93aW4vU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v U2tpcHBlZAkocmV2aXNpb24gNTAxOTQpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tp cHBlZAkod29ya2luZyBjb3B5KQpAQCAtMzgyLDYgKzM4Miw3IEBAIGFjY2Vzc2liaWxpdHkvbm9j aGlsZHJlbi1lbGVtZW50cy5odG1sCiBhY2Nlc3NpYmlsaXR5L25vbi1kYXRhLXRhYmxlLWNlbGwt dGl0bGUtdWktZWxlbWVudC5odG1sCiBhY2Nlc3NpYmlsaXR5L25vbi1uYXRpdmUtaW1hZ2UtY3Jh c2guaHRtbAogYWNjZXNzaWJpbGl0eS9vbmNsaWNrLWhhbmRsZXJzLmh0bWwKK2FjY2Vzc2liaWxp dHkvYXJpYS1vcHRpb24tcm9sZS5odG1sCiBhY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwK IGFjY2Vzc2liaWxpdHkvcGx1Z2luLmh0bWwKIGFjY2Vzc2liaWxpdHkvcmFkaW8tYnV0dG9uLWNo ZWNrYm94LXNpemUuaHRtbAo=