30833 2009-10-27 13:55:55 -0700 Chromium builds should not use JavaScriptCore/wtf/CurrentTime.cpp 2009-10-27 14:52:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jamesr webkit-unassigned fishd mbelshe oldest_to_newest 158346 0 jamesr 2009-10-27 13:55:55 -0700 Chromium uses a different method to calculate the current time than is used in JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use. See http://code.google.com/p/chromium/issues/detail?id=25892 for an example. Chromium provides its own implementation of WTF::currentTime() which it should always use instead. 158360 1 41985 jamesr 2009-10-27 14:15:03 -0700 Created attachment 41985 Patch that excludes wtf/CurrentTime.cpp from the Chromium build Here's a fix - it adds an exclusion for wtf/CurrentTime.cpp in JavaScriptCore.gyp and adds a #error to ensure that the file isn't accidentally linked into a Chromium build. 158379 2 fishd 2009-10-27 14:52:26 -0700 Landed as http://trac.webkit.org/changeset/50173 41985 2009-10-27 14:15:03 -0700 2009-10-27 14:42:24 -0700 Patch that excludes wtf/CurrentTime.cpp from the Chromium build wtf_current.diff text/plain 2051 jamesr ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmYjg0MDkxLi44NjE5ZDZlIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMDktMTAtMjcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmVzIHRo YXQgSmF2YVNjcmlwdENvcmUvd3RmL0N1cnJlbnRUaW1lLmNwcCBpcyBub3QgYnVpbHQgaW4gUExB VEZPUk0oQ0hST01JVU0pIGJ1aWxkcy4KKworICAgICAgICBDaHJvbWl1bSB1c2VzIGEgZGlmZmVy ZW50IG1ldGhvZCB0byBjYWxjdWxhdGUgdGhlIGN1cnJlbnQgdGltZSB0aGFuIGlzIHVzZWQgaW4K KyAgICAgICAgSmF2YVNjcmlwdENvcmUvd3RmL0N1cnJlbnRUaW1lLmNwcC4gVGhpcyBjYW4gbGVh ZCB0byB0aW1lIHNrZXcgd2hlbiBjYWxscyB0byBjdXJyZW50VGltZSgpIGFuZCBDaHJvbWl1bSdz IHRpbWUKKyAgICAgICAgZnVuY3Rpb24gYXJlIG1peGVkLiAgSW4gcGFydGljdWxhciwgdGltZXJz IGNhbiBnZXQgc2NoZWR1bGVkIGluIHRoZSBwYXN0IHdoaWNoIGxlYWRzIHRvIDEwMCUgQ1BVIHVz ZS4KKyAgICAgICAgU2VlIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMv ZGV0YWlsP2lkPTI1ODkyIGZvciBhbiBleGFtcGxlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDgzMworCisgICAgICAgICogSmF2YVNjcmlwdENv cmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKyAgICAgICAgKiB3dGYvQ3VycmVudFRpbWUuY3Bw OgorCiAyMDA5LTEwLTI3ICBQZXRlciBWYXJnYSAgPHB2YXJnYUBpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAgYi9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwCmluZGV4 IDg4ZmU0ODQuLmNmYWQzY2YgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAKKysrIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlw dENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cApAQCAtMTIxLDYgKzEyMSw3IEBACiAgICAgICAg ICMgR0xpYi9HVEssIGV2ZW4gdGhvdWdoIGl0cyBuYW1lIGRvZXNuJ3QgcmVhbGx5IGluZGljYXRl LgogICAgICAgICBbJ2V4Y2x1ZGUnLCAnLyhHT3duUHRyfGdsaWIvLiopXFwuKGNwcHxoKSQnXSwK ICAgICAgICAgWydleGNsdWRlJywgJyhEZWZhdWx0fEd0a3xNYWN8Tm9uZXxRdHxXaW58V3gpXFwu KGNwcHxtbSkkJ10sCisgICAgICAgIFsnZXhjbHVkZScsICd3dGYvQ3VycmVudFRpbWVcXC5jcHAk J10sCiAgICAgICBdLAogICAgICAgJ2RpcmVjdF9kZXBlbmRlbnRfc2V0dGluZ3MnOiB7CiAgICAg ICAgICdpbmNsdWRlX2RpcnMnOiBbCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvQ3Vy cmVudFRpbWUuY3BwIGIvSmF2YVNjcmlwdENvcmUvd3RmL0N1cnJlbnRUaW1lLmNwcAppbmRleCBh M2Q1MjkwLi5iMzZjYWU1IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvQ3VycmVudFRp bWUuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9DdXJyZW50VGltZS5jcHAKQEAgLTYzLDYg KzYzLDEwIEBAIGV4dGVybiAiQyIgdGltZV90IG1rdGltZShzdHJ1Y3QgdG0gKnQpOwogI2luY2x1 ZGUgPHN5cy90aW1lLmg+CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorI2Vycm9y IENocm9taXVtIHVzZXMgYSBkaWZmZXJlbnQgdGltZXIgaW1wbGVtZW50YXRpb24KKyNlbmRpZgor CiBuYW1lc3BhY2UgV1RGIHsKIAogY29uc3QgZG91YmxlIG1zUGVyU2Vjb25kID0gMTAwMC4wOwo=