30825 2009-10-27 09:17:30 -0700 [CHROMIUM] Chromium/skia's canvas getImageData() is not accurate 2009-11-09 17:30:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco eric oldest_to_newest 158212 0 senorblanco 2009-10-27 09:17:30 -0700 Chromium/skia's implementation of canvas getImageData() does not unpremultiply colour values correctly. In particular, LayoutTests/fast/canvas/canvas-getImageData.html requires that premultiplied values retrieved from the canvas are accurately divided by alpha, but not rounded. See http://crbug.com/22700 158214 1 41958 senorblanco 2009-10-27 09:22:23 -0700 Created attachment 41958 Fix for data getImageData()'s unpremultiply 158359 2 41958 levin 2009-10-27 14:14:45 -0700 Comment on attachment 41958 Fix for data getImageData()'s unpremultiply > Index: WebCore/platform/graphics/skia/ImageBufferSkia.cpp > + destPixel[1] = a ? SkColorGetG(color) * 255 / a : 0, I think you wanted a ";" here instead of a ",". 158388 3 41990 senorblanco 2009-10-27 15:06:52 -0700 Created attachment 41990 Fix typo 161852 4 41990 commit-queue 2009-11-09 17:25:27 -0800 Comment on attachment 41990 Fix typo Rejecting patch 41990 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dmitri Titov', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/graphics/skia/ImageBufferSkia.cpp Hunk #1 FAILED at 164. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/graphics/skia/ImageBufferSkia.cpp.rej 161855 5 eric 2009-11-09 17:30:35 -0800 Looks like this was landed as r50408 but just not closed. 41958 2009-10-27 09:22:23 -0700 2009-10-27 15:06:52 -0700 Fix for data getImageData()'s unpremultiply unpremultiply-webkit.patch text/plain 2275 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDE1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTAtMjcgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODI1CisgICAg ICAgIFRoaXMgaXMgdGhlIFdlYktpdC1zaWRlIGNoYW5nZSBuZWVkZWQgdG8gZml4IGNhbnZhcy5n ZXRJbWFnZURhdGEoKSBmb3IKKyAgICAgICAgQ2hyb21pdW0uICBUaGUgdW5wcmVtdWx0aXBseSBj b2RlIGluIFNraWEgYXNzdW1lcyB0aGF0IHVucHJlbXVsdGlwbGllZAorICAgICAgICB2YWx1ZXMg c2hvdWxkIGJlIHJvdW5kZWQsIHdoaWxlIENHIGRvZXMgbm90LiAgSW4gYWRkaXRpb24sIHRoZSBm aXhlZAorICAgICAgICBwb2ludCBpbnZlcnNpb24gdXNlZCBieSBTa2lhIGludHJvZHVjZXMgc2xp Z2h0IGluYWNjdXJhY2llcyB0aGF0IG1ha2UKKyAgICAgICAgdXMgZmFpbCB0aGlzIHRlc3QuICBU aGlzIGNoYW5nZSBicmluZ3MgQ2hyb21pdW0gaW4gbGluZSB3aXRoCisgICAgICAgIHRoZSBDRyBw YXRoLgorCisgICAgICAgIENvdmVyZWQgYnkgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFz LWdldEltYWdlRGF0YS5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0lt YWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRJbWFnZURhdGEpOgorCiAy MDA5LTEwLTI3ICBBbmRyYXMgQmVjc2kgIDxiZWNzaS5hbmRyYXNAc3R1ZC51LXN6ZWdlZC5odT4K IAogICAgICAgICBSZXZpZXdlZCBieSBUb3IgQXJuZSBWZXN0YsO4LgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAJKHJldmlz aW9uIDUwMTUxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVy U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NCwxMSArMTY0LDEyIEBAIFBhc3NSZWZQdHI8 SW1hZ2VEYXRhPiBnZXRJbWFnZURhdGEoY29uc3QKICAgICAgICAgZm9yIChpbnQgeCA9IDA7IHgg PCBudW1Db2x1bW5zOyArK3gpIHsKICAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIGRlc3RQaXhl bCA9ICZkZXN0Um93W3ggKiA0XTsKICAgICAgICAgICAgIGlmIChtdWx0aXBsaWVkID09IFVubXVs dGlwbGllZCkgewotICAgICAgICAgICAgICAgIFNrQ29sb3IgY29sb3IgPSBTa1BNQ29sb3JUb0Nv bG9yKHNyY1Jvd1t4XSk7Ci0gICAgICAgICAgICAgICAgZGVzdFBpeGVsWzBdID0gU2tDb2xvckdl dFIoY29sb3IpOwotICAgICAgICAgICAgICAgIGRlc3RQaXhlbFsxXSA9IFNrQ29sb3JHZXRHKGNv bG9yKTsKLSAgICAgICAgICAgICAgICBkZXN0UGl4ZWxbMl0gPSBTa0NvbG9yR2V0Qihjb2xvcik7 Ci0gICAgICAgICAgICAgICAgZGVzdFBpeGVsWzNdID0gU2tDb2xvckdldEEoY29sb3IpOworICAg ICAgICAgICAgICAgIFNrQ29sb3IgY29sb3IgPSBzcmNSb3dbeF07CisgICAgICAgICAgICAgICAg dW5zaWduZWQgYSA9IFNrQ29sb3JHZXRBKGNvbG9yKTsKKyAgICAgICAgICAgICAgICBkZXN0UGl4 ZWxbMF0gPSBhID8gU2tDb2xvckdldFIoY29sb3IpICogMjU1IC8gYSA6IDA7CisgICAgICAgICAg ICAgICAgZGVzdFBpeGVsWzFdID0gYSA/IFNrQ29sb3JHZXRHKGNvbG9yKSAqIDI1NSAvIGEgOiAw LAorICAgICAgICAgICAgICAgIGRlc3RQaXhlbFsyXSA9IGEgPyBTa0NvbG9yR2V0Qihjb2xvcikg KiAyNTUgLyBhIDogMDsKKyAgICAgICAgICAgICAgICBkZXN0UGl4ZWxbM10gPSBhOwogICAgICAg ICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAvLyBJbnB1dCBhbmQgb3V0cHV0IGFyZSBi b3RoIHByZS1tdWx0aXBsaWVkLCB3ZSBqdXN0IG5lZWQgdG8gcmUtYXJyYW5nZSB0aGUKICAgICAg ICAgICAgICAgICAvLyBieXRlcyBmcm9tIHRoZSBiaXRtYXAgZm9ybWF0IHRvIFJHQkEuCg== 41990 2009-10-27 15:06:52 -0700 2009-11-09 17:25:27 -0800 Fix typo unpremultiply-webkit.patch text/plain 2261 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDE3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTAtMjcgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODI1CisgICAg ICAgIFRoaXMgaXMgdGhlIFdlYktpdC1zaWRlIGNoYW5nZSBuZWVkZWQgdG8gZml4IGNhbnZhcy5n ZXRJbWFnZURhdGEoKSBmb3IKKyAgICAgICAgQ2hyb21pdW0uICBUaGUgdW5wcmVtdWx0aXBseSBj b2RlIGluIFNraWEgYXNzdW1lcyB0aGF0IHVucHJlbXVsdGlwbGllZAorICAgICAgICB2YWx1ZXMg c2hvdWxkIGJlIHJvdW5kZWQsIHdoaWxlIENHIGRvZXMgbm90LiAgSW4gYWRkaXRpb24sIHRoZSBm aXhlZAorICAgICAgICBwb2ludCBpbnZlcnNpb24gdXNlZCBieSBTa2lhIGludHJvZHVjZXMgc2xp Z2h0IGluYWNjdXJhY2llcyB0aGF0IG1ha2UKKyAgICAgICAgdXMgZmFpbCB0aGlzIHRlc3QuICBU aGlzIGNoYW5nZSBicmluZ3MgQ2hyb21pdW0gaW4gbGluZSB3aXRoCisgICAgICAgIHRoZSBDRyBw YXRoLgorCisgICAgICAgIENvdmVyZWQgYnkgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFz LWdldEltYWdlRGF0YS5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0lt YWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRJbWFnZURhdGEpOgorCiAy MDA5LTEwLTI3ICBDYXJvbCBTemFibyAgPGNhcm9sLnN6YWJvQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCShyZXZpc2lvbiA1MDE3MSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjQsMTEgKzE2NCwxMiBAQCBQYXNzUmVmUHRyPEltYWdlRGF0YT4gZ2V0 SW1hZ2VEYXRhKGNvbnN0CiAgICAgICAgIGZvciAoaW50IHggPSAwOyB4IDwgbnVtQ29sdW1uczsg Kyt4KSB7CiAgICAgICAgICAgICB1bnNpZ25lZCBjaGFyKiBkZXN0UGl4ZWwgPSAmZGVzdFJvd1t4 ICogNF07CiAgICAgICAgICAgICBpZiAobXVsdGlwbGllZCA9PSBVbm11bHRpcGxpZWQpIHsKLSAg ICAgICAgICAgICAgICBTa0NvbG9yIGNvbG9yID0gU2tQTUNvbG9yVG9Db2xvcihzcmNSb3dbeF0p OwotICAgICAgICAgICAgICAgIGRlc3RQaXhlbFswXSA9IFNrQ29sb3JHZXRSKGNvbG9yKTsKLSAg ICAgICAgICAgICAgICBkZXN0UGl4ZWxbMV0gPSBTa0NvbG9yR2V0Ryhjb2xvcik7Ci0gICAgICAg ICAgICAgICAgZGVzdFBpeGVsWzJdID0gU2tDb2xvckdldEIoY29sb3IpOwotICAgICAgICAgICAg ICAgIGRlc3RQaXhlbFszXSA9IFNrQ29sb3JHZXRBKGNvbG9yKTsKKyAgICAgICAgICAgICAgICBT a0NvbG9yIGNvbG9yID0gc3JjUm93W3hdOworICAgICAgICAgICAgICAgIHVuc2lnbmVkIGEgPSBT a0NvbG9yR2V0QShjb2xvcik7CisgICAgICAgICAgICAgICAgZGVzdFBpeGVsWzBdID0gYSA/IFNr Q29sb3JHZXRSKGNvbG9yKSAqIDI1NSAvIGEgOiAwOworICAgICAgICAgICAgICAgIGRlc3RQaXhl bFsxXSA9IGEgPyBTa0NvbG9yR2V0Ryhjb2xvcikgKiAyNTUgLyBhIDogMDsKKyAgICAgICAgICAg ICAgICBkZXN0UGl4ZWxbMl0gPSBhID8gU2tDb2xvckdldEIoY29sb3IpICogMjU1IC8gYSA6IDA7 CisgICAgICAgICAgICAgICAgZGVzdFBpeGVsWzNdID0gYTsKICAgICAgICAgICAgIH0gZWxzZSB7 CiAgICAgICAgICAgICAgICAgLy8gSW5wdXQgYW5kIG91dHB1dCBhcmUgYm90aCBwcmUtbXVsdGlw bGllZCwgd2UganVzdCBuZWVkIHRvIHJlLWFycmFuZ2UgdGhlCiAgICAgICAgICAgICAgICAgLy8g Ynl0ZXMgZnJvbSB0aGUgYml0bWFwIGZvcm1hdCB0byBSR0JBLgo=