30821 2009-10-27 06:52:02 -0700 Storage test cases have FAIL cases in the expected results 2009-10-27 15:05:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Minor --- 0 kinuko webkit-unassigned commit-queue oldest_to_newest 158179 0 kinuko 2009-10-27 06:52:02 -0700 New local/session combined storage tests contain some FAIL test cases. It appears that there's a bug both in the test case and expected results to me. The change was made in: https://bugs.webkit.org/show_bug.cgi?id=30640 The last three cases are failing in the expected results: http://trac.webkit.org/browser/trunk/LayoutTests/storage/domstorage/complex-values-expected.txt?rev=49928 158181 1 41951 kinuko 2009-10-27 07:00:48 -0700 Created attachment 41951 Fix test cases and expected-results to avoid FAIL tests. 158372 2 41951 eric 2009-10-27 14:41:19 -0700 Comment on attachment 41951 Fix test cases and expected-results to avoid FAIL tests. Kinuko is not a committer, so adding to the commit-queue. 158386 3 41951 commit-queue 2009-10-27 15:05:05 -0700 Comment on attachment 41951 Fix test cases and expected-results to avoid FAIL tests. Clearing flags on attachment: 41951 Committed r50176: <http://trac.webkit.org/changeset/50176> 158387 4 commit-queue 2009-10-27 15:05:09 -0700 All reviewed patches have been landed. Closing bug. 41951 2009-10-27 07:00:48 -0700 2009-10-27 15:05:05 -0700 Fix test cases and expected-results to avoid FAIL tests. bug-30821-20091027230046.patch text/plain 2047 kinuko ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjY2M1YzhiLi5jYTM1ZTYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAt MjcgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcgYSB0ZXN0IGNhc2UgdGhhdCB5 aWVsZHMgRkFJTCByZXN1bHRzLiAgQWxzbyB1cGRhdGluZworICAgICAgICB0aGUgY29ycmVzcG9u ZGluZyBleHBlY3RlZCByZXN1bHRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzA4MjEKKworICAgICAgICAqIHN0b3JhZ2UvZG9tc3RvcmFnZS9jb21w bGV4LXZhbHVlcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogc3RvcmFnZS9kb21zdG9yYWdlL3Nj cmlwdC10ZXN0cy9jb21wbGV4LXZhbHVlcy5qczoKKwogMjAwOS0xMC0yNSAgR3VzdGF2byBOb3Jv bmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBV bnJldmlld2VkLiBSZWJhc2VsaW5lIHRlc3QgYWZ0ZXIgNDk5OTguCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9zdG9yYWdlL2RvbXN0b3JhZ2UvY29tcGxleC12YWx1ZXMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvc3RvcmFnZS9kb21zdG9yYWdlL2NvbXBsZXgtdmFsdWVzLWV4cGVjdGVkLnR4 dAppbmRleCBlNmZhNjgzLi4xOTRiM2I4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdl L2RvbXN0b3JhZ2UvY29tcGxleC12YWx1ZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L3N0b3JhZ2UvZG9tc3RvcmFnZS9jb21wbGV4LXZhbHVlcy1leHBlY3RlZC50eHQKQEAgLTIxNCwx MSArMjE0LDExIEBAIFBBU1Mgc3RvcmFnZS5nZXRJdGVtKCdmb28xMicpIGlzICLul4HDv+ywoWhl bGxvIgogVmVyaWZ5IHN0b3JhZ2UgZXZlbnRzIGFyZSBjYXNlIHNlbnNpdGl2ZQogc3RvcmFnZS5m b28gPSAndGVzdCcKIFNldHRpbmcgZXZlbnQgbGlzdGVuZXIKLUZBSUwgZXZlbnRDb3VudGVyIHNo b3VsZCBiZSAwLiBXYXMgMTUuCitQQVNTIGV2ZW50Q291bnRlciBpcyAwCiBzdG9yYWdlLmZvbyA9 ICd0ZXN0JwotRkFJTCBldmVudENvdW50ZXIgc2hvdWxkIGJlIDAuIFdhcyAxNS4KK1BBU1MgZXZl bnRDb3VudGVyIGlzIDAKIHN0b3JhZ2UuZm9vID0gJ1RFU1QnCi1GQUlMIGV2ZW50Q291bnRlciBz aG91bGQgYmUgMS4gV2FzIDE2LgorUEFTUyBldmVudENvdW50ZXIgaXMgMQogUEFTUyBzdWNjZXNz ZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9zdG9yYWdlL2RvbXN0b3JhZ2Uvc2NyaXB0LXRlc3RzL2NvbXBsZXgtdmFsdWVzLmpzIGIv TGF5b3V0VGVzdHMvc3RvcmFnZS9kb21zdG9yYWdlL3NjcmlwdC10ZXN0cy9jb21wbGV4LXZhbHVl cy5qcwppbmRleCBmMWViYWQ0Li5kZWE5ZGI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9y YWdlL2RvbXN0b3JhZ2Uvc2NyaXB0LXRlc3RzL2NvbXBsZXgtdmFsdWVzLmpzCisrKyBiL0xheW91 dFRlc3RzL3N0b3JhZ2UvZG9tc3RvcmFnZS9zY3JpcHQtdGVzdHMvY29tcGxleC12YWx1ZXMuanMK QEAgLTg0LDYgKzg0LDEwIEBAIGZ1bmN0aW9uIHRlc3Qoc3RvcmFnZVN0cmluZykKICAgICBzaG91 bGRCZSgiZXZlbnRDb3VudGVyIiwgIjAiKTsKICAgICBldmFsQW5kTG9nKCJzdG9yYWdlLmZvbyA9 ICdURVNUJyIpOwogICAgIHNob3VsZEJlKCJldmVudENvdW50ZXIiLCAiMSIpOworCisgICAgLy8g UmVzZXQgdGhlIGNvdW50ZXIgZm9yIG5leHQgdGVzdHMgKGlmIGFueSkuCisgICAgd2luZG93LnJl bW92ZUV2ZW50TGlzdGVuZXIoInN0b3JhZ2UiLCBoYW5kbGVTdG9yYWdlRXZlbnQsIGZhbHNlKTsK KyAgICBldmVudENvdW50ZXIgPSAwOwogfQogCiB0ZXN0KCJzZXNzaW9uU3RvcmFnZSIpOw==