<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>30814</bug_id>
          
          <creation_ts>2009-10-27 06:17:24 -0700</creation_ts>
          <short_desc>[GTK] Threading problems with some of the tests</short_desc>
          <delta_ts>2011-03-11 13:29:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>33294</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alejandro G. Castro">alex</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>levin</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>158163</commentid>
    <comment_count>0</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2009-10-27 06:17:24 -0700</bug_when>
    <thetext>These tests crash in one thread assertion randomly:

storage/close-during-stress-test.html -&gt; crashed
storage/domstorage/documentURI.html -&gt; crashed
storage/test-authorizer-stderr.txt -&gt; crashed

The assertion is:

ASSERTION FAILED: currentThread() == m_openingThread
(../../WebCore/platform/sql/SQLiteDatabase.h:100 sqlite3* WebCore::SQLiteDatabase::sqlite3Handle() const)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158213</commentid>
    <comment_count>1</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2009-10-27 09:18:41 -0700</bug_when>
    <thetext>Another test with threading problems:

storage/execute-sql-args.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158236</commentid>
    <comment_count>2</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2009-10-27 10:10:18 -0700</bug_when>
    <thetext>Two more tests causing the same problem:

storage/hash-change-with-xhr.html
storage/database-lock-after-reload.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158241</commentid>
    <comment_count>3</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2009-10-27 10:19:42 -0700</bug_when>
    <thetext>This is another one failing in the last round, not sure if we should just skip all the storage test cases until we find the problem:

storage/domstorage/complex-keys.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158941</commentid>
    <comment_count>4</comment_count>
      <attachid>42109</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-10-29 10:29:10 -0700</bug_when>
    <thetext>Created attachment 42109
crossthreadstring.diff

This patch seems to fix the crashers I can reproduce locally. I don&apos;t claim to fully understand what&apos;s going on, but from reading the code it seems the m_name string in Database is created with crossThreading String, the others are not used differently than this one is, and so it would seem natural to expect that all of them have to be created like that. More evidence for this comes from the fact that the trace for the crash is like:

Thread 3 (Thread 0xb6defb90 (LWP 19474)):
#0  0x00cabea9 in WTF::CrossThreadRefCounted&lt;WTF::OwnFastMallocPtr&lt;unsigned short&gt; &gt;::deref (this=0x840c390) at ../../JavaScriptCore/wtf/CrossThreadRefCounted.h:122
#1  0x0117b4b2 in ~StringImpl (this=0x83d3cf0) at ../../WebCore/platform/text/StringImpl.cpp:108
#2  0x00b10ad5 in WTF::RefCounted&lt;WebCore::StringImpl&gt;::deref (this=0x83d3cf0) at ../../JavaScriptCore/wtf/RefCounted.h:109
#3  0x00b107eb in ~RefPtr (this=0x840bbac) at ../../JavaScriptCore/wtf/RefPtr.h:53
#4  0x00b10129 in ~String (this=0x840bbac) at ../../WebCore/platform/text/PlatformString.h:69
#5  0x012d4825 in ~Database (this=0x840bb10) at ../../WebCore/storage/Database.cpp:200
#6  0x010055a1 in WTF::ThreadSafeShared&lt;WebCore::Database&gt;::deref (this=0x840bb10) at ../../JavaScriptCore/wtf/Threading.h:313
#7  0x01001153 in ~RefPtr (this=0x8408aec) at ../../JavaScriptCore/wtf/RefPtr.h:53
#8  0x012e0fa6 in WTF::HashTable&lt;WTF::RefPtr&lt;WebCore::Database&gt;, WTF::RefPtr&lt;WebCore::Database&gt;, WTF::IdentityExtractor&lt;WTF::RefPtr&lt;WebCore::Database&gt; &gt;, WTF::PtrHash&lt;WTF::RefPtr&lt;WebCore::Database&gt; &gt;, WTF::HashTraits&lt;WTF::RefPtr&lt;WebCore::Database&gt; &gt;, WTF::HashTraits&lt;WTF::RefPtr&lt;WebCore::Database&gt; &gt; &gt;::deallocateTable (table=0x8408a50, size=64) at ../../JavaScriptCore/wtf/HashTable.h:872
#9  0x012e0392 in ~HashTable (this=0xb6def24c) at ../../JavaScriptCore/wtf/HashTable.h:296
#10 0x012e0105 in ~HashSet (this=0xb6def24c) at ../../JavaScriptCore/wtf/HashSet.h:38
#11 0x012dfc16 in WebCore::DatabaseThread::databaseThread (this=0x83d3e48) at ../../WebCore/storage/DatabaseThread.cpp:117
#12 0x012dfa2b in WebCore::DatabaseThread::databaseThreadStart (vDatabaseThread=0x83d3e48) at ../../WebCore/storage/DatabaseThread.cpp:82
#13 0x00c0540e in threadEntryPoint (contextData=0x83d3f10) at ../../JavaScriptCore/wtf/Threading.cpp:64
#14 0x0024651f in start_thread (arg=0xb6defb90) at pthread_create.c:297
#15 0x0309b04e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130

And upon inspection the string being destroyed is m_displayName.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158942</commentid>
    <comment_count>5</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-10-29 10:29:57 -0700</bug_when>
    <thetext>CCing the last person touching this code, so he can comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158963</commentid>
    <comment_count>6</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-10-29 10:59:58 -0700</bug_when>
    <thetext>This was landed in r50285, closing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166495</commentid>
    <comment_count>7</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2009-11-25 09:52:13 -0800</bug_when>
    <thetext>These problems are not still completely gone, we have to add this test also to the list in Skipped:

http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r51387%20(1286)/fast/js/excessive-comma-usage-stderr.txt

ASSERTION FAILED: currentThread() == m_openingThread
(../../WebCore/platform/sql/SQLiteDatabase.h:100 sqlite3* WebCore::SQLiteDatabase::sqlite3Handle() const)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166503</commentid>
    <comment_count>8</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2009-11-25 10:27:05 -0800</bug_when>
    <thetext>And another one with the same problem:

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r51389%20(1302)/storage/transaction-error-callback-stderr.txt</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>170160</commentid>
    <comment_count>9</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-09 14:04:04 -0800</bug_when>
    <thetext>Should this bug still be open?  Wasn&apos;t this patch landed?  If the patch was landed but the bug should still be open please obsolete the patch and clear the r+ flag.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178317</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-07 12:32:09 -0800</bug_when>
    <thetext>Looks like bug 33294 can probably be duped to this one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178318</commentid>
    <comment_count>11</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-07 12:32:37 -0800</bug_when>
    <thetext>If this is not easy to fix, I recommend we skip storage/ on the gtk bots so that the bots stay green.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178597</commentid>
    <comment_count>12</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-08 03:13:20 -0800</bug_when>
    <thetext>This would appear to be the worst reliability bug affecting the Gtk bots.  Unless someone knows what&apos;s going wrong here, I would recommend we skip storage/ for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178605</commentid>
    <comment_count>13</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2010-01-08 03:27:36 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; This would appear to be the worst reliability bug affecting the Gtk bots. 
&gt; Unless someone knows what&apos;s going wrong here, I would recommend we skip
&gt; storage/ for now.

I have talked to Xan and we agree about skipping them until we find a solution to this threading problem. I&apos;m going to upload the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178611</commentid>
    <comment_count>14</comment_count>
      <attachid>46128</attachid>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2010-01-08 03:37:48 -0800</bug_when>
    <thetext>Created attachment 46128
Proposed patch to skip all the storage tests

Following Eric&apos;s recommendation this patch skips all the storage tests, we should leave the bug open after committing this patch until we find a proper solution.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178614</commentid>
    <comment_count>15</comment_count>
      <attachid>46128</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-08 03:38:53 -0800</bug_when>
    <thetext>Comment on attachment 46128
Proposed patch to skip all the storage tests

Just skip &quot;storage&quot; instead of adding them all manually.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178615</commentid>
    <comment_count>16</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-08 03:39:17 -0800</bug_when>
    <thetext>Unless GTK intentionally avoids skipping whole directories?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178616</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-08 03:39:18 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 46128 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178618</commentid>
    <comment_count>18</comment_count>
      <attachid>46129</attachid>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2010-01-08 03:41:39 -0800</bug_when>
    <thetext>Created attachment 46129
Proposed patch to skip all the storage tests

I tested with just storage and it works. Thanks for the comment Eric.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178621</commentid>
    <comment_count>19</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-08 03:45:25 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 46129 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178622</commentid>
    <comment_count>20</comment_count>
      <attachid>46129</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-01-08 03:46:03 -0800</bug_when>
    <thetext>Comment on attachment 46129
Proposed patch to skip all the storage tests

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178623</commentid>
    <comment_count>21</comment_count>
      <attachid>46129</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-08 03:47:06 -0800</bug_when>
    <thetext>Comment on attachment 46129
Proposed patch to skip all the storage tests

Looks fine to me.  If you want to keep this bug open, you&apos;ll either have to land this manually, or re-open it after using the commit-queue.  The commit-queue will close the bug after landing because no other patches are waiting review on this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178641</commentid>
    <comment_count>22</comment_count>
      <attachid>46129</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-08 04:46:58 -0800</bug_when>
    <thetext>Comment on attachment 46129
Proposed patch to skip all the storage tests

Clearing flags on attachment: 46129

Committed r52988: &lt;http://trac.webkit.org/changeset/52988&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178642</commentid>
    <comment_count>23</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-08 04:47:12 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>178644</commentid>
    <comment_count>24</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2010-01-08 04:53:36 -0800</bug_when>
    <thetext>Reopening until we find the problem with these tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179069</commentid>
    <comment_count>25</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-09 15:34:12 -0800</bug_when>
    <thetext>This bug is also causing fast/js/excessive-comma-usage.html to fail:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r53016%20(2228)/fast/js/excessive-comma-usage-stderr.txt
ASSERTION FAILED: currentThread() == m_openingThread
(../../WebCore/platform/sql/SQLiteDatabase.h:100 sqlite3* WebCore::SQLiteDatabase::sqlite3Handle() const)

Seems we should skip that test too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179175</commentid>
    <comment_count>26</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-10 14:42:27 -0800</bug_when>
    <thetext>Hit this again:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r53050%20(2248)/fast/js/excessive-comma-usage-stderr.txt

I&apos;ll post a patch to skip that test too tomorrow unless someone beats me to it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179274</commentid>
    <comment_count>27</comment_count>
      <attachid>46257</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-10 21:18:30 -0800</bug_when>
    <thetext>Created attachment 46257
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179797</commentid>
    <comment_count>28</comment_count>
      <attachid>46257</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-12 05:06:03 -0800</bug_when>
    <thetext>Comment on attachment 46257
Patch

Clearing flags on attachment: 46257

Committed r53137: &lt;http://trac.webkit.org/changeset/53137&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179798</commentid>
    <comment_count>29</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-12 05:06:12 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366275</commentid>
    <comment_count>30</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-03-11 13:29:35 -0800</bug_when>
    <thetext>I&apos;ve unskipped these tests on the bots and haven&apos;t seen any trouble yet.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>42109</attachid>
            <date>2009-10-29 10:29:10 -0700</date>
            <delta_ts>2009-12-09 23:07:30 -0800</delta_ts>
            <desc>crossthreadstring.diff</desc>
            <filename>crossthreadstring.diff</filename>
            <type>text/plain</type>
            <size>1924</size>
            <attacher name="Xan Lopez">xan.lopez</attacher>
            
              <data encoding="base64">RnJvbSBkNTAyOWVkNGVmNGJkMjNhN2RlNzM1NDcxNjRlNzY1YzU1MDY5YWEzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU
aHUsIDI5IE9jdCAyMDA5IDE5OjI1OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0xMC0y
OSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBUaHJlYWRpbmcgcHJvYmxlbXMgd2l0aCBzb21l
IG9mIHRoZSB0ZXN0cwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0zMDgxNAoKICAgICAgICBDcmVhdGUgc3RyaW5ncyBzaGFyZWQgYW1vbmcgdGhyZWFkcyB3
aXRoIGNyb3NzVGhyZWFkU3RyaW5nCiAgICAgICAgY29uc3RydWN0b3IgbWV0aG9kLgoKICAgICAg
ICAqIHN0b3JhZ2UvRGF0YWJhc2UuY3BwOgogICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6RGF0
YWJhc2UpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgfCAgIDEzICsrKysrKysr
KysrKysKIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5jcHAgfCAgICA0ICsrLS0KIDIgZmlsZXMg
Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X
ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDk1YmZlMDguLjBjYjNi
MGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjkgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEu
Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtH
VEtdIFRocmVhZGluZyBwcm9ibGVtcyB3aXRoIHNvbWUgb2YgdGhlIHRlc3RzCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDgxNAorCisgICAgICAgIENy
ZWF0ZSBzdHJpbmdzIHNoYXJlZCBhbW9uZyB0aHJlYWRzIHdpdGggY3Jvc3NUaHJlYWRTdHJpbmcK
KyAgICAgICAgY29uc3RydWN0b3IgbWV0aG9kLgorCisgICAgICAgICogc3RvcmFnZS9EYXRhYmFz
ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6RGF0YWJhc2UpOgorCiAyMDA5LTEw
LTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgVGlnZXIgYnVp
bGQgZml4IGFmdGVyIHI1MDI1OQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNl
LmNwcCBiL1dlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5jcHAKaW5kZXggNWFhYTI2Zi4uMmY4Mjc0
MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAorKysgYi9XZWJDb3Jl
L3N0b3JhZ2UvRGF0YWJhc2UuY3BwCkBAIC0xNTIsOCArMTUyLDggQEAgRGF0YWJhc2U6OkRhdGFi
YXNlKERvY3VtZW50KiBkb2N1bWVudCwgY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcm
IGV4cGVjdGUKICAgICAsIG1fZG9jdW1lbnQoZG9jdW1lbnQpCiAgICAgLCBtX25hbWUobmFtZS5j
cm9zc1RocmVhZFN0cmluZygpKQogICAgICwgbV9ndWlkKDApCi0gICAgLCBtX2V4cGVjdGVkVmVy
c2lvbihleHBlY3RlZFZlcnNpb24pCi0gICAgLCBtX2Rpc3BsYXlOYW1lKGRpc3BsYXlOYW1lKQor
ICAgICwgbV9leHBlY3RlZFZlcnNpb24oZXhwZWN0ZWRWZXJzaW9uLmNyb3NzVGhyZWFkU3RyaW5n
KCkpCisgICAgLCBtX2Rpc3BsYXlOYW1lKGRpc3BsYXlOYW1lLmNyb3NzVGhyZWFkU3RyaW5nKCkp
CiAgICAgLCBtX2VzdGltYXRlZFNpemUoZXN0aW1hdGVkU2l6ZSkKICAgICAsIG1fZGVsZXRlZChm
YWxzZSkKICAgICAsIG1fc3RvcHBlZChmYWxzZSkKLS0gCjEuNi41LjEKCg==
</data>
<flag name="review"
          id="23611"
          type_id="1"
          status="-"
          setter="xan.lopez"
    />
    <flag name="commit-queue"
          id="23612"
          type_id="3"
          status="-"
          setter="xan.lopez"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46128</attachid>
            <date>2010-01-08 03:37:48 -0800</date>
            <delta_ts>2010-01-08 03:41:39 -0800</delta_ts>
            <desc>Proposed patch to skip all the storage tests</desc>
            <filename>skip_storage.patch</filename>
            <type>text/plain</type>
            <size>4293</size>
            <attacher name="Alejandro G. Castro">alex</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA1Y2NmZGQ4Li44NGUxZTlhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt
MDggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVGhyZWFkaW5nIHByb2Js
ZW1zIHdpdGggc29tZSBvZiB0aGUgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTMwODE0CisKKyAgICAgICAgV2UgYXJlIGdvaW5nIHRvIHNraXAg
YWxsIHRoZSBzdG9yYWdlIHRlc3RzIHVudGlsIHdlIGZpbmQgdGhlIGlzc3VlCisgICAgICAgIHdp
dGggdGhlIHRocmVhZGluZyBzeXN0ZW0gaW4gdGhlIGd0ayBwb3J0LgorCisgICAgICAgICogcGxh
dGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIwMTAtMDEtMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJr
aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm
b3JtL2d0ay9Ta2lwcGVkCmluZGV4IGI2ZDAwMjkuLmMxOWVkNTAgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0
ay9Ta2lwcGVkCkBAIC01NTQ5LDEyICs1NTQ5LDY4IEBAIGZhc3QveHNsL3NvcnQtbG9jYWxlLnht
bAogCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDgxNAogc3Rv
cmFnZS9jbG9zZS1kdXJpbmctc3RyZXNzLXRlc3QuaHRtbAotc3RvcmFnZS9kb21zdG9yYWdlL2Rv
Y3VtZW50VVJJLmh0bWwKK3N0b3JhZ2UvZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQuaHRtbAor
c3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi5odG1sCitzdG9yYWdlL2VtcHR5LXN0YXRlbWVudC5odG1s
CiBzdG9yYWdlL3Rlc3QtYXV0aG9yaXplci5odG1sCi1zdG9yYWdlL2V4ZWN1dGUtc3FsLWFyZ3Mu
aHRtbAorc3RvcmFnZS9tdWx0aXBsZS10cmFuc2FjdGlvbnMuaHRtbAorc3RvcmFnZS90cmFuc2Fj
dGlvbi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2guaHRtbAorc3RvcmFnZS9yZWFkLWFuZC13cml0
ZS10cmFuc2FjdGlvbnMtZG9udC1ydW4tdG9nZXRoZXIuaHRtbAorc3RvcmFnZS9zdWNjZXNzLWNh
bGxiYWNrLmh0bWwKIHN0b3JhZ2UvaGFzaC1jaGFuZ2Utd2l0aC14aHIuaHRtbAotc3RvcmFnZS9k
YXRhYmFzZS1sb2NrLWFmdGVyLXJlbG9hZC5odG1sCitzdG9yYWdlL3ByaXZhdGUtYnJvd3Npbmct
cmVhZG9ubHkuaHRtbAorc3RvcmFnZS9tdWx0aXBsZS1kYXRhYmFzZXMtZ2FyYmFnZS1jb2xsZWN0
aW9uLmh0bWwKK3N0b3JhZ2UvbXVsdGlwbGUtdHJhbnNhY3Rpb25zLW9uLWRpZmZlcmVudC1oYW5k
bGVzLmh0bWwKK3N0b3JhZ2Uvc3FsLWRhdGEtdHlwZXMuaHRtbAorc3RvcmFnZS9vcGVuLWRhdGFi
YXNlLXdoaWxlLXRyYW5zYWN0aW9uLWluLXByb2dyZXNzLmh0bWwKK3N0b3JhZ2Uvb3Blbi1kYXRh
YmFzZS1lbXB0eS12ZXJzaW9uLmh0bWwKK3N0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1zZXQtZW1wdHkt
dmVyc2lvbi5odG1sCitzdG9yYWdlL3F1b3RhLXRyYWNraW5nLmh0bWwKK3N0b3JhZ2UvZG9tc3Rv
cmFnZS9xdW90YS5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2UvY29tcGxleC12YWx1ZXMuaHRtbAor
c3RvcmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL2lmcmFtZS1ldmVudHMuaHRtbAorc3Rv
cmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL2VudW1lcmF0ZS1zdG9yYWdlLmh0bWwKK3N0
b3JhZ2UvZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9zaW1wbGUtdXNhZ2UuaHRtbAorc3RvcmFn
ZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL29uc3RvcmFnZS1hdHRyaWJ1dGUtc2V0YXR0cmli
dXRlLmh0bWwKK3N0b3JhZ2UvZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9kZWxldGUtcmVtb3Zh
bC5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2UvcHJpdmF0ZS1icm93c2lu
Zy1hZmZlY3RzLXN0b3JhZ2UuaHRtbAorc3RvcmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdl
L3N0cmluZy1jb252ZXJzaW9uLmh0bWwKK3N0b3JhZ2UvZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFn
ZS9vbnN0b3JhZ2UtYXR0cmlidXRlLXNldHdpbmRvdy5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2Uv
c2Vzc2lvbnN0b3JhZ2UvZW51bWVyYXRlLXdpdGgtbGVuZ3RoLWFuZC1rZXkuaHRtbAorc3RvcmFn
ZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL3dpbmRvdy1vcGVuLmh0bWwKK3N0b3JhZ2UvZG9t
c3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9pbmRleC1nZXQtYW5kLXNldC5odG1sCitzdG9yYWdlL2Rv
bXN0b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2Uvb25zdG9yYWdlLWF0dHJpYnV0ZS1tYXJrdXAuaHRtbAor
c3RvcmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL3NpbXBsZS1ldmVudHMuaHRtbAorc3Rv
cmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL3Jlc291cmNlcy93aW5kb3ctb3Blbi1zZWNv
bmQuaHRtbAorc3RvcmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdlL3Jlc291cmNlcy9pZnJh
bWUtZXZlbnRzLXNlY29uZC5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2UvY2xlYXIuaHRtbAorc3Rv
cmFnZS9kb21zdG9yYWdlL3dpbmRvdy1hdHRyaWJ1dGVzLWV4aXN0Lmh0bWwKK3N0b3JhZ2UvZG9t
c3RvcmFnZS9zY3JpcHQtdGVzdHMvVEVNUExBVEUuaHRtbAogc3RvcmFnZS9kb21zdG9yYWdlL2Nv
bXBsZXgta2V5cy5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL2lmcmFtZS1l
dmVudHMuaHRtbAorc3RvcmFnZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9lbnVtZXJhdGUtc3Rv
cmFnZS5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL3NpbXBsZS11c2FnZS5o
dG1sCitzdG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL29uc3RvcmFnZS1hdHRyaWJ1dGUt
c2V0YXR0cmlidXRlLmh0bWwKK3N0b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3JhZ2UvZGVsZXRl
LXJlbW92YWwuaHRtbAorc3RvcmFnZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9wcml2YXRlLWJy
b3dzaW5nLWFmZmVjdHMtc3RvcmFnZS5odG1sCitzdG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9y
YWdlL3N0cmluZy1jb252ZXJzaW9uLmh0bWwKK3N0b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3Jh
Z2Uvb25zdG9yYWdlLWF0dHJpYnV0ZS1zZXR3aW5kb3cuaHRtbAorc3RvcmFnZS9kb21zdG9yYWdl
L2xvY2Fsc3RvcmFnZS9lbnVtZXJhdGUtd2l0aC1sZW5ndGgtYW5kLWtleS5odG1sCitzdG9yYWdl
L2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL3dpbmRvdy1vcGVuLmh0bWwKK3N0b3JhZ2UvZG9tc3Rv
cmFnZS9sb2NhbHN0b3JhZ2UvaW5kZXgtZ2V0LWFuZC1zZXQuaHRtbAorc3RvcmFnZS9kb21zdG9y
YWdlL2xvY2Fsc3RvcmFnZS9vbnN0b3JhZ2UtYXR0cmlidXRlLW1hcmt1cC5odG1sCitzdG9yYWdl
L2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL3NpbXBsZS1ldmVudHMuaHRtbAorc3RvcmFnZS9kb21z
dG9yYWdlL2xvY2Fsc3RvcmFnZS9yZXNvdXJjZXMvd2luZG93LW9wZW4tc2Vjb25kLmh0bWwKK3N0
b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3JhZ2UvcmVzb3VyY2VzL2lmcmFtZS1ldmVudHMtc2Vj
b25kLmh0bWwKK3N0b3JhZ2UvZG9tc3RvcmFnZS9kb2N1bWVudFVSSS5odG1sCitzdG9yYWdlL2Rv
bXN0b3JhZ2UvcmVtb3ZlLWl0ZW0uaHRtbAorc3RvcmFnZS9zdGF0ZW1lbnQtZXJyb3ItY2FsbGJh
Y2suaHRtbAorc3RvcmFnZS90cmFuc2FjdGlvbi1lcnJvci1jYWxsYmFjay5odG1sCitzdG9yYWdl
L2V4ZWN1dGUtc3FsLWFyZ3MuaHRtbAorc3RvcmFnZS9yZWFkLXRyYW5zYWN0aW9ucy1ydW5uaW5n
LWNvbmN1cnJlbnRseS5odG1sCitzdG9yYWdlL2NoYW5nZS12ZXJzaW9uLWhhbmRsZS1yZXVzZS5o
dG1sCitzdG9yYWdlL3Jlc291cmNlcy9kYXRhYmFzZS1sb2NrLWFmdGVyLXJlbG9hZC0yLmh0bWwK
K3N0b3JhZ2UvcmVzb3VyY2VzL3N0cmVzcy1mcmFtZS5odG1sCiAKICMgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODE1CiBodHRwL3Rlc3RzL21pc2MvaXNpbmRleC13
aXRoLW5vLWZvcm0uaHRtbCAK
</data>
<flag name="review"
          id="28350"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46129</attachid>
            <date>2010-01-08 03:41:39 -0800</date>
            <delta_ts>2010-01-10 21:18:25 -0800</delta_ts>
            <desc>Proposed patch to skip all the storage tests</desc>
            <filename>skip_storage.patch</filename>
            <type>text/plain</type>
            <size>1302</size>
            <attacher name="Alejandro G. Castro">alex</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA1Y2NmZGQ4Li44NGUxZTlhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt
MDggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVGhyZWFkaW5nIHByb2Js
ZW1zIHdpdGggc29tZSBvZiB0aGUgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTMwODE0CisKKyAgICAgICAgV2UgYXJlIGdvaW5nIHRvIHNraXAg
YWxsIHRoZSBzdG9yYWdlIHRlc3RzIHVudGlsIHdlIGZpbmQgdGhlIGlzc3VlCisgICAgICAgIHdp
dGggdGhlIHRocmVhZGluZyBzeXN0ZW0gaW4gdGhlIGd0ayBwb3J0LgorCisgICAgICAgICogcGxh
dGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIwMTAtMDEtMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJr
aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm
b3JtL2d0ay9Ta2lwcGVkCmluZGV4IGI2ZDAwMjkuLjkzM2Q5NWYgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0
ay9Ta2lwcGVkCkBAIC01NTQ4LDEzICs1NTQ4LDcgQEAgZmFzdC9kb20vV2luZG93L3dpbmRvdy1w
cm9wZXJ0aWVzLmh0bWwKIGZhc3QveHNsL3NvcnQtbG9jYWxlLnhtbAogCiAjIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDgxNAotc3RvcmFnZS9jbG9zZS1kdXJpbmct
c3RyZXNzLXRlc3QuaHRtbAotc3RvcmFnZS9kb21zdG9yYWdlL2RvY3VtZW50VVJJLmh0bWwKLXN0
b3JhZ2UvdGVzdC1hdXRob3JpemVyLmh0bWwKLXN0b3JhZ2UvZXhlY3V0ZS1zcWwtYXJncy5odG1s
Ci1zdG9yYWdlL2hhc2gtY2hhbmdlLXdpdGgteGhyLmh0bWwKLXN0b3JhZ2UvZGF0YWJhc2UtbG9j
ay1hZnRlci1yZWxvYWQuaHRtbAotc3RvcmFnZS9kb21zdG9yYWdlL2NvbXBsZXgta2V5cy5odG1s
CitzdG9yYWdlCiAKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMw
ODE1CiBodHRwL3Rlc3RzL21pc2MvaXNpbmRleC13aXRoLW5vLWZvcm0uaHRtbCAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46257</attachid>
            <date>2010-01-10 21:18:30 -0800</date>
            <delta_ts>2010-01-12 05:06:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-30814-20100110211829.patch</filename>
            <type>text/plain</type>
            <size>1193</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAxMWJmMzUyLi5iNDljZWM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt
MTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFRocmVhZGluZyBwcm9ibGVtcyB3aXRo
IHNvbWUgb2YgdGhlIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0zMDgxNAorCisgICAgICAgIFNraXAgYW5vdGhlciB0ZXN0IHdoaWNoIGlzIGhp
dHRpbmcgdGhlIFNRTGl0ZURhdGFiYXNlOjpzcWxpdGVIYW5kbGUoKSB0aHJlYWRpbmcgQVNTRVJU
LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIwMTAtMDEtMTAgIEFkYW0g
QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB
ZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5
b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggOTMzZDk1Zi4uNDVjOGQ2ZSAxMDA2
NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz
dHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTU1NDcsOCArNTU0NywxMCBAQCBmYXN0L2RvbS9X
aW5kb3cvd2luZG93LXByb3BlcnRpZXMuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MzA2MjAKIGZhc3QveHNsL3NvcnQtbG9jYWxlLnhtbAogCisjIEFTU0VS
VElPTiBGQUlMRUQ6IGN1cnJlbnRUaHJlYWQoKSA9PSBtX29wZW5pbmdUaHJlYWQgaW4gV2ViQ29y
ZTo6U1FMaXRlRGF0YWJhc2U6OnNxbGl0ZTNIYW5kbGUoKQogIyBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA4MTQKIHN0b3JhZ2UKK2Zhc3QvanMvZXhjZXNzaXZlLWNv
bW1hLXVzYWdlLmh0bWwKIAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MzA4MTUKIGh0dHAvdGVzdHMvbWlzYy9pc2luZGV4LXdpdGgtbm8tZm9ybS5odG1sIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>