30812 2009-10-27 02:53:07 -0700 [Regression 50090] Windows and Qt fail new editing/style/remove-nested-inline-styles.html test 2009-10-28 10:33:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P1 Critical --- 30784 1 eric webkit-unassigned adele justin.garcia rniwa oldest_to_newest 158131 0 eric 2009-10-27 02:53:07 -0700 Windows and Qt fail new editing/style/remove-nested-inline-styles.html test http://build.webkit.org/results/Windows%20Release%20(Tests)/r50133%20(5506)/editing/style/remove-nested-inline-styles-pretty-diff.html http://build.webkit.org/results/Qt%20Linux%20Release/r50134%20(3134)/editing/style/remove-nested-inline-styles-pretty-diff.html 158282 1 rniwa 2009-10-27 11:32:03 -0700 This is due to the bug 30784. My patch for 30784 (which has been r- for various reasons) should also fix this bug. 158286 2 rniwa 2009-10-27 11:38:11 -0700 To clarify, on very platform except Mac, executeToggleStyle will check if the entire selection has the specified style. But because of the bug 30784 (nested b'tag result in tri state of false), the selectionHasStyle returns false in Windows and Qt platforms. 158290 3 eric 2009-10-27 11:41:11 -0700 So what's your suggestion for how we should resolve this? We can't leave tests red on the bots. :( Do Windows/Qt need platform-specific results? Should the "failing" section of the test be split out into a mac-only test? 158315 4 rniwa 2009-10-27 12:28:37 -0700 (In reply to comment #3) > So what's your suggestion for how we should resolve this? We can't leave tests > red on the bots. :( > > Do Windows/Qt need platform-specific results? Should the "failing" section of > the test be split out into a mac-only test? I have fixed my patch for the bug 30784. Could you take a look? This should fix Windows build unless I misunderstood the problem and I'm not reproducing the error properly. Around L166 of EditorCommand.cpp inside executeToggleStyle, there is a if-statement that changes behavior for Mac. I have confirmed that this bug is demonstrated when I forced to run the statement in else clause, and is fixed with my patch. I'd like to confirm this on Windows but unfortunately, I don't have access to Windows machine with WebKit check out. 158631 5 rniwa 2009-10-28 10:33:23 -0700 This regression has been fixed in http://trac.webkit.org/changeset/50172.