30811 2009-10-27 02:50:42 -0700 REGRESSION(49818): Tiger fails new fast/js/navigator-language.html test 2009-10-28 10:24:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned commit-queue cshu mjs oldest_to_newest 158130 0 eric 2009-10-27 02:50:42 -0700 http://build.webkit.org/results/Tiger%20Intel%20Release/r50133%20(5583)/results.html http://trac.webkit.org/browser/trunk/LayoutTests/fast/js/navigator-language.html Tiger returns "en" instead of "en-us" as expected. We could fix the Tiger codepath, or easier would be to just update the Tiger results. 158431 1 eric 2009-10-27 17:26:08 -0700 http://trac.webkit.org/changeset/49818 158436 2 eric 2009-10-27 17:47:30 -0700 Here is the file for the mac: http://trac.webkit.org/browser/trunk/WebCore/platform/mac/Language.mm The implementation is in WebKit: http://trac.webkit.org/browser/trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm#L129 Which calls through to here: http://trac.webkit.org/browser/trunk/WebKit/mac/Misc/WebNSUserDefaultsExtras.m I'm not sure what part of that ends up different on Tiger though. None of it is special-cased for Tiger. It's possible that "WKCopyCFLocalizationPreferredName" has a special Tiger implementation and thus is the root of the difference here. Again, for now I think we should just check in the "failing" result for Tiger. 158437 3 eric 2009-10-27 17:49:29 -0700 Really someone at Apple should confirm that we don't care about Tiger being different here. I expect we don't. 158549 4 cshu 2009-10-28 06:23:20 -0700 (In reply to comment #3) > Really someone at Apple should confirm that we don't care about Tiger being > different here. I expect we don't. Eric, I can add the special expected result for Tiger. 158552 5 42025 cshu 2009-10-28 07:04:03 -0700 Created attachment 42025 fix regression 158590 6 42025 commit-queue 2009-10-28 09:35:35 -0700 Comment on attachment 42025 fix regression Rejecting patch 42025 from commit-queue. Chang.Shu@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 158603 7 42025 eric 2009-10-28 09:48:37 -0700 Comment on attachment 42025 fix regression This result looks wrong? I don't see how Tiger would produce this result. It's going to say FAIL instead of PASS. You should pull the result off the tiger bot instead of creating it by hand. http://build.webkit.org/results/Tiger%20Intel%20Release/r50217%20(5641)/fast/js/navigator-language-actual.txt 158605 8 cshu 2009-10-28 09:51:35 -0700 (In reply to comment #7) > (From update of attachment 42025 [details]) > This result looks wrong? I don't see how Tiger would produce this result. > It's going to say FAIL instead of PASS. You should pull the result off the > tiger bot instead of creating it by hand. > http://build.webkit.org/results/Tiger%20Intel%20Release/r50217%20(5641)/fast/js/navigator-language-actual.txt You are right, Eric. Thanks! 158613 9 42040 cshu 2009-10-28 09:57:23 -0700 Created attachment 42040 fix result content 158617 10 42040 eric 2009-10-28 09:59:53 -0700 Comment on attachment 42040 fix result content LGTM. The commit-queue will close the bug. I'm not sure if we need a bug open about tiger's misbehavior here or not. I guess I'll assume not for now. If one of the apple folks feels otherwise they should feel free to re-open. 158618 11 eric 2009-10-28 10:00:29 -0700 Thank you very much for taking care of this Chang. 158624 12 42040 commit-queue 2009-10-28 10:10:15 -0700 Comment on attachment 42040 fix result content Clearing flags on attachment: 42040 Committed r50223: <http://trac.webkit.org/changeset/50223> 158625 13 commit-queue 2009-10-28 10:10:24 -0700 All reviewed patches have been landed. Closing bug. 158628 14 cshu 2009-10-28 10:24:13 -0700 (In reply to comment #11) > Thank you very much for taking care of this Chang. My pleasure. I usually panic when I see my patches cause regression. :) 42025 2009-10-28 07:04:03 -0700 2009-10-28 09:57:23 -0700 fix regression bug30811_1.patch text/plain 1212 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwMjE2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjggIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgc3BlY2lhbCBleHBlY3RlZCB0ZXN0IHJlc3VsdCBmb3IgVGlnZXIgdG8g Zml4IHJlZ3Jlc3Npb24gdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDgxMQorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXRpZ2VyL2Zhc3Qv anMvbmF2aWdhdG9yLWxhbmd1YWdlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMDktMTAtMjgg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXIt c3RhbXBlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtdGlnZXIvZmFzdC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9mYXN0L2pzL25hdmlnYXRvci1s YW5ndWFnZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtdGlnZXIvZmFzdC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKK1Rlc3QgZm9yIGJ1ZyAyOTY1MzogW1F0XSBRdC1iYXNl ZCBicm93c2VyIGZhaWxzIHRvIHNob3cgdGhlIHJpZ2h0IGxhbmd1YWdlIHRyYW5zbGF0aW9uLgor T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgbmF2aWdhdG9yLmxhbmd1YWdlLnRv TG93ZXJDYXNlKCkgaXMgJ2VuJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitU RVNUIENPTVBMRVRFCisK 42040 2009-10-28 09:57:23 -0700 2009-10-28 10:10:15 -0700 fix result content bug30811_2.patch text/plain 1229 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwMjE2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjggIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgc3BlY2lhbCBleHBlY3RlZCB0ZXN0IHJlc3VsdCBmb3IgVGlnZXIgdG8g Zml4IHJlZ3Jlc3Npb24gdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDgxMQorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXRpZ2VyL2Zhc3Qv anMvbmF2aWdhdG9yLWxhbmd1YWdlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMDktMTAtMjgg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXIt c3RhbXBlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtdGlnZXIvZmFzdC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9mYXN0L2pzL25hdmlnYXRvci1s YW5ndWFnZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtdGlnZXIvZmFzdC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKK1Rlc3QgZm9yIGJ1ZyAyOTY1MzogW1F0XSBRdC1iYXNl ZCBicm93c2VyIGZhaWxzIHRvIHNob3cgdGhlIHJpZ2h0IGxhbmd1YWdlIHRyYW5zbGF0aW9uLgor T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK0ZBSUwgbmF2aWdhdG9yLmxhbmd1YWdlLnRv TG93ZXJDYXNlKCkgc2hvdWxkIGJlIGVuLXVzLiBXYXMgZW4uCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwo=