30809 2009-10-27 01:43:44 -0700 buildbots should use --exit-after-N-failures 2009-12-16 16:16:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 eric ossy abarth commit-queue hausmann kenneth mrowe oldest_to_newest 158122 0 eric 2009-10-27 01:43:44 -0700 buildbots should use --exit-after-N-failures http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/6544 has taken over an hour to run because every layout test is crashing! http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/6544/steps/layout-test/logs/stdio It should have exited after the first 10 failures or similar. 158123 1 41936 eric 2009-10-27 01:51:40 -0700 Created attachment 41936 Patch v1 158124 2 41937 eric 2009-10-27 02:05:38 -0700 Created attachment 41937 Upped limit to 20 per Mark's request. Also added failure line to phase output. 158828 3 41937 levin 2009-10-28 21:35:36 -0700 Comment on attachment 41937 Upped limit to 20 per Mark's request. Also added failure line to phase output. Looks good to me and it sounds like you got feedback from Mark as well. I'll not cq+ this at the moment in case anyone else (Mark) wants a last chance to comment. 159699 4 41937 eric 2009-11-01 18:20:12 -0800 Comment on attachment 41937 Upped limit to 20 per Mark's request. Also added failure line to phase output. No comments. Mark has to manually update the buildbots anyway, so he will see it again then. 159713 5 41937 commit-queue 2009-11-01 19:31:02 -0800 Comment on attachment 41937 Upped limit to 20 per Mark's request. Also added failure line to phase output. Clearing flags on attachment: 41937 Committed r50401: <http://trac.webkit.org/changeset/50401> 159714 6 commit-queue 2009-11-01 19:31:07 -0800 All reviewed patches have been landed. Closing bug. 166097 7 43773 ossy 2009-11-24 08:16:33 -0800 Created attachment 43773 upped limit to 40 Yesterday master config was updated and it made QtBuildBot unhappy, because we had 16 failing and 31 new tests. ( 31+16 > 20 ) On the one hand failing tests counter shouldn't include new tests, that's why I propose to modify it: https://bugs.webkit.org/show_bug.cgi?id=31829. On the other hand if a patch committed make some layout tests fail, and later an other patch make more failing tests, etc, we can easily lost which commit caused which fails. If we don't have this information, debugging can be more difficult. We make an effort to fix Qt related bugs ASAP, but quite a lot Qt-port maintainer sleep when american guys work. (because of timezone difference) To make QtBuildbot and Qt guys happier, I suggest increasing the failure limit to 40. 167351 8 abarth 2009-11-30 12:37:20 -0800 style-queue successfully ran check-webkit-style on attachment 43773 without any errors 169923 9 43773 eric 2009-12-09 00:37:24 -0800 Comment on attachment 43773 upped limit to 40 I don't think we want this change. I think this is fixing a symptom, not the root problem. If I correctly overheard in #webkit, Mark Rowe feels similar. 41936 2009-10-27 01:51:40 -0700 2009-10-27 02:05:24 -0700 Patch v1 bug-30809-20091027015138.patch text/plain 1524 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL21hc3Rlci5jZmcgYi9XZWJLaXRUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDYyMTliMGQuLjM1YmVmMTkgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcKKysrIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwpAQCAtMjE1LDcgKzIxNSw3IEBAIGNsYXNz IFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsibGF5 b3V0LXRlc3RzIl0KICAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vV2ViS2l0VG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzIiwgIi0tbm8tbGF1bmNoLXNhZmFyaSIsICItLW5vLW5ldy10ZXN0 LXJlc3VsdHMiLAogICAgICAgICAgICAgICAgIi0tbm8tc2FtcGxlLW9uLXRpbWVvdXQiLCAiLS1y ZXN1bHRzLWRpcmVjdG9yeSIsICJsYXlvdXQtdGVzdC1yZXN1bHRzIiwgIi0tdXNlLXJlbW90ZS1s aW5rcy10by10ZXN0cyIsCi0gICAgICAgICAgICAgICBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZp Z3VyYXRpb24pcyIpXQorICAgICAgICAgICAgICAgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1 cmF0aW9uKXMiKSwgIi0tZXhpdC1hZnRlci1uLWZhaWx1cmVzIiwgIjEwIl0KIAogICAgIGRlZiBf X2luaXRfXyhzZWxmLCBza2lwQnVpbGQ9RmFsc2UsICphcmdzLCAqKmt3YXJncyk6CiAgICAgICAg IHNlbGYuc2tpcEJ1aWxkID0gc2tpcEJ1aWxkCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFu Z2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggZjE0ODIyZS4uNzY5ZjRhZiAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTEwLTI3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBi dWlsZGJvdHMgc2hvdWxkIHVzZSAtLWV4aXQtYWZ0ZXItTi1mYWlsdXJlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA4MDkKKworICAgICAgICBNYWtl IHRoZSBib3RzIGV4aXQgYWZ0ZXIgMTAgZmFpbHVyZXMgdG8gcHJldmVudCBuZXZlci1lbmRpbmcK KyAgICAgICAgdGVzdCBydW5zIHdoZXJlIGV2ZXJ5IHRlc3Qgc3BlbmRzIGEgbWludXRlIGNyYXNo aW5nLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZzoKKwogMjAwOS0xMC0yMCAgQW50b24gTXVoaW4gIDxhbnRvbm1AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu 41937 2009-10-27 02:05:38 -0700 2009-11-01 19:31:02 -0800 Upped limit to 20 per Mark's request. Also added failure line to phase output. bug-30809-20091027020536.patch text/plain 1988 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL21hc3Rlci5jZmcgYi9XZWJLaXRUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDYyMTliMGQuLmQyZGExOTIgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcKKysrIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwpAQCAtMjE1LDcgKzIxNSw3IEBAIGNsYXNz IFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsibGF5 b3V0LXRlc3RzIl0KICAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vV2ViS2l0VG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzIiwgIi0tbm8tbGF1bmNoLXNhZmFyaSIsICItLW5vLW5ldy10ZXN0 LXJlc3VsdHMiLAogICAgICAgICAgICAgICAgIi0tbm8tc2FtcGxlLW9uLXRpbWVvdXQiLCAiLS1y ZXN1bHRzLWRpcmVjdG9yeSIsICJsYXlvdXQtdGVzdC1yZXN1bHRzIiwgIi0tdXNlLXJlbW90ZS1s aW5rcy10by10ZXN0cyIsCi0gICAgICAgICAgICAgICBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZp Z3VyYXRpb24pcyIpXQorICAgICAgICAgICAgICAgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1 cmF0aW9uKXMiKSwgIi0tZXhpdC1hZnRlci1uLWZhaWx1cmVzIiwgIjIwIl0KIAogICAgIGRlZiBf X2luaXRfXyhzZWxmLCBza2lwQnVpbGQ9RmFsc2UsICphcmdzLCAqKmt3YXJncyk6CiAgICAgICAg IHNlbGYuc2tpcEJ1aWxkID0gc2tpcEJ1aWxkCkBAIC0yNDAsNiArMjQwLDggQEAgY2xhc3MgUnVu V2ViS2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgICAgICAgICAgaW5jb3JyZWN0TGF5b3V0 TGluZXMuYXBwZW5kKGxpbmUpCiAgICAgICAgICAgICBlbGlmIGxpbmUuc3RhcnRzd2l0aCgiV0FS TklORzoiKSBhbmQgbGluZS5maW5kKCcgbGVhaycpID49IDA6CiAgICAgICAgICAgICAgICAgaW5j b3JyZWN0TGF5b3V0TGluZXMuYXBwZW5kKGxpbmUucmVwbGFjZSgnV0FSTklORzogJywgJycpKQor ICAgICAgICAgICAgZWxpZiBsaW5lLmZpbmQoJ0V4aXRpbmcgZWFybHknKSA+PSAwOgorICAgICAg ICAgICAgICAgIGluY29ycmVjdExheW91dExpbmVzLmFwcGVuZChsaW5lKQogCiAgICAgICAgICAg ICAjIEZJWE1FOiBEZXRlY3QgYW5kIHN1bW1hcml6ZSBsZWFrcyBvZiBSZWZDb3VudGVkIG9iamVj dHMKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCmluZGV4IGE0NGNlN2EuLjNlNjhhNmMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0No YW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAw OS0xMC0yNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYnVpbGRib3RzIHNob3VsZCB1c2UgLS1l eGl0LWFmdGVyLU4tZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMwODA5CisKKyAgICAgICAgTWFrZSB0aGUgYm90cyBleGl0IGFmdGVyIDIw IGZhaWx1cmVzIHRvIHByZXZlbnQgbmV2ZXItZW5kaW5nCisgICAgICAgIHRlc3QgcnVucyB3aGVy ZSBldmVyeSB0ZXN0IHNwZW5kcyBhIG1pbnV0ZSBjcmFzaGluZy4KKworICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisKIDIwMDkt MTAtMjYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIE5vIHJldmll dywganVzdCBhZGRpbmcgTWlrZSBCZWxzaGUgdG8gdGhlIGNvbW1pdHRlcnMgbGlzdC4= 43773 2009-11-24 08:16:33 -0800 2009-12-09 00:37:23 -0800 upped limit to 40 master_config.patch text/plain 1498 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL21hc3Rlci5jZmcgYi9XZWJLaXRUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGNkODExMDguLjljMTM2MzIgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcKKysrIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwpAQCAtMTc0LDcgKzE3NCw3IEBAIGNsYXNz IFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsibGF5 b3V0LXRlc3RzIl0KICAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vV2ViS2l0VG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzIiwgIi0tbm8tbGF1bmNoLXNhZmFyaSIsICItLW5vLW5ldy10ZXN0 LXJlc3VsdHMiLAogICAgICAgICAgICAgICAgIi0tbm8tc2FtcGxlLW9uLXRpbWVvdXQiLCAiLS1y ZXN1bHRzLWRpcmVjdG9yeSIsICJsYXlvdXQtdGVzdC1yZXN1bHRzIiwgIi0tdXNlLXJlbW90ZS1s aW5rcy10by10ZXN0cyIsCi0gICAgICAgICAgICAgICBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZp Z3VyYXRpb24pcyIpLCAiLS1leGl0LWFmdGVyLW4tZmFpbHVyZXMiLCAiMjAiXQorICAgICAgICAg ICAgICAgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKSwgIi0tZXhpdC1hZnRl ci1uLWZhaWx1cmVzIiwgIjQwIl0KIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBza2lwQnVpbGQ9 RmFsc2UsICphcmdzLCAqKmt3YXJncyk6CiAgICAgICAgIHNlbGYuc2tpcEJ1aWxkID0gc2tpcEJ1 aWxkCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFu Z2VMb2cKaW5kZXggMzkyOTVmOS4uMzU1OGVkOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5 LTExLTI0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYnVpbGRib3RzIHNob3VsZCB1 c2UgLS1leGl0LWFmdGVyLU4tZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwODA5CisKKyAgICAgICAgRmFpbHVyZXMgbGltaXQgaW5jcmVh c2VkIHRvIDQwLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvbWFzdGVyLmNmZzoKKwogMjAwOS0xMS0yMyAgTGFzemxvIEdvbWJvcyAgPGxhc3ps by4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCg==