30808 2009-10-27 00:08:11 -0700 chromium test_shell crash in WebSocket when running LayoutTests 2009-10-27 10:01:02 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned commit-queue oldest_to_newest 158106 0 ukai 2009-10-27 00:08:11 -0700 When running LayoutTests by chromium test_shell, test_shell crashes in WebSocket code. > test_shell.exe!WebCore::WebSocket::didClose() Line 216 + 0x70 bytes C++ test_shell.exe!WebCore::WebSocketChannel::didClose(WebCore::SocketStreamHandle * handle=0x03dc01f0) Line 135 + 0x9 bytes C++ test_shell.exe!WebCore::SocketStreamHandleInternal::didClose(WebKit::WebSocketStreamHandle * socketHandle=0x018ffeb8) Line 186 + 0xb bytes C++ test_shell.exe!webkit_glue::WebSocketStreamHandleImpl::Context::DidClose(WebKit::WebSocketStreamHandle * web_handle=0x03f8ec00) Line 144 C++ test_shell.exe!`anonymous namespace'::WebSocketStreamHandleBridgeImpl::DoOnClose() Line 213 C++ test_shell.exe!MessageLoop::RunTask(Task * task=0x03e88a68) Line 315 C++ test_shell.exe!MessageLoop::DoWork() Line 437 C++ test_shell.exe!base::MessagePumpForUI::DoRunLoop() Line 210 C++ 158112 1 41934 ukai 2009-10-27 00:45:23 -0700 Created attachment 41934 Fix crash found in chromium test_shell. 158193 2 41934 dglazkov 2009-10-27 07:50:22 -0700 Comment on attachment 41934 Fix crash found in chromium test_shell. It would be great to capture this in a layout test. r=me because I'd like to get rid of the sporadic crashing on buildbots, but please follow up and write a test for it. 158198 3 41934 dglazkov 2009-10-27 08:30:38 -0700 Comment on attachment 41934 Fix crash found in chromium test_shell. cq ftw! 158227 4 41934 commit-queue 2009-10-27 10:00:58 -0700 Comment on attachment 41934 Fix crash found in chromium test_shell. Clearing flags on attachment: 41934 Committed r50155: <http://trac.webkit.org/changeset/50155> 158228 5 commit-queue 2009-10-27 10:01:02 -0700 All reviewed patches have been landed. Closing bug. 41934 2009-10-27 00:45:23 -0700 2009-10-27 10:00:58 -0700 Fix crash found in chromium test_shell. bug-30808-20091027164520.patch text/plain 5608 ukai ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTBmOWMyMi4uZGRmODhkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMyBAQAorMjAwOS0xMC0yNyAgRnVtaXRvc2hpIFVr YWkgIDx1a2FpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY3Jhc2ggZm91bmQgaW4gY2hyb21pdW0gdGVzdF9zaGVsbC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODA4CisK KyAgICAgICAgV2hlbiBXZWJTb2NrZXQgaXMgZGVsZXRlZCB3aXRob3V0IGNsb3NlLCB3ZWJraXQg d291bGQgY3Jhc2gKKyAgICAgICAgd2hlbiBpdCBoYW5kbGVzIGRpZENsb3NlLgorCisgICAgICAg IENoZWNrIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgYmVmb3JlIHBvc3QgdGFzayBmb3IgZXZlbnQu CisgICAgICAgIFVzZSBXZWJTb2NrZXRDaGFubmVsOjpkaXNjb25uZWN0KCkgaW5zdGVhZCBvZiBj bG9zZSgpIGluIFdlYlNvY2tldAorICAgICAgICBkZXN0cnVjdG9yLCBzbyB0aGF0IFdlYlNvY2tl dENoYW5uZWwgc2hvdWxkIG5vdCBjYWxsIGRlbGV0ZWQgV2ViU29ja2V0CisgICAgICAgIGJhY2sg aW4gZGlkQ2xvc2UoKS4KKyAgICAgICAgVG8gbWFrZSBzdXJlIFdlYlNvY2tldENoYW5uZWwgYWxp dmUgd2hpbGUgaXQgaXMgcHJvY2Vzc2luZyBXZWJTb2NrZXQKKyAgICAgICAgcHJvdG9jb2wgb3Zl ciBTb2NrZXRTdHJlYW1IYW5kbGUsIHJlZigpIGluIGNvbm5lY3QoKSBhbmQgZGVyZWYoKSBpbgor ICAgICAgICBkaWRDbG9zZSgpLgorCisgICAgICAgICogd2Vic29ja2V0cy9XZWJTb2NrZXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Ojp+V2ViU29ja2V0KToKKyAgICAgICAgKFdl YkNvcmU6OldlYlNvY2tldDo6ZGlkQ29ubmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpXZWJTb2Nr ZXQ6OmRpZFJlY2VpdmVNZXNzYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYlNvY2tldDo6ZGlk Q2xvc2UpOgorICAgICAgICAqIHdlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsOjpjb25uZWN0KToKKyAgICAgICAgKFdlYkNv cmU6OldlYlNvY2tldENoYW5uZWw6OmRpc2Nvbm5lY3QpOgorICAgICAgICAoV2ViQ29yZTo6V2Vi U29ja2V0Q2hhbm5lbDo6ZGlkQ2xvc2UpOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Q2hh bm5lbDo6ZGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAqIHdlYnNvY2tldHMvV2ViU29ja2V0Q2hh bm5lbC5oOgorCiAyMDA5LTEwLTI2ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5v a2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS93ZWJz b2NrZXRzL1dlYlNvY2tldC5jcHAgYi9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcApp bmRleCBmM2JiZGQ3Li4zMmUwNTU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dlYnNvY2tldHMvV2Vi U29ja2V0LmNwcAorKysgYi9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcApAQCAtMTEw LDcgKzExMCw4IEBAIFdlYlNvY2tldDo6V2ViU29ja2V0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IGNvbnRleHQpCiAKIFdlYlNvY2tldDo6fldlYlNvY2tldCgpCiB7Ci0gICAgY2xvc2UoKTsKKyAg ICBpZiAobV9jaGFubmVsLmdldCgpKQorICAgICAgICBtX2NoYW5uZWwtPmRpc2Nvbm5lY3QoKTsK IH0KIAogdm9pZCBXZWJTb2NrZXQ6OmNvbm5lY3QoY29uc3QgS1VSTCYgdXJsLCBFeGNlcHRpb25D b2RlJiBlYykKQEAgLTE5MCw3ICsxOTEsNyBAQCBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBXZWJT b2NrZXQ6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdAogdm9pZCBXZWJTb2NrZXQ6OmRp ZENvbm5lY3QoKQogewogICAgIExPRyhOZXR3b3JrLCAiV2ViU29ja2V0ICVwIGRpZENvbm5lY3Qi LCB0aGlzKTsKLSAgICBpZiAobV9zdGF0ZSAhPSBDT05ORUNUSU5HKSB7CisgICAgaWYgKG1fc3Rh dGUgIT0gQ09OTkVDVElORyB8fCAhc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKSB7CiAgICAgICAg IGRpZENsb3NlKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0yMDEsNyArMjAyLDcgQEAg dm9pZCBXZWJTb2NrZXQ6OmRpZENvbm5lY3QoKQogdm9pZCBXZWJTb2NrZXQ6OmRpZFJlY2VpdmVN ZXNzYWdlKGNvbnN0IFN0cmluZyYgbXNnKQogewogICAgIExPRyhOZXR3b3JrLCAiV2ViU29ja2V0 ICVwIGRpZFJlY2VpdmVNZXNzYWdlICVzIiwgdGhpcywgbXNnLnV0ZjgoKS5kYXRhKCkpOwotICAg IGlmIChtX3N0YXRlICE9IE9QRU4pCisgICAgaWYgKG1fc3RhdGUgIT0gT1BFTiB8fCAhc2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpKQogICAgICAgICByZXR1cm47CiAgICAgUmVmUHRyPE1lc3NhZ2VF dmVudD4gZXZ0ID0gTWVzc2FnZUV2ZW50OjpjcmVhdGUoKTsKICAgICAvLyBGSVhNRTogb3JpZ2lu LCBsYXN0RXZlbnRJZCwgc291cmNlLCBtZXNzYWdlUG9ydC4KQEAgLTIxMyw3ICsyMTQsOCBAQCB2 b2lkIFdlYlNvY2tldDo6ZGlkQ2xvc2UoKQogewogICAgIExPRyhOZXR3b3JrLCAiV2ViU29ja2V0 ICVwIGRpZENsb3NlIiwgdGhpcyk7CiAgICAgbV9zdGF0ZSA9IENMT1NFRDsKLSAgICBzY3JpcHRF eGVjdXRpb25Db250ZXh0KCktPnBvc3RUYXNrKFByb2Nlc3NXZWJTb2NrZXRFdmVudFRhc2s6OmNy ZWF0ZSh0aGlzLCBFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5jbG9zZUV2ZW50LCBmYWxzZSwg ZmFsc2UpKSk7CisgICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKKyAgICAgICAgc2Ny aXB0RXhlY3V0aW9uQ29udGV4dCgpLT5wb3N0VGFzayhQcm9jZXNzV2ViU29ja2V0RXZlbnRUYXNr OjpjcmVhdGUodGhpcywgRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuY2xvc2VFdmVudCwgZmFs c2UsIGZhbHNlKSkpOwogfQogCiBFdmVudFRhcmdldERhdGEqIFdlYlNvY2tldDo6ZXZlbnRUYXJn ZXREYXRhKCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVs LmNwcCBiL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAppbmRleCA1Y2Ji ZDI0Li5iZTM4OGI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hh bm5lbC5jcHAKKysrIGIvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCkBA IC03MSw2ICs3MSw3IEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6Y29ubmVjdCgpCiAgICAgTE9H KE5ldHdvcmssICJXZWJTb2NrZXRDaGFubmVsICVwIGNvbm5lY3QiLCB0aGlzKTsKICAgICBBU1NF UlQoIW1faGFuZGxlLmdldCgpKTsKICAgICBtX2hhbmRzaGFrZS5yZXNldCgpOworICAgIHJlZigp OwogICAgIG1faGFuZGxlID0gU29ja2V0U3RyZWFtSGFuZGxlOjpjcmVhdGUobV9oYW5kc2hha2Uu dXJsKCksIHRoaXMpOwogfQogCkBAIC0xMDMsNiArMTA0LDE0IEBAIHZvaWQgV2ViU29ja2V0Q2hh bm5lbDo6Y2xvc2UoKQogICAgICAgICBtX2hhbmRsZS0+Y2xvc2UoKTsgIC8vIHdpbGwgY2FsbCBk aWRDbG9zZSgpCiB9CiAKK3ZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlzY29ubmVjdCgpCit7Cisg ICAgTE9HKE5ldHdvcmssICJXZWJTb2NrZXRDaGFubmVsICVwIGRpc2Nvbm5lY3QiLCB0aGlzKTsK KyAgICBtX2NsaWVudCA9IDA7CisgICAgaWYgKG1faGFuZGxlLmdldCgpKQorICAgICAgICBtX2hh bmRsZS0+Y2xvc2UoKTsKK30KKwogdm9pZCBXZWJTb2NrZXRDaGFubmVsOjp3aWxsT3BlblN0cmVh bShTb2NrZXRTdHJlYW1IYW5kbGUqLCBjb25zdCBLVVJMJikKIHsKIH0KQEAgLTEyNiwxMyArMTM1 LDE1IEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkQ2xvc2UoU29ja2V0U3RyZWFtSGFuZGxl KiBoYW5kbGUpCiB7CiAgICAgTE9HKE5ldHdvcmssICJXZWJTb2NrZXRDaGFubmVsICVwIGRpZENs b3NlIiwgdGhpcyk7CiAgICAgQVNTRVJUKGhhbmRsZSA9PSBtX2hhbmRsZS5nZXQoKSB8fCAhbV9o YW5kbGUuZ2V0KCkpOwotICAgIGlmICghbV9oYW5kbGUuZ2V0KCkpCi0gICAgICAgIHJldHVybjsK LSAgICBtX3VuaGFuZGxlZEJ1ZmZlclNpemUgPSBoYW5kbGUtPmJ1ZmZlcmVkQW1vdW50KCk7Ci0g ICAgV2ViU29ja2V0Q2hhbm5lbENsaWVudCogY2xpZW50ID0gbV9jbGllbnQ7Ci0gICAgbV9jbGll bnQgPSAwOwotICAgIG1faGFuZGxlID0gMDsKLSAgICBjbGllbnQtPmRpZENsb3NlKCk7CisgICAg aWYgKG1faGFuZGxlLmdldCgpKSB7CisgICAgICAgIG1fdW5oYW5kbGVkQnVmZmVyU2l6ZSA9IGhh bmRsZS0+YnVmZmVyZWRBbW91bnQoKTsKKyAgICAgICAgV2ViU29ja2V0Q2hhbm5lbENsaWVudCog Y2xpZW50ID0gbV9jbGllbnQ7CisgICAgICAgIG1fY2xpZW50ID0gMDsKKyAgICAgICAgbV9oYW5k bGUgPSAwOworICAgICAgICBpZiAoY2xpZW50KQorICAgICAgICAgICAgY2xpZW50LT5kaWRDbG9z ZSgpOworICAgIH0KKyAgICBkZXJlZigpOwogfQogCiB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRp ZFJlY2VpdmVEYXRhKFNvY2tldFN0cmVhbUhhbmRsZSogaGFuZGxlLCBjb25zdCBjaGFyKiBkYXRh LCBpbnQgbGVuKQpAQCAtMTQzLDYgKzE1NCwxMCBAQCB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRp ZFJlY2VpdmVEYXRhKFNvY2tldFN0cmVhbUhhbmRsZSogaGFuZGxlLCBjb25zdCBjaGFyKiBkYQog ICAgICAgICBoYW5kbGUtPmNsb3NlKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisgICAgaWYg KCFtX2NsaWVudCkgeworICAgICAgICBoYW5kbGUtPmNsb3NlKCk7CisgICAgICAgIHJldHVybjsK KyAgICB9CiAgICAgaWYgKG1faGFuZHNoYWtlLm1vZGUoKSAhPSBXZWJTb2NrZXRIYW5kc2hha2U6 OkNvbm5lY3RlZCkgewogICAgICAgICBpbnQgaGVhZGVyTGVuZ3RoID0gbV9oYW5kc2hha2UucmVh ZFNlcnZlckhhbmRzaGFrZShtX2J1ZmZlciwgbV9idWZmZXJTaXplKTsKICAgICAgICAgaWYgKGhl YWRlckxlbmd0aCA8PSAwKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tl dENoYW5uZWwuaCBiL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmgKaW5kZXgg MjY4ZDExMy4uYWQzODE2MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tl dENoYW5uZWwuaAorKysgYi9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5oCkBA IC01Nyw2ICs1Nyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2aXJ0dWFsIHZv aWQgY2xvc2UoKTsKIAorICAgICAgICB2aXJ0dWFsIHZvaWQgZGlzY29ubmVjdCgpOworCiAgICAg ICAgIHZpcnR1YWwgdm9pZCB3aWxsT3BlblN0cmVhbShTb2NrZXRTdHJlYW1IYW5kbGUqLCBjb25z dCBLVVJMJik7CiAgICAgICAgIHZpcnR1YWwgdm9pZCB3aWxsU2VuZERhdGEoU29ja2V0U3RyZWFt SGFuZGxlKiwgY29uc3QgY2hhciosIGludCk7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRPcGVu KFNvY2tldFN0cmVhbUhhbmRsZSopOw==