30794 2009-10-26 15:50:40 -0700 [V8] Tidy up the DOM Storage runtime flag stuff 2009-10-26 16:45:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow dglazkov dumi oldest_to_newest 157982 0 jorlow 2009-10-26 15:50:40 -0700 Clean up the DOM Storage runtime flag stuff to match the new way of doing things. 157983 1 41908 jorlow 2009-10-26 15:52:48 -0700 Created attachment 41908 Patch v1 157985 2 41908 dglazkov 2009-10-26 15:55:48 -0700 Comment on attachment 41908 Patch v1 r=me, except -- I don't know for sure, but I think all new code uses just camelCase for statics. Can you change that back? 157996 3 dumi 2009-10-26 16:11:21 -0700 I've seen more static variables without s_, and Eric raised the same question when I uploaded a patch with s_ static variables. So I think we should get rid of the s_ prefix. Also, I don't see why 'enabled' is better than 'isEnabled': ~15 'bool enabled' parameters in ~5 different .cpp files in all of WebCore can hardly be called a 'standard'. But I don't feel strongly about this. 158005 4 jorlow 2009-10-26 16:16:27 -0700 I switched back to isBlahBlahEnabled and isEnabled. Didn't realize those were the more accepted conventions. (Kind of wish that, whenever such decisions are made, that people would just change everything over right away....it's so hard knowing what's currently in favor!) 158018 5 jorlow 2009-10-26 16:45:18 -0700 Committed r50113: <http://trac.webkit.org/changeset/50113> 41908 2009-10-26 15:52:48 -0700 2009-10-26 15:55:48 -0700 Patch v1 bug-30794-20091026155247.patch text/plain 5452 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDEwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDktMTAtMjYgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W1Y4XSBUaWR5IHVwIHRoZSBET00gU3RvcmFnZSBydW50aW1lIGZsYWcgc3R1ZmYKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzk0CisKKyAgICAgICAg Q2xlYW4gdXAgdGhlIERPTSBTdG9yYWdlIHJ1bnRpbWUgZmxhZyBzdHVmZiB0byBtYXRjaCB0aGUg bmV3IHdheSBvZiBkb2luZworICAgICAgICB0aGluZ3MuICBObyBiZWhhdmlvcmFsIGNoYW5nZXMu CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmg6CisgICAgICAgIChX ZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXREYXRhYmFzZUVuYWJsZWQpOgorICAg ICAgICAoV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6ZGF0YWJhc2VFbmFibGVkKToK KyAgICAgICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldExvY2FsU3RvcmFn ZUVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6bG9j YWxTdG9yYWdlRW5hYmxlZCk6CisgICAgICAgIChXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1 cmVzOjpzZXRTZXNzaW9uU3RvcmFnZUVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6UnVudGlt ZUVuYWJsZWRGZWF0dXJlczo6c2Vzc2lvblN0b3JhZ2VFbmFibGVkKToKKyAgICAgICAgKiBiaW5k aW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QUNDRVNTT1JfUlVOVElNRV9FTkFCTEVSKToKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2UuY3Bw OgorICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZS5oOgorCiAyMDA5LTEwLTI2ICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNw cAkocmV2aXNpb24gNTAwODYpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1J1bnRpbWVFbmFibGVk RmVhdHVyZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw4IEBACiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAotYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0RhdGFiYXNlRW5h YmxlZCA9IGZhbHNlOworYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzX2RhdGFiYXNlRW5h YmxlZCA9IGZhbHNlOworYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzX2xvY2FsU3RvcmFn ZUVuYWJsZWQgPSBmYWxzZTsKK2Jvb2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c19zZXNzaW9u U3RvcmFnZUVuYWJsZWQgPSBmYWxzZTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDog V2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgJKHJldmlzaW9u IDUwMDg2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM2LDEzICszNiwyMiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAv LyBBIGNsYXNzIHRoYXQgc3RvcmVzIHN0YXRpYyBlbmFibGVycyBmb3IgYWxsIGV4cGVyaW1lbnRh bCBmZWF0dXJlcwogY2xhc3MgUnVudGltZUVuYWJsZWRGZWF0dXJlcyB7CiBwdWJsaWM6Ci0gICAg c3RhdGljIHZvaWQgc2V0RGF0YWJhc2VFbmFibGVkKGJvb2wgaXNFbmFibGVkKSB7IGlzRGF0YWJh c2VFbmFibGVkID0gaXNFbmFibGVkOyB9Ci0gICAgc3RhdGljIGJvb2wgZGF0YWJhc2VFbmFibGVk KCkgeyByZXR1cm4gaXNEYXRhYmFzZUVuYWJsZWQ7IH0KKyAgICBzdGF0aWMgdm9pZCBzZXREYXRh YmFzZUVuYWJsZWQoYm9vbCBlbmFibGVkKSB7IHNfZGF0YWJhc2VFbmFibGVkID0gZW5hYmxlZDsg fQorICAgIHN0YXRpYyBib29sIGRhdGFiYXNlRW5hYmxlZCgpIHsgcmV0dXJuIHNfZGF0YWJhc2VF bmFibGVkOyB9CisKKyAgICBzdGF0aWMgdm9pZCBzZXRMb2NhbFN0b3JhZ2VFbmFibGVkKGJvb2wg ZW5hYmxlZCkgeyBzX2xvY2FsU3RvcmFnZUVuYWJsZWQgPSBlbmFibGVkOyB9CisgICAgc3RhdGlj IGJvb2wgbG9jYWxTdG9yYWdlRW5hYmxlZCgpIHsgcmV0dXJuIHNfbG9jYWxTdG9yYWdlRW5hYmxl ZDsgfQorCisgICAgc3RhdGljIHZvaWQgc2V0U2Vzc2lvblN0b3JhZ2VFbmFibGVkKGJvb2wgZW5h YmxlZCkgeyBzX3Nlc3Npb25TdG9yYWdlRW5hYmxlZCA9IGVuYWJsZWQ7IH0KKyAgICBzdGF0aWMg Ym9vbCBzZXNzaW9uU3RvcmFnZUVuYWJsZWQoKSB7IHJldHVybiBzX3Nlc3Npb25TdG9yYWdlRW5h YmxlZDsgfQogCiBwcml2YXRlOgorICAgIC8vIE5ldmVyIGluc3RhbnRpYXRlLgogICAgIFJ1bnRp bWVFbmFibGVkRmVhdHVyZXMoKSB7IH0KIAotICAgIHN0YXRpYyBib29sIGlzRGF0YWJhc2VFbmFi bGVkOworICAgIHN0YXRpYyBib29sIHNfZGF0YWJhc2VFbmFibGVkOworICAgIHN0YXRpYyBib29s IHNfbG9jYWxTdG9yYWdlRW5hYmxlZDsKKyAgICBzdGF0aWMgYm9vbCBzX3Nlc3Npb25TdG9yYWdl RW5hYmxlZDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHJldmlzaW9uIDUw MDg2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yOTIsMTIgKzI5MiwxMiBAQCBBQ0NFU1NPUl9SVU5USU1FX0VO QUJMRVIoRE9NV2luZG93T3BlbkRhCiAjaWYgRU5BQkxFKERPTV9TVE9SQUdFKQogQUNDRVNTT1Jf UlVOVElNRV9FTkFCTEVSKERPTVdpbmRvd0xvY2FsU3RvcmFnZSkKIHsKLSAgICByZXR1cm4gU3Rv cmFnZTo6bG9jYWxTdG9yYWdlQXZhaWxhYmxlKCk7CisgICAgcmV0dXJuIFJ1bnRpbWVFbmFibGVk RmVhdHVyZXM6OmxvY2FsU3RvcmFnZUVuYWJsZWQoKTsKIH0KIAogQUNDRVNTT1JfUlVOVElNRV9F TkFCTEVSKERPTVdpbmRvd1Nlc3Npb25TdG9yYWdlKQogewotICAgIHJldHVybiBTdG9yYWdlOjpz ZXNzaW9uU3RvcmFnZUF2YWlsYWJsZSgpOworICAgIHJldHVybiBSdW50aW1lRW5hYmxlZEZlYXR1 cmVzOjpzZXNzaW9uU3RvcmFnZUVuYWJsZWQoKTsKIH0KICNlbmRpZgogCkluZGV4OiBXZWJDb3Jl L3N0b3JhZ2UvU3RvcmFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdG9yYWdlL1N0b3Jh Z2UuY3BwCShyZXZpc2lvbiA1MDA4NikKKysrIFdlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzQsMzIgKzM0LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewog Ci0jaWYgVVNFKFY4KQotLy8gRklYTUU6IFJlbW92ZSBvbmNlIHRoZXNlIGZlYXR1cmVzIGFyZSB0 dXJuZWQgb24gYnkgZGVmYXVsdCBpbiBDaHJvbWl1bS4KLXN0YXRpYyBib29sIHNfbG9jYWxTdG9y YWdlQXZhaWxhYmxlID0gdHJ1ZTsKLXN0YXRpYyBib29sIHNfc2Vzc2lvblN0b3JhZ2VBdmFpbGFi bGUgPSB0cnVlOwotCi12b2lkIFN0b3JhZ2U6OnNldExvY2FsU3RvcmFnZUF2YWlsYWJsZShib29s IGF2YWlsYWJsZSkKLXsKLSAgICBzX2xvY2FsU3RvcmFnZUF2YWlsYWJsZSA9IGF2YWlsYWJsZTsK LX0KLQotYm9vbCBTdG9yYWdlOjpsb2NhbFN0b3JhZ2VBdmFpbGFibGUoKQotewotICAgIHJldHVy biBzX2xvY2FsU3RvcmFnZUF2YWlsYWJsZTsKLX0KLQotdm9pZCBTdG9yYWdlOjpzZXRTZXNzaW9u U3RvcmFnZUF2YWlsYWJsZShib29sIGF2YWlsYWJsZSkKLXsKLSAgICBzX3Nlc3Npb25TdG9yYWdl QXZhaWxhYmxlID0gYXZhaWxhYmxlOwotfQotCi1ib29sIFN0b3JhZ2U6OnNlc3Npb25TdG9yYWdl QXZhaWxhYmxlKCkKLXsKLSAgICByZXR1cm4gc19zZXNzaW9uU3RvcmFnZUF2YWlsYWJsZTsKLX0K LSNlbmRpZgotCiBQYXNzUmVmUHRyPFN0b3JhZ2U+IFN0b3JhZ2U6OmNyZWF0ZShGcmFtZSogZnJh bWUsIFBhc3NSZWZQdHI8U3RvcmFnZUFyZWE+IHN0b3JhZ2VBcmVhKQogewogICAgIHJldHVybiBh ZG9wdFJlZihuZXcgU3RvcmFnZShmcmFtZSwgc3RvcmFnZUFyZWEpKTsKSW5kZXg6IFdlYkNvcmUv c3RvcmFnZS9TdG9yYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2Uu aAkocmV2aXNpb24gNTAwODYpCisrKyBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZS5oCSh3b3JraW5n IGNvcHkpCkBAIC00NCwxMyArNDQsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHN0 YXRpYyBQYXNzUmVmUHRyPFN0b3JhZ2U+IGNyZWF0ZShGcmFtZSosIFBhc3NSZWZQdHI8U3RvcmFn ZUFyZWE+KTsKICAgICAgICAgflN0b3JhZ2UoKTsKIAotI2lmIFVTRShWOCkKLSAgICAgICAgc3Rh dGljIHZvaWQgc2V0TG9jYWxTdG9yYWdlQXZhaWxhYmxlKGJvb2wpOwotICAgICAgICBzdGF0aWMg Ym9vbCBsb2NhbFN0b3JhZ2VBdmFpbGFibGUoKTsKLSAgICAgICAgc3RhdGljIHZvaWQgc2V0U2Vz c2lvblN0b3JhZ2VBdmFpbGFibGUoYm9vbCk7Ci0gICAgICAgIHN0YXRpYyBib29sIHNlc3Npb25T dG9yYWdlQXZhaWxhYmxlKCk7Ci0jZW5kaWYKLQogICAgICAgICB1bnNpZ25lZCBsZW5ndGgoKSBj b25zdDsKICAgICAgICAgU3RyaW5nIGtleSh1bnNpZ25lZCBpbmRleCkgY29uc3Q7CiAgICAgICAg IFN0cmluZyBnZXRJdGVtKGNvbnN0IFN0cmluZyYpIGNvbnN0Ow==