30781 2009-10-26 11:49:20 -0700 noreferrer links currently suppress window.opener in origin frame incorrectly 2009-10-26 14:02:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet ap commit-queue oldest_to_newest 157843 0 japhet 2009-10-26 11:49:20 -0700 A noreferrer link should only suppress window.opener if the link is a <a rel="noreferrer" target="_blank">, and only in the new frame. I am incorrectly calling setOpener(0) for the original FrameLoader, causing window.opener to be nulled in the origin frame (which shouldn't happen in any case, even if we're opening a noreferrer link in the current frame). 157847 1 41880 japhet 2009-10-26 11:55:33 -0700 Created attachment 41880 patch + updated layout test 157866 2 41880 ap 2009-10-26 12:30:15 -0700 Comment on attachment 41880 patch + updated layout test r=me It would help to have the reasons for this change documented here for posterity (the bug description says "should", but doesn't explain why - are we following the spec? other browser's behavior? fixing website compatibility? just pure common sense?). This change seems logical though. 157870 3 japhet 2009-10-26 12:36:59 -0700 (In reply to comment #2) > (From update of attachment 41880 [details]) > r=me > > It would help to have the reasons for this change documented here for posterity > (the bug description says "should", but doesn't explain why - are we following > the spec? other browser's behavior? fixing website compatibility? just pure > common sense?). This change seems logical though. Certainly, sorry for not including that. After discussions with a couple of chromium folks that initially helped me realize something wasn't quite right, I posted to whatwg ( http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023800.html ) The spec (http://www.whatwg.org/specs/web-apps/current-work/#link-type-noreferrer) only states that opener should remain null when a noreferrer link is opened in a new browsing context. In the absence of specific instructions on what to do when opened in an existing context, I seem to have extrapolated incorrectly. 157883 4 41880 commit-queue 2009-10-26 13:04:31 -0700 Comment on attachment 41880 patch + updated layout test Rejecting patch 41880 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/navigation/no-referrer-reset-expected.txt M LayoutTests/http/tests/navigation/no-referrer-reset.html M WebCore/ChangeLog M WebCore/loader/FrameLoader.cpp Merge conflict during commit: MERGE request failed on '/repository/webkit/trunk': Conflict at '/trunk/WebCore/ChangeLog' at /usr/local/libexec/git-core//git-svn line 469 157890 5 41880 eric 2009-10-26 13:41:52 -0700 Comment on attachment 41880 patch + updated layout test bugzilla-tool has code to catch this type of error. That's not an expected error from git svn. Perhaps it was related the fact that svn.webkit.org went down right as/after this commit happened... Trying again. 157896 6 41880 commit-queue 2009-10-26 13:45:41 -0700 Comment on attachment 41880 patch + updated layout test Rejecting patch 41880 from commit-queue. Failed to run "WebKitTools/Scripts/build-webkit" exit_code: 1 Last 500 characters of output: l/Projects/build/WebCore.build/Release/WebCore.build/Script-5D0D540D0E9862F60029E223.sh Touch /Users/eseidel/Projects/build/Release/WebCore.framework cd /Users/eseidel/Projects/CommitQueue/WebCore /usr/bin/touch -c /Users/eseidel/Projects/build/Release/WebCore.framework ** BUILD FAILED ** The following build commands failed: Derived Sources: PhaseScriptExecution "/Users/eseidel/Projects/build/WebCore.build/Release/Derived Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh" (1 failure) 157898 7 41880 eric 2009-10-26 13:48:09 -0700 Comment on attachment 41880 patch + updated layout test Some cosmic power does not want this patch landed. Lets try again, this could be exciting! :) 157913 8 41880 commit-queue 2009-10-26 14:02:23 -0700 Comment on attachment 41880 patch + updated layout test Clearing flags on attachment: 41880 Committed r50092: <http://trac.webkit.org/changeset/50092> 157914 9 commit-queue 2009-10-26 14:02:29 -0700 All reviewed patches have been landed. Closing bug. 41880 2009-10-26 11:55:33 -0700 2009-10-26 14:02:22 -0700 patch + updated layout test patch.txt text/plain 4643 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDA3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMjYgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE b24ndCBzZXQgd2luZG93Lm9wZW5lciB0byAwIGZvciB0aGUgY3VycmVudCBGcmFtZUxvYWRlciBp ZiBhIG5vcmVmZXJyZXIgbGluayB3YXMgY2xpY2tlZCwgb25seSBzdXBwcmVzcyBvcGVuZXIgaW4g YSBuZXcgZnJhbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDc4MQorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lTG9hZGVyOjp1cmxTZWxlY3RlZCk6IERvbid0IHN1cHByZXNzIG9wZW5l ciBpbiB0aGUgY3VycmVudCBmcmFtZSBmb3Igbm9yZWZlcnJlciBuYXZpZ2F0aW9ucy4KKwogMjAw OS0xMC0yNiAgTWlrZSBCZWxzaGUgIDxtaWtlQGJlbHNoZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24g NTAwNzEpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTMzNywxMCArMzM3LDkgQEAgdm9pZCBGcmFtZUxvYWRlcjo6dXJsU2VsZWN0ZWQoY29uc3Qg UmVzbwogCiAgICAgRnJhbWVMb2FkUmVxdWVzdCBmcmFtZVJlcXVlc3QocmVxdWVzdCwgdGFyZ2V0 KTsKIAotICAgIGlmIChyZWZlcnJlclBvbGljeSA9PSBOb1JlZmVycmVyKSB7CisgICAgaWYgKHJl ZmVycmVyUG9saWN5ID09IE5vUmVmZXJyZXIpCiAgICAgICAgIG1fc3VwcHJlc3NPcGVuZXJJbk5l d0ZyYW1lID0gdHJ1ZTsKLSAgICAgICAgc2V0T3BlbmVyKDApOwotICAgIH0gZWxzZSBpZiAoZnJh bWVSZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLmh0dHBSZWZlcnJlcigpLmlzRW1wdHkoKSkKKyAg ICBlbHNlIGlmIChmcmFtZVJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuaHR0cFJlZmVycmVyKCku aXNFbXB0eSgpKQogICAgICAgICBmcmFtZVJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0SFRU UFJlZmVycmVyKG1fb3V0Z29pbmdSZWZlcnJlcik7CiAgICAgYWRkSFRUUE9yaWdpbklmTmVlZGVk KGZyYW1lUmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKSwgb3V0Z29pbmdPcmlnaW4oKSk7CiAKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDUwMDc5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjYgIE5hdGUgQ2hhcGluICA8amFwaGV0 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVcGRhdGUgbm8tcmVmZXJyZXItcmVzZXQgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMDc4MS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdh dGlvbi9uby1yZWZlcnJlci1yZXNldC1leHBlY3RlZC50eHQ6IEV4cGVjdCB3aW5kb3cub3BlbmVy IHRvIHN0aWxsIGJlIHNldC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vbm8tcmVm ZXJyZXItcmVzZXQuaHRtbDogVXBkYXRlIHRleHQgdG8gcmVmbGVjdCB3aGF0IHRoZSB0ZXN0IGFj dHVhbGx5IGRvZXMuCisKIDIwMDktMTAtMjYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHR5cG8gZml4LgpJbmRleDogTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL25vLXJlZmVycmVyLXJlc2V0LWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vbm8tcmVmZXJy ZXItcmVzZXQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1MDA3MSkKKysrIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbmF2aWdhdGlvbi9uby1yZWZlcnJlci1yZXNldC1leHBlY3RlZC50eHQJKHdvcmtp bmcgY29weSkKQEAgLTEsMTEgKzEsMTEgQEAKIFRoaXMgdGVzdHMgd2hldGhlciByZWZlcnJlciBp bmZvcm1hdGlvbiBnZXRzIHByb3Blcmx5IHNldCBhbmQgcmVzZXQgd2hlbiAibm9yZWZlcnJlciIg bGlua3MgYXJlIHByZXNlbnQuIFdlIGRvIHRoZSBmb2xsb3dpbmc6CiAxLiBPcGVuIGEgbGluayBp biBhIG5ldyB3aW5kb3c6IHJlZmVycmVyIGlzIHNlbnQgYW5kIHdpbmRvdy5vcGVuZXIgaXMgc2Vu dC4KLTIuIENsaWNrIGEgcmVsPSJub3JlZmVycmVyIiBsaW5rOiByZWZlcnJlciBhbmQgd2luZG93 Lm9wZW5lciBhcmUgbnVsbGVkLgotMy4gQ2xpY2sgYSBsaW5rIHdpdGhvdXQgcmVsPSJub3JlZmVy cmVyIjogcmVmZXJyZXIgaXMgc2VudCwgYnV0IHdpbmRvdy5vcGVuZXIgaXMgc3RpbGwgbnVsbCAo c2luY2UgaXQgd2FzIG51bGxlZCBpbiB0aGUgcHJldmlvdXMgc3RlcCkuIAorMi4gQ2xpY2sgYSBy ZWw9Im5vcmVmZXJyZXIiIGxpbms6IHJlZmVycmVyIGlzIG51bGwsIGJ1dCB3aW5kb3cub3BlbmVy IHJlbWFpbnMgc2V0IHNpbmNlIHRoZSBsaW5rIHdhcyBub3Qgb3BlbmVkIHdpdGggdGFyZ2V0PSJf YmxhbmsiLgorMy4gQ2xpY2sgYSBsaW5rIHdpdGhvdXQgcmVsPSJub3JlZmVycmVyIjogcmVmZXJy ZXIgaXMgc2VudCwgYnV0IHdpbmRvdy5vcGVuZXIgaXMgc3RpbGwgc2V0LiAKIFN0YXJ0IHJlc2V0 IHRlc3QKIFJlZmVycmVyOiBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9uby1yZWZl cnJlci1yZXNldC5odG1sCiB3aW5kb3cub3BlbmVyOiBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2 aWdhdGlvbi9uby1yZWZlcnJlci1yZXNldC5odG1sCiBSZWZlcnJlcjoKLXdpbmRvdy5vcGVuZXI6 Cit3aW5kb3cub3BlbmVyOiBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9uby1yZWZl cnJlci1yZXNldC5odG1sCiBSZWZlcnJlcjogaHR0cDovLzEyNy4wLjAuMTo4MDAwL25hdmlnYXRp b24vcmVzb3VyY2VzL25vLXJlZmVycmVyLXJlc2V0LWhlbHBlci5waHAKLXdpbmRvdy5vcGVuZXI6 Cit3aW5kb3cub3BlbmVyOiBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9uby1yZWZl cnJlci1yZXNldC5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24v bm8tcmVmZXJyZXItcmVzZXQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL25hdmlnYXRpb24vbm8tcmVmZXJyZXItcmVzZXQuaHRtbAkocmV2aXNpb24gNTAwNzEpCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vbm8tcmVmZXJyZXItcmVzZXQuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMSw4ICsxLDggQEAKIDxodG1sPjxib2R5PgogVGhpcyB0ZXN0 cyB3aGV0aGVyIHJlZmVycmVyIGluZm9ybWF0aW9uIGdldHMgcHJvcGVybHkgc2V0IGFuZCByZXNl dCB3aGVuICJub3JlZmVycmVyIiBsaW5rcyBhcmUgcHJlc2VudC4gV2UgZG8gdGhlIGZvbGxvd2lu Zzo8YnIvPgogMS4gT3BlbiBhIGxpbmsgaW4gYSBuZXcgd2luZG93OiByZWZlcnJlciBpcyBzZW50 IGFuZCB3aW5kb3cub3BlbmVyIGlzIHNlbnQuPGJyLz4KLTIuIENsaWNrIGEgcmVsPSJub3JlZmVy cmVyIiBsaW5rOiByZWZlcnJlciBhbmQgd2luZG93Lm9wZW5lciBhcmUgbnVsbGVkLjxici8+Ci0z LiBDbGljayBhIGxpbmsgd2l0aG91dCByZWw9Im5vcmVmZXJyZXIiOiByZWZlcnJlciBpcyBzZW50 LCBidXQgd2luZG93Lm9wZW5lciBpcyBzdGlsbCBudWxsIChzaW5jZSBpdCB3YXMgbnVsbGVkIGlu IHRoZSBwcmV2aW91cyBzdGVwKS4KKzIuIENsaWNrIGEgcmVsPSJub3JlZmVycmVyIiBsaW5rOiBy ZWZlcnJlciBpcyBudWxsLCBidXQgd2luZG93Lm9wZW5lciByZW1haW5zIHNldCBzaW5jZSB0aGUg bGluayB3YXMgbm90IG9wZW5lZCB3aXRoIHRhcmdldD0iX2JsYW5rIi48YnIvPgorMy4gQ2xpY2sg YSBsaW5rIHdpdGhvdXQgcmVsPSJub3JlZmVycmVyIjogcmVmZXJyZXIgaXMgc2VudCwgYnV0IHdp bmRvdy5vcGVuZXIgaXMgc3RpbGwgc2V0LgogPGJyLz4KIDxhIGlkPSJsaW5rIiBocmVmPSJyZXNv dXJjZXMvbm8tcmVmZXJyZXItcmVzZXQtaGVscGVyLnBocCIgdGFyZ2V0PSJfYmxhbmsiPlN0YXJ0 IHJlc2V0IHRlc3Q8L2E+CiA8c2NyaXB0Pgo=