30777 2009-10-26 08:54:39 -0700 [Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash 2009-10-26 15:23:00 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 157783 0 laszlo.gombos 2009-10-26 08:54:39 -0700 To reproduce the original crash do the following: - Build QtWebKit on Windows in debug mode - Launch QtLauncher and navigate to http://html5demos.com/database The crash backtrace revealed that SQLiteDatabase::setMaximumSize failed as "PRAGMA max_page_count .." SQLiteStatement was malformed because String::number(newMaxPageCount) returned "%I64u". This is because on WIN_OS "long long" is formatted using "%I64u" and Qt's QString::vsprintf does not seems to understand this format string. Using the "%lli" to format "long long" types fixes the problem. 157810 1 41875 laszlo.gombos 2009-10-26 10:18:10 -0700 Created attachment 41875 proposed patch 157915 2 41895 laszlo.gombos 2009-10-26 14:06:04 -0700 Created attachment 41895 2nd try Update the ChangeLog to describe the patch better. 157937 3 41895 eric 2009-10-26 14:46:27 -0700 Comment on attachment 41895 2nd try OK. I'll believe you. 157961 4 41895 commit-queue 2009-10-26 15:22:56 -0700 Comment on attachment 41895 2nd try Clearing flags on attachment: 41895 Committed r50103: <http://trac.webkit.org/changeset/50103> 157962 5 commit-queue 2009-10-26 15:23:00 -0700 All reviewed patches have been landed. Closing bug. 41875 2009-10-26 10:18:10 -0700 2009-10-26 14:06:04 -0700 proposed patch 30777.patch text/plain 1447 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDA3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gVXNlICIlbGxpIiB0byBmb3JtYXQgImxvbmcgbG9uZyIgb24gV0lOX09TIHRv IGZpeCBIVE1MNSBXZWJEQiBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzA3NzcKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlIGNyYXNo IGNhbiBiZSByZXByb2R1Y2VkIGJ5IGV4aXN0aW5nIHN0b3JhZ2UKKyAgICAgICAgTGF5b3V0VGVz dHMgKGJ5IGhpdHRpbmcgYW4gYXNzZXJ0IGluIGRlYnVnIG1vZGUgV2Via2l0IG9uIFdJTl9PUyku CisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L1N0cmluZy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTdHJpbmc6Om51bWJlcik6CisKIDIwMDktMTAtMjYgIEtlbGx5IE5vcnRvbiAgPGtub3J0b25A Z29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L1N0cmluZy5jcHAJKHJldmlzaW9uIDUwMDQ2KQorKysgV2ViQ29yZS9wbGF0 Zm9ybS90ZXh0L1N0cmluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0MSw3ICs0NDEsNyBAQCBT dHJpbmcgU3RyaW5nOjpudW1iZXIodW5zaWduZWQgbG9uZyBuKQogCiBTdHJpbmcgU3RyaW5nOjpu dW1iZXIobG9uZyBsb25nIG4pCiB7Ci0jaWYgUExBVEZPUk0oV0lOX09TKQorI2lmIFBMQVRGT1JN KFdJTl9PUykgJiYgIVBMQVRGT1JNKFFUKQogICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJUk2 NGkiLCBuKTsKICNlbHNlCiAgICAgcmV0dXJuIFN0cmluZzo6Zm9ybWF0KCIlbGxpIiwgbik7CkBA IC00NTAsNyArNDUwLDcgQEAgU3RyaW5nIFN0cmluZzo6bnVtYmVyKGxvbmcgbG9uZyBuKQogCiBT dHJpbmcgU3RyaW5nOjpudW1iZXIodW5zaWduZWQgbG9uZyBsb25nIG4pCiB7Ci0jaWYgUExBVEZP Uk0oV0lOX09TKQorI2lmIFBMQVRGT1JNKFdJTl9PUykgJiYgIVBMQVRGT1JNKFFUKQogICAgIHJl dHVybiBTdHJpbmc6OmZvcm1hdCgiJUk2NHUiLCBuKTsKICNlbHNlCiAgICAgcmV0dXJuIFN0cmlu Zzo6Zm9ybWF0KCIlbGx1Iiwgbik7Cg== 41895 2009-10-26 14:06:04 -0700 2009-10-26 15:22:56 -0700 2nd try 30777_2.patch text/plain 1583 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDA4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMjYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gVXNlICIlbGxpIiB0byBmb3JtYXQgImxvbmcgbG9uZyIgb24gV0lOX09TIHRv IGZpeCBIVE1MNSBXZWJEQiBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzA3NzcKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlIGNyYXNo IGNhbiBiZSByZXByb2R1Y2VkIGJ5IGV4aXN0aW5nIHN0b3JhZ2UKKyAgICAgICAgTGF5b3V0VGVz dHMgKGJ5IGhpdHRpbmcgYW4gYXNzZXJ0IGluIGRlYnVnIG1vZGUgV2Via2l0IG9uIFdJTl9PUyku CisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L1N0cmluZy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTdHJpbmc6Om51bWJlcik6IFF0J3MgUVN0cmluZzo6dnNwcmludGYgZG9lcyBub3QKKyAgICAg ICAgdW5kZXJzdGFuZCB0aGUgIiVJNjR1IiBmb3JtYXQgc3RyaW5nLiBBbHdheXMgdXNlIHRoZSAi JWxsaSIKKyAgICAgICAgZm9ybWF0IHN0cmluZyBmb3IgUXQgcG9ydC4KKwogMjAwOS0xMC0yMSAg SmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmcuY3BwCShyZXZpc2lvbiA1 MDA0NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NDEsNyArNDQxLDcgQEAgU3RyaW5nIFN0cmluZzo6bnVtYmVyKHVuc2lnbmVkIGxvbmcg bikKIAogU3RyaW5nIFN0cmluZzo6bnVtYmVyKGxvbmcgbG9uZyBuKQogewotI2lmIFBMQVRGT1JN KFdJTl9PUykKKyNpZiBQTEFURk9STShXSU5fT1MpICYmICFQTEFURk9STShRVCkKICAgICByZXR1 cm4gU3RyaW5nOjpmb3JtYXQoIiVJNjRpIiwgbik7CiAjZWxzZQogICAgIHJldHVybiBTdHJpbmc6 OmZvcm1hdCgiJWxsaSIsIG4pOwpAQCAtNDUwLDcgKzQ1MCw3IEBAIFN0cmluZyBTdHJpbmc6Om51 bWJlcihsb25nIGxvbmcgbikKIAogU3RyaW5nIFN0cmluZzo6bnVtYmVyKHVuc2lnbmVkIGxvbmcg bG9uZyBuKQogewotI2lmIFBMQVRGT1JNKFdJTl9PUykKKyNpZiBQTEFURk9STShXSU5fT1MpICYm ICFQTEFURk9STShRVCkKICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoIiVJNjR1Iiwgbik7CiAj ZWxzZQogICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJWxsdSIsIG4pOwo=