30774 2009-10-26 06:47:42 -0700 [V8] Missing null check after string conversion in error reporting 2009-10-27 11:03:34 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ager webkit-unassigned abarth commit-queue dglazkov eric oldest_to_newest 157750 0 ager 2009-10-26 06:47:42 -0700 When reporting exceptions, we sometimes perform a string conversion on an exception object. That string conversion can fail if an exception is thrown during conversion. In that case an empty handle is returned. We need to check for that. See comment 1 and 3 of http://crbug.com/24130. 157752 1 41863 ager 2009-10-26 06:53:03 -0700 Created attachment 41863 Add null check. 157772 2 41863 abarth 2009-10-26 07:54:46 -0700 Comment on attachment 41863 Add null check. Test? 157794 3 ager 2009-10-26 09:24:06 -0700 A test would indeed be great. I haven't been able to reproduce this crash yet, but there are a number of crashes reported where we get into this situation. I'll spent some more time tomorrow attempting to reproduce. 157795 4 abarth 2009-10-26 09:26:06 -0700 You can't just throw an exception in the toString? 157798 5 ager 2009-10-26 09:29:42 -0700 Yeah, that is not the problem. The problem is getting into this case in the code first. I need to be in a situation where the TryCatch has no message *and* the ToString operations throws an exception. The first part is the hard part - most of the time a TryCatch should have a message. I need something like a stack overflow at an unfortunate time to hit this path. 157802 6 abarth 2009-10-26 09:44:46 -0700 So, I'm supposed to lean on you to write a test, but if you complain enough that it's hard to write the test, then we can go ahead with the patch anyway. In any case, you don't need me to lecture you about testing. :) 158149 7 41942 ager 2009-10-27 03:56:37 -0700 Created attachment 41942 Add null check and test case. 158209 8 41942 abarth 2009-10-27 09:08:24 -0700 Comment on attachment 41942 Add null check and test case. Beautiful patch. Thanks! 158216 9 41942 commit-queue 2009-10-27 09:37:15 -0700 Comment on attachment 41942 Add null check and test case. Rejecting patch 41942 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth', '--force']" exit_code: 2 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/bindings/v8/V8Utilities.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/error-to-string-stack-overflow-expected.txt Died at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 438, <> line 109. 158220 10 eric 2009-10-27 09:44:29 -0700 Investigating the strange failure... 158222 11 eric 2009-10-27 09:46:21 -0700 } elsif (isGit()) { system "git", "add", $path or die; } I'm just not sure why it died yet, but I will investigate. 158235 12 eric 2009-10-27 10:09:25 -0700 My apologies. False rejection. I'm working on a fix to svn-apply right now. bug 30826 158259 13 41942 eric 2009-10-27 10:38:52 -0700 Comment on attachment 41942 Add null check and test case. svn-apply fixed. Trying again. 158271 14 41942 commit-queue 2009-10-27 11:03:29 -0700 Comment on attachment 41942 Add null check and test case. Clearing flags on attachment: 41942 Committed r50160: <http://trac.webkit.org/changeset/50160> 158272 15 commit-queue 2009-10-27 11:03:34 -0700 All reviewed patches have been landed. Closing bug. 41863 2009-10-26 06:53:03 -0700 2009-10-27 03:56:37 -0700 Add null check. patch.txt text/plain 1853 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDA1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMjYgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g TWlzc2luZyBudWxsIGNoZWNrIGFmdGVyIHN0cmluZyBjb252ZXJzaW9uIGluIGVycm9yIHJlcG9y dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3 NzQKKworICAgICAgICBBZGQgbnVsbCBjaGVjayBhZnRlciBzdHJpbmcgY29udmVyc2lvbiBpbiBl cnJvciByZXBvcnRpbmcgY29kZS4KKyAgICAgICAgVG9TdHJpbmcgY29udmVyc2lvbiBjYW4gZmFp bCBmb3IgaW5zdGFuY2Ugd2hlbiBhbiBleGNlcHRpb24gaXMKKyAgICAgICAgdGhyb3duIGR1cmlu ZyBjb252ZXJzaW9uLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6cmVwb3J0RXhjZXB0aW9uKToKKwogMjAwOS0xMC0yNiAgU3RldmUg QmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAkocmV2aXNpb24g NTAwNTUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTM1LDkgKzEzNSwxMyBAQCB2b2lkIHJlcG9ydEV4Y2VwdGlvbihTY3JpcHRTdGF0 ZSogc2NyaXB0CiAKICAgICAvLyBUaGVyZSBjYW4gYmUgYSBzaXR1YXRpb24gdGhhdCBhbiBleGNl cHRpb24gaXMgdGhyb3duIHdpdGhvdXQgc2V0dGluZyBhIG1lc3NhZ2UuCiAgICAgdjg6OkxvY2Fs PHY4OjpNZXNzYWdlPiBtZXNzYWdlID0gZXhjZXB0aW9uQ2F0Y2hlci5NZXNzYWdlKCk7Ci0gICAg aWYgKG1lc3NhZ2UuSXNFbXB0eSgpKQotICAgICAgICBlcnJvck1lc3NhZ2UgPSB0b1dlYkNvcmVT dHJpbmcoZXhjZXB0aW9uQ2F0Y2hlci5FeGNlcHRpb24oKS0+VG9TdHJpbmcoKSk7Ci0gICAgZWxz ZSB7CisgICAgaWYgKG1lc3NhZ2UuSXNFbXB0eSgpKSB7CisgICAgICAgIHY4OjpMb2NhbDx2ODo6 U3RyaW5nPiBleGNlcHRpb25TdHJpbmcgPSBleGNlcHRpb25DYXRjaGVyLkV4Y2VwdGlvbigpLT5U b1N0cmluZygpOworICAgICAgICAvLyBDb252ZXJzaW9uIG9mIHRoZSBleGNlcHRpb24gb2JqZWN0 IHRvIHN0cmluZyBjYW4gZmFpbCBpZiBhbgorICAgICAgICAvLyBleGNlcHRpb24gaXMgdGhyb3du IGR1cmluZyBjb252ZXJzaW9uLgorICAgICAgICBpZiAoIWV4Y2VwdGlvblN0cmluZy5Jc0VtcHR5 KCkpCisgICAgICAgICAgICBlcnJvck1lc3NhZ2UgPSB0b1dlYkNvcmVTdHJpbmcoZXhjZXB0aW9u U3RyaW5nKTsKKyAgICB9IGVsc2UgewogICAgICAgICBlcnJvck1lc3NhZ2UgPSB0b1dlYkNvcmVT dHJpbmcobWVzc2FnZS0+R2V0KCkpOwogICAgICAgICBsaW5lTnVtYmVyID0gbWVzc2FnZS0+R2V0 TGluZU51bWJlcigpOwogICAgICAgICBzb3VyY2VVUkwgPSB0b1dlYkNvcmVTdHJpbmcobWVzc2Fn ZS0+R2V0U2NyaXB0UmVzb3VyY2VOYW1lKCkpOwo= 41942 2009-10-27 03:56:37 -0700 2009-10-27 11:03:29 -0700 Add null check and test case. patch.txt text/plain 4287 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDEzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTAtMjcgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g TWlzc2luZyBudWxsIGNoZWNrIGFmdGVyIHN0cmluZyBjb252ZXJzaW9uIGluIGVycm9yIHJlcG9y dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3 NzQKKworICAgICAgICBBZGQgbnVsbCBjaGVjayBhZnRlciBzdHJpbmcgY29udmVyc2lvbiBpbiBl cnJvciByZXBvcnRpbmcgY29kZS4KKyAgICAgICAgVG9TdHJpbmcgY29udmVyc2lvbiBjYW4gZmFp bCBmb3IgaW5zdGFuY2Ugd2hlbiBhbiBleGNlcHRpb24gaXMKKyAgICAgICAgdGhyb3duIGR1cmlu ZyBjb252ZXJzaW9uLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2Vycm9yLXRvLXN0cmluZy1z dGFjay1vdmVyZmxvdy5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFV0aWxpdGllcy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRFeGNlcHRpb24pOgorCiAyMDA5LTEwLTI3ICBM YXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGls aXRpZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMu Y3BwCShyZXZpc2lvbiA1MDEzNCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzUsOSArMTM1LDEzIEBAIHZvaWQgcmVwb3J0RXhjZXB0 aW9uKFNjcmlwdFN0YXRlKiBzY3JpcHQKIAogICAgIC8vIFRoZXJlIGNhbiBiZSBhIHNpdHVhdGlv biB0aGF0IGFuIGV4Y2VwdGlvbiBpcyB0aHJvd24gd2l0aG91dCBzZXR0aW5nIGEgbWVzc2FnZS4K ICAgICB2ODo6TG9jYWw8djg6Ok1lc3NhZ2U+IG1lc3NhZ2UgPSBleGNlcHRpb25DYXRjaGVyLk1l c3NhZ2UoKTsKLSAgICBpZiAobWVzc2FnZS5Jc0VtcHR5KCkpCi0gICAgICAgIGVycm9yTWVzc2Fn ZSA9IHRvV2ViQ29yZVN0cmluZyhleGNlcHRpb25DYXRjaGVyLkV4Y2VwdGlvbigpLT5Ub1N0cmlu ZygpKTsKLSAgICBlbHNlIHsKKyAgICBpZiAobWVzc2FnZS5Jc0VtcHR5KCkpIHsKKyAgICAgICAg djg6OkxvY2FsPHY4OjpTdHJpbmc+IGV4Y2VwdGlvblN0cmluZyA9IGV4Y2VwdGlvbkNhdGNoZXIu RXhjZXB0aW9uKCktPlRvU3RyaW5nKCk7CisgICAgICAgIC8vIENvbnZlcnNpb24gb2YgdGhlIGV4 Y2VwdGlvbiBvYmplY3QgdG8gc3RyaW5nIGNhbiBmYWlsIGlmIGFuCisgICAgICAgIC8vIGV4Y2Vw dGlvbiBpcyB0aHJvd24gZHVyaW5nIGNvbnZlcnNpb24uCisgICAgICAgIGlmICghZXhjZXB0aW9u U3RyaW5nLklzRW1wdHkoKSkKKyAgICAgICAgICAgIGVycm9yTWVzc2FnZSA9IHRvV2ViQ29yZVN0 cmluZyhleGNlcHRpb25TdHJpbmcpOworICAgIH0gZWxzZSB7CiAgICAgICAgIGVycm9yTWVzc2Fn ZSA9IHRvV2ViQ29yZVN0cmluZyhtZXNzYWdlLT5HZXQoKSk7CiAgICAgICAgIGxpbmVOdW1iZXIg PSBtZXNzYWdlLT5HZXRMaW5lTnVtYmVyKCk7CiAgICAgICAgIHNvdXJjZVVSTCA9IHRvV2ViQ29y ZVN0cmluZyhtZXNzYWdlLT5HZXRTY3JpcHRSZXNvdXJjZU5hbWUoKSk7CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiA1MDEzOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE2IEBACisyMDA5LTEwLTI3ICBNYWRzIEFnZXIgIDxhZ2VyQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhdIE1p c3NpbmcgbnVsbCBjaGVjayBhZnRlciBzdHJpbmcgY29udmVyc2lvbiBpbiBlcnJvciByZXBvcnRp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzc0 CisKKyAgICAgICAgVGVzdCBjYXNlIGZvciB0b1N0cmluZyBjb252ZXJzaW9uIGZhaWx1cmUgb24g YW4gZXJyb3Igb2JqZWN0IGluCisgICAgICAgIHN0YWNrIG92ZXJmbG93IHNpdHVhdGlvbnMuICBU ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLgorICAgICAgICAKKyAgICAgICAgKiBmYXN0 L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3ctZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3cuaHRtbDog QWRkZWQuCisKIDIwMDktMTAtMjYgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vZXJyb3ItdG8tc3RyaW5nLXN0YWNrLW92ZXJmbG93LWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2stb3ZlcmZs b3ctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vZXJy b3ItdG8tc3RyaW5nLXN0YWNrLW92ZXJmbG93LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwxMCBAQAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE3OiAKK1JlZ3Jlc3Npb24gdGVz dCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzc0LiBUaGlz IHRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgY3Jhc2guCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZXJyb3ItdG8tc3RyaW5nLXN0YWNrLW92 ZXJmbG93Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZXJyb3ItdG8t c3RyaW5nLXN0YWNrLW92ZXJmbG93Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3cuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwyMyBAQAorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIg aHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIu Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25sb2FkPSdsb2FkKCknPgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKworPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJSZWdyZXNzaW9uIHRlc3QgZm9y IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDc3NC4gIFRoaXMgdGVz dCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4iKTsKKworLy8gRm9yY2Ugc3RyaW5nIGNvbnZl cnNpb24gb2YgZXJyb3Igb2JqZWN0cyB0byB0aHJvdyBleGNlcHRpb25zLgorRXJyb3IucHJvdG90 eXBlLnRvU3RyaW5nID0gZnVuY3Rpb24oKSB7IHRocm93IDA7IH0KKworLy8gRm9yY2UgYSBzdGFj ay1vdmVyZmxvdyBpbiB0aGUgb25sb2FkIGhhbmRsZXIuCitmdW5jdGlvbiBsb2FkKCkgeyBsb2Fk KCk7IH0KKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K