30755 2009-10-25 04:39:31 -0700 [Qt] Conditional jump on uninitialized variable in QWebSettings 2009-11-13 04:55:57 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID Qt P2 Major --- 29042 1 antialize webkit-unassigned benjamin eric jturcotte kenneth oldest_to_newest 157578 0 antialize 2009-10-25 04:39:31 -0700 When I made the patch in https://bugs.webkit.org/show_bug.cgi?id=29042. I did not fully understand the QWebSettings class. The result is that calling apply will result in a jump on an uninitialized variable. 157579 1 41818 antialize 2009-10-25 04:44:08 -0700 Created attachment 41818 Fix unitialize valiabels Fix uninitialized variabels and give global variabels default values (copied from within webkit) 157942 2 41818 eric 2009-10-26 14:50:31 -0700 Comment on attachment 41818 Fix unitialize valiabels Why change the defaults? That's not documented in the Changelog. Also, are these the only defaults that constructor misses? What about defaultTextEncoding? 158104 3 antialize 2009-10-26 23:55:17 -0700 The default was changed to bring it in line with other variables, such as defaultTextEncoding, but I can not do that if you like. The defaultTextEncoding is a QString, so naturally it cannot be uninitialized. There wight have been other floates, ints, or bools that where unititialized, but I do not think so. At least valgrind did not complain about this. 162858 4 43053 antialize 2009-11-12 03:14:40 -0800 Created attachment 43053 Fix uninitialized vars and ABI issues 162891 5 jturcotte 2009-11-12 06:23:02 -0800 Duplicate of bug #31058 Please ensure that both bugs are closed when the issue is resolved. 163196 6 43053 abarth 2009-11-12 20:47:54 -0800 Comment on attachment 43053 Fix uninitialized vars and ABI issues No test. 163279 7 kenneth 2009-11-13 04:55:57 -0800 The patch that introduced this change was reverted, so this should be part of a newer version of that patch, when reintroduced. Marking invalid. 41818 2009-10-25 04:44:08 -0700 2009-11-12 03:14:40 -0800 Fix unitialize valiabels shrik text/plain 1515 antialize SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZyAocmV2aXNpb24gNTAwNDQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nICh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjUgIEpha29iIFRydWVsc2VuICA8YW50aWFs aXplQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbml0aWFsaXplIHNocmluayB2YXJpYWJsZXMgcHJvcGVybHkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzU1CisKKyAgICAgICAg KiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKFFXZWJTZXR0aW5nczo6UVdlYlNldHRp bmdzKToKKwogMjAwOS0xMC0yNCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tp YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDogV2Vi S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkv cXdlYnNldHRpbmdzLmNwcCAgICAgIChyZXZpc2lvbiA1MDA0NCkKKysrIFdlYktpdC9xdC9BcGkv cXdlYnNldHRpbmdzLmNwcCAgICAgICh3b3JraW5nIGNvcHkpCkBAIC0zODYsOCArMzg2LDggQEAg UVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MoKQogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFX ZWJTZXR0aW5nczo6U2Vzc2lvblN0b3JhZ2VFbmFibGVkLCB0cnVlKTsKICAgICBkLT5vZmZsaW5l U3RvcmFnZURlZmF1bHRRdW90YSA9IDUgKiAxMDI0ICogMTAyNDsKICAgICBkLT5kZWZhdWx0VGV4 dEVuY29kaW5nID0gUUxhdGluMVN0cmluZygiaXNvLTg4NTktMSIpOwotICAgIGQtPnByaW50aW5n TWluaW11bVNocmlua0ZhY3RvciA9IDAuMGY7Ci0gICAgZC0+cHJpbnRpbmdNYXhpbXVtU2hyaW5r RmFjdG9yID0gMC4wZjsKKyAgICBkLT5wcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3IgPSAxLjI1 ZjsKKyAgICBkLT5wcmludGluZ01heGltdW1TaHJpbmtGYWN0b3IgPSAyLjBmOwogfQogCiAvKiEK QEAgLTM5Niw2ICszOTYsOCBAQCBRV2ViU2V0dGluZ3M6OlFXZWJTZXR0aW5ncygpCiBRV2ViU2V0 dGluZ3M6OlFXZWJTZXR0aW5ncyhXZWJDb3JlOjpTZXR0aW5ncyogc2V0dGluZ3MpCiAgICAgOiBk KG5ldyBRV2ViU2V0dGluZ3NQcml2YXRlKHNldHRpbmdzKSkKIHsKKyAgICBkLT5wcmludGluZ01p bmltdW1TaHJpbmtGYWN0b3IgPSAwLjBmOworICAgIGQtPnByaW50aW5nTWF4aW11bVNocmlua0Zh Y3RvciA9IDAuMGY7CiAgICAgZC0+c2V0dGluZ3MgPSBzZXR0aW5nczsKICAgICBkLT5hcHBseSgp OwogICAgIGFsbFNldHRpbmdzKCktPmFwcGVuZChkKTsK 43053 2009-11-12 03:14:40 -0800 2009-11-12 20:47:54 -0800 Fix uninitialized vars and ABI issues fixvars_and_abi.patch text/plain 4346 antialize SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA4NzMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMTIgIEpha29iIFRydWVsc2VuICA8YW50aWFs aXplQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbml0aWFsaXplIHNocmluayB2YXJpYWJsZXMgcHJvcGVybHkuIEFuZCBmaXggQVBJ IGlzc3Vlcy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzA3NTUKKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdl YlNldHRpbmdzOjpRV2ViU2V0dGluZ3MpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpzZXRQcmlu dGluZ01pbmltdW1TaHJpbmtGYWN0b3IpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpwcmludGlu Z01pbmltdW1TaHJpbmtGYWN0b3IpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpzZXRQcmludGlu Z01heGltdW1TaHJpbmtGYWN0b3IpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpwcmludGluZ01h eGltdW1TaHJpbmtGYWN0b3IpOgorICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuaDoKKwogMjAw OS0xMS0xMSAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViS2l0L3F0L0FwaS9x d2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdz LmNwcAkocmV2aXNpb24gNTA4NzEpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTYyLDggKzYyLDggQEAgcHVibGljOgogICAgIFFTdHJpbmcgbG9j YWxTdG9yYWdlUGF0aDsKICAgICBRU3RyaW5nIG9mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hlUGF0 aDsKICAgICBxaW50NjQgb2ZmbGluZVN0b3JhZ2VEZWZhdWx0UXVvdGE7Ci0gICAgZmxvYXQgcHJp bnRpbmdNaW5pbXVtU2hyaW5rRmFjdG9yOwotICAgIGZsb2F0IHByaW50aW5nTWF4aW11bVNocmlu a0ZhY3RvcjsKKyAgICBxcmVhbCBwcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3I7CisgICAgcXJl YWwgcHJpbnRpbmdNYXhpbXVtU2hyaW5rRmFjdG9yOwogCiAgICAgdm9pZCBhcHBseSgpOwogICAg IFdlYkNvcmU6OlNldHRpbmdzKiBzZXR0aW5nczsKQEAgLTM4OSw2ICszODksOCBAQCBRV2ViU2V0 dGluZ3M6OlFXZWJTZXR0aW5ncygpCiBRV2ViU2V0dGluZ3M6OlFXZWJTZXR0aW5ncyhXZWJDb3Jl OjpTZXR0aW5ncyogc2V0dGluZ3MpCiAgICAgOiBkKG5ldyBRV2ViU2V0dGluZ3NQcml2YXRlKHNl dHRpbmdzKSkKIHsKKyAgICBkLT5wcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3IgPSAwLjBmOwor ICAgIGQtPnByaW50aW5nTWF4aW11bVNocmlua0ZhY3RvciA9IDAuMGY7CiAgICAgZC0+c2V0dGlu Z3MgPSBzZXR0aW5nczsKICAgICBkLT5hcHBseSgpOwogICAgIGFsbFNldHRpbmdzKCktPmFwcGVu ZChkKTsKQEAgLTQ5NSw3ICs0OTcsNyBAQCBRU3RyaW5nIFFXZWJTZXR0aW5nczo6ZGVmYXVsdFRl eHRFbmNvZGluCiB9CiAKIC8qIQotICAgIFxzaW5jZSA0LjcgCisgICAgXHNpbmNlIDQuNgogICAg IFNwZWNpZmllcyBtaW5pbXVtIHNocmluayBmYXRvciBhbGxvd2VkIGZvciBwcmludGluZy4gSWYg c2V0IHRvIDAgYQogICAgIGRlZmF1bHQgdmFsdWUgaXMgdXNlZC4KIApAQCAtNTA3LDQzICs1MDks NDMgQEAgUVN0cmluZyBRV2ViU2V0dGluZ3M6OmRlZmF1bHRUZXh0RW5jb2RpbgogICAgIFxzYSBz ZXRQcmludGluZ01heGltdW1TaHJpbmtGYWN0b3IoKQogICAgIFxzYSBwcmludGluZ01heGltdW1T aHJpbmtGYWN0b3IoKQogKi8KLXZvaWQgUVdlYlNldHRpbmdzOjpzZXRQcmludGluZ01pbmltdW1T aHJpbmtGYWN0b3IoZmxvYXQgcHJpbnRpbmdNaW5pbXVtU2hyaW5rRmFjdG9yKQordm9pZCBRV2Vi U2V0dGluZ3M6OnNldFByaW50aW5nTWluaW11bVNocmlua0ZhY3RvcihxcmVhbCBwcmludGluZ01p bmltdW1TaHJpbmtGYWN0b3IpCiB7CiAgICAgZC0+cHJpbnRpbmdNaW5pbXVtU2hyaW5rRmFjdG9y ID0gcHJpbnRpbmdNaW5pbXVtU2hyaW5rRmFjdG9yOwogICAgIGQtPmFwcGx5KCk7CiB9CiAKIC8q IQotICAgIFxzaW5jZSA0LjcgCisgICAgXHNpbmNlIDQuNgogICAgIHJldHVybnMgdGhlIG1pbmlt dW0gc2hyaW5rIGZhY3RvciB1c2VkIGZvciBwcmludGluZy4KIAogICAgIFxzYSBzZXRQcmludGlu Z01pbmltdW1TaHJpbmtGYWN0b3IoKQogKi8KLWZsb2F0IFFXZWJTZXR0aW5nczo6cHJpbnRpbmdN aW5pbXVtU2hyaW5rRmFjdG9yKCkgY29uc3QKK3FyZWFsIFFXZWJTZXR0aW5nczo6cHJpbnRpbmdN aW5pbXVtU2hyaW5rRmFjdG9yKCkgY29uc3QKIHsKICAgICByZXR1cm4gZC0+cHJpbnRpbmdNaW5p bXVtU2hyaW5rRmFjdG9yOwogfQogCiAvKiEKLSAgICBcc2luY2UgNC43IAorICAgIFxzaW5jZSA0 LjYgCiAgICAgU3BlY2lmaWVzIG1heGltdW0gc2hyaW5rIGZhdG9yIGFsbG93ZWQgZm9yIHByaW50 aW5nLiBJZiBzZXQgdG8gMCBhCiAgICAgZGVmYXVsdCB2YWx1ZSBpcyB1c2VkLgogCiAgICAgXHNh IHNldFByaW50aW5nTWluaW11bVNocmlua0ZhY3RvcigpCiAqLwotdm9pZCBRV2ViU2V0dGluZ3M6 OnNldFByaW50aW5nTWF4aW11bVNocmlua0ZhY3RvcihmbG9hdCBwcmludGluZ01heGltdW1TaHJp bmtGYWN0b3IpCit2b2lkIFFXZWJTZXR0aW5nczo6c2V0UHJpbnRpbmdNYXhpbXVtU2hyaW5rRmFj dG9yKHFyZWFsIHByaW50aW5nTWF4aW11bVNocmlua0ZhY3RvcikKIHsKICAgICBkLT5wcmludGlu Z01heGltdW1TaHJpbmtGYWN0b3IgPSBwcmludGluZ01heGltdW1TaHJpbmtGYWN0b3I7CiAgICAg ZC0+YXBwbHkoKTsKIH0KIAogLyohCi0gICAgXHNpbmNlIDQuNyAKKyAgICBcc2luY2UgNC42IAog ICAgIHJldHVybnMgdGhlIG1heGltdW0gc2hyaW5rIGZhY3RvciB1c2VkIGZvciBwcmludGluZy4K IAogICAgIFxzYSBzZXRQcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3IoKQogKi8KLWZsb2F0IFFX ZWJTZXR0aW5nczo6cHJpbnRpbmdNYXhpbXVtU2hyaW5rRmFjdG9yKCkgY29uc3QKK3FyZWFsIFFX ZWJTZXR0aW5nczo6cHJpbnRpbmdNYXhpbXVtU2hyaW5rRmFjdG9yKCkgY29uc3QKIHsKICAgICBy ZXR1cm4gZC0+cHJpbnRpbmdNYXhpbXVtU2hyaW5rRmFjdG9yOwogfQpJbmRleDogV2ViS2l0L3F0 L0FwaS9xd2Vic2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0 aW5ncy5oCShyZXZpc2lvbiA1MDg3MSkKKysrIFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEwMiwxMSArMTAyLDExIEBAIHB1YmxpYzoKICAgICB2b2lkIHNl dERlZmF1bHRUZXh0RW5jb2RpbmcoY29uc3QgUVN0cmluZyAmZW5jb2RpbmcpOwogICAgIFFTdHJp bmcgZGVmYXVsdFRleHRFbmNvZGluZygpIGNvbnN0OwogCi0gICAgdm9pZCBzZXRQcmludGluZ01p bmltdW1TaHJpbmtGYWN0b3IoZmxvYXQgcHJpbnRpbmdNaW5pbXVtU2hyaW5rRmFjdG9yKTsKLSAg ICBmbG9hdCBwcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3IoKSBjb25zdDsKKyAgICB2b2lkIHNl dFByaW50aW5nTWluaW11bVNocmlua0ZhY3RvcihxcmVhbCBwcmludGluZ01pbmltdW1TaHJpbmtG YWN0b3IpOworICAgIHFyZWFsIHByaW50aW5nTWluaW11bVNocmlua0ZhY3RvcigpIGNvbnN0Owog Ci0gICAgdm9pZCBzZXRQcmludGluZ01heGltdW1TaHJpbmtGYWN0b3IoZmxvYXQgcHJpbnRpbmdN YXhpbWltU2hyaW5rRmFjdG9yKTsKLSAgICBmbG9hdCBwcmludGluZ01heGltdW1TaHJpbmtGYWN0 b3IoKSBjb25zdDsKKyAgICB2b2lkIHNldFByaW50aW5nTWF4aW11bVNocmlua0ZhY3RvcihxcmVh bCBwcmludGluZ01heGltaW1TaHJpbmtGYWN0b3IpOworICAgIHFyZWFsIHByaW50aW5nTWF4aW11 bVNocmlua0ZhY3RvcigpIGNvbnN0OwogCiAgICAgc3RhdGljIHZvaWQgc2V0SWNvbkRhdGFiYXNl UGF0aChjb25zdCBRU3RyaW5nICZsb2NhdGlvbik7CiAgICAgc3RhdGljIFFTdHJpbmcgaWNvbkRh dGFiYXNlUGF0aCgpOwo=