30753 2009-10-24 20:55:52 -0700 Build fix for WIN_OS if Netscape plugin support is turned off 2009-10-25 15:45:19 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned kevino tonikitoo oldest_to_newest 157545 0 laszlo.gombos 2009-10-24 20:55:52 -0700 PLATFORM(WX) guards were placed into the plugin code, because WX port does not yet support Netscape plugins; PLATFORM(WX) guard is misused in this context as there could be other ports without Netscape plugin support. I would suggest to consistently use !ENABLE(NETSCAPE_PLUGIN_API) instead of PLATFORM(WX) in the plugin code. THis will make the code easier to read and will resolve some of the build problems when Netscape plugins are not supported or turned off. 157546 1 41810 laszlo.gombos 2009-10-24 20:58:35 -0700 Created attachment 41810 proposed patch 157586 2 kevino 2009-10-25 08:33:19 -0700 I'd prefer not to do this because we intend to support plugins in the not-too-distant future (i.e. I intend to devote some serious time to it in the next couple months and actually have some code in a git branch as a start on it), and in the meantime, it's convenient that we get notified of any breakages as they happen rather than trying to figure out why some change doesn't work with the wx port 3-4 months after the fact. 157589 3 laszlo.gombos 2009-10-25 08:56:44 -0700 (In reply to comment #2) > I'd prefer not to do this because we intend to support plugins in the > not-too-distant future (i.e. I intend to devote some serious time to it in the > next couple months and actually have some code in a git branch as a start on > it), and in the meantime, it's convenient that we get notified of any breakages > as they happen rather than trying to figure out why some change doesn't work > with the wx port 3-4 months after the fact. Ollivier, I would say this change will help to turn on plugin support for wx port. In the meantime wx port can set ENABLE_NETSCAPE_PLUGIN_API to 0 (as other ports, like the QtWebKit Symbian port used to). I missed the fact that wx port did not already set ENABLE_NETSCAPE_PLUGIN_API to 0. Do you have a preference where to set ENABLE_NETSCAPE_PLUGIN_API to 0 for wx port (bkl files or Platform.h or some other pace) ? Thanks. Laszlo 157595 4 kevino 2009-10-25 10:18:16 -0700 (In reply to comment #3) > (In reply to comment #2) > > I'd prefer not to do this because we intend to support plugins in the > > not-too-distant future (i.e. I intend to devote some serious time to it in the > > next couple months and actually have some code in a git branch as a start on > > it), and in the meantime, it's convenient that we get notified of any breakages > > as they happen rather than trying to figure out why some change doesn't work > > with the wx port 3-4 months after the fact. > > Ollivier, I would say this change will help to turn on plugin support for wx > port. How? I don't really understand the logic behind this change. > In the meantime wx port can set ENABLE_NETSCAPE_PLUGIN_API to 0 (as other > ports, like the QtWebKit Symbian port used to). > > I missed the fact that wx port did not already set ENABLE_NETSCAPE_PLUGIN_API > to 0. Do you have a preference where to set ENABLE_NETSCAPE_PLUGIN_API to 0 for > wx port (bkl files or Platform.h or some other pace) ? Thanks. Laszlo It is intentionally not set. Maybe you are not clear on this - I *want* ENABLE_NETSCAPE_PLUGIN_API set to 1, not 0. The platform APIs are not yet implemented, but they will be, and in the meantime, the stubbed implementation compiles just fine. What is wrong with that? Could you explain what problem you're trying to address? Does wx's ability to compile with ENABLE_NETSCAPE_PLUGIN_API support on cause problems for you? 157627 5 laszlo.gombos 2009-10-25 15:32:13 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > I'd prefer not to do this because we intend to support plugins in the > > > not-too-distant future (i.e. I intend to devote some serious time to it in the > > > next couple months and actually have some code in a git branch as a start on > > > it), and in the meantime, it's convenient that we get notified of any breakages > > > as they happen rather than trying to figure out why some change doesn't work > > > with the wx port 3-4 months after the fact. > > > > Ollivier, I would say this change will help to turn on plugin support for wx > > port. > > How? I don't really understand the logic behind this change. > > > In the meantime wx port can set ENABLE_NETSCAPE_PLUGIN_API to 0 (as other > > ports, like the QtWebKit Symbian port used to). > > > > I missed the fact that wx port did not already set ENABLE_NETSCAPE_PLUGIN_API > > to 0. Do you have a preference where to set ENABLE_NETSCAPE_PLUGIN_API to 0 for > > wx port (bkl files or Platform.h or some other pace) ? Thanks. Laszlo > > It is intentionally not set. Maybe you are not clear on this - I *want* > ENABLE_NETSCAPE_PLUGIN_API set to 1, not 0. The platform APIs are not yet > implemented, but they will be, and in the meantime, the stubbed implementation > compiles just fine. What is wrong with that? > > Could you explain what problem you're trying to address? Does wx's ability to > compile with ENABLE_NETSCAPE_PLUGIN_API support on cause problems for you? You're right, I though Netscape plugin support is turned off for wx port. My particular problem was turning off Netscape plugin support for WIN_OS. I changed the bug title to say just that and will change the patch to address just that particular problem; and will not change the PLATFORM(WX) guards. Thanks for helping fixing my patch. Laszlo 157629 6 laszlo.gombos 2009-10-25 15:45:19 -0700 After addressing only the WIN_OS specific problem the patch become trivial build fix. Committed as http://trac.webkit.org/changeset/50047. Closing the bug. 41810 2009-10-24 20:58:35 -0700 2009-10-25 15:36:16 -0700 proposed patch 30753.patch text/plain 4423 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDAzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSBQTEFURk9STShXWCkgZ3VhcmRzIGZyb20gdGhlIHBsdWdpbnMgY29kZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3NTMKKwor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luRGF0YWJhc2UuY3BwOgorICAgICAgICAqIHBsdWdpbnMv UGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzdG9wKToKKyAg ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OlBsdWdpblZpZXcpOgorICAgICAgICAqIHBsdWdp bnMvUGx1Z2luVmlldy5oOgorCiAyMDA5LTEwLTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUv cGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5z L1BsdWdpbkRhdGFiYXNlLmNwcAkocmV2aXNpb24gNTAwMjgpCisrKyBXZWJDb3JlL3BsdWdpbnMv UGx1Z2luRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjAsNyArMzIwLDcgQEAgdm9p ZCBQbHVnaW5EYXRhYmFzZTo6Y2xlYXIoKQogICAgIG1fcHJlZmVycmVkUGx1Z2lucy5jbGVhcigp OwogfQogCi0jaWYgKCFQTEFURk9STShTWU1CSUFOKSkgJiYgKCFQTEFURk9STShXSU5fT1MpIHx8 IFBMQVRGT1JNKFdYKSkKKyNpZiAoIVBMQVRGT1JNKFNZTUJJQU4pKSAmJiAoIVBMQVRGT1JNKFdJ Tl9PUykgfHwgIUVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKSkKIC8vIEZvciBTYWZhcmkvV2lu IHRoZSBmb2xsb3dpbmcgdGhyZWUgbWV0aG9kcyBhcmUgaW1wbGVtZW50ZWQKIC8vIGluIFBsdWdp bkRhdGFiYXNlV2luLmNwcCwgYnV0IGlmIHdlIGNhbiB1c2UgV2ViQ29yZSBjb25zdHJ1Y3RzCiAv LyBmb3IgdGhlIGxvZ2ljIHdlIHNob3VsZCBwZXJoYXBzIG1vdmUgaXQgaGVyZSB1bmRlciBYUF9X SU4/CkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCShyZXZpc2lvbiA1MDAyOCkKKysrIFdlYkNv cmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBA QAogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKICNpbmNs dWRlICJQbGF0Zm9ybU1vdXNlRXZlbnQuaCIKLSNpZiBQTEFURk9STShXSU5fT1MpICYmICFQTEFU Rk9STShXWCkgJiYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCisjaWYgUExBVEZPUk0oV0lO X09TKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICNpbmNsdWRlICJQbHVnaW5NZXNz YWdlVGhyb3R0bGVyV2luLmgiCiAjZW5kaWYKICNpbmNsdWRlICJQbHVnaW5QYWNrYWdlLmgiCkBA IC0zMDYsNyArMzA2LDYgQEAgdm9pZCBQbHVnaW5WaWV3OjpzdG9wKCkKICAgICBKU0M6OkpTTG9j azo6RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhKU0M6OlNpbGVuY2VBc3NlcnRpb25zT25seSk7 CiAKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKLSNpZiAhUExBVEZPUk0oV1gpIC8v IEZJWE1FOiBSZXZpc2l0IHRoaXMgd2hlbiBpbXBsZW1lbnRpbmcgcGx1Z2lucyBmb3Igd3gKICNp ZmRlZiBYUF9XSU4KICAgICAvLyBVbnN1YmNsYXNzIHRoZSB3aW5kb3cKICAgICBpZiAobV9pc1dp bmRvd2VkKSB7CkBAIC0zMjMsNyArMzIyLDYgQEAgdm9pZCBQbHVnaW5WaWV3OjpzdG9wKCkKICNl bmRpZgogICAgIH0KICNlbmRpZiAvLyBYUF9XSU4KLSNlbmRpZiAvLyAhUExBVEZPUk0oV1gpCiAj ZW5kaWYgLy8gRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAKICNpZiAhZGVmaW5lZChYUF9N QUNPU1gpCkBAIC04MDQsNyArODAyLDcgQEAgUGx1Z2luVmlldzo6UGx1Z2luVmlldyhGcmFtZSog cGFyZW50RnJhbQogI2lmIGRlZmluZWQoWFBfVU5JWCkgfHwgZGVmaW5lZChRX1dTX1gxMSkKICAg ICAsIG1fbmVlZHNYRW1iZWQoZmFsc2UpCiAjZW5kaWYKLSNpZiBQTEFURk9STShXSU5fT1MpICYm ICFQTEFURk9STShXWCkgJiYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCisjaWYgUExBVEZP Uk0oV0lOX09TKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICAsIG1fcGx1Z2lu V25kUHJvYygwKQogICAgICwgbV9sYXN0TWVzc2FnZSgwKQogICAgICwgbV9pc0NhbGxpbmdQbHVn aW5XbmRQcm9jKGZhbHNlKQpJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCShyZXZpc2lvbiA1MDAyOCkK KysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDcg KzY1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNsYXNzIEtleWJvYXJkRXZlbnQ7CiAg ICAgY2xhc3MgTW91c2VFdmVudDsKICAgICBjbGFzcyBLVVJMOwotI2lmIFBMQVRGT1JNKFdJTl9P UykgJiYgIVBMQVRGT1JNKFdYKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKKyNpZiBQ TEFURk9STShXSU5fT1MpICYmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAgIGNsYXNz IFBsdWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW47CiAjZW5kaWYKICAgICBjbGFzcyBQbHVnaW5QYWNr YWdlOwpAQCAtMTgzLDcgKzE4Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgY29u c3QgU3RyaW5nJiBtaW1lVHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWltZVR5cGU7IH0KICAgICAg ICAgY29uc3QgS1VSTCYgdXJsKCkgY29uc3QgeyByZXR1cm4gbV91cmw7IH0KIAotI2lmIFBMQVRG T1JNKFdJTl9PUykgJiYgIVBMQVRGT1JNKFdYKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ SSkKKyNpZiBQTEFURk9STShXSU5fT1MpICYmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQog ICAgICAgICBzdGF0aWMgTFJFU1VMVCBDQUxMQkFDSyBQbHVnaW5WaWV3V25kUHJvYyhIV05ELCBV SU5ULCBXUEFSQU0sIExQQVJBTSk7CiAgICAgICAgIExSRVNVTFQgd25kUHJvYyhIV05EIGhXbmQs IFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSk7CiAgICAgICAgIFdO RFBST0MgcGx1Z2luV25kUHJvYygpIGNvbnN0IHsgcmV0dXJuIG1fcGx1Z2luV25kUHJvYzsgfQpA QCAtMjI2LDcgKzIyNiw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2b2lkIGlu dmFsaWRhdGVXaW5kb3dsZXNzUGx1Z2luUmVjdChjb25zdCBJbnRSZWN0Jik7CiAKLSNpZiBQTEFU Rk9STShXSU5fT1MpICYmICFQTEFURk9STShXWCkgJiYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9B UEkpCisjaWYgUExBVEZPUk0oV0lOX09TKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkK ICAgICAgICAgdm9pZCBwYWludFdpbmRvd2VkUGx1Z2luSW50b0NvbnRleHQoR3JhcGhpY3NDb250 ZXh0KiwgY29uc3QgSW50UmVjdCYpOwogICAgICAgICBzdGF0aWMgSERDIFdJTkFQSSBob29rZWRC ZWdpblBhaW50KEhXTkQsIFBBSU5UU1RSVUNUKik7CiAgICAgICAgIHN0YXRpYyBCT09MIFdJTkFQ SSBob29rZWRFbmRQYWludChIV05ELCBjb25zdCBQQUlOVFNUUlVDVCopOwpAQCAtMjk2LDcgKzI5 Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgYm9vbCBtX25lZWRzWEVtYmVkOwog I2VuZGlmCiAKLSNpZiBQTEFURk9STShXSU5fT1MpICYmICFQTEFURk9STShXWCkgJiYgRU5BQkxF KE5FVFNDQVBFX1BMVUdJTl9BUEkpCisjaWYgUExBVEZPUk0oV0lOX09TKSAmJiBFTkFCTEUoTkVU U0NBUEVfUExVR0lOX0FQSSkKICAgICAgICAgT3duUHRyPFBsdWdpbk1lc3NhZ2VUaHJvdHRsZXJX aW4+IG1fbWVzc2FnZVRocm90dGxlcjsKICAgICAgICAgV05EUFJPQyBtX3BsdWdpblduZFByb2M7 CiAgICAgICAgIHVuc2lnbmVkIG1fbGFzdE1lc3NhZ2U7Cg==