30750 2009-10-24 14:48:18 -0700 Make .rc files compile on Windows without depending on MFC headers 2009-10-26 19:34:07 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 laszlo.gombos laszlo.gombos aroben eric mrowe sfalken oldest_to_newest 157492 0 laszlo.gombos 2009-10-24 14:48:18 -0700 It seems to me that that a few Safari win components are unnecessary depend on MFC. The two header files that are used from MFC as a dependency (winres.h and afxres.h) can be easily eliminated by including winresrc.h and windows.h instead. winres.h is nothing more than the MFC wrapper around winresrc.h. The benefit of these changes would be that for those using VC Express installing "Windows Server 2003 R2 Platform SDK" becomes unnecessary (see http://webkit.org/building/tools.html). 157493 1 41797 laszlo.gombos 2009-10-24 14:55:01 -0700 Created attachment 41797 proposed patch 157527 2 laszlo.gombos 2009-10-24 19:19:07 -0700 Just another thought why this could be useful - as far as I know none of the other WebKit win ports (e.g Qt, wx) depends directly on MFC. 157643 3 41797 darin 2009-10-25 17:25:52 -0700 Comment on attachment 41797 proposed patch If the comments in the change log explained why these are good changes, this patch would be much better! It could simply say something like "Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here." And the equivalent elsewhere. Or the bug title could be more specific: "Make .rc files compile on Windows without depending on MFC headers." Then you might be OK without further comments. Either of these changes would remove the mysterious "improvements" aspect of this and make this small simple patch much better! r=me, as is. Next time, please be clearer in the change log or the bug title or both. 157857 4 laszlo.gombos 2009-10-26 12:07:23 -0700 Will land myself fixing the ChangeLog as suggested by Darin. 158059 5 laszlo.gombos 2009-10-26 19:33:54 -0700 Landed as http://trac.webkit.org/changeset/50120. Thanks for the review, Darin ! 41797 2009-10-24 14:55:01 -0700 2009-10-26 19:34:07 -0700 proposed patch 30750.patch text/plain 4846 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwMDI4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjQgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGltcHJvdmVtZW50cyBmb3IgV2luCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDc1MAorCisg ICAgICAgICogSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlLnJjOgorCiAyMDA5LTEwLTI0ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5v a2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4OiBK YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNj cmlwdENvcmUucmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu dmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnJjCShyZXZpc2lvbiA1MDAyNykK KysrIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS5yYwkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAKIC8vIE1pY3Jv c29mdCBWaXN1YWwgQysrIGdlbmVyYXRlZCByZXNvdXJjZSBzY3JpcHQuCiAvLwogI2luY2x1ZGUg ImF1dG92ZXJzaW9uLmgiCi0jaW5jbHVkZSAid2lucmVzLmgiCisjaW5jbHVkZSAid2lucmVzcmMu aCIKIAogI2lmZGVmIF9XSU4zMgogTEFOR1VBR0UgTEFOR19FTkdMSVNILCBTVUJMQU5HX0VOR0xJ U0hfVVMKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiA1MDAyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEJ1aWxkIGltcHJvdmVtZW50cyBmb3IgV2luCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDc1MAorCisgICAgICAgICogV2ViQ29y ZS52Y3Byb2ovUVRNb3ZpZVdpbi5yYzoKKwogMjAwOS0xMC0yNCAgTGFzemxvIEdvbWJvcyAgPGxh c3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IFdl YkNvcmUvV2ViQ29yZS52Y3Byb2ovUVRNb3ZpZVdpbi5yYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L1dlYkNvcmUudmNwcm9qL1FUTW92aWVXaW4ucmMJKHJldmlzaW9uIDUwMDI3KQorKysgV2ViQ29y ZS9XZWJDb3JlLnZjcHJvai9RVE1vdmllV2luLnJjCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEs NyBAQAogLy8gTWljcm9zb2Z0IFZpc3VhbCBDKysgZ2VuZXJhdGVkIHJlc291cmNlIHNjcmlwdC4K IC8vCiAjaW5jbHVkZSAiYXV0b3ZlcnNpb24uaCIKLSNpbmNsdWRlICJ3aW5yZXMuaCIKKyNpbmNs dWRlICJ3aW5yZXNyYy5oIgogCiAjaWZkZWYgX1dJTjMyCiBMQU5HVUFHRSBMQU5HX0VOR0xJU0gs IFNVQkxBTkdfRU5HTElTSF9VUwpJbmRleDogV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwMDI4KQorKysgV2ViS2l0L3dp bi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0xMC0yNCAg TGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGQgaW1wcm92ZW1lbnRzIGZv ciBXaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMw NzUwCisKKyAgICAgICAgKiBXZWJLaXQudmNwcm9qL1dlYktpdC5yYzoKKwogMjAwOS0xMC0yMyAg TWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4gIEluY2x1 ZGUgY29uZmlnLmggYmVmb3JlIGluY2x1ZGluZyBvdGhlciBmaWxlcy4KSW5kZXg6IFdlYktpdC93 aW4vV2ViS2l0LnZjcHJvai9XZWJLaXQucmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9XZWJL aXQudmNwcm9qL1dlYktpdC5yYwkocmV2aXNpb24gNTAwMjcpCisrKyBXZWJLaXQvd2luL1dlYktp dC52Y3Byb2ovV2ViS2l0LnJjCSh3b3JraW5nIGNvcHkpCkBAIC0yLDcgKzIsNyBAQAogLy8KICNp bmNsdWRlICJyZXNvdXJjZS5oIgogI2luY2x1ZGUgImF1dG92ZXJzaW9uLmgiCi0jaW5jbHVkZSAi d2lucmVzLmgiCisjaW5jbHVkZSAid2lucmVzcmMuaCIKIAogI2lmZGVmIF9XSU4zMgogTEFOR1VB R0UgTEFOR19FTkdMSVNILCBTVUJMQU5HX0VOR0xJU0hfVVMKSW5kZXg6IFdlYktpdFRvb2xzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDUw MDI4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTMgQEAKKzIwMDktMTAtMjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1 aWxkIGltcHJvdmVtZW50cyBmb3IgV2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDc1MAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL1Rl c3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4ucmM6CisgICAgICAgICogRmluZFNh ZmFyaS9GaW5kU2FmYXJpLnJjOgorCiAyMDA5LTEwLTIzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIG9ubHkgYWRkaW5nIEFsaWNlIHRvIHRoZSBs aXN0IG9mIHJldmlld2Vycy4KSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9U ZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnJjCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNj YXBlUGx1Z2luLnJjCShyZXZpc2lvbiA1MDAyNykKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3dpbi9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnJjCSh3b3JraW5n IGNvcHkpCkBAIC03LDcgKzcsNyBAQAogLy8NCiAvLyBHZW5lcmF0ZWQgZnJvbSB0aGUgVEVYVElO Q0xVREUgMiByZXNvdXJjZS4NCiAvLw0KLSNpbmNsdWRlICJhZnhyZXMuaCINCisjaW5jbHVkZSAi d2luZG93cy5oIg0KIA0KIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vDQogI3VuZGVmIEFQU1RVRElPX1JF QURPTkxZX1NZTUJPTFMNCkBAIC0zNCw3ICszNCw3IEBAIEVORA0KIA0KIDIgVEVYVElOQ0xVREUg DQogQkVHSU4NCi0gICAgIiNpbmNsdWRlICIiYWZ4cmVzLmgiIlxyXG4iDQorICAgICIjaW5jbHVk ZSAiIndpbmRvd3MuaCIiXHJcbiINCiAgICAgIlwwIg0KIEVORA0KIA0KSW5kZXg6IFdlYktpdFRv b2xzL0ZpbmRTYWZhcmkvRmluZFNhZmFyaS5yYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9G aW5kU2FmYXJpL0ZpbmRTYWZhcmkucmMJKHJldmlzaW9uIDUwMDI3KQorKysgV2ViS2l0VG9vbHMv RmluZFNhZmFyaS9GaW5kU2FmYXJpLnJjCSh3b3JraW5nIGNvcHkpCkBAIC03LDcgKzcsNyBAQAog Ly8KIC8vIEdlbmVyYXRlZCBmcm9tIHRoZSBURVhUSU5DTFVERSAyIHJlc291cmNlLgogLy8KLSNp bmNsdWRlICJhZnhyZXMuaCIKKyNpbmNsdWRlICJ3aW5kb3dzLmgiCiAKIC8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vCiAjdW5kZWYgQVBTVFVESU9fUkVBRE9OTFlfU1lNQk9MUwpAQCAtMzQsNyArMzQsNyBA QCBFTkQKIAogMiBURVhUSU5DTFVERSAKIEJFR0lOCi0gICAgIiNpbmNsdWRlICIiYWZ4cmVzLmgi IlxyXG4iCisgICAgIiNpbmNsdWRlICIid2luZG93cy5oIiJcclxuIgogICAgICJcMCIKIEVORAog Cg==