30749 2009-10-24 12:04:02 -0700 Web Inspector: Expanding a node in the Console should not show the element in Elements panel 2009-10-25 01:55:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 timothy keishi aroben bweinstein commit-queue joepeck pfeldman rik timothy oldest_to_newest 157466 0 timothy 2009-10-24 12:04:02 -0700 If you log a node in the Console and go to expand it, it reveals the node in Elements and selectes it. But it should not. We should only reveal when clicking on the node text. 157472 1 41791 keishi 2009-10-24 13:15:25 -0700 Created attachment 41791 proposed patch 157478 2 41791 timothy 2009-10-24 13:20:21 -0700 Comment on attachment 41791 proposed patch Remove console.log(event.target); otherwise r+. 157526 3 41805 keishi 2009-10-24 19:13:15 -0700 Created attachment 41805 proposed patch 2 Sorry, fixed. 157574 4 41805 commit-queue 2009-10-25 01:54:54 -0700 Comment on attachment 41805 proposed patch 2 Clearing flags on attachment: 41805 Committed r50044: <http://trac.webkit.org/changeset/50044> 157575 5 commit-queue 2009-10-25 01:55:01 -0700 All reviewed patches have been landed. Closing bug. 41791 2009-10-24 13:15:25 -0700 2009-10-24 19:13:15 -0700 proposed patch 30749.diff text/plain 1443 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDAyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMjQgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViIEluc3BlY3RvcjogRXhwYW5kaW5nIGEgbm9kZSBpbiB0aGUgQ29uc29sZSBzaG91 bGQgbm90IHNob3cgdGhlIGVsZW1lbnQgaW4gRWxlbWVudHMgcGFuZWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzQ5CisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUub25tb3VzZWRvd24pOiBDaGVjayBp ZiBpbnNpZGUgZGlzY2xvc3VyZSB0cmlhbmdsZS4KKwogMjAwOS0xMC0yNCAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxk IGZpeC4KSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRs aW5lLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50 c1RyZWVPdXRsaW5lLmpzCShyZXZpc2lvbiA0OTkzNykKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC01MTAsNyAr NTEwLDEwIEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHkKICAgICAg ICAgaWYgKHRoaXMuX2VkaXRpbmcpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYg KHRoaXMudHJlZU91dGxpbmUuc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQpIHsgICAgCisgICAg ICAgIGlmICh0aGlzLmlzRXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUoZXZlbnQpKQorICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmICh0aGlzLnRyZWVPdXRsaW5lLnNob3dJbkVs ZW1lbnRzUGFuZWxFbmFibGVkKSB7Y29uc29sZS5sb2coZXZlbnQudGFyZ2V0KTsKICAgICAgICAg ICAgIFdlYkluc3BlY3Rvci5zaG93RWxlbWVudHNQYW5lbCgpOwogICAgICAgICAgICAgV2ViSW5z cGVjdG9yLnBhbmVscy5lbGVtZW50cy5mb2N1c2VkRE9NTm9kZSA9IHRoaXMucmVwcmVzZW50ZWRP YmplY3Q7CiAgICAgICAgIH0K 41805 2009-10-24 19:13:15 -0700 2009-10-25 01:54:53 -0700 proposed patch 2 30749.diff text/plain 1395 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDAzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMjQgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViIEluc3BlY3RvcjogRXhwYW5kaW5nIGEgbm9kZSBpbiB0aGUgQ29uc29sZSBzaG91 bGQgbm90IHNob3cgdGhlIGVsZW1lbnQgaW4gRWxlbWVudHMgcGFuZWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzQ5CisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUub25tb3VzZWRvd24pOiBDaGVjayBp ZiBpbnNpZGUgZGlzY2xvc3VyZSB0cmlhbmdsZS4KKwogMjAwOS0xMC0yNCAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB0aGUgc2NvcGUgYmFycyBp biB0aGUgV2ViIEluc3BlY3RvciBtYXRjaCBvdGhlciBzY29wZSBiYXJzIGluIE1hYyBPUyBYLgpJ bmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91 dGxpbmUuanMJKHJldmlzaW9uIDUwMDI3KQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanMJKHdvcmtpbmcgY29weSkKQEAgLTUxMCw2ICs1MTAsOSBA QCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5CiAgICAgICAgIGlmICh0 aGlzLl9lZGl0aW5nKQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIGlmICh0aGlzLmlz RXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUoZXZlbnQpKQorICAgICAgICAgICAgcmV0dXJu OworCiAgICAgICAgIGlmICh0aGlzLnRyZWVPdXRsaW5lLnNob3dJbkVsZW1lbnRzUGFuZWxFbmFi bGVkKSB7ICAgIAogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnNob3dFbGVtZW50c1BhbmVsKCk7 CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRzLmZvY3VzZWRET01Ob2Rl ID0gdGhpcy5yZXByZXNlbnRlZE9iamVjdDsK