30745 2009-10-24 11:52:09 -0700 [v8] implement ReturnsNew IDL hint for V8 code generator 2009-10-24 15:40:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 antonm webkit-unassigned commit-queue oldest_to_newest 157458 0 antonm 2009-10-24 11:52:09 -0700 In IDL some methods has ReturnsNew tag which guarantees that results of such methods are fresh objects. It allows to skip checks for presence of the wrapper for the object. 157460 1 41786 antonm 2009-10-24 11:55:32 -0700 Created attachment 41786 First take 157465 2 41786 abarth 2009-10-24 12:00:53 -0700 Comment on attachment 41786 First take This looks fine. + No new tests. (OOPS!) This line will prevent the commit-queue from landing the patch, however. 157495 3 41798 antonm 2009-10-24 15:04:30 -0700 Created attachment 41798 "No new tests" line removed 157496 4 antonm 2009-10-24 15:05:42 -0700 (In reply to comment #2) > (From update of attachment 41786 [details]) > This looks fine. > > + No new tests. (OOPS!) > > This line will prevent the commit-queue from landing the patch, however. Thanks a lot for review, Adam. "No new tests" line removed in the new patch. 157505 5 41798 commit-queue 2009-10-24 15:40:25 -0700 Comment on attachment 41798 "No new tests" line removed Clearing flags on attachment: 41798 Committed r50030: <http://trac.webkit.org/changeset/50030> 157506 6 commit-queue 2009-10-24 15:40:28 -0700 All reviewed patches have been landed. Closing bug. 41786 2009-10-24 11:55:32 -0700 2009-10-24 15:04:30 -0700 First take WebKit.patch text/plain 2207 antonm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDAyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjQgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bXBsZW1lbnRzIFJldHVybnNOZXcgaGludCBmb3IgVjggYmluZGluZ3MgZ2VuZXJhdGlvbiBjb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3NDUK KworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3Jh cHBlci5oOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpjb252ZXJ0TmV3Tm9kZVRv VjhPYmplY3QpOgorCiAyMDA5LTEwLTI0ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4LgpJbmRleDogV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCShyZXZpc2lvbiA0OTk2MSkK KysrIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHdvcmtpbmcg Y29weSkKQEAgLTIxNTQsNyArMjE1NCwxMSBAQAogCiAgICAgIyBzcGVjaWFsIGNhc2UgZm9yIG5v bi1ET00gbm9kZSBpbnRlcmZhY2VzCiAgICAgaWYgKElzRE9NTm9kZVR5cGUoJHR5cGUpKSB7Ci0g ICAgICAgIHJldHVybiAicmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydE5vZGVUb1Y4T2JqZWN0 KCR2YWx1ZSkiOworICAgICAgICBpZiAoJHNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IlJldHVybnNOZXcifSkgeworICAgICAgICAgICAgcmV0dXJuICJyZXR1cm4gVjhET01XcmFwcGVy Ojpjb252ZXJ0TmV3Tm9kZVRvVjhPYmplY3QoJHZhbHVlKSI7CisgICAgICAgIH0gZWxzZSB7Cisg ICAgICAgICAgICByZXR1cm4gInJldHVybiBWOERPTVdyYXBwZXI6OmNvbnZlcnROb2RlVG9WOE9i amVjdCgkdmFsdWUpIjsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGlmICgkdHlwZSBlcSAiRXZl bnRUYXJnZXQiIG9yICR0eXBlIGVxICJTVkdFbGVtZW50SW5zdGFuY2UiKSB7CkluZGV4OiBXZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvdjgvVjhET01XcmFwcGVyLmgJKHJldmlzaW9uIDQ5OTYxKQorKysgV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTY2LDYgKzE2NiwxNiBA QAogCiAgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29udmVydERvY3VtZW50 VG9WOE9iamVjdChEb2N1bWVudCopOwogCisgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gY29udmVydE5ld05vZGVUb1Y4T2JqZWN0KFBhc3NSZWZQdHI8Tm9kZT4gbm9kZSkKKyAg ICAgICAgeworICAgICAgICAgICAgcmV0dXJuIGNvbnZlcnROZXdOb2RlVG9WOE9iamVjdChub2Rl LmdldCgpKTsKKyAgICAgICAgfQorCisgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gY29udmVydE5ld05vZGVUb1Y4T2JqZWN0KE5vZGUqIG5vZGUpCisgICAgICAgIHsKKyAgICAg ICAgICAgIHJldHVybiBjb252ZXJ0TmV3Tm9kZVRvVjhPYmplY3Qobm9kZSwgMCwgZ2V0RE9NTm9k ZU1hcCgpKTsKKyAgICAgICAgfQorCiAgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gY29udmVydE5ld05vZGVUb1Y4T2JqZWN0KE5vZGUqLCBWOFByb3h5KiwgRE9NV3JhcHBlck1h cDxOb2RlPiYpOwogCiAgICAgICAgIHRlbXBsYXRlIDxjbGFzcyBDPgo= 41798 2009-10-24 15:04:30 -0700 2009-10-24 15:40:25 -0700 "No new tests" line removed WebCore.patch text/plain 2174 antonm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDAyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjQgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bXBsZW1lbnRzIFJldHVybnNOZXcgaGludCBmb3IgVjggYmluZGluZ3MgZ2VuZXJhdGlvbiBjb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3NDUK KworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oOgorICAgICAgICAoV2ViQ29yZTo6VjhET01X cmFwcGVyOjpjb252ZXJ0TmV3Tm9kZVRvVjhPYmplY3QpOgorCiAyMDA5LTEwLTI0ICBEaW1pdHJp IEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg YnVpbGQgZml4LgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JW OC5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCShyZXZpc2lvbiA0OTk2MSkKKysrIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG0JKHdvcmtpbmcgY29weSkKQEAgLTIxNTQsNyArMjE1NCwxMSBAQAogCiAg ICAgIyBzcGVjaWFsIGNhc2UgZm9yIG5vbi1ET00gbm9kZSBpbnRlcmZhY2VzCiAgICAgaWYgKElz RE9NTm9kZVR5cGUoJHR5cGUpKSB7Ci0gICAgICAgIHJldHVybiAicmV0dXJuIFY4RE9NV3JhcHBl cjo6Y29udmVydE5vZGVUb1Y4T2JqZWN0KCR2YWx1ZSkiOworICAgICAgICBpZiAoJHNpZ25hdHVy ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJldHVybnNOZXcifSkgeworICAgICAgICAgICAgcmV0 dXJuICJyZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0TmV3Tm9kZVRvVjhPYmplY3QoJHZhbHVl KSI7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICByZXR1cm4gInJldHVybiBWOERPTVdy YXBwZXI6OmNvbnZlcnROb2RlVG9WOE9iamVjdCgkdmFsdWUpIjsKKyAgICAgICAgfQogICAgIH0K IAogICAgIGlmICgkdHlwZSBlcSAiRXZlbnRUYXJnZXQiIG9yICR0eXBlIGVxICJTVkdFbGVtZW50 SW5zdGFuY2UiKSB7CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgJKHJldmlzaW9u IDQ5OTYxKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAkod29ya2luZyBj b3B5KQpAQCAtMTY2LDYgKzE2NiwxNiBAQAogCiAgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gY29udmVydERvY3VtZW50VG9WOE9iamVjdChEb2N1bWVudCopOwogCisgICAgICAg IHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29udmVydE5ld05vZGVUb1Y4T2JqZWN0KFBh c3NSZWZQdHI8Tm9kZT4gbm9kZSkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIGNvbnZl cnROZXdOb2RlVG9WOE9iamVjdChub2RlLmdldCgpKTsKKyAgICAgICAgfQorCisgICAgICAgIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29udmVydE5ld05vZGVUb1Y4T2JqZWN0KE5vZGUq IG5vZGUpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiBjb252ZXJ0TmV3Tm9kZVRvVjhP YmplY3Qobm9kZSwgMCwgZ2V0RE9NTm9kZU1hcCgpKTsKKyAgICAgICAgfQorCiAgICAgICAgIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29udmVydE5ld05vZGVUb1Y4T2JqZWN0KE5vZGUq LCBWOFByb3h5KiwgRE9NV3JhcHBlck1hcDxOb2RlPiYpOwogCiAgICAgICAgIHRlbXBsYXRlIDxj bGFzcyBDPgo=