30743 2009-10-24 10:58:29 -0700 Web Inspector: REGRESSION: Can't click on Resources to view them 2009-10-24 20:01:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Normal --- 0 timothy timothy aroben bweinstein joepeck pfeldman rik timothy oldest_to_newest 157454 0 timothy 2009-10-24 10:58:29 -0700 You can no longer click on a Resource to view it. 157475 1 timothy 2009-10-24 13:17:49 -0700 This was caused by the Resource scope bar change. I have a fix I am working on. 157479 2 bweinstein 2009-10-24 13:21:06 -0700 Will the fix for https://bugs.webkit.org/show_bug.cgi?id=30744 fix this? Or what did changing the scope bar do to break it? All that should do is change the css, nothing to do with clinking resources. 157480 3 timothy 2009-10-24 13:22:19 -0700 You removed WebInspector.panels.resources._filterCategory, and it is used to determine selectability. 157481 4 bweinstein 2009-10-24 13:23:37 -0700 Oh, hm, that is weird. Why does it need _filterCategory for selectability? Sorry, I didn't think that would be an issue so I didn't check it. 157483 5 41794 timothy 2009-10-24 13:34:46 -0700 Created attachment 41794 Proposed Patch 157484 6 timothy 2009-10-24 13:35:54 -0700 Since the filter just hides the items in the tree, they are still there. So selectable is called when arrowing through the list. Otherwise you would arrow to invisible resources. 157485 7 bweinstein 2009-10-24 13:37:24 -0700 (In reply to comment #5) > Created an attachment (id=41794) [details] > Proposed Patch Does the category name need to be in lower case? Are CSS classes case sensitive? Otherwise, looks good here but I can't review yet. 157490 8 41796 timothy 2009-10-24 13:52:03 -0700 Created attachment 41796 Proposed Patch 157491 9 bweinstein 2009-10-24 13:55:44 -0700 (In reply to comment #8) > Created an attachment (id=41796) [details] > Proposed Patch Looks good, hopefully pfeldman or someone can come along and r+ it. 157533 10 timothy 2009-10-24 20:01:59 -0700 Committed r50035: <http://trac.webkit.org/changeset/50035> 41794 2009-10-24 13:34:46 -0700 2009-10-24 13:51:59 -0700 Proposed Patch bug-30743-20091024133444.patch text/plain 1856 timothy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjJjMmUzNy4uMjcwZDQxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0xMC0yNCAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IHNlbGVjdGluZyBSZXNvdXJj ZXMgaW4gdGhlIFdlYiBJbnNwZWN0b3IncyBSZXNvdXJjZXMgcGFuZWwuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzQzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVs LnByb3RvdHlwZS5pc0NhdGVnb3J5VmlzaWJsZSk6IEFkZGVkLgorICAgICAgICAoV2ViSW5zcGVj dG9yLlJlc291cmNlU2lkZWJhclRyZWVFbGVtZW50LnByb3RvdHlwZS5nZXQgc2VsZWN0YWJsZSk6 IENhbGwKKyAgICAgICAgaXNDYXRlZ29yeVZpc2libGUgb24gdGhlIFJlc291cmNlc1BhbmVsLgor CisyMDA5LTEwLTI0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAg ICAgICBGaXggdGhlIFNjb3BlIEJhciBpbiB0aGUgV2ViIEluc3BlY3RvcidzIFJlc291cmNlIHBh bmVsLCBzbyB0aGF0IHNlbGVjdGluZwogICAgICAgICBBbGwgd2lsbCBkZXNlbGVjdCB0aGUgb3Ro ZXIgZmlsdGVycy4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlc1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1Bh bmVsLmpzCmluZGV4IDRhNTU5ZDcuLjY5YzBlNDEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKQEAgLTIyOSw3ICsyMjksMTIgQEAgV2ViSW5zcGVj dG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKLSAg ICBfdXBkYXRlRmlsdGVyOiBmdW5jdGlvbiAoZSkKKyAgICBpc0NhdGVnb3J5VmlzaWJsZTogZnVu Y3Rpb24oY2F0ZWdvcnlOYW1lKQorICAgIHsKKyAgICAgICAgcmV0dXJuICh0aGlzLnJlc291cmNl c0dyYXBoc0VsZW1lbnQuaGFzU3R5bGVDbGFzcygiZmlsdGVyLWFsbCIpIHx8IHRoaXMucmVzb3Vy Y2VzR3JhcGhzRWxlbWVudC5oYXNTdHlsZUNsYXNzKCJmaWx0ZXItIiArIGNhdGVnb3J5TmFtZSkp OworICAgIH0sCisKKyAgICBfdXBkYXRlRmlsdGVyOiBmdW5jdGlvbihlKQogICAgIHsKICAgICAg ICAgdGhpcy5maWx0ZXIoZS50YXJnZXQpOwogICAgIH0sCkBAIC0xMzMyLDcgKzEzMzcsNyBAQCBX ZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAg ICAgZ2V0IHNlbGVjdGFibGUoKQogICAgIHsKLSAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5w YW5lbHMucmVzb3VyY2VzLl9maWx0ZXJDYXRlZ29yeSA9PSAiYWxsIiB8fCBXZWJJbnNwZWN0b3Iu cGFuZWxzLnJlc291cmNlcy5fZmlsdGVyQ2F0ZWdvcnkgPT0gdGhpcy5yZXNvdXJjZS5jYXRlZ29y eS5uYW1lOworICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLnBhbmVscy5yZXNvdXJjZXMuaXND YXRlZ29yeVZpc2libGUodGhpcy5yZXNvdXJjZS5jYXRlZ29yeS5uYW1lKTsKICAgICB9LAogCiAg ICAgY3JlYXRlSWNvbkVsZW1lbnQ6IGZ1bmN0aW9uKCk= 41796 2009-10-24 13:52:03 -0700 2009-10-24 15:56:12 -0700 Proposed Patch bug-30743-20091024135201.patch text/plain 1870 timothy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjJjMmUzNy4uMjcwZDQxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0xMC0yNCAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IHNlbGVjdGluZyBSZXNvdXJj ZXMgaW4gdGhlIFdlYiBJbnNwZWN0b3IncyBSZXNvdXJjZXMgcGFuZWwuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzQzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVs LnByb3RvdHlwZS5pc0NhdGVnb3J5VmlzaWJsZSk6IEFkZGVkLgorICAgICAgICAoV2ViSW5zcGVj dG9yLlJlc291cmNlU2lkZWJhclRyZWVFbGVtZW50LnByb3RvdHlwZS5nZXQgc2VsZWN0YWJsZSk6 IENhbGwKKyAgICAgICAgaXNDYXRlZ29yeVZpc2libGUgb24gdGhlIFJlc291cmNlc1BhbmVsLgor CisyMDA5LTEwLTI0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAg ICAgICBGaXggdGhlIFNjb3BlIEJhciBpbiB0aGUgV2ViIEluc3BlY3RvcidzIFJlc291cmNlIHBh bmVsLCBzbyB0aGF0IHNlbGVjdGluZwogICAgICAgICBBbGwgd2lsbCBkZXNlbGVjdCB0aGUgb3Ro ZXIgZmlsdGVycy4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlc1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1Bh bmVsLmpzCmluZGV4IDRhNTU5ZDcuLmNmMTJmMGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKQEAgLTIyOSw3ICsyMjksMTIgQEAgV2ViSW5zcGVj dG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKLSAg ICBfdXBkYXRlRmlsdGVyOiBmdW5jdGlvbiAoZSkKKyAgICBpc0NhdGVnb3J5VmlzaWJsZTogZnVu Y3Rpb24oY2F0ZWdvcnlOYW1lKQorICAgIHsKKyAgICAgICAgcmV0dXJuICh0aGlzLnJlc291cmNl c0dyYXBoc0VsZW1lbnQuaGFzU3R5bGVDbGFzcygiZmlsdGVyLWFsbCIpIHx8IHRoaXMucmVzb3Vy Y2VzR3JhcGhzRWxlbWVudC5oYXNTdHlsZUNsYXNzKCJmaWx0ZXItIiArIGNhdGVnb3J5TmFtZS50 b0xvd2VyQ2FzZSgpKSk7CisgICAgfSwKKworICAgIF91cGRhdGVGaWx0ZXI6IGZ1bmN0aW9uKGUp CiAgICAgewogICAgICAgICB0aGlzLmZpbHRlcihlLnRhcmdldCk7CiAgICAgfSwKQEAgLTEzMzIs NyArMTMzNyw3IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJUcmVlRWxlbWVudC5wcm90 b3R5cGUgPSB7CiAKICAgICBnZXQgc2VsZWN0YWJsZSgpCiAgICAgewotICAgICAgICByZXR1cm4g V2ViSW5zcGVjdG9yLnBhbmVscy5yZXNvdXJjZXMuX2ZpbHRlckNhdGVnb3J5ID09ICJhbGwiIHx8 IFdlYkluc3BlY3Rvci5wYW5lbHMucmVzb3VyY2VzLl9maWx0ZXJDYXRlZ29yeSA9PSB0aGlzLnJl c291cmNlLmNhdGVnb3J5Lm5hbWU7CisgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IucGFuZWxz LnJlc291cmNlcy5pc0NhdGVnb3J5VmlzaWJsZSh0aGlzLnJlc291cmNlLmNhdGVnb3J5Lm5hbWUp OwogICAgIH0sCiAKICAgICBjcmVhdGVJY29uRWxlbWVudDogZnVuY3Rpb24oKQ==