30738 2009-10-23 22:52:53 -0700 "Evaluate selection" feature is broken 2009-10-26 09:17:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys commit-queue pfeldman timothy oldest_to_newest 157429 0 yurys 2009-10-23 22:52:53 -0700 Steps to reproduce: 1. Pause script on a breakpoint. 2. Select some expression in the current function source code. 3. Press Cmd+Shift+'E' on Mac or Ctrl+Shift+'E' on Win. Expected: expression result is printed in the console. Actual: nothing happens. This is a regression introduced in https://bugs.webkit.org/show_bug.cgi?id=29891 WebInspector.SourceFrame.prototype._evalSelectionInCallFrame should pass objectGroup as third parameter when it is calling WebInspector.panels.scripts.evaluateInSelectedCallFrame. 157785 1 41869 yurys 2009-10-26 09:02:53 -0700 Created attachment 41869 patch 157791 2 41869 commit-queue 2009-10-26 09:17:38 -0700 Comment on attachment 41869 patch Clearing flags on attachment: 41869 Committed r50065: <http://trac.webkit.org/changeset/50065> 157792 3 commit-queue 2009-10-26 09:17:41 -0700 All reviewed patches have been landed. Closing bug. 41869 2009-10-26 09:02:53 -0700 2009-10-26 09:17:37 -0700 patch evaluate-selection.patch text/plain 1385 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGVmNTUyZS4uZWRjMjMwZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMC0yNiAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQYXNzICJjb25zb2xlIiBhcyBvYmplY3QgZ3JvdXAgd2hlbiBl dmFsdWF0aW5nIHNlbGVjdGlvbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzA3MzgKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU291 cmNlRnJhbWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBl Ll9ldmFsU2VsZWN0aW9uSW5DYWxsRnJhbWUpOgorCiAyMDA5LTEwLTI2ICBDaHJpcyBGbGVpemFj aCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUu anMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKaW5kZXggNzkw MDU1YS4uOTg2ZWI1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nv dXJjZUZyYW1lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFt ZS5qcwpAQCAtNDI1LDcgKzQyNSw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5 cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgdmFyIGV4cHJlc3Npb24gPSBz ZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKS50b1N0cmluZygpLnRyaW1XaGl0ZXNwYWNlKCk7Ci0gICAg ICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5ldmFsdWF0ZUluU2VsZWN0ZWRDYWxsRnJh bWUoZXhwcmVzc2lvbiwgZmFsc2UsIGZ1bmN0aW9uKHJlc3VsdCwgZXhjZXB0aW9uKSB7CisgICAg ICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5ldmFsdWF0ZUluU2VsZWN0ZWRDYWxsRnJh bWUoZXhwcmVzc2lvbiwgZmFsc2UsICJjb25zb2xlIiwgZnVuY3Rpb24ocmVzdWx0LCBleGNlcHRp b24pIHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5zaG93Q29uc29sZSgpOwogICAgICAgICAg ICAgdmFyIGNvbW1hbmRNZXNzYWdlID0gbmV3IFdlYkluc3BlY3Rvci5Db25zb2xlQ29tbWFuZChl eHByZXNzaW9uKTsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5jb25zb2xlLmFkZE1lc3NhZ2Uo Y29tbWFuZE1lc3NhZ2UpOwo=