30736 2009-10-23 20:18:38 -0700 Web Inspector: remove double click to re-root the tree 2009-10-24 16:03:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 timothy timothy aroben bweinstein commit-queue joepeck pfeldman rik timothy oldest_to_newest 157414 0 timothy 2009-10-23 20:18:38 -0700 We should remove double click to re-root the tree. THis has bitten me while trying to edit attributes and text nodes. If you miss, you will re-root the tree and it is surprising to new users and annoying to fix. We should remove it completly or religate it to the bread crumbs, so double click on them will re-root. 157425 1 pfeldman 2009-10-23 22:14:11 -0700 +1 on removing them. not sure we need it in crumbs. 157426 2 bweinstein 2009-10-23 22:15:30 -0700 Agreed on removing it. Do developers use it a lot? Is this something we should post on webkit-dev? 157431 3 timothy 2009-10-23 23:21:28 -0700 Let remove it and see if anyone notices it. 157434 4 joepeck 2009-10-23 23:53:55 -0700 +1 to removing. I have never intentionally used the feature and get surprised every time it happens =). I just haven't found a use case for it that isn't handled by the full tree and expanding. Really deep nesting? Not a problem when docked and I would just resize if undocked. 157451 5 41782 timothy 2009-10-24 09:51:23 -0700 Created attachment 41782 Proposed Patch 157508 6 41782 commit-queue 2009-10-24 16:02:55 -0700 Comment on attachment 41782 Proposed Patch Clearing flags on attachment: 41782 Committed r50031: <http://trac.webkit.org/changeset/50031> 157509 7 commit-queue 2009-10-24 16:03:01 -0700 All reviewed patches have been landed. Closing bug. 41782 2009-10-24 09:51:23 -0700 2009-10-24 16:02:55 -0700 Proposed Patch bug-30736-20091024095122.patch text/plain 1390 timothy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDI2ZGY5Ny4uOGY3MzU5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0yNCAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRoZSByZS1yb290IHRy ZWUgZmVhdHVyZSBmcm9tIHRoZSBXZWIgSW5zcGVjdG9yJ3MKKyAgICAgICAgRWxlbWVudHMgcGFu ZWwuIFRoaXMgZmVhdHVyZSB3YXNuJ3Qgc3VwZXIgdXNlZnVsIGFuZCBnZXRzCisgICAgICAgIGlu IHRoZSB3YXkgb2YgZG91YmxlLWNsaWNrIHRvIGVkaXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz VHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVu dC5wcm90b3R5cGUub25kYmxjbGljayk6CisKIDIwMDktMTAtMjMgIEJyaWFuIFdlaW5zdGVpbiAg PGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0 Y2hlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1Ry ZWVPdXRsaW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91 dGxpbmUuanMKaW5kZXggMjBjODUyOS4uZmE5ZDM2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTUyOCwxMSArNTI4LDYg QEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAg ICBpZiAodGhpcy5fc3RhcnRFZGl0aW5nRnJvbUV2ZW50KGV2ZW50LCB0cmVlRWxlbWVudCkpCiAg ICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKHRoaXMudHJlZU91dGxpbmUucGFuZWwp IHsKLSAgICAgICAgICAgIHRoaXMudHJlZU91dGxpbmUucm9vdERPTU5vZGUgPSB0aGlzLnJlcHJl c2VudGVkT2JqZWN0LnBhcmVudE5vZGU7Ci0gICAgICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLmZv Y3VzZWRET01Ob2RlID0gdGhpcy5yZXByZXNlbnRlZE9iamVjdDsKLSAgICAgICAgfQotCiAgICAg ICAgIGlmICh0aGlzLmhhc0NoaWxkcmVuICYmICF0aGlzLmV4cGFuZGVkKQogICAgICAgICAgICAg dGhpcy5leHBhbmQoKTsKICAgICB9LA==