30735 2009-10-23 20:13:43 -0700 Web Inspector: hovering in the DOM tree it is very hard to double-click to edit 2009-10-24 20:01:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 timothy timothy aroben bweinstein joepeck pfeldman rik timothy oldest_to_newest 157413 0 timothy 2009-10-23 20:13:43 -0700 When hovering in the DOM tree it is very hard to double-click to edit now. The other day I was editing the Inspector with the Inspector to quickly test things for the Timeline mock-up. And I was very frustrated when I went to double-click on an attribute or text node that it would shift under my and I might miss it. I think we need to rethink the hover to add a new attribute changes. I feel this was better when it didn't shift so much, but since it changed to: ?="" it is more likely going to shift and rewrap. Options I see are: - Some control show up on hover that does not affect layout. THe control could have other things like "New Child", etc in there. - Move the controls to the right end of the row, or the left before the node. (There is also a bug when the hover causes the text to wrap to a new line. THer selection highlight does not grow, so you don't see the white text on the new line. updateSelection() needs called.) 157424 1 pfeldman 2009-10-23 22:13:13 -0700 (In reply to comment #0) > When hovering in the DOM tree it is very hard to double-click to edit now. The > other day I was editing the Inspector with the Inspector to quickly test things > for the Timeline mock-up. And I was very frustrated when I went to double-click > on an attribute or text node that it would shift under my and I might miss it. > > I think we need to rethink the hover to add a new attribute changes. I feel > this was better when it didn't shift so much, but since it changed to: ?="" it > is more likely going to shift and rewrap. > Actually, now that it has a timeout you have at least some chance of hitting what you want. > Options I see are: > > - Some control show up on hover that does not affect layout. THe control could > have other things like "New Child", etc in there. > - Move the controls to the right end of the row, or the left before the node. > > (There is also a bug when the hover causes the text to wrap to a new line. THer > selection highlight does not grow, so you don't see the white text on the new > line. updateSelection() needs called.) I don't think this operation should pop up on hover at all - it is not that important. I was thinking about a small "New" popup menu when user clicks "+" or "Insert" or win? Cmd+N would be too much I guess. 157430 2 timothy 2009-10-23 23:20:58 -0700 I think the timeout makes it tricky. Since It is fine for a bit, then by the time I double-click it changes. Not having it on hover would be fine too, if we find a discoverable way to do it. 157452 3 41783 timothy 2009-10-24 10:08:37 -0700 Created attachment 41783 Proposed Patch 157529 4 timothy 2009-10-24 20:01:13 -0700 Committed r50032: <http://trac.webkit.org/changeset/50032> 41783 2009-10-24 10:08:37 -0700 2009-10-24 15:52:18 -0700 Proposed Patch bug-30735-20091024100836.patch text/plain 2662 timothy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGY3MzU5MS4uYTY3OGE4YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAwOS0xMC0yNCAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKKyAgICAgICAgQ2FsbCB1cGRhdGVTZWxlY3Rpb24o KSBpbiBhIGZldyBwbGFjZXMgc28gaG92ZXJpbmcgaW4gdGhlIFdlYiBJbnNwZWN0b3IncworICAg ICAgICBFbGVtZW50cyBwYW5lbCBhbHdheXMgaGFzIHRoZSBjb3JyZWN0IHJvdyBzZWxlY3Rpb24g aGVpZ2h0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMDczNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLnRvZ2dsZU5ld0F0dHJp YnV0ZUJ1dHRvbik6IENhbGwgdXBkYXRlU2VsZWN0aW9uKCkuCisgICAgICAgIChXZWJJbnNwZWN0 b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUuX2luc2VydEluTGFzdEF0dHJpYnV0ZVBv c2l0aW9uKTogRGl0dG8uCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3Iu Y3NzOiBQcmV2ZW50IHRleHQgd3JhcHBpbmcgaW4gdGhlIG1pZGRsZSBvZiB0aGUgYWRkIGF0dHJp YnV0ZSB0ZXh0LgorCisyMDA5LTEwLTI0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KKwogICAgICAgICBSZW1vdmUgdGhlIHJlLXJvb3QgdHJlZSBmZWF0dXJlIGZyb20gdGhl IFdlYiBJbnNwZWN0b3IncwogICAgICAgICBFbGVtZW50cyBwYW5lbC4gVGhpcyBmZWF0dXJlIHdh c24ndCBzdXBlciB1c2VmdWwgYW5kIGdldHMKICAgICAgICAgaW4gdGhlIHdheSBvZiBkb3VibGUt Y2xpY2sgdG8gZWRpdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1l bnRzVHJlZU91dGxpbmUuanMKaW5kZXggZmE5ZDM2OS4uYjA5MDQ5MiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTMyOCw2 ICszMjgsOCBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7 CiAgICAgICAgICAgICBpZiAodGhpcy5fYWRkQXR0cmlidXRlRWxlbWVudCAmJiB0aGlzLl9hZGRB dHRyaWJ1dGVFbGVtZW50LnBhcmVudE5vZGUpCiAgICAgICAgICAgICAgICAgdGhpcy5fYWRkQXR0 cmlidXRlRWxlbWVudC5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKHRoaXMuX2FkZEF0dHJpYnV0ZUVs ZW1lbnQpOwogICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2FkZEF0dHJpYnV0ZUVsZW1lbnQ7CisK KyAgICAgICAgICAgIHRoaXMudXBkYXRlU2VsZWN0aW9uKCk7CiAgICAgICAgIH0KIAogICAgICAg ICBpZiAoIXRoaXMuX2FkZEF0dHJpYnV0ZUVsZW1lbnQgJiYgdmlzaWJsZSAmJiAhdGhpcy5fZWRp dGluZykgewpAQCAtMzQyLDcgKzM0NCw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVt ZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgfSBlbHNlIGlmICghdmlzaWJsZSAmJiB0aGlzLl9h ZGRBdHRyaWJ1dGVFbGVtZW50KQogICAgICAgICAgICAgcmVtb3ZlQWRkQXR0cmlidXRlU3Bhbi5j YWxsKHRoaXMpOwogICAgIH0sCi0gICAgCisKICAgICB1cGRhdGVTZWxlY3Rpb246IGZ1bmN0aW9u KCkKICAgICB7CiAgICAgICAgIHZhciBsaXN0SXRlbUVsZW1lbnQgPSB0aGlzLmxpc3RJdGVtRWxl bWVudDsKQEAgLTU0Myw2ICs1NDUsOCBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVu dC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0YWcuYXBwZW5kQ2hpbGQobm9kZSk7CiAgICAg ICAgICAgICB0YWcuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJz4nKSk7CiAg ICAgICAgIH0KKworICAgICAgICB0aGlzLnVwZGF0ZVNlbGVjdGlvbigpOwogICAgIH0sCiAKICAg ICBfc3RhcnRFZGl0aW5nRnJvbUV2ZW50OiBmdW5jdGlvbihldmVudCwgdHJlZUVsZW1lbnQpCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzCmluZGV4IDEzMDg3NTkuLjky MzU2NGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3Iu Y3NzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzCkBAIC0x MTYzLDYgKzExNjMsNyBAQCBib2R5LmRyYXdlci12aXNpYmxlICNkcmF3ZXIgewogLmFkZC1hdHRy aWJ1dGUgewogICAgIG1hcmdpbi1sZWZ0OiAxcHg7CiAgICAgbWFyZ2luLXJpZ2h0OiAxcHg7Cisg ICAgd2hpdGUtc3BhY2U6IG5vd3JhcDsKIH0KIAogLnBsYWNhcmQgew==