<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>307347</bug_id>
          
          <creation_ts>2026-02-09 09:43:09 -0800</creation_ts>
          <short_desc>[check-webkit-style] Fix false positive in safercpp/protected_getter_for_init checker</short_desc>
          <delta_ts>2026-02-09 16:43:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>306787</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2179479</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-02-09 09:43:09 -0800</bug_when>
    <thetext>The `check-webkit-style` script produces false positives for code like:

```cpp
if (RefPtr document = viewportDocumentForFrame(protect(mainFrame())))
```

Error message:
```
error: [safercpp/protected_getter_for_init] Do not use protect() for variable initialization.
```

This is a false positive because `protect(mainFrame())` is an argument to `viewportDocumentForFrame()`, not the direct initializer for `document`.

The checker should only warn when `protect()`, `protectedFoo()`, or `checkedFoo()` functions are used as the direct initializer, not when they are nested inside other function calls.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2179480</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-02-09 09:43:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/169975626&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2179521</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-02-09 11:15:53 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/58222</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2179669</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-02-09 16:42:43 -0800</bug_when>
    <thetext>Committed 307125@main (d93063803637): &lt;https://commits.webkit.org/307125@main&gt;

Reviewed commits have been landed. Closing PR #58222 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>