30731 2009-10-23 15:58:31 -0700 Web Inspector: Clash Between Search's onkeyup and incremental search events 2009-10-23 17:27:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck aroben bweinstein joepeck pfeldman rik timothy oldest_to_newest 157356 0 joepeck 2009-10-23 15:58:31 -0700 When quickly forcing a search on a short query with "Enter" (<3 characters) the Inspector's search field fires both its onkeyup and incremental search events, causing conflicts. The "search" does see the forced search and clobbers the earlier fired forced search. Example Video. The first search causes a conflict due to "quickly" searching, the second goes through fine because no incremental search event fired due to the text not changing: http://screencast.com/t/uHozOKDiy7D8 157357 1 41759 joepeck 2009-10-23 16:03:44 -0700 Created attachment 41759 [PATCH] Search Fix 157364 2 joepeck 2009-10-23 16:22:51 -0700 Hmm, the first patch does not handle the following scenario: 1. User quickly searches a 1 character search. No Clobber happens (but the flag is deleted). 2. User types a 2nd character. Clobbering happens. I guess we should prevent clobbering for any <3 character search if it was forced (meaning keep the flag around). This complicates things slightly: Users searches "a", Enter, "b", "c", Backspace --> "a" does nothing --> Enter forces search [search "a" happening] --> "b" does nothing [search "a" happening] --> "c" spawns incremental search [search "abc" happening] --> Backspace brings us back into <3 character range, what do we do here? Current behavior is that backspacing until the query is below 3 characters clears the search. I think we should keep that behavior. But I do feel that if you forced a search with 1 character then it should be kept (not cleared) at 2 characters. If this is not desired we can use the first patch. 157372 3 joepeck 2009-10-23 16:49:02 -0700 Bah. Ignore Comment #2. When a search happens the search text is selected, making my user scenario a highly unlikely scenario. Instead, I implemented the following behavior: Whenever you make a search, be it short or not... it goes back to normal for the next search. http://screencast.com/t/IKbwdQWjJ 157373 4 41764 joepeck 2009-10-23 16:50:51 -0700 Created attachment 41764 [PATCH] Behavior in Comment #3 157375 5 joepeck 2009-10-23 17:00:23 -0700 Ugh. The "this.currentQuery !== query", is not necessary and I will remove it before I land if this gets r+. 157388 6 joepeck 2009-10-23 17:27:32 -0700 The currentQuery comparison was needed for certain cases and was okay to leave in. Landed in http://trac.webkit.org/changeset/50014 r50014 = 7dabc822eac2979ea589a340500102e389e55e4a 41759 2009-10-23 16:03:44 -0700 2009-10-23 16:50:51 -0700 [PATCH] Search Fix search_fix.txt text/plain 1731 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmVkNGUwZi4uYThlNzdmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0yMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsYXNoIEJldHdlZW4gU2VhcmNoJ3Mg b25rZXl1cCBhbmQgaW5jcmVtZW50YWwgc2VhcmNoIGV2ZW50cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3MzEKKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLnBlcmZvcm1T ZWFyY2gpOiBwcmV2ZW50IGluY3JlbWVudGFsIHNlYXJjaCBldmVudCBmcm9tIGNsb2JiZXJpbmcg YSBmb3JjZWQgc2VhcmNoCisKIDIwMDktMTAtMjMgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0 dG9yaUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKaW5kZXggYTU2YmU5Mi4uMjFi N2ZjZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0xNDYz LDggKzE0NjMsMjMgQEAgV2ViSW5zcGVjdG9yLnBlcmZvcm1TZWFyY2ggPSBmdW5jdGlvbihldmVu dCkKIHsKICAgICB2YXIgcXVlcnkgPSBldmVudC50YXJnZXQudmFsdWU7CiAgICAgdmFyIGZvcmNl U2VhcmNoID0gZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIkVudGVyIjsKKyAgICB2YXIgaXNTaG9y dFNlYXJjaCA9IChxdWVyeS5sZW5ndGggPCAzKTsKKworICAgIC8vIE9ubHkgYSBLZXlib2FyZEV2 ZW50IGNhbiBzZXQgdGhpcyBmbGFnLgorICAgIGlmIChmb3JjZVNlYXJjaCkgeworICAgICAgICBp ZiAoaXNTaG9ydFNlYXJjaCkKKyAgICAgICAgICAgIHRoaXMuc2hvcnRTZWFyY2hXYXNGb3JjZWRC eUtleUV2ZW50ID0gdHJ1ZTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgZGVsZXRlIHRoaXMu c2hvcnRTZWFyY2hXYXNGb3JjZWRCeUtleUV2ZW50OworICAgIH0KKworICAgIGlmICghcXVlcnkg fHwgIXF1ZXJ5Lmxlbmd0aCB8fCAoIWZvcmNlU2VhcmNoICYmIGlzU2hvcnRTZWFyY2gpKSB7Cisg ICAgICAgIC8vIFByZXZlbnQgY2xvYmJlcmluZyBhIHNob3J0IHNlYXJjaCBmb3JjZWQgYnkgdGhl IHVzZXIKKyAgICAgICAgaWYgKHRoaXMuc2hvcnRTZWFyY2hXYXNGb3JjZWRCeUtleUV2ZW50KSB7 CisgICAgICAgICAgICBkZWxldGUgdGhpcy5zaG9ydFNlYXJjaFdhc0ZvcmNlZEJ5S2V5RXZlbnQ7 CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAotICAgIGlmICghcXVlcnkgfHwgIXF1 ZXJ5Lmxlbmd0aCB8fCAoIWZvcmNlU2VhcmNoICYmIHF1ZXJ5Lmxlbmd0aCA8IDMpKSB7CiAgICAg ICAgIGRlbGV0ZSB0aGlzLmN1cnJlbnRRdWVyeTsKIAogICAgICAgICBmb3IgKHZhciBwYW5lbE5h bWUgaW4gdGhpcy5wYW5lbHMpIHsK 41764 2009-10-23 16:50:51 -0700 2009-10-23 17:05:57 -0700 [PATCH] Behavior in Comment #3 better.patch text/plain 1880 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmVkNGUwZi4uYThlNzdmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0yMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsYXNoIEJldHdlZW4gU2VhcmNoJ3Mg b25rZXl1cCBhbmQgaW5jcmVtZW50YWwgc2VhcmNoIGV2ZW50cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3MzEKKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLnBlcmZvcm1T ZWFyY2gpOiBwcmV2ZW50IGluY3JlbWVudGFsIHNlYXJjaCBldmVudCBmcm9tIGNsb2JiZXJpbmcg YSBmb3JjZWQgc2VhcmNoCisKIDIwMDktMTAtMjMgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0 dG9yaUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKaW5kZXggYTU2YmU5Mi4uOThm ODg2MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0xNDYz LDggKzE0NjMsMjMgQEAgV2ViSW5zcGVjdG9yLnBlcmZvcm1TZWFyY2ggPSBmdW5jdGlvbihldmVu dCkKIHsKICAgICB2YXIgcXVlcnkgPSBldmVudC50YXJnZXQudmFsdWU7CiAgICAgdmFyIGZvcmNl U2VhcmNoID0gZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIkVudGVyIjsKKyAgICB2YXIgaXNTaG9y dFNlYXJjaCA9IChxdWVyeS5sZW5ndGggPCAzKTsKKworICAgIC8vIENsZWFyIGEgbGVmdG92ZXIg c2hvcnQgc2VhcmNoIGZsYWcgZHVlIHRvIGEgbm9uLWNvbmZsaWN0aW5nIGZvcmNlZCBzZWFyY2gu CisgICAgaWYgKGlzU2hvcnRTZWFyY2ggJiYgdGhpcy5zaG9ydFNlYXJjaFdhc0ZvcmNlZEJ5S2V5 RXZlbnQgJiYgdGhpcy5jdXJyZW50UXVlcnkgIT09IHF1ZXJ5KQorICAgICAgICBkZWxldGUgdGhp cy5zaG9ydFNlYXJjaFdhc0ZvcmNlZEJ5S2V5RXZlbnQKKworICAgIC8vIEluZGljYXRlIHRoaXMg d2FzIGEgZm9yY2VkIHNlYXJjaCBvbiBhIHNob3J0IHF1ZXJ5LgorICAgIGlmIChpc1Nob3J0U2Vh cmNoICYmIGZvcmNlU2VhcmNoKQorICAgICAgICB0aGlzLnNob3J0U2VhcmNoV2FzRm9yY2VkQnlL ZXlFdmVudCA9IHRydWU7CisKKyAgICBpZiAoIXF1ZXJ5IHx8ICFxdWVyeS5sZW5ndGggfHwgKCFm b3JjZVNlYXJjaCAmJiBpc1Nob3J0U2VhcmNoKSkgeworICAgICAgICAvLyBQcmV2ZW50IGNsb2Ji ZXJpbmcgYSBzaG9ydCBzZWFyY2ggZm9yY2VkIGJ5IHRoZSB1c2VyLgorICAgICAgICBpZiAodGhp cy5zaG9ydFNlYXJjaFdhc0ZvcmNlZEJ5S2V5RXZlbnQpIHsKKyAgICAgICAgICAgIGRlbGV0ZSB0 aGlzLnNob3J0U2VhcmNoV2FzRm9yY2VkQnlLZXlFdmVudDsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQogCi0gICAgaWYgKCFxdWVyeSB8fCAhcXVlcnkubGVuZ3RoIHx8ICghZm9yY2VT ZWFyY2ggJiYgcXVlcnkubGVuZ3RoIDwgMykpIHsKICAgICAgICAgZGVsZXRlIHRoaXMuY3VycmVu dFF1ZXJ5OwogCiAgICAgICAgIGZvciAodmFyIHBhbmVsTmFtZSBpbiB0aGlzLnBhbmVscykgewo=