30714 2009-10-23 08:20:09 -0700 [Qt] Windowed Plugins : Print preview shows only part of flash when view is scrolled 2009-10-26 19:50:21 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 0 girish webkit-unassigned commit-queue koivisto oldest_to_newest 157163 0 girish 2009-10-23 08:20:09 -0700 Print preview shows only part of flash when view is scrolled 157164 1 41726 girish 2009-10-23 08:23:04 -0700 Created attachment 41726 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled 157408 2 41774 girish 2009-10-23 19:54:48 -0700 Created attachment 41774 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled When printing, QPrinter's preview mode uses a QPicture to capture the output. The QPicture holds a reference to the X Pixmap. As a result, the print preview would update itself when the X Pixmap changes. To prevent the print preview from updating whenever m_drawable is updated (i.e when the view updates), we create a copy. We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap regardless of the graphicssystem. This is taken care of by commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6) The beauty of this patch is that the newly created X Pixmap is managed by Qt and it will free the Pixmap whenever the user closes the print preview dialog and handles the case of displaying multiple preview dialogs nicely. All credit to Samuel Rødal for suggesting usage of QPixmap::copy(). https://bugs.webkit.org/show_bug.cgi?id=30714 --- WebCore/plugins/qt/PluginViewQt.cpp | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) 157409 3 41775 girish 2009-10-23 19:55:46 -0700 Created attachment 41775 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled When printing, QPrinter's preview mode uses a QPicture to capture the output. The QPicture holds a reference to the X Pixmap. As a result, the print preview would update itself when the X Pixmap changes. To prevent the print preview from updating whenever m_drawable is updated (i.e when the view updates), we create a copy. We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap regardless of the graphicssystem. This is taken care of by commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6) The beauty of this patch is that the newly created X Pixmap is managed by Qt and it will free the Pixmap whenever the user closes the print preview dialog and handles the case of displaying multiple preview dialogs nicely. All credit to Samuel Rødal for suggesting usage of QPixmap::copy(). https://bugs.webkit.org/show_bug.cgi?id=30714 --- WebCore/ChangeLog | 26 ++++++++++++++++++++++++++ WebCore/plugins/qt/PluginViewQt.cpp | 8 +++++++- 2 files changed, 33 insertions(+), 1 deletions(-) 157410 4 41775 girish 2009-10-23 19:57:23 -0700 Comment on attachment 41775 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled Sorry, I keep forgetting the ChangeLog. 157416 5 41775 zecke 2009-10-23 20:50:44 -0700 Comment on attachment 41775 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled > + // When printing, Qt uses a QPicture the capture the output in preview mode. The Replace the 2nd the to "to"? looks great besides that. 157418 6 girish 2009-10-23 20:55:58 -0700 (In reply to comment #5) > (From update of attachment 41775 [details]) > > > + // When printing, Qt uses a QPicture the capture the output in preview mode. The > > Replace the 2nd the to "to"? looks great besides that. The third patch I uploaded sometime back fixes that. 157981 7 koivisto 2009-10-26 15:50:18 -0700 r=me 157988 8 41775 commit-queue 2009-10-26 16:04:32 -0700 Comment on attachment 41775 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled Rejecting patch 41775 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11520 test cases. svg/css/getComputedStyle-basic.xhtml -> failed Exiting early after 1 failures. 9845 tests run. 322.18s total testing time 9844 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output 158011 9 41775 eric 2009-10-26 16:24:23 -0700 Comment on attachment 41775 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled The bots are just way behind. bug 30098 158067 10 41775 commit-queue 2009-10-26 19:50:15 -0700 Comment on attachment 41775 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled Clearing flags on attachment: 41775 Committed r50123: <http://trac.webkit.org/changeset/50123> 158068 11 commit-queue 2009-10-26 19:50:21 -0700 All reviewed patches have been landed. Closing bug. 41726 2009-10-23 08:23:04 -0700 2009-10-23 19:56:32 -0700 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled foo text/plain 2657 girish Y29tbWl0IDdmY2QzZTk5ZGEwNjJiYjE4NWViNjM2MWZhYmRlM2U1MDNhYzYyZmIKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgRnJpIE9j dCAyMyAxOTowODo1NyAyMDA5ICswNTMwCgogICAgW1F0XSBXaW5kb3dsZXNzIFBsdWdpbnMgOiBQ cmludCBwcmV2aWV3IHNob3dzIG9ubHkgcGFydCBvZiBmbGFzaCB3aGVuIHZpZXcgaXMgc2Nyb2xs ZWQKICAgIAogICAgV2hlbiBwcmludGluZywgUVByaW50ZXIncyBwcmV2aWV3IG1vZGUgdXNlcyBh IFFQaWN0dXJlIHRoZSBjYXB0dXJlIHRoZSBvdXRwdXQuIFRoZQogICAgUVBpY3R1cmUgaG9sZHMg YSByZWZlcmVuY2UgdG8gdGhlIFggUGl4bWFwLiBBcyBhIHJlc3VsdCwgdGhlIHByaW50IHByZXZp ZXcgd291bGQKICAgIHVwZGF0ZSBpdHNlbGYgd2hlbiB0aGUgWCBQaXhtYXAgY2hhbmdlcy4gVG8g cHJldmVudCB0aGUgcHJpbnQgcHJldmlldyBmcm9tIHVwZGF0aW5nCiAgICB3aGVuZXZlciBtX2Ry YXdhYmxlIGlzIHVwZGF0ZWQgKGkuZSB3aGVuIHRoZSB2aWV3IHVwZGF0ZXMpLCB3ZSBjcmVhdGUg YSBjb3B5LgogICAgCiAgICBXZSByZXF1aXJlIHRoYXQgYSBRUGl4bWFwOjpjb3B5KCkgcmVzdWx0 cyBpbiBhIFFQaXhtYXAgYmFja2VkIGJ5IGEgWFBpeG1hcAogICAgcmVnYXJkbGVzcyBvZiB0aGUg Z3JhcGhpY3NzeXN0ZW0uIFRoaXMgaXMgdGFrZW4gY2FyZSBvZiBieQogICAgY29tbWl0IGQzMTBm N2M3MTBlY2IzMzFhOTY4OTg2MWYwNTUxZWFiZDM4ZTk0NmUgaW4gUXQgKDQuNikKICAgIAogICAg VGhlIGJlYXV0eSBvZiB0aGlzIHBhdGNoIGlzIHRoYXQgdGhlIG5ld2x5IGNyZWF0ZWQgWCBQaXht YXAgaXMgbWFuYWdlZCBieSBRdCBhbmQKICAgIGl0IHdpbGwgZnJlZSB0aGUgUGl4bWFwIHdoZW5l dmVyIHRoZSB1c2VyIGNsb3NlcyB0aGUgcHJpbnQgcHJldmlldyBkaWFsb2cgYW5kCiAgICBoYW5k bGVzIHRoZSBjYXNlIG9mIGRpc3BsYXlpbmcgbXVsdGlwbGUgcHJldmlldyBkaWFsb2dzIG5pY2Vs eS4KICAgIAogICAgQWxsIGNyZWRpdCB0byBTYW11ZWwgUsO4ZGFsIGZvciBzdWdnZXN0aW5nIHVz YWdlIG9mIFFQaXhtYXA6OmNvcHkoKS4KICAgIAogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMwNzE0CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3F0L1Bs dWdpblZpZXdRdC5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRl eCBmNjdjNmJhLi5kZjRhZDMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2lu Vmlld1F0LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcApAQCAt MTg2LDYgKzE4NiwxMiBAQCB2b2lkIFBsdWdpblZpZXc6OnBhaW50KEdyYXBoaWNzQ29udGV4dCog Y29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBjb25zdCBpbnQgZHJhd2FibGVEZXB0 aCA9ICgoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCopbV9ucFdpbmRvdy53c19pbmZvKS0+ZGVw dGg7CiAgICAgQVNTRVJUKGRyYXdhYmxlRGVwdGggPT0gcXREcmF3YWJsZS5kZXB0aCgpKTsKIAor ICAgIC8vIFdoZW4gcHJpbnRpbmcsIFF0IHVzZXMgYSBRUGljdHVyZSB0aGUgY2FwdHVyZSB0aGUg b3V0cHV0IGluIHByZXZpZXcgbW9kZS4gVGhlCisgICAgLy8gUVBpY3R1cmUgaG9sZHMgYSByZWZl cmVuY2UgdG8gdGhlIFggUGl4bWFwLiBBcyBhIHJlc3VsdCwgdGhlIHByaW50IHByZXZpZXcgd291 bGQKKyAgICAvLyB1cGRhdGUgaXRzZWxmIHdoZW4gdGhlIFggUGl4bWFwIGNoYW5nZXMuIFRvIHBy ZXZlbnQgdGhpcywgd2UgY3JlYXRlIGEgY29weS4KKyAgICBpZiAobV9lbGVtZW50LT5kb2N1bWVu dCgpLT5wcmludGluZygpKQorICAgICAgICBxdERyYXdhYmxlID0gcXREcmF3YWJsZS5jb3B5KCk7 CisKICAgICBpZiAobV9pc1RyYW5zcGFyZW50ICYmIGRyYXdhYmxlRGVwdGggIT0gMzIpIHsKICAg ICAgICAgLy8gQXR0ZW1wdCBjb250ZW50IHByb3BhZ2F0aW9uIGZvciBkcmF3YWJsZSB3aXRoIG5v IGFscGhhIGJ5IGNvcHlpbmcgb3ZlciBmcm9tIHRoZSBiYWNraW5nIHN0b3JlCiAgICAgICAgIFFQ b2ludCBvZmZzZXQ7CkBAIC0yMjEsNyArMjI3LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpwYWludChH cmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEludFJlY3QmIHJlY3QpCiAgICAgWEdyYXBo aWNzRXhwb3NlRXZlbnQmIGV4cG9zZUV2ZW50ID0geGV2ZW50LnhncmFwaGljc2V4cG9zZTsKICAg ICBleHBvc2VFdmVudC50eXBlID0gR3JhcGhpY3NFeHBvc2U7CiAgICAgZXhwb3NlRXZlbnQuZGlz cGxheSA9IFFYMTFJbmZvOjpkaXNwbGF5KCk7Ci0gICAgZXhwb3NlRXZlbnQuZHJhd2FibGUgPSBt X2RyYXdhYmxlOworICAgIGV4cG9zZUV2ZW50LmRyYXdhYmxlID0gcXREcmF3YWJsZS5oYW5kbGUo KTsKICAgICBleHBvc2VFdmVudC54ID0gZXhwb3NlZFJlY3QueCgpOwogICAgIGV4cG9zZUV2ZW50 LnkgPSBleHBvc2VkUmVjdC55KCk7CiAgICAgZXhwb3NlRXZlbnQud2lkdGggPSBleHBvc2VkUmVj dC54KCkgKyBleHBvc2VkUmVjdC53aWR0aCgpOyAvLyBmbGFzaCBidWc/IGl0IHRoaW5rcyB3aWR0 aCBpcyB0aGUgcmlnaHQgaW4gdHJhbnNwYXJlbnQgbW9kZQo= 41774 2009-10-23 19:54:48 -0700 2009-10-23 19:56:46 -0700 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled -Qt-Windowless-Plugins-Print-preview-shows-only-part-of-flash-when-view-is-scrolled.patch text/plain 1535 girish NTYyODgwM2NjNDMzZWNhODBkMzliNmFmOTljYzMwN2RhZTc5YTQwNwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcAppbmRleCA5ZDAyNWE4Li5hODI3MGRkIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcApAQCAtMTg2LDYgKzE4NiwxMiBAQCB2b2lkIFBsdWdpblZpZXc6OnBhaW50 KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBjb25z dCBpbnQgZHJhd2FibGVEZXB0aCA9ICgoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCopbV9ucFdp bmRvdy53c19pbmZvKS0+ZGVwdGg7CiAgICAgQVNTRVJUKGRyYXdhYmxlRGVwdGggPT0gcXREcmF3 YWJsZS5kZXB0aCgpKTsKIAorICAgIC8vIFdoZW4gcHJpbnRpbmcsIFF0IHVzZXMgYSBRUGljdHVy ZSB0aGUgY2FwdHVyZSB0aGUgb3V0cHV0IGluIHByZXZpZXcgbW9kZS4gVGhlCisgICAgLy8gUVBp Y3R1cmUgaG9sZHMgYSByZWZlcmVuY2UgdG8gdGhlIFggUGl4bWFwLiBBcyBhIHJlc3VsdCwgdGhl IHByaW50IHByZXZpZXcgd291bGQKKyAgICAvLyB1cGRhdGUgaXRzZWxmIHdoZW4gdGhlIFggUGl4 bWFwIGNoYW5nZXMuIFRvIHByZXZlbnQgdGhpcywgd2UgY3JlYXRlIGEgY29weS4KKyAgICBpZiAo bV9lbGVtZW50LT5kb2N1bWVudCgpLT5wcmludGluZygpKQorICAgICAgICBxdERyYXdhYmxlID0g cXREcmF3YWJsZS5jb3B5KCk7CisKICAgICBpZiAobV9pc1RyYW5zcGFyZW50ICYmIGRyYXdhYmxl RGVwdGggIT0gMzIpIHsKICAgICAgICAgLy8gQXR0ZW1wdCBjb250ZW50IHByb3BhZ2F0aW9uIGZv ciBkcmF3YWJsZSB3aXRoIG5vIGFscGhhIGJ5IGNvcHlpbmcgb3ZlciBmcm9tIHRoZSBiYWNraW5n IHN0b3JlCiAgICAgICAgIFFQb2ludCBvZmZzZXQ7CkBAIC0yMjEsNyArMjI3LDcgQEAgdm9pZCBQ bHVnaW5WaWV3OjpwYWludChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEludFJlY3Qm IHJlY3QpCiAgICAgWEdyYXBoaWNzRXhwb3NlRXZlbnQmIGV4cG9zZUV2ZW50ID0geGV2ZW50Lnhn cmFwaGljc2V4cG9zZTsKICAgICBleHBvc2VFdmVudC50eXBlID0gR3JhcGhpY3NFeHBvc2U7CiAg ICAgZXhwb3NlRXZlbnQuZGlzcGxheSA9IFFYMTFJbmZvOjpkaXNwbGF5KCk7Ci0gICAgZXhwb3Nl RXZlbnQuZHJhd2FibGUgPSBtX2RyYXdhYmxlOworICAgIGV4cG9zZUV2ZW50LmRyYXdhYmxlID0g cXREcmF3YWJsZS5oYW5kbGUoKTsKICAgICBleHBvc2VFdmVudC54ID0gZXhwb3NlZFJlY3QueCgp OwogICAgIGV4cG9zZUV2ZW50LnkgPSBleHBvc2VkUmVjdC55KCk7CiAgICAgZXhwb3NlRXZlbnQu d2lkdGggPSBleHBvc2VkUmVjdC54KCkgKyBleHBvc2VkUmVjdC53aWR0aCgpOyAvLyBmbGFzaCBi dWc/IGl0IHRoaW5rcyB3aWR0aCBpcyB0aGUgcmlnaHQgaW4gdHJhbnNwYXJlbnQgbW9kZQo= 41775 2009-10-23 19:55:46 -0700 2009-10-26 19:50:15 -0700 [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled -Qt-Windowless-Plugins-Print-preview-shows-only-part-of-flash-when-view-is-scrolled.patch text/plain 3056 girish OGE0NGZmOTQ5YzIzMDQxNGZlMTc4OTE3OTY5MGJjNzNiNjBiMGEzNgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxNmIyYWYzLi5jYjkxMjQ5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDI5IEBACisyMDA5LTEwLTIzICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNo QGZvcndhcmRiaWFzLmluPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gV2luZG93bGVzcyBQbHVnaW5zIDogUHJpbnQgcHJldmlldyBzaG93cyBv bmx5IHBhcnQgb2YgZmxhc2ggd2hlbiB2aWV3IGlzIHNjcm9sbGVkCisgICAgICAgIAorICAgICAg ICBXaGVuIHByaW50aW5nLCBRUHJpbnRlcidzIHByZXZpZXcgbW9kZSB1c2VzIGEgUVBpY3R1cmUg dG8gY2FwdHVyZSB0aGUgb3V0cHV0LiBUaGUKKyAgICAgICAgUVBpY3R1cmUgaG9sZHMgYSByZWZl cmVuY2UgdG8gdGhlIFggUGl4bWFwLiBBcyBhIHJlc3VsdCwgdGhlIHByaW50IHByZXZpZXcgd291 bGQKKyAgICAgICAgdXBkYXRlIGl0c2VsZiB3aGVuIHRoZSBYIFBpeG1hcCBjaGFuZ2VzLiBUbyBw cmV2ZW50IHRoZSBwcmludCBwcmV2aWV3IGZyb20gdXBkYXRpbmcKKyAgICAgICAgd2hlbmV2ZXIg bV9kcmF3YWJsZSBpcyB1cGRhdGVkIChpLmUgd2hlbiB0aGUgdmlldyB1cGRhdGVzKSwgd2UgY3Jl YXRlIGEgY29weS4KKyAgICAgICAgCisgICAgICAgIFdlIHJlcXVpcmUgdGhhdCBhIFFQaXhtYXA6 OmNvcHkoKSByZXN1bHQgaW4gYSBRUGl4bWFwIGJhY2tlZCBieSBhIFhQaXhtYXAKKyAgICAgICAg cmVnYXJkbGVzcyBvZiB0aGUgZ3JhcGhpY3NzeXN0ZW0uIFRoaXMgaXMgdGFrZW4gY2FyZSBvZiBi eQorICAgICAgICBjb21taXQgZDMxMGY3YzcxMGVjYjMzMWE5Njg5ODYxZjA1NTFlYWJkMzhlOTQ2 ZSBpbiBRdCAoNC42KQorICAgICAgICAKKyAgICAgICAgVGhlIGJlYXV0eSBvZiB0aGlzIHBhdGNo IGlzIHRoYXQgdGhlIG5ld2x5IGNyZWF0ZWQgWCBQaXhtYXAgaXMgbWFuYWdlZCBieSBRdCBhbmQK KyAgICAgICAgaXQgd2lsbCBmcmVlIHRoZSBQaXhtYXAgd2hlbmV2ZXIgdGhlIHVzZXIgY2xvc2Vz IHRoZSBwcmludCBwcmV2aWV3IGRpYWxvZyBhbmQKKyAgICAgICAgaGFuZGxlcyB0aGUgY2FzZSBv ZiBkaXNwbGF5aW5nIG11bHRpcGxlIHByZXZpZXcgZGlhbG9ncyBuaWNlbHkuCisgICAgICAgIAor ICAgICAgICBBbGwgY3JlZGl0IHRvIFNhbXVlbCBSw7hkYWwgZm9yIHN1Z2dlc3RpbmcgdXNhZ2Ug b2YgUVBpeG1hcDo6Y29weSgpLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNzE0CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdp blZpZXdRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpwYWludCk6CisKIDIw MDktMTAtMjMgIENocmlzIEV2YW5zICA8Y2V2YW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3F0L1Bs dWdpblZpZXdRdC5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRl eCA5ZDAyNWE4Li5hODI3MGRkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2lu Vmlld1F0LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcApAQCAt MTg2LDYgKzE4NiwxMiBAQCB2b2lkIFBsdWdpblZpZXc6OnBhaW50KEdyYXBoaWNzQ29udGV4dCog Y29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBjb25zdCBpbnQgZHJhd2FibGVEZXB0 aCA9ICgoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCopbV9ucFdpbmRvdy53c19pbmZvKS0+ZGVw dGg7CiAgICAgQVNTRVJUKGRyYXdhYmxlRGVwdGggPT0gcXREcmF3YWJsZS5kZXB0aCgpKTsKIAor ICAgIC8vIFdoZW4gcHJpbnRpbmcsIFF0IHVzZXMgYSBRUGljdHVyZSB0aGUgY2FwdHVyZSB0aGUg b3V0cHV0IGluIHByZXZpZXcgbW9kZS4gVGhlCisgICAgLy8gUVBpY3R1cmUgaG9sZHMgYSByZWZl cmVuY2UgdG8gdGhlIFggUGl4bWFwLiBBcyBhIHJlc3VsdCwgdGhlIHByaW50IHByZXZpZXcgd291 bGQKKyAgICAvLyB1cGRhdGUgaXRzZWxmIHdoZW4gdGhlIFggUGl4bWFwIGNoYW5nZXMuIFRvIHBy ZXZlbnQgdGhpcywgd2UgY3JlYXRlIGEgY29weS4KKyAgICBpZiAobV9lbGVtZW50LT5kb2N1bWVu dCgpLT5wcmludGluZygpKQorICAgICAgICBxdERyYXdhYmxlID0gcXREcmF3YWJsZS5jb3B5KCk7 CisKICAgICBpZiAobV9pc1RyYW5zcGFyZW50ICYmIGRyYXdhYmxlRGVwdGggIT0gMzIpIHsKICAg ICAgICAgLy8gQXR0ZW1wdCBjb250ZW50IHByb3BhZ2F0aW9uIGZvciBkcmF3YWJsZSB3aXRoIG5v IGFscGhhIGJ5IGNvcHlpbmcgb3ZlciBmcm9tIHRoZSBiYWNraW5nIHN0b3JlCiAgICAgICAgIFFQ b2ludCBvZmZzZXQ7CkBAIC0yMjEsNyArMjI3LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpwYWludChH cmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEludFJlY3QmIHJlY3QpCiAgICAgWEdyYXBo aWNzRXhwb3NlRXZlbnQmIGV4cG9zZUV2ZW50ID0geGV2ZW50LnhncmFwaGljc2V4cG9zZTsKICAg ICBleHBvc2VFdmVudC50eXBlID0gR3JhcGhpY3NFeHBvc2U7CiAgICAgZXhwb3NlRXZlbnQuZGlz cGxheSA9IFFYMTFJbmZvOjpkaXNwbGF5KCk7Ci0gICAgZXhwb3NlRXZlbnQuZHJhd2FibGUgPSBt X2RyYXdhYmxlOworICAgIGV4cG9zZUV2ZW50LmRyYXdhYmxlID0gcXREcmF3YWJsZS5oYW5kbGUo KTsKICAgICBleHBvc2VFdmVudC54ID0gZXhwb3NlZFJlY3QueCgpOwogICAgIGV4cG9zZUV2ZW50 LnkgPSBleHBvc2VkUmVjdC55KCk7CiAgICAgZXhwb3NlRXZlbnQud2lkdGggPSBleHBvc2VkUmVj dC54KCkgKyBleHBvc2VkUmVjdC53aWR0aCgpOyAvLyBmbGFzaCBidWc/IGl0IHRoaW5rcyB3aWR0 aCBpcyB0aGUgcmlnaHQgaW4gdHJhbnNwYXJlbnQgbW9kZQo=