30713 2009-10-23 06:38:28 -0700 Disable ReadWriteLock on platforms using pthreads but which do not support pthread_rwlock 2009-10-26 03:47:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 steveblock steveblock benm commit-queue hyatt steveblock oldest_to_newest 157153 0 steveblock 2009-10-23 06:38:28 -0700 ReadWriteLock is currently used only on SnowLeopard. See http://trac.webkit.org/changeset/44651. It is therefore implemented only on platforms using pthreads. However, some platforms that use pthreads (eg Android) do not support pthread_rwlock. For these platforms, ReadWriteLock should be disabled. 157155 1 41723 steveblock 2009-10-23 06:45:01 -0700 Created attachment 41723 Patch 1 for Bug 30713 157219 2 41723 eric 2009-10-23 11:42:46 -0700 Comment on attachment 41723 Patch 1 for Bug 30713 This looks sane to me, but whoever added the ReadWriteLock stuff should really review/comment here. 157435 3 mrowe 2009-10-24 00:54:10 -0700 It’s not used anywhere. I suspect it was added for a short-lived experiment, and that we can now rip it out completely. 157633 4 41723 darin 2009-10-25 16:18:28 -0700 Comment on attachment 41723 Patch 1 for Bug 30713 Seems OK. I'm not sure it's good to have all these cases, this one included, where the type PlatformReadWriteLock defined to be void*. If we're going to omit ReadWriteLock, then I suggest we do that in the header too rather than compiling a useless ReadWriteLock. What's more, I can't find any code using ReadWriteLock anywhere in the WebKit source code nor in Safari's source code. It looks like Hyatt added this class but never started using it. This patch is fine, but I think we could also consider dropping this unused code. I see that Mark Rowe said the same thing in his recent comment. 157718 5 steveblock 2009-10-26 03:26:23 -0700 > What's more, I can't find any code using ReadWriteLock anywhere in the WebKit > source code nor in Safari's source code. I wasn't sure if Hyatt was still working on the code that makes use of this class. I'll commit this patch, but if Hyatt can confirm that the class isn't needed, I'll happily send a patch to remove it completely. 157723 6 41723 commit-queue 2009-10-26 03:47:04 -0700 Comment on attachment 41723 Patch 1 for Bug 30713 Clearing flags on attachment: 41723 Committed r50052: <http://trac.webkit.org/changeset/50052> 157724 7 commit-queue 2009-10-26 03:47:11 -0700 All reviewed patches have been landed. Closing bug. 41723 2009-10-23 06:45:01 -0700 2009-10-26 03:47:04 -0700 Patch 1 for Bug 30713 rwlock.txt text/plain 3294 steveblock SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5OTc2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjMgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYWJpbGl0eSB0byBkaXNhYmxlIFJlYWRXcml0ZUxv Y2sgb24gcGxhdGZvcm1zIChlZyBBbmRyb2lkKSB0aGF0IHVzZSBwdGhyZWFkcyBidXQgZG8gbm90 IHN1cHBvcnQgcHRocmVhZF9yd2xvY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDcxMworCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6IE1vZGlm aWVkLiBEZWZpbmVzIEhBVkVfUFRIUkVBRF9SV0xPQ0sgZm9yIGFsbCBwbGF0Zm9ybXMgY3VycmVu dGx5IHVzaW5nIHB0aHJlYWRzLgorICAgICAgICAqIHd0Zi9UaHJlYWRpbmcuaDogTW9kaWZpZWQu IFVzZSBwdGhyZWFkX3J3bG9ja190IG9ubHkgd2hlbiBIQVZFX1BUSFJFQURfUldMT0NLIGlzIGRl ZmluZWQuCisgICAgICAgICogd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcDogTW9kaWZpZWQuIEJ1 aWxkIFJlYWRXcml0ZUxvY2sgbWV0aG9kcyBvbmx5IHdoZW4gSEFWRV9QVEhSRUFEX1JXTE9DSyBp cyBkZWZpbmVkLgorCiAyMDA5LTEwLTIyICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA0OTk3NSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9Q bGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NjYsNiArNDY2LDcgQEAKICNpZiBQTEFURk9S TShNQUMpICYmICFQTEFURk9STShJUEhPTkUpCiAjZGVmaW5lIFdURl9QTEFURk9STV9DRiAxCiAj ZGVmaW5lIFdURl9VU0VfUFRIUkVBRFMgMQorI2RlZmluZSBIQVZFX1BUSFJFQURfUldMT0NLIDEK ICNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChCVUlMRElOR19P Tl9USUdFUikgJiYgZGVmaW5lZChfX3g4Nl82NF9fKQogI2RlZmluZSBXVEZfVVNFX1BMVUdJTl9I T1NUX1BST0NFU1MgMQogI2VuZGlmCkBAIC00ODIsNiArNDgzLDcgQEAKICNpZiBQTEFURk9STShD SFJPTUlVTSkgJiYgUExBVEZPUk0oREFSV0lOKQogI2RlZmluZSBXVEZfUExBVEZPUk1fQ0YgMQog I2RlZmluZSBXVEZfVVNFX1BUSFJFQURTIDEKKyNkZWZpbmUgSEFWRV9QVEhSRUFEX1JXTE9DSyAx CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKElQSE9ORSkKQEAgLTQ5OCw2ICs1MDAsNyBAQAogI2Rl ZmluZSBIQVZFX1JFQURMSU5FIDEKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0NGIDEKICNkZWZpbmUg V1RGX1VTRV9QVEhSRUFEUyAxCisjZGVmaW5lIEhBVkVfUFRIUkVBRF9SV0xPQ0sgMQogI2VuZGlm CiAKICNpZiBQTEFURk9STShXSU4pCkBAIC01MTEsNiArNTE0LDcgQEAKICNpZiBQTEFURk9STShH VEspCiAjaWYgSEFWRShQVEhSRUFEX0gpCiAjZGVmaW5lIFdURl9VU0VfUFRIUkVBRFMgMQorI2Rl ZmluZSBIQVZFX1BUSFJFQURfUldMT0NLIDEKICNlbmRpZgogI2VuZGlmCiAKQEAgLTUxOCw2ICs1 MjIsNyBAQAogI2RlZmluZSBIQVZFX1BPU0lYX01FTUFMSUdOIDEKICNkZWZpbmUgV1RGX1VTRV9D VVJMIDEKICNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAxCisjZGVmaW5lIEhBVkVfUFRIUkVBRF9S V0xPQ0sgMQogI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCiAjZGVmaW5lIEVOQUJMRV9ORVRT Q0FQRV9QTFVHSU5fQVBJIDAKICNlbmRpZgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1RocmVh ZGluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAkocmV2 aXNpb24gNDk5NzUpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nLmgJKHdvcmtpbmcg Y29weSkKQEAgLTEyOCw3ICsxMjgsMTEgQEAgdm9pZCBkZXRhY2hUaHJlYWQoVGhyZWFkSWRlbnRp Zmllcik7CiAKICNpZiBVU0UoUFRIUkVBRFMpCiB0eXBlZGVmIHB0aHJlYWRfbXV0ZXhfdCBQbGF0 Zm9ybU11dGV4OworI2lmIEhBVkUoUFRIUkVBRF9SV0xPQ0spCiB0eXBlZGVmIHB0aHJlYWRfcnds b2NrX3QgUGxhdGZvcm1SZWFkV3JpdGVMb2NrOworI2Vsc2UKK3R5cGVkZWYgdm9pZCogUGxhdGZv cm1SZWFkV3JpdGVMb2NrOworI2VuZGlmCiB0eXBlZGVmIHB0aHJlYWRfY29uZF90IFBsYXRmb3Jt Q29uZGl0aW9uOwogI2VsaWYgUExBVEZPUk0oR1RLKQogdHlwZWRlZiBHT3duUHRyPEdNdXRleD4g UGxhdGZvcm1NdXRleDsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFk cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRz LmNwcAkocmV2aXNpb24gNDk5NzUpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRo cmVhZHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzAsNyArMjcwLDcgQEAgdm9pZCBNdXRleDo6 dW5sb2NrKCkKICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgIXJlc3VsdCk7CiB9CiAKLQorI2lm IEhBVkUoUFRIUkVBRF9SV0xPQ0spCiBSZWFkV3JpdGVMb2NrOjpSZWFkV3JpdGVMb2NrKCkKIHsK ICAgICBwdGhyZWFkX3J3bG9ja19pbml0KCZtX3JlYWRXcml0ZUxvY2ssIE5VTEwpOwpAQCAtMzI0 LDYgKzMyNCw3IEBAIHZvaWQgUmVhZFdyaXRlTG9jazo6dW5sb2NrKCkKICAgICBpbnQgcmVzdWx0 ID0gcHRocmVhZF9yd2xvY2tfdW5sb2NrKCZtX3JlYWRXcml0ZUxvY2spOwogICAgIEFTU0VSVF9V TlVTRUQocmVzdWx0LCAhcmVzdWx0KTsKIH0KKyNlbmRpZiAgLy8gSEFWRShQVEhSRUFEX1JXTE9D SykKIAogVGhyZWFkQ29uZGl0aW9uOjpUaHJlYWRDb25kaXRpb24oKQogeyAK