30706 2009-10-22 22:00:25 -0700 [Qt] Plugins: Use the window's winId() for NPNVnetscapeWindow 2009-10-23 12:02:31 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 0 girish webkit-unassigned zecke oldest_to_newest 157105 0 girish 2009-10-22 22:00:25 -0700 Patch follows. 157106 1 41713 girish 2009-10-22 22:07:08 -0700 Created attachment 41713 [Qt] Plugins : Use window's winId() instead of the widget's. As per, https://developer.mozilla.org/en/NPN_GetValue NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the plug-in is displayed; returns Window". The issue was found because NPNVNetscapeWindow winId() ends up creating a native window resulting in flicker. --- WebCore/plugins/qt/PluginViewQt.cpp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 157107 2 41714 girish 2009-10-22 22:12:46 -0700 Created attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. As per, https://developer.mozilla.org/en/NPN_GetValue NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the plug-in is displayed; returns Window". The issue was found because NPNVNetscapeWindow winId() ends up creating a native window resulting in flicker. --- WebCore/ChangeLog | 18 ++++++++++++++++++ WebCore/plugins/qt/PluginViewQt.cpp | 2 +- 2 files changed, 19 insertions(+), 1 deletions(-) 157108 3 41714 girish 2009-10-22 22:13:50 -0700 Comment on attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. Forgot ChangeLog in other patch. 157109 4 41714 zecke 2009-10-22 22:43:27 -0700 Comment on attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. Okay, I hope we don't need a NULL check and Gtk/X11 seems to do the right thing too. 157130 5 41714 commit-queue 2009-10-23 02:50:15 -0700 Comment on attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. Rejecting patch 41714 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 135.99s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157140 6 41714 zecke 2009-10-23 03:09:09 -0700 Comment on attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. The failing test must be unrelated to this change. I hope it is appropriate to try again. 157141 7 41714 commit-queue 2009-10-23 03:13:52 -0700 Comment on attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. Rejecting patch 41714 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 134.54s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157145 8 zecke 2009-10-23 05:04:21 -0700 Landed in r49975. 157233 9 41714 eric 2009-10-23 12:02:31 -0700 Comment on attachment 41714 [Qt] Plugins : Use window's winId() instead of the widget's. Sorry about the commit-queue trouble. Should work fine now. 41713 2009-10-22 22:07:08 -0700 2009-10-22 22:14:09 -0700 [Qt] Plugins : Use window's winId() instead of the widget's. -Qt-Plugins-Use-window-s-winId-instead-of-the-widget-s..patch text/plain 689 girish MTk0OWNiZjNmZjc2YWU1ZTJiMWM0ZDhjNmZiMjUzNDZiNWE0ZTQ4NQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcAppbmRleCAyODYzN2ExLi41MWVjZGI5IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcApAQCAtNjMwLDcgKzYzMCw3IEBAIE5QRXJyb3IgUGx1Z2luVmlldzo6Z2V0 VmFsdWUoTlBOVmFyaWFibGUgdmFyaWFibGUsIHZvaWQqIHZhbHVlKQogICAgIGNhc2UgTlBOVm5l dHNjYXBlV2luZG93OiB7CiAgICAgICAgIHZvaWQqIHcgPSByZWludGVycHJldF9jYXN0PHZvaWQq Pih2YWx1ZSk7CiAgICAgICAgIFFXZWJQYWdlQ2xpZW50KiBjbGllbnQgPSBtX3BhcmVudEZyYW1l LT52aWV3KCktPmhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7Ci0gICAgICAgICoo KFhJRCAqKXcpID0gY2xpZW50ID8gY2xpZW50LT5vd25lcldpZGdldCgpLT53aW5JZCgpIDogMDsK KyAgICAgICAgKigoWElEICopdykgPSBjbGllbnQgPyBjbGllbnQtPm93bmVyV2lkZ2V0KCktPndp bmRvdygpLT53aW5JZCgpIDogMDsKICAgICAgICAgcmV0dXJuIE5QRVJSX05PX0VSUk9SOwogICAg IH0KIAo= 41714 2009-10-22 22:12:46 -0700 2009-10-23 12:02:31 -0700 [Qt] Plugins : Use window's winId() instead of the widget's. -Qt-Plugins-Use-window-s-winId-instead-of-the-widget-s..patch text/plain 1579 girish NjA5MzQ2ZmFhYjk4MTU2Mjc1YWJiNjZkMjEyMTk3MjcxZjI2OGU2ZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5YmY5MWI2Li41ODYxNjMw IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIxIEBACisyMDA5LTEwLTIyICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNo QGZvcndhcmRiaWFzLmluPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gUGx1Z2lucyA6IFVzZSB3aW5kb3cncyB3aW5JZCgpIGluc3RlYWQgb2Yg dGhlIHdpZGdldCdzLgorICAgICAgICAKKyAgICAgICAgQXMgcGVyLCBodHRwczovL2RldmVsb3Bl ci5tb3ppbGxhLm9yZy9lbi9OUE5fR2V0VmFsdWUKKyAgICAgICAgTlBOVm5ldHNjYXBlV2luZG93 IG9uIFVuaXgvWDExOiAiR2V0cyB0aGUgYnJvd3NlciB0b3BsZXZlbCB3aW5kb3cgaW4gd2hpY2gg dGhlCisgICAgICAgIHBsdWctaW4gaXMgZGlzcGxheWVkOyByZXR1cm5zIFdpbmRvdyIuCisgICAg ICAgIAorICAgICAgICBUaGUgaXNzdWUgd2FzIGZvdW5kIGJlY2F1c2UgTlBOVk5ldHNjYXBlV2lu ZG93IHdpbklkKCkgZW5kcyB1cCBjcmVhdGluZworICAgICAgICBhIG5hdGl2ZSB3aW5kb3cgcmVz dWx0aW5nIGluIGZsaWNrZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMwNzA2CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpnZXRWYWx1ZSk6CisKIDIwMDktMTAt MjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgVGltIEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2lu Vmlld1F0LmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCmluZGV4IDI4 NjM3YTEuLjUxZWNkYjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3 UXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBAIC02MzAs NyArNjMwLDcgQEAgTlBFcnJvciBQbHVnaW5WaWV3OjpnZXRWYWx1ZShOUE5WYXJpYWJsZSB2YXJp YWJsZSwgdm9pZCogdmFsdWUpCiAgICAgY2FzZSBOUE5WbmV0c2NhcGVXaW5kb3c6IHsKICAgICAg ICAgdm9pZCogdyA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHZhbHVlKTsKICAgICAgICAgUVdl YlBhZ2VDbGllbnQqIGNsaWVudCA9IG1fcGFyZW50RnJhbWUtPnZpZXcoKS0+aG9zdFdpbmRvdygp LT5wbGF0Zm9ybVBhZ2VDbGllbnQoKTsKLSAgICAgICAgKigoWElEICopdykgPSBjbGllbnQgPyBj bGllbnQtPm93bmVyV2lkZ2V0KCktPndpbklkKCkgOiAwOworICAgICAgICAqKChYSUQgKil3KSA9 IGNsaWVudCA/IGNsaWVudC0+b3duZXJXaWRnZXQoKS0+d2luZG93KCktPndpbklkKCkgOiAwOwog ICAgICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CiAgICAgfQogCg==