30700 2009-10-22 18:03:50 -0700 fast/media/mq-transform-02.html failed on Leopard Commit Bot 2009-10-25 22:29:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth darin eric.carlson simon.fraser oldest_to_newest 157071 0 eric 2009-10-22 18:03:50 -0700 fast/media/mq-transform-02.html failed on Leopard Bot https://bugs.webkit.org/show_bug.cgi?id=30669#c5 https://bugs.webkit.org/show_bug.cgi?id=28284#c10 I think it is that I just upgraded QuickTime on the commit-queue machine and now the compositing is not longer disabled due to the version check in DRT. 157077 1 mrowe 2009-10-22 18:22:38 -0700 Eric, which Leopard build bot did these tests fail on? I don’t see any link to the buildbot results. 157198 2 eric 2009-10-23 11:19:59 -0700 commit bot. Sorry if that wasn't clear. To resolve this I think I just need to update the version check in DumpRenderTree. Before I do that, I need to know if a fix for rdar://problem/7189153 has already been shipped in QuickTime. This started failing when I installed QuickTime 7.6.4 on the commit-bot. #if defined(BUILDING_ON_LEOPARD) // Disable hardware composititing to avoid timeouts and crashes from buggy CoreVideo teardown code. // https://bugs.webkit.org/show_bug.cgi?id=28845 and rdar://problem/7228836 SInt32 qtVersion; OSErr err = Gestalt(gestaltQuickTimeVersion, &qtVersion); assert(err == noErr); // Bug 7228836 exists in at least 7.6.3 and 7.6.4, hopefully it will be fixed in 7.6.5. // FIXME: Once we know the exact versions of QuickTime affected, we can update this check. if (qtVersion <= 0x07640000) [preferences setAcceleratedCompositingEnabled:NO]; else #endif [preferences setAcceleratedCompositingEnabled:YES]; Is the current check in DumpRenderTree.mm 157203 3 eric 2009-10-23 11:28:35 -0700 According to: OSErr err = Gestalt(gestaltQuickTimeVersion, &qtVersion); printf("\n\nQuickTime version: %lx\n\n", qtVersion); My quicktime version is: QuickTime version: 7648000 So I'll update the version check: if (qtVersion <= 0x07640000) assuming that the QuickTime crasher still isn't fixed. I guess the leopard build bots haven't upgraded quicktime versions yet. 157209 4 simon.fraser 2009-10-23 11:33:02 -0700 Yes, oddly, Leopard gets QT 7.6.4, and SL has 7.6.3. 157210 5 41737 eric 2009-10-23 11:35:24 -0700 Created attachment 41737 update qtVersion check 157211 6 eric 2009-10-23 11:37:42 -0700 Doing a version check here at all is a little strange as these two tests will fail for anyone who has a new enough version of QuickTime on leopard. I'm assuming QuickTime hasn't been fixed yet and have posted a patch to disable HW compositing under 7.6.4.8 (which is what the commit-bot got installed on it yesterday). 157221 7 41737 eric.carlson 2009-10-23 11:47:04 -0700 Comment on attachment 41737 update qtVersion check > - // Bug 7228836 exists in at least 7.6.3 and 7.6.4, hopefully it will be fixed in 7.6.5. > + // Bug 7228836 exists in at least 7.6.3 through 7.6.4.8, hopefully it will be fixed in 7.6.5. This comment is incorrect. The version is encoded in BCD where the third byte is the "release stage", and 80 indicates the final release (see http://developer.apple.com/mac/library/technotes/tn/tn1132.html). r=me with a fixed comment 157227 8 eric 2009-10-23 11:57:52 -0700 Committed r49984: <http://trac.webkit.org/changeset/49984> 157634 9 darin 2009-10-25 16:28:15 -0700 If it was me, I would have done: < 0x07650000 or: <= 0x0764FFFF We'll probably be OK with 0x07648000, but back when we originally designed this BCD scheme (and one of the first things I did my first time at Apple was write the technical note describing it), there was such a thing as "final 2" and such, which would have some nonzero digits in the low byte. It may be that QuickTime won't do such a thing. 157678 10 eric 2009-10-25 22:29:00 -0700 I agree. "< 0x07650000" would have been cleaner. If 7.6.5 doesn't have the fix I'll do that for 7.6.6. :) 41737 2009-10-23 11:35:24 -0700 2009-10-23 11:47:04 -0700 update qtVersion check bug-30700-20091023113522.patch text/plain 1445 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMmQ0MTVlLi44NDU1Mzc2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MjMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZhc3QvbWVkaWEvbXEtdHJhbnNmb3JtLTAyLmh0 bWwgZmFpbGVkIG9uIExlb3BhcmQgQ29tbWl0IEJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3MDAKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L21hYy9EdW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAgKHJlc2V0RGVmYXVsdHNUb0NvbnNpc3Rl bnRWYWx1ZXMpOiBVcGRhdGUgUXVpY2tUaW1lIHZlcnNpb24gY2hlY2suCisKIDIwMDktMTAtMjEg IEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVt cFJlbmRlclRyZWUubW0gYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRl clRyZWUubW0KaW5kZXggZGZhZTI2NS4uYTAzYThjZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCisrKyBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpAQCAtNDM0LDkgKzQzNCw5IEBAIHN0 YXRpYyB2b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIFNJbnQzMiBx dFZlcnNpb247CiAgICAgT1NFcnIgZXJyID0gR2VzdGFsdChnZXN0YWx0UXVpY2tUaW1lVmVyc2lv biwgJnF0VmVyc2lvbik7CiAgICAgYXNzZXJ0KGVyciA9PSBub0Vycik7Ci0gICAgLy8gQnVnIDcy Mjg4MzYgZXhpc3RzIGluIGF0IGxlYXN0IDcuNi4zIGFuZCA3LjYuNCwgaG9wZWZ1bGx5IGl0IHdp bGwgYmUgZml4ZWQgaW4gNy42LjUuCisgICAgLy8gQnVnIDcyMjg4MzYgZXhpc3RzIGluIGF0IGxl YXN0IDcuNi4zIHRocm91Z2ggNy42LjQuOCwgaG9wZWZ1bGx5IGl0IHdpbGwgYmUgZml4ZWQgaW4g Ny42LjUuCiAgICAgLy8gRklYTUU6IE9uY2Ugd2Uga25vdyB0aGUgZXhhY3QgdmVyc2lvbnMgb2Yg UXVpY2tUaW1lIGFmZmVjdGVkLCB3ZSBjYW4gdXBkYXRlIHRoaXMgY2hlY2suCi0gICAgaWYgKHF0 VmVyc2lvbiA8PSAweDA3NjQwMDAwKQorICAgIGlmIChxdFZlcnNpb24gPD0gMHgwNzY0ODAwMCkK ICAgICAgICAgW3ByZWZlcmVuY2VzIHNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkOk5P XTsKICAgICBlbHNlCiAjZW5kaWY=