30699 2009-10-22 17:42:04 -0700 Add a media layout test asserting that pause has an immediate effect 2009-10-23 13:13:59 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 scherkus webkit-unassigned commit-queue eric.carlson oldest_to_newest 157062 0 scherkus 2009-10-22 17:42:04 -0700 While investigating media layout tests I came across an interesting intermittent bug in Chromium. Our media backend is written to be as asynchronous as possible. While this is great most of the time (we don't hang the rendering thread) it also introduced the possibility of the clock still ticking after we issued an asynchronous pause. I originally stumbled across the bug in video-played-ranges-1.html, but the reason wasn't obvious and I thought the bug had to do with rounding error. So here's a layout test that asserts that implementors pause their clock immediately. 157065 1 41703 scherkus 2009-10-22 17:46:01 -0700 Created attachment 41703 Round 1 QuickTime's pause is synchronous so you already pass this test :P 157066 2 41704 scherkus 2009-10-22 17:47:37 -0700 Created attachment 41704 Round 1 - no tabs some tabs slipped into my changelog 157104 3 41704 eric.carlson 2009-10-22 21:49:08 -0700 Comment on attachment 41704 Round 1 - no tabs r=me 157131 4 41704 commit-queue 2009-10-23 02:53:36 -0700 Comment on attachment 41704 Round 1 - no tabs Rejecting patch 41704 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11507 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 138.12s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157213 5 scherkus 2009-10-23 11:39:25 -0700 Hrmm that commit queue failures doesn't look like it's related. 157237 6 41704 eric 2009-10-23 12:03:50 -0700 Comment on attachment 41704 Round 1 - no tabs Sorry about the commit-queue trouble. Should work fine now. 157270 7 41704 commit-queue 2009-10-23 13:13:55 -0700 Comment on attachment 41704 Round 1 - no tabs Clearing flags on attachment: 41704 Committed r49993: <http://trac.webkit.org/changeset/49993> 157271 8 commit-queue 2009-10-23 13:13:59 -0700 All reviewed patches have been landed. Closing bug. 41703 2009-10-22 17:46:01 -0700 2009-10-22 17:47:37 -0700 Round 1 pause_imm.patch text/plain 2849 scherkus ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4ZmI4YTgyLi4wNDFhZjBhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMTAt MjIgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB0 byBhc3NlcnQgdGhhdCBtZWRpYSBlbGVtZW50IGltcGxlbWVudG9ycyBkbyBub3QKKwlhZHZhbmNl IGN1cnJlbnRUaW1lIGFmdGVyIGJlaW5nIHBhdXNlZC4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2OTkKKworICAgICAgICAqIG1lZGlhL3ZpZGVv LXBhdXNlLWltbWVkaWF0ZWx5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEv dmlkZW8tcGF1c2UtaW1tZWRpYXRlbHkuaHRtbDogQWRkZWQuCisKKzIwMDktMTAtMjIgIEFuZHJl dyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIENhcmxzb24uCiAKICAgICAgICAgRml4IHZpZGVvLXBsYXllZC5qcyB0byB1c2UgYW4g ZXJyb3IgdGltZW91dCBiYXNlZCBvbiB0aW1lIHJhdGhlciB0aGFuIGZ1bmN0aW9uIGNhbGwgY291 bnQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVzZS1pbW1lZGlhdGVs eS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVzZS1pbW1lZGlhdGVs eS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2M2ZmVi MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBhdXNlLWltbWVk aWF0ZWx5LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDkgQEAKK1Rlc3QgdGhhdCBwYXVzaW5nIHRo ZSBtZWRpYSBlbGVtZW50IGhhcyBhbiBpbW1lZGlhdGUgZWZmZWN0IG9uIHRoZSBjbG9jay4KKwor RVZFTlQoY2FucGxheSkKK0VWRU5UKHBsYXlpbmcpCitFVkVOVChwYXVzZSkKK0VYUEVDVEVEICgo dmlkZW8uY3VycmVudFRpbWUgLSB0aW1lQWZ0ZXJQYXVzZSkgPT0gJzAnKSBPSworRVhQRUNURUQg KCh2aWRlby5wbGF5ZWQuZW5kKDApIC0gdGltZUFmdGVyUGF1c2UpID09ICcwJykgT0sKK0VORCBP RiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBhdXNlLWltbWVk aWF0ZWx5Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVzZS1pbW1lZGlhdGVseS5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjA5NDAxOTkKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVzZS1pbW1lZGlhdGVseS5odG1s CkBAIC0wLDAgKzEsNDcgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8dGl0bGU+VGVz dCBwYXVzZSgpIHBhdXNlcyB0aGUgY2xvY2sgaW1tZWRpYXRlbHk8L3RpdGxlPgorICAgICAgICA8 c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0IHNyYz12 aWRlby10ZXN0LmpzPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgdmFy IHRpbWVBZnRlclBhdXNlOworCisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0KCkKKyAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICAg ICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7Cisg ICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KCJjYW5wbGF5IiwgY2FucGxheSk7CisgICAgICAg ICAgICAgICAgd2FpdEZvckV2ZW50KCJwbGF5aW5nIiwgcGxheWluZyk7CisgICAgICAgICAgICAg ICAgd2FpdEZvckV2ZW50KCJwYXVzZSIsIHBhdXNlKTsKKyAgICAgICAgICAgIH0KKworICAgICAg ICAgICAgZnVuY3Rpb24gY2FucGxheSgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg dmlkZW8ucGxheSgpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBwbGF5 aW5nKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KHBhdXNlVmlk ZW8sIDIwMCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHBhdXNlVmlk ZW8oKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHZpZGVvLnBhdXNlKCk7CisgICAg ICAgICAgICAgICAgdGltZUFmdGVyUGF1c2UgPSB2aWRlby5jdXJyZW50VGltZTsKKyAgICAgICAg ICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gcGF1c2UoKQorICAgICAgICAgICAgeworICAg ICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiKHZpZGVvLmN1cnJlbnRUaW1lIC0gdGltZUFmdGVy UGF1c2UpIiwgMCk7CisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCIodmlkZW8ucGxheWVk LmVuZCgwKSAtIHRpbWVBZnRlclBhdXNlKSIsIDApOworICAgICAgICAgICAgICAgIGVuZFRlc3Qo KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAgIDwvaGVhZD4KKyAgICA8 Ym9keSBvbmxvYWQ9InRlc3QoKSI+CisgICAgICAgIDxwPlRlc3QgdGhhdCBwYXVzaW5nIHRoZSBt ZWRpYSBlbGVtZW50IGhhcyBhbiBpbW1lZGlhdGUgZWZmZWN0IG9uIHRoZSBjbG9jay48L3A+Cisg ICAgICAgIDx2aWRlbyBjb250cm9scz48L3ZpZGVvPgorICAgIDwvYm9keT4KKzwvaHRtbD4KKwo= 41704 2009-10-22 17:47:37 -0700 2009-10-23 13:13:55 -0700 Round 1 - no tabs pause_imm.patch text/plain 2856 scherkus ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4ZmI4YTgyLi4yNGIyMWZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMTAt MjIgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB0 byBhc3NlcnQgdGhhdCBtZWRpYSBlbGVtZW50IGltcGxlbWVudG9ycyBkbyBub3QKKyAgICAgICAg YWR2YW5jZSBjdXJyZW50VGltZSBhZnRlciBiZWluZyBwYXVzZWQuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjk5CisKKyAgICAgICAgKiBtZWRp YS92aWRlby1wYXVzZS1pbW1lZGlhdGVseS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IG1lZGlhL3ZpZGVvLXBhdXNlLWltbWVkaWF0ZWx5Lmh0bWw6IEFkZGVkLgorCisyMDA5LTEwLTIy ICBBbmRyZXcgU2NoZXJrdXMgIDxzY2hlcmt1c0BjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2 aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgogCiAgICAgICAgIEZpeCB2aWRlby1wbGF5ZWQuanMgdG8g dXNlIGFuIGVycm9yIHRpbWVvdXQgYmFzZWQgb24gdGltZSByYXRoZXIgdGhhbiBmdW5jdGlvbiBj YWxsIGNvdW50LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGF1c2UtaW1t ZWRpYXRlbHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGF1c2UtaW1t ZWRpYXRlbHktZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LjdjNmZlYjAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVz ZS1pbW1lZGlhdGVseS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitUZXN0IHRoYXQgcGF1 c2luZyB0aGUgbWVkaWEgZWxlbWVudCBoYXMgYW4gaW1tZWRpYXRlIGVmZmVjdCBvbiB0aGUgY2xv Y2suCisKK0VWRU5UKGNhbnBsYXkpCitFVkVOVChwbGF5aW5nKQorRVZFTlQocGF1c2UpCitFWFBF Q1RFRCAoKHZpZGVvLmN1cnJlbnRUaW1lIC0gdGltZUFmdGVyUGF1c2UpID09ICcwJykgT0sKK0VY UEVDVEVEICgodmlkZW8ucGxheWVkLmVuZCgwKSAtIHRpbWVBZnRlclBhdXNlKSA9PSAnMCcpIE9L CitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVz ZS1pbW1lZGlhdGVseS5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGF1c2UtaW1tZWRp YXRlbHkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4wOTQwMTk5Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGF1c2UtaW1tZWRpYXRl bHkuaHRtbApAQCAtMCwwICsxLDQ3IEBACis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHRp dGxlPlRlc3QgcGF1c2UoKSBwYXVzZXMgdGhlIGNsb2NrIGltbWVkaWF0ZWx5PC90aXRsZT4KKyAg ICAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlw dCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAg ICAgIHZhciB0aW1lQWZ0ZXJQYXVzZTsKKworICAgICAgICAgICAgZnVuY3Rpb24gdGVzdCgpCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOworICAgICAg ICAgICAgICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvdGVz dCIpOworICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgiY2FucGxheSIsIGNhbnBsYXkpOwor ICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgicGxheWluZyIsIHBsYXlpbmcpOworICAgICAg ICAgICAgICAgIHdhaXRGb3JFdmVudCgicGF1c2UiLCBwYXVzZSk7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGZ1bmN0aW9uIGNhbnBsYXkoKQorICAgICAgICAgICAgeworICAgICAgICAg ICAgICAgIHZpZGVvLnBsYXkoKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rp b24gcGxheWluZygpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgc2V0VGltZW91dChw YXVzZVZpZGVvLCAyMDApOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBw YXVzZVZpZGVvKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB2aWRlby5wYXVzZSgp OworICAgICAgICAgICAgICAgIHRpbWVBZnRlclBhdXNlID0gdmlkZW8uY3VycmVudFRpbWU7Cisg ICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHBhdXNlKCkKKyAgICAgICAgICAg IHsKKyAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoIih2aWRlby5jdXJyZW50VGltZSAtIHRp bWVBZnRlclBhdXNlKSIsIDApOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiKHZpZGVv LnBsYXllZC5lbmQoMCkgLSB0aW1lQWZ0ZXJQYXVzZSkiLCAwKTsKKyAgICAgICAgICAgICAgICBl bmRUZXN0KCk7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgICA8L2hlYWQ+ CisgICAgPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorICAgICAgICA8cD5UZXN0IHRoYXQgcGF1c2lu ZyB0aGUgbWVkaWEgZWxlbWVudCBoYXMgYW4gaW1tZWRpYXRlIGVmZmVjdCBvbiB0aGUgY2xvY2su PC9wPgorICAgICAgICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KKyAgICA8L2JvZHk+Cis8L2h0 bWw+CisK