30698 2009-10-22 17:32:22 -0700 createThreadInternal on Android leaks on failure 2009-10-23 12:15:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 steveblock benm benm steveblock oldest_to_newest 157061 0 steveblock 2009-10-22 17:32:22 -0700 On Android, createThreadInternal leaks an object of type ThreadData on failure. 157069 1 41706 steveblock 2009-10-22 17:53:58 -0700 Created attachment 41706 Patch 1 for Bug 30698 157135 2 41706 commit-queue 2009-10-23 03:01:42 -0700 Comment on attachment 41706 Patch 1 for Bug 30698 Rejecting patch 41706 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 138.55s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157139 3 benm 2009-10-23 03:07:28 -0700 Will land manually, looks like https://bugs.webkit.org/show_bug.cgi?id=30700 caused the cq to fail. 157156 4 benm 2009-10-23 07:09:21 -0700 Landed as r49977. 157235 5 41706 eric 2009-10-23 12:03:11 -0700 Comment on attachment 41706 Patch 1 for Bug 30698 Sorry about the commit-queue trouble. Should work fine now. 157246 6 steveblock 2009-10-23 12:11:36 -0700 benm@google.com has already landed this by hand. 41706 2009-10-22 17:53:58 -0700 2009-10-23 12:15:40 -0700 Patch 1 for Bug 30698 fixPthreadLeak.txt text/plain 1258 steveblock SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5OTYxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMjIgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGEgbGVhayBpbiBjcmVhdGVUaHJlYWRJbnRlcm5h bCBvbiBBbmRyb2lkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzA2OTgKKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHA6IE1vZGlm aWVkLgorICAgICAgICAoV1RGOjpjcmVhdGVUaHJlYWRJbnRlcm5hbCk6IEF2b2lkIGxlYWtpbmcg YSBUaHJlYWREYXRhIG9iamVjdCBvbiBmYWlsdXJlLgorCiAyMDA5LTEwLTIyICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFBy b3NrdXJ5YWtvdi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNw cAkocmV2aXNpb24gNDk5NTcpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVh ZHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjcsNiArMTY3LDcgQEAgVGhyZWFkSWRlbnRpZmll ciBjcmVhdGVUaHJlYWRJbnRlcm5hbChUaAogCiAgICAgaWYgKHB0aHJlYWRfY3JlYXRlKCZ0aHJl YWRIYW5kbGUsIDAsIHJ1blRocmVhZFdpdGhSZWdpc3RyYXRpb24sIHN0YXRpY19jYXN0PHZvaWQq Pih0aHJlYWREYXRhKSkpIHsKICAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gY3JlYXRlIHB0 aHJlYWQgYXQgZW50cnkgcG9pbnQgJXAgd2l0aCBkYXRhICVwIiwgZW50cnlQb2ludCwgZGF0YSk7 CisgICAgICAgIGRlbGV0ZSB0aHJlYWREYXRhOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAg ICAgcmV0dXJuIGVzdGFibGlzaElkZW50aWZpZXJGb3JQdGhyZWFkSGFuZGxlKHRocmVhZEhhbmRs ZSk7Cg==