30682 2009-10-22 11:31:02 -0700 [Qt] Add Print shortcut to QtLauncher 2009-10-22 19:44:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 0 girish webkit-unassigned commit-queue oldest_to_newest 156950 0 girish 2009-10-22 11:31:02 -0700 Add shortcut. 156972 1 41677 girish 2009-10-22 12:20:51 -0700 Created attachment 41677 [Qt] Add Print Shortcut to QtLauncher WebKit/qt/ChangeLog | 11 +++++++++++ WebKit/qt/QtLauncher/main.cpp | 2 +- 2 files changed, 12 insertions(+), 1 deletions(-) 156976 2 41677 eric 2009-10-22 12:43:59 -0700 Comment on attachment 41677 [Qt] Add Print Shortcut to QtLauncher Looks like this is new as of 4.2. I'm not sure what version of Qt the QtWebKit folks are trying to target. http://doc.trolltech.com/4.4/qkeysequence.html#StandardKey-enum That said, this looks fine as far as I can tell. This is a debugging tool after all. :) 156988 3 41677 commit-queue 2009-10-22 13:10:19 -0700 Comment on attachment 41677 [Qt] Add Print Shortcut to QtLauncher Clearing flags on attachment: 41677 Committed r49953: <http://trac.webkit.org/changeset/49953> 156989 4 commit-queue 2009-10-22 13:10:25 -0700 All reviewed patches have been landed. Closing bug. 157090 5 girish 2009-10-22 19:44:06 -0700 (In reply to comment #2) > (From update of attachment 41677 [details]) > Looks like this is new as of 4.2. I'm not sure what version of Qt the QtWebKit > folks are trying to target. > http://doc.trolltech.com/4.4/qkeysequence.html#StandardKey-enum > > That said, this looks fine as far as I can tell. This is a debugging tool > after all. :) We target >= Qt 4.4. Thanks :) 41677 2009-10-22 12:20:51 -0700 2009-10-22 13:10:18 -0700 [Qt] Add Print Shortcut to QtLauncher -Qt-Add-Print-Shortcut-to-QtLauncher.patch text/plain 1252 girish NmQ3YWEyNjg1NzI3NmM0MWI0OTAyZDVlODNlNTU5ZGViYTExZTkzZgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggZWEwM2NiZC4uZDcw NTdiNSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjIgIEdpcmlzaCBSYW1ha3Jpc2huYW4g IDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBBZGQgUHJpbnQgU2hvcnRjdXQgdG8gUXRMYXVuY2hlcgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDY4Mgor CisgICAgICAgICogUXRMYXVuY2hlci9tYWluLmNwcDoKKyAgICAgICAgKE1haW5XaW5kb3c6OnNl dHVwVUkpOgorCiAyMDA5LTEwLTIwICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5l dGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBCeSBBZGFtIEJhcnRoLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L1F0TGF1bmNoZXIvbWFpbi5jcHAgYi9XZWJLaXQvcXQvUXRMYXVuY2hl ci9tYWluLmNwcAppbmRleCA4Y2UwOWQyLi5jNDU0Y2JlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQv UXRMYXVuY2hlci9tYWluLmNwcAorKysgYi9XZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcApA QCAtMzAzLDcgKzMwMyw3IEBAIHByaXZhdGU6CiAgICAgICAgIFFNZW51ICpmaWxlTWVudSA9IG1l bnVCYXIoKS0+YWRkTWVudSgiJkZpbGUiKTsKICAgICAgICAgUUFjdGlvbiAqbmV3V2luZG93ID0g ZmlsZU1lbnUtPmFkZEFjdGlvbigiTmV3IFdpbmRvdyIsIHRoaXMsIFNMT1QobmV3V2luZG93KCkp KTsKICNpZiBRVF9WRVJTSU9OID49IDB4MDQwNDAwCi0gICAgICAgIGZpbGVNZW51LT5hZGRBY3Rp b24odHIoIlByaW50IiksIHRoaXMsIFNMT1QocHJpbnQoKSkpOworICAgICAgICBmaWxlTWVudS0+ YWRkQWN0aW9uKHRyKCJQcmludCIpLCB0aGlzLCBTTE9UKHByaW50KCkpLCBRS2V5U2VxdWVuY2U6 OlByaW50KTsKICNlbmRpZgogICAgICAgICBRQWN0aW9uKiBzY3JlZW5zaG90ID0gZmlsZU1lbnUt PmFkZEFjdGlvbigiU2NyZWVuc2hvdCIsIHRoaXMsIFNMT1Qoc2NyZWVuc2hvdCgpKSk7CiAgICAg ICAgIGZpbGVNZW51LT5hZGRBY3Rpb24oIkNsb3NlIiwgdGhpcywgU0xPVChjbG9zZSgpKSk7Cg==