30677 2009-10-22 09:07:45 -0700 Missing UnusedParam.h include when INSPECTOR is not enabled 2009-10-23 12:16:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock benm benm steveblock oldest_to_newest 156901 0 steveblock 2009-10-22 09:07:45 -0700 WebCore/page/Console.cpp and WebCore/workers/WorkerContext.cpp both use the UNUSED_PARAM macro but do not include UnusedParam.h. The macro is only used when INSPECTOR is not enabled, so the build succeeds when INSPECTOR is enabled. 156906 1 41663 steveblock 2009-10-22 09:39:24 -0700 Created attachment 41663 Patch 1 for Bug 30677 156922 2 41663 eric 2009-10-22 10:40:21 -0700 Comment on attachment 41663 Patch 1 for Bug 30677 OK, looks OK. 157133 3 41663 commit-queue 2009-10-23 02:57:33 -0700 Comment on attachment 41663 Patch 1 for Bug 30677 Rejecting patch 41663 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 135.60s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157138 4 benm 2009-10-23 03:06:20 -0700 Will land manually, looks like https://bugs.webkit.org/show_bug.cgi?id=30700 caused the cq to fail. 157149 5 benm 2009-10-23 05:56:22 -0700 Landed as r49976. 157236 6 41663 eric 2009-10-23 12:03:30 -0700 Comment on attachment 41663 Patch 1 for Bug 30677 Sorry about the commit-queue trouble. Should work fine now. 157245 7 steveblock 2009-10-23 12:09:36 -0700 benm@google.com has already landed this by hand. 41663 2009-10-22 09:39:24 -0700 2009-10-23 12:16:31 -0700 Patch 1 for Bug 30677 includeUnusedParam.txt text/plain 1447 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTk0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMjIgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgbWlzc2luZyBVbnVzZWRQYXJhbS5oIGluY2x1ZGVzLCByZXF1aXJlZCB3aGVuIElOU1BF Q1RPUiBpcyBub3QgZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMwNjc3CisKKyAgICAgICAgQnVpbGQgZml4LCBubyBuZXcgdGVzdHMgcmVx dWlyZWQuCisKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuY3BwOiBNb2RpZmllZC4gQWRkZWQgVW51 c2VkUGFyYW0uaCBpbmNsdWRlLgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5jcHA6 IE1vZGlmaWVkLiBBZGRlZCBVbnVzZWRQYXJhbS5oIGluY2x1ZGUuCisKIDIwMDktMTAtMjIgIEtl aXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9yaUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAJKHJldmlzaW9uIDQ5OTM2KQorKysg V2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw2ICs0Niw3IEBA CiAKICNpbmNsdWRlICJTY3JpcHRDYWxsU3RhY2suaCIKICNpbmNsdWRlIDxzdGRpby5oPgorI2lu Y2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKSW5kZXg6 IFdlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3dvcmtlcnMvV29ya2VyQ29udGV4dC5jcHAJKHJldmlzaW9uIDQ5OTM2KQorKysgV2ViQ29yZS93 b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw3IEBA CiAjaW5jbHVkZSAiV29ya2VyVGhyZWFkYWJsZUxvYWRlci5oIgogI2luY2x1ZGUgIlhNTEh0dHBS ZXF1ZXN0RXhjZXB0aW9uLmgiCiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgorI2luY2x1ZGUgPHd0 Zi9VbnVzZWRQYXJhbS5oPgogCiAjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCiAjaW5jbHVkZSAi Tm90aWZpY2F0aW9uQ2VudGVyLmgiCg==