30675 2009-10-22 08:39:10 -0700 Inspector injects _inspectorCommandLineAPI into global object when opened 2009-10-23 12:31:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 spamfaenger webkit-unassigned aroben commit-queue joepeck keishi pfeldman rik timothy oldest_to_newest 156887 0 41659 spamfaenger 2009-10-22 08:39:10 -0700 Created attachment 41659 Showcase of the problem This is of course disturbing my unit tests which check if I accidentally pollute the global object with any new keys. I guess this is not intentional, but instead because there is a var statement missing in front o f a variable declaration. This is a regression as Safari 4 does not behave like this. 156888 1 spamfaenger 2009-10-22 08:40:21 -0700 You may need to reload the example a few times for the problem to show up. 156889 2 spamfaenger 2009-10-22 08:40:39 -0700 Drat. With the Inspector open that is. 157076 3 41709 keishi 2009-10-22 18:18:58 -0700 Created attachment 41709 proposed patch Moved _inspectorCommandLineAPI to console. _inspectorCommandLineAPI I guess will be safer. 157129 4 41709 commit-queue 2009-10-23 02:46:55 -0700 Comment on attachment 41709 proposed patch Rejecting patch 41709 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 139.35s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157238 5 41709 eric 2009-10-23 12:04:24 -0700 Comment on attachment 41709 proposed patch Sorry about the commit-queue trouble. Should work fine now. 157256 6 41709 commit-queue 2009-10-23 12:31:02 -0700 Comment on attachment 41709 proposed patch Clearing flags on attachment: 41709 Committed r49988: <http://trac.webkit.org/changeset/49988> 157257 7 commit-queue 2009-10-23 12:31:09 -0700 All reviewed patches have been landed. Closing bug. 41659 2009-10-22 08:39:10 -0700 2009-10-22 08:39:10 -0700 Showcase of the problem reduction.html text/html 412 spamfaenger PGh0bWw+CjxoZWFkPgoJPHNjcmlwdCBzcmM9Imh0dHA6Ly9hamF4Lmdvb2dsZWFwaXMuY29tL2Fq YXgvbGlicy9qcXVlcnkvMS4zLjIvanF1ZXJ5LmpzIj48L3NjcmlwdD4KCTxzY3JpcHQ+Cgl2YXIg YmVmb3JlID0gW107Cglmb3IgKHZhciBrZXkgaW4gd2luZG93KQoJCWJlZm9yZS5wdXNoKGtleSk7 CgoJc2V0VGltZW91dCgJZnVuY3Rpb24oKXsKCQkJZm9yICh2YXIga2V5IGluIHdpbmRvdykKCQkJ CWlmICgtMSA9PT0gJC5pbkFycmF5KGtleSwgYmVmb3JlKSkKCQkJCQljb25zb2xlLmxvZygiRm91 bmQga2V5IHRoYXQgd2FzIG5vdCBwcmVzZW50IGJlZm9yZTogIiArIGtleSk7CgkJfSwgMTAwKQov Lwl3aW5kb3cubG9jYXRpb24ucmVsb2FkKCkKCTwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5PgoKPC9i b2R5Pgo8L2h0bWw+Cg== 41709 2009-10-22 18:18:58 -0700 2009-10-23 12:31:02 -0700 proposed patch fixclapi.diff text/plain 4624 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTk2MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjIgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5zcGVjdG9yIGluamVjdHMgX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJIGludG8gZ2xv YmFsIG9iamVjdCB3aGVuIG9wZW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzA2NzUKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW5q ZWN0ZWRTY3JpcHQuanM6CisgICAgICAgIChJbmplY3RlZFNjcmlwdC5nZXRDb21wbGV0aW9ucyk6 CisgICAgICAgIChJbmplY3RlZFNjcmlwdC5fZXZhbHVhdGVPbik6CisgICAgICAgIChJbmplY3Rl ZFNjcmlwdC5hZGRJbnNwZWN0ZWROb2RlKToKKyAgICAgICAgKEluamVjdGVkU2NyaXB0Ll9lbnN1 cmVDb21tYW5kTGluZUFQSUluc3RhbGxlZCk6IE1vdmVkIF9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSBmcm9tIHdpbmRvdyB0byBjb25zb2xlLgorCiAyMDA5LTEwLTIyICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIYXRjaGVyLgpJ bmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwko cmV2aXNpb24gNDk5MzcpCisrKyBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRT Y3JpcHQuanMJKHdvcmtpbmcgY29weSkKQEAgLTU0MCw3ICs1NDAsNyBAQCBJbmplY3RlZFNjcmlw dC5nZXRDb21wbGV0aW9ucyA9IGZ1bmN0aW9uCiAgICAgICAgICAgICBmb3IgKHZhciBwcm9wIGlu IGV4cHJlc3Npb25SZXN1bHQpCiAgICAgICAgICAgICAgICAgcHJvcHNbcHJvcF0gPSB0cnVlOwog ICAgICAgICBpZiAoaW5jbHVkZUluc3BlY3RvckNvbW1hbmRMaW5lQVBJKQotICAgICAgICAgICAg Zm9yICh2YXIgcHJvcCBpbiBJbmplY3RlZFNjcmlwdC5fd2luZG93KCkuX2luc3BlY3RvckNvbW1h bmRMaW5lQVBJKQorICAgICAgICAgICAgZm9yICh2YXIgcHJvcCBpbiBJbmplY3RlZFNjcmlwdC5f d2luZG93KCkuY29uc29sZS5faW5zcGVjdG9yQ29tbWFuZExpbmVBUEkpCiAgICAgICAgICAgICAg ICAgaWYgKHByb3AuY2hhckF0KDApICE9PSAnXycpCiAgICAgICAgICAgICAgICAgICAgIHByb3Bz W3Byb3BdID0gdHJ1ZTsKICAgICB9IGNhdGNoKGUpIHsKQEAgLTU3NSw3ICs1NzUsNyBAQCBJbmpl Y3RlZFNjcmlwdC5fZXZhbHVhdGVPbiA9IGZ1bmN0aW9uKGV2CiAgICAgSW5qZWN0ZWRTY3JpcHQu X2Vuc3VyZUNvbW1hbmRMaW5lQVBJSW5zdGFsbGVkKGV2YWxGdW5jdGlvbiwgb2JqZWN0KTsKICAg ICAvLyBTdXJyb3VuZCB0aGUgZXhwcmVzc2lvbiBpbiB3aXRoIHN0YXRlbWVudHMgdG8gaW5qZWN0 IG91ciBjb21tYW5kIGxpbmUgQVBJIHNvIHRoYXQKICAgICAvLyB0aGUgd2luZG93IG9iamVjdCBw cm9wZXJ0aWVzIHN0aWxsIHRha2UgbW9yZSBwcmVjZWRlbnQgdGhhbiBvdXIgQVBJIGZ1bmN0aW9u cy4KLSAgICBleHByZXNzaW9uID0gIndpdGggKHdpbmRvdy5faW5zcGVjdG9yQ29tbWFuZExpbmVB UEkpIHsgd2l0aCAod2luZG93KSB7ICIgKyBleHByZXNzaW9uICsgIiB9IH0iOworICAgIGV4cHJl c3Npb24gPSAid2l0aCAod2luZG93LmNvbnNvbGUuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJKSB7 IHdpdGggKHdpbmRvdykgeyAiICsgZXhwcmVzc2lvbiArICIgfSB9IjsKICAgICB2YXIgdmFsdWUg PSBldmFsRnVuY3Rpb24uY2FsbChvYmplY3QsIGV4cHJlc3Npb24pOwogCiAgICAgLy8gV2hlbiBl dmFsdWF0aW5nIG9uIGNhbGwgZnJhbWUgZXJyb3IgaXMgbm90IHRocm93biwgYnV0IHJldHVybmVk IGFzIGEgdmFsdWUuCkBAIC01OTIsNyArNTkyLDcgQEAgSW5qZWN0ZWRTY3JpcHQuYWRkSW5zcGVj dGVkTm9kZSA9IGZ1bmN0aQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBJbmplY3RlZFNj cmlwdC5fZW5zdXJlQ29tbWFuZExpbmVBUElJbnN0YWxsZWQoSW5qZWN0ZWRTY3JpcHQuX3dpbmRv dygpLmV2YWwsIEluamVjdGVkU2NyaXB0Ll93aW5kb3coKSk7Ci0gICAgdmFyIGluc3BlY3RlZE5v ZGVzID0gSW5qZWN0ZWRTY3JpcHQuX3dpbmRvdygpLl9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5f aW5zcGVjdGVkTm9kZXM7CisgICAgdmFyIGluc3BlY3RlZE5vZGVzID0gSW5qZWN0ZWRTY3JpcHQu X3dpbmRvdygpLmNvbnNvbGUuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJLl9pbnNwZWN0ZWROb2Rl czsKICAgICBpbnNwZWN0ZWROb2Rlcy51bnNoaWZ0KG5vZGUpOwogICAgIGlmIChpbnNwZWN0ZWRO b2Rlcy5sZW5ndGggPj0gNSkKICAgICAgICAgaW5zcGVjdGVkTm9kZXMucG9wKCk7CkBAIC05MDEs OSArOTAxLDkgQEAgSW5qZWN0ZWRTY3JpcHQuX2luc3BlY3RPYmplY3QgPSBmdW5jdGlvbgogCiBJ bmplY3RlZFNjcmlwdC5fZW5zdXJlQ29tbWFuZExpbmVBUElJbnN0YWxsZWQgPSBmdW5jdGlvbihl dmFsRnVuY3Rpb24sIGV2YWxPYmplY3QpCiB7Ci0gICAgaWYgKGV2YWxGdW5jdGlvbi5jYWxsKGV2 YWxPYmplY3QsICJ3aW5kb3cuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJIikpCisgICAgaWYgKGV2 YWxGdW5jdGlvbi5jYWxsKGV2YWxPYmplY3QsICJ3aW5kb3cuY29uc29sZS5faW5zcGVjdG9yQ29t bWFuZExpbmVBUEkiKSkKICAgICAgICAgcmV0dXJuOwotICAgIHZhciBpbnNwZWN0b3JDb21tYW5k TGluZUFQSSA9IGV2YWxGdW5jdGlvbi5jYWxsKGV2YWxPYmplY3QsICJ3aW5kb3cuX2luc3BlY3Rv ckNvbW1hbmRMaW5lQVBJID0geyBcCisgICAgdmFyIGluc3BlY3RvckNvbW1hbmRMaW5lQVBJID0g ZXZhbEZ1bmN0aW9uLmNhbGwoZXZhbE9iamVjdCwgIndpbmRvdy5jb25zb2xlLl9pbnNwZWN0b3JD b21tYW5kTGluZUFQSSA9IHsgXAogICAgICAgICAkOiBmdW5jdGlvbigpIHsgcmV0dXJuIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkLmFwcGx5KGRvY3VtZW50LCBhcmd1bWVudHMpIH0sIFwKICAgICAg ICAgJCQ6IGZ1bmN0aW9uKCkgeyByZXR1cm4gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbC5hcHBs eShkb2N1bWVudCwgYXJndW1lbnRzKSB9LCBcCiAgICAgICAgICR4OiBmdW5jdGlvbih4cGF0aCwg Y29udGV4dCkgeyBcCkBAIC05MjMsMTEgKzkyMywxMSBAQCBJbmplY3RlZFNjcmlwdC5fZW5zdXJl Q29tbWFuZExpbmVBUElJbnN0CiAgICAgICAgIHByb2ZpbGU6IGZ1bmN0aW9uKCkgeyByZXR1cm4g Y29uc29sZS5wcm9maWxlLmFwcGx5KGNvbnNvbGUsIGFyZ3VtZW50cykgfSwgXAogICAgICAgICBw cm9maWxlRW5kOiBmdW5jdGlvbigpIHsgcmV0dXJuIGNvbnNvbGUucHJvZmlsZUVuZC5hcHBseShj b25zb2xlLCBhcmd1bWVudHMpIH0sIFwKICAgICAgICAgX2luc3BlY3RlZE5vZGVzOiBbXSwgXAot ICAgICAgICBnZXQgJDAoKSB7IHJldHVybiBfaW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuX2luc3Bl Y3RlZE5vZGVzWzBdIH0sIFwKLSAgICAgICAgZ2V0ICQxKCkgeyByZXR1cm4gX2luc3BlY3RvckNv bW1hbmRMaW5lQVBJLl9pbnNwZWN0ZWROb2Rlc1sxXSB9LCBcCi0gICAgICAgIGdldCAkMigpIHsg cmV0dXJuIF9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVjdGVkTm9kZXNbMl0gfSwgXAot ICAgICAgICBnZXQgJDMoKSB7IHJldHVybiBfaW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuX2luc3Bl Y3RlZE5vZGVzWzNdIH0sIFwKLSAgICAgICAgZ2V0ICQ0KCkgeyByZXR1cm4gX2luc3BlY3RvckNv bW1hbmRMaW5lQVBJLl9pbnNwZWN0ZWROb2Rlc1s0XSB9IFwKKyAgICAgICAgZ2V0ICQwKCkgeyBy ZXR1cm4gY29uc29sZS5faW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuX2luc3BlY3RlZE5vZGVzWzBd IH0sIFwKKyAgICAgICAgZ2V0ICQxKCkgeyByZXR1cm4gY29uc29sZS5faW5zcGVjdG9yQ29tbWFu ZExpbmVBUEkuX2luc3BlY3RlZE5vZGVzWzFdIH0sIFwKKyAgICAgICAgZ2V0ICQyKCkgeyByZXR1 cm4gY29uc29sZS5faW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuX2luc3BlY3RlZE5vZGVzWzJdIH0s IFwKKyAgICAgICAgZ2V0ICQzKCkgeyByZXR1cm4gY29uc29sZS5faW5zcGVjdG9yQ29tbWFuZExp bmVBUEkuX2luc3BlY3RlZE5vZGVzWzNdIH0sIFwKKyAgICAgICAgZ2V0ICQ0KCkgeyByZXR1cm4g Y29uc29sZS5faW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuX2luc3BlY3RlZE5vZGVzWzRdIH0gXAog ICAgIH07Iik7CiAKICAgICBpbnNwZWN0b3JDb21tYW5kTGluZUFQSS5jbGVhciA9IEluc3BlY3Rv ckNvbnRyb2xsZXIud3JhcENhbGxiYWNrKEluamVjdGVkU2NyaXB0Ll9jbGVhckNvbnNvbGVNZXNz YWdlcyk7Cg==