30674 2009-10-22 07:05:26 -0700 Failed on test case: http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm 2009-11-06 10:59:01 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED INVALID P3 Normal --- 30574 1 cshu cshu oldest_to_newest 156874 0 cshu 2009-10-22 07:05:26 -0700 Run test case on any WebKit browsers: http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm Expected result: the color of the link should be green Actual result: the color of the link is red 159385 1 42222 cshu 2009-10-30 11:43:13 -0700 Created attachment 42222 fix patch This patch does not have test case yet as I just want to make sure the code change is fine. 159400 2 42222 darin 2009-10-30 12:23:01 -0700 Comment on attachment 42222 fix patch This only patches the Qt-specific code path, not the normal platform-independent one. It’s also not the best practice to post a patch knowingly leaving out the test you plan to make. It creates more work for reviewers who have to review it twice even if there’s nothing wrong with it. It’s better engineering to write the test before the bug fix -- you need to make sure it fails without the code change. 159439 3 cshu 2009-10-30 14:04:05 -0700 (In reply to comment #2) > (From update of attachment 42222 [details]) > This only patches the Qt-specific code path, not the normal > platform-independent one. It’s also not the best practice to post a patch > knowingly leaving out the test you plan to make. It creates more work for > reviewers who have to review it twice even if there’s nothing wrong with it. > It’s better engineering to write the test before the bug fix -- you need to > make sure it fails without the code change. Thanks very much for the comments. I will take care of the test cases soon. 160826 4 cshu 2009-11-05 07:52:30 -0800 It turns out that none of the major browsers: IE, Firefox, Safari, supports this. As a result, I have to cancel the review process. If nobody rejects, I will mark this bug as resolved. Is this the right procedure? 42222 2009-10-30 11:43:13 -0700 2009-10-30 12:23:01 -0700 fix patch bug30674_1.patch text/plain 1319 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTk4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMjMgIFNodSBDaGFuZyAgPENoYW5nLlNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVy IFJGQzIzOTYsICJhbiBlbXB0eSBVUkkgcmVmZXJlbmNlIHdpdGhpbiBhIGRvY3VtZW50IGlzIGlu dGVycHJldGVkCisgICAgICAgIGFzIGEgcmVmZXJlbmNlIHRvIHRoZSBzdGFydCBvZiB0aGF0IGRv Y3VtZW50LiIgQXMgYSByZXN1bHQsIGFuIGVtcHR5IGxpbmsKKyAgICAgICAgc2hvdWxkIGJlIHRy ZWF0ZWQgYXMgdmlzaXRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMwNjc0CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAg ICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHls ZVNlbGVjdG9yOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrUHNldWRvU3RhdGUpOgorCiAyMDA5LTEw LTIzICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3Iu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZp c2lvbiA0OTk4MikKKysrIFdlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC04OTEsNyArODkxLDcgQEAgUHNldWRvU3RhdGUgQ1NTU3R5bGVTZWxlY3Rvcjo6 U2VsZWN0b3JDaAogICAgIFZlY3RvcjxVQ2hhciwgNTEyPiB1cmw7CiAgICAgdmlzaXRlZFVSTCht X2RvY3VtZW50LT5iYXNlVVJMKCksICphdHRyLCB1cmwpOwogICAgIGlmICh1cmwuaXNFbXB0eSgp KQotICAgICAgICByZXR1cm4gUHNldWRvTGluazsKKyAgICAgICAgcmV0dXJuIFBzZXVkb1Zpc2l0 ZWQ7CiAKICAgICAvLyBJZiB0aGUgUXQ0LjQgaW50ZXJmYWNlIGZvciB0aGUgaGlzdG9yeSBpcyB1 c2VkLCB3ZSB3aWxsIGhhdmUgdG8gZmFsbGJhY2sKICAgICAvLyB0byB0aGUgb2xkIGdsb2JhbCBo aXN0b3J5Lgo=