306673 2026-01-30 17:33:57 -0800 [ITP] Crash in ResourceLoadStatisticsStore::ensureResourceStatisticsForRegistrableDomain due to unsafe std::optional access 2026-02-02 18:37:42 -0800 1 1 1 Unclassified WebKit Website Storage WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer sihui_liu webkit-bug-importer oldest_to_newest 2176764 0 ddkilzer 2026-01-30 17:33:57 -0800 ResourceLoadStatisticsStore::ensureResourceStatisticsForRegistrableDomain() crashes with `std::bad_optional_access` when calling `.value()` on an empty `std::optional<unsigned>` returned by `domainID(domain)`. The crash occurs when: 1. `insertObservedDomain()` successfully inserts a domain into the database 2. `domainID(domain)` immediately fails to find the just-inserted domain, returning `std::nullopt` 3. Calling `.value()` on the empty optional throws `std::bad_optional_access` 4. C++ runtime calls `abort()`, terminating the process Stack trace: ``` 0 libsystem_c.dylib: abort 1 libc++.1.dylib: std::bad_optional_access 2 libc++.1.dylib: std::optional<unsigned>::value 3 WebKit: WebKit::ResourceLoadStatisticsStore::domainID 4 WebKit: WebKit::ResourceLoadStatisticsStore::insertObservedDomain 5 WebKit: WebKit::ResourceLoadStatisticsStore::ensureResourceStatisticsForRegistrableDomain 6 WebKit: WebKit::ResourceLoadStatisticsStore::setIsScheduledForAllScriptWrittenStorageRemoval [...] ``` <rdar://167532652> 2176765 1 ddkilzer 2026-01-30 17:33:58 -0800 The fix replaces the unsafe `.value()` call with proper optional checking and error recovery. Also fixes a misleading error message. Testing notes: Unable to write a test since it would require removing a just-inserted domain from the database using an unknown mechanism external to ensureResourceStatisticsForRegistrableDomain(). No change in behavior for successful operations, only improves error handling for edge cases. 2176772 2 ddkilzer 2026-01-30 18:16:08 -0800 Pull request: https://github.com/WebKit/WebKit/pull/57608 2177379 3 ews-feeder 2026-02-02 18:37:40 -0800 Committed 306672@main (215b7246a621): <https://commits.webkit.org/306672@main> Reviewed commits have been landed. Closing PR #57608 and removing active labels.