30663 2009-10-21 23:20:24 -0700 Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive" 2009-10-22 14:09:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck aroben bweinstein joepeck pfeldman rik timothy oldest_to_newest 156797 0 joepeck 2009-10-21 23:20:24 -0700 The style class "inactive" is not getting added to the body. It is used numerous times in the CSS. 156800 1 41639 joepeck 2009-10-21 23:24:21 -0700 Created attachment 41639 [PATCH] Check document.defaultView The events are registered on a doc.defaultView: doc.defaultView.addEventListener("focus", this.windowFocused.bind(this), true); doc.defaultView.addEventListener("blur", this.windowBlured.bind(this), true); The doc.defaultView is a DOMWindow. Old behavior always fails: if (event.target.nodeType === Node.DOCUMENT_NODE) New behavior tests against the defaultView: if (event.target === document.defaultView) 156801 2 joepeck 2009-10-21 23:38:14 -0700 NOTE TO SELF: the function should be renamed to "windowBlurred" to fix the typo. 156882 3 41639 pfeldman 2009-10-22 07:41:14 -0700 Comment on attachment 41639 [PATCH] Check document.defaultView Fix the Reviewed by :P. 156886 4 joepeck 2009-10-22 08:29:31 -0700 Landed in http://trac.webkit.org/changeset/49939 r49939 = 4a2c682da0e4de665ca85ef024415a8bdaf830b0 156898 5 41639 timothy 2009-10-22 08:56:01 -0700 Comment on attachment 41639 [PATCH] Check document.defaultView The WebInspector.windowFocused and WebInspector.windowBlured functions are registered on iframes too. So this will break break for iframes. Try clicking in a Resource source frame, the Inspector should not become "inactive" then. SourceFrame.js _loaded calls: WebInspector.addMainEventListeners(this.element.contentDocument); 156899 6 timothy 2009-10-22 08:57:02 -0700 Maybe you were seeing it fire twice because you were testing with a source frame? 156995 7 41680 joepeck 2009-10-22 13:35:58 -0700 Created attachment 41680 [PATCH] Handle Focus/Blur of inner <iframe>s Because focus/blur do not tell you _what_ they are focusing on there has to be a bit of co-dependence between the focus/blur: - Blur runs first, if you're blurring any inner document, always add "inactive" - Focus runs next, if you're focusing on any inner document, remove "inactive" Changing useCapture to false no longer fires duplicate blur/focus events. This was happening when clicking a toolbar (when they were in their :active state). Could be a bug in itself, and may require some investigation. 156997 8 joepeck 2009-10-22 13:39:22 -0700 (In reply to comment #7) > Changing useCapture to false no longer fires duplicate blur/focus events. Oh, this also makes it so event.target is what we expect it to be (doc.defaultView a DOMWindow) so the following should never blow up with an undefined for document: event.target.document.nodeType 157006 9 joepeck 2009-10-22 14:09:31 -0700 Landed Second Patch in http://trac.webkit.org/changeset/49956 r49956 = 3ba0b1d4a6414ecd8dc61d94fe35153b36c04eae 41639 2009-10-21 23:24:21 -0700 2009-10-22 13:35:58 -0700 [PATCH] Check document.defaultView blur.patch text/plain 1314 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmRlYWI0YS4uNTBmNDgxMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMC0yMSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkg SGF0Y2hlci4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB3aW5kb3dGb2N1c2VkIGFuZCB3aW5k b3dCbHVyZWQgRmFpbCB0byBDbGVhci9NYXJrIEluc3BlY3RvciBhcyAiaW5hY3RpdmUiCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDY2MworCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3Iud2luZG93Rm9jdXNlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iud2luZG93Qmx1cmVk KToKKwogMjAwOS0xMC0yMCAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IDE3YjAyYTEuLjlhMTI0MGMgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNTExLDEzICs1MTEsMTMgQEAgV2Vi SW5zcGVjdG9yLndpbmRvd1Jlc2l6ZSA9IGZ1bmN0aW9uKGV2ZW50KQogCiBXZWJJbnNwZWN0b3Iu d2luZG93Rm9jdXNlZCA9IGZ1bmN0aW9uKGV2ZW50KQogewotICAgIGlmIChldmVudC50YXJnZXQu bm9kZVR5cGUgPT09IE5vZGUuRE9DVU1FTlRfTk9ERSkKKyAgICBpZiAoZXZlbnQudGFyZ2V0ID09 PSBkb2N1bWVudC5kZWZhdWx0VmlldykKICAgICAgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVTdHls ZUNsYXNzKCJpbmFjdGl2ZSIpOwogfQogCiBXZWJJbnNwZWN0b3Iud2luZG93Qmx1cmVkID0gZnVu Y3Rpb24oZXZlbnQpCiB7Ci0gICAgaWYgKGV2ZW50LnRhcmdldC5ub2RlVHlwZSA9PT0gTm9kZS5E T0NVTUVOVF9OT0RFKQorICAgIGlmIChldmVudC50YXJnZXQgPT09IGRvY3VtZW50LmRlZmF1bHRW aWV3KQogICAgICAgICBkb2N1bWVudC5ib2R5LmFkZFN0eWxlQ2xhc3MoImluYWN0aXZlIik7CiB9 CiAK 41680 2009-10-22 13:35:58 -0700 2009-10-22 13:57:18 -0700 [PATCH] Handle Focus/Blur of inner <iframe>s handle_iframes.patch text/plain 2495 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2UzNDk5My4uYWViODViYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0yMiAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHdpbmRvd0ZvY3VzZWQgYW5kIHdpbmRv d0JsdXJlZCBGYWlsIHRvIENsZWFyL01hcmsgSW5zcGVjdG9yIGFzICJpbmFjdGl2ZSIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjYzCisKKyAgICAg ICAgICBDb3JyZWN0bHkgaGFuZGxlIGZvY3VzaW5nL2JsdXJyaW5nIG9uIGlubmVyIDxpZnJhbWU+ J3Mgc3VjaCBhcyBTb3VyY2UgRnJhbWVzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iud2luZG93Rm9jdXNlZCk6IGZp eCBmb3IgaW5uZXIgaWZyYW1lcworICAgICAgICAoV2ViSW5zcGVjdG9yLndpbmRvd0JsdXJyZWQp OiBmaXggZm9yIGlubmVyIGlmcmFtZXMKKyAgICAgICAgKFdlYkluc3BlY3Rvci5hZGRNYWluRXZl bnRMaXN0ZW5lcnMpOiBjaGFuZ2UgdXNlQ2FwdHVyZSB0byBmYWxzZQorCiAyMDA5LTEwLTIxICBK b3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpz CmluZGV4IGY1MWYzMWIuLmE1NmJlOTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2lu c3BlY3Rvci5qcwpAQCAtNTExLDEzICs1MTEsMTkgQEAgV2ViSW5zcGVjdG9yLndpbmRvd1Jlc2l6 ZSA9IGZ1bmN0aW9uKGV2ZW50KQogCiBXZWJJbnNwZWN0b3Iud2luZG93Rm9jdXNlZCA9IGZ1bmN0 aW9uKGV2ZW50KQogewotICAgIGlmIChldmVudC50YXJnZXQgPT09IGRvY3VtZW50LmRlZmF1bHRW aWV3KQorICAgIC8vIEZpcmVzIGFmdGVyIGJsdXIsIHNvIHdoZW4gZm9jdXNpbmcgb24gZWl0aGVy IHRoZSBtYWluIGluc3BlY3RvcgorICAgIC8vIG9yIGFuIDxpZnJhbWU+IHdpdGhpbiB0aGUgaW5z cGVjdG9yIHdlIHNob3VsZCBhbHdheXMgcmVtb3ZlIHRoZQorICAgIC8vICJpbmFjdGl2ZSIgY2xh c3MuCisgICAgaWYgKGV2ZW50LnRhcmdldC5kb2N1bWVudC5ub2RlVHlwZSA9PT0gTm9kZS5ET0NV TUVOVF9OT0RFKQogICAgICAgICBkb2N1bWVudC5ib2R5LnJlbW92ZVN0eWxlQ2xhc3MoImluYWN0 aXZlIik7CiB9CiAKIFdlYkluc3BlY3Rvci53aW5kb3dCbHVycmVkID0gZnVuY3Rpb24oZXZlbnQp CiB7Ci0gICAgaWYgKGV2ZW50LnRhcmdldCA9PT0gZG9jdW1lbnQuZGVmYXVsdFZpZXcpCisgICAg Ly8gTGVhdmluZyB0aGUgbWFpbiBpbnNwZWN0b3Igb3IgYW4gPGlmcmFtZT4gd2l0aGluIHRoZSBp bnNwZWN0b3IuCisgICAgLy8gV2UgY2FuIGFkZCAiaW5hY3RpdmUiIG5vdywgYW5kIGlmIHdlIGFy ZSBtb3ZpbmcgdGhlIGZvY3VzIHRvIGFub3RoZXIKKyAgICAvLyBwYXJ0IG9mIHRoZSBpbnNwZWN0 b3IgdGhlbiB3aW5kb3dGb2N1c2VkIHdpbGwgY29ycmVjdCB0aGlzLgorICAgIGlmIChldmVudC50 YXJnZXQuZG9jdW1lbnQubm9kZVR5cGUgPT09IE5vZGUuRE9DVU1FTlRfTk9ERSkKICAgICAgICAg ZG9jdW1lbnQuYm9keS5hZGRTdHlsZUNsYXNzKCJpbmFjdGl2ZSIpOwogfQogCkBAIC0xNDIzLDgg KzE0MjksOCBAQCBXZWJJbnNwZWN0b3IubGlua2lmeVVSTCA9IGZ1bmN0aW9uKHVybCwgbGlua1Rl eHQsIGNsYXNzZXMsIGlzRXh0ZXJuYWwpCiAKIFdlYkluc3BlY3Rvci5hZGRNYWluRXZlbnRMaXN0 ZW5lcnMgPSBmdW5jdGlvbihkb2MpCiB7Ci0gICAgZG9jLmRlZmF1bHRWaWV3LmFkZEV2ZW50TGlz dGVuZXIoImZvY3VzIiwgdGhpcy53aW5kb3dGb2N1c2VkLmJpbmQodGhpcyksIHRydWUpOwotICAg IGRvYy5kZWZhdWx0Vmlldy5hZGRFdmVudExpc3RlbmVyKCJibHVyIiwgdGhpcy53aW5kb3dCbHVy cmVkLmJpbmQodGhpcyksIHRydWUpOworICAgIGRvYy5kZWZhdWx0Vmlldy5hZGRFdmVudExpc3Rl bmVyKCJmb2N1cyIsIHRoaXMud2luZG93Rm9jdXNlZC5iaW5kKHRoaXMpLCBmYWxzZSk7CisgICAg ZG9jLmRlZmF1bHRWaWV3LmFkZEV2ZW50TGlzdGVuZXIoImJsdXIiLCB0aGlzLndpbmRvd0JsdXJy ZWQuYmluZCh0aGlzKSwgZmFsc2UpOwogICAgIGRvYy5hZGRFdmVudExpc3RlbmVyKCJjbGljayIs IHRoaXMuZG9jdW1lbnRDbGljay5iaW5kKHRoaXMpLCB0cnVlKTsKIH0KIAo=