30657 2009-10-21 18:52:04 -0700 video-played.js uses too short of a timeout 2009-10-22 08:53:23 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 scherkus webkit-unassigned commit-queue eric.carlson oldest_to_newest 156749 0 scherkus 2009-10-21 18:52:04 -0700 We have issues running LayoutTest/media/video-played-*.html family of tests because the error timeout is too aggressive. Since it's based on reaching 10 call counts, tests that use a short delay will result in a tight window to meet the deadline. For example: playForMillisecs(100) -> 100 x 10 = 1 second deadline playForMillisecs(30) -> 30 x 10 = 300 millisecond deadline I propose letting call counts go wild while measuring the actual time elapsed. 156750 1 41628 scherkus 2009-10-21 18:55:12 -0700 Created attachment 41628 Round 1 No change to expectations required. Passing on WebKit Mac. 156867 2 41628 eric.carlson 2009-10-22 06:27:57 -0700 Comment on attachment 41628 Round 1 Nice change, thanks! r=me 156895 3 41628 commit-queue 2009-10-22 08:53:19 -0700 Comment on attachment 41628 Round 1 Clearing flags on attachment: 41628 Committed r49941: <http://trac.webkit.org/changeset/49941> 156896 4 commit-queue 2009-10-22 08:53:23 -0700 All reviewed patches have been landed. Closing bug. 41628 2009-10-21 18:55:12 -0700 2009-10-22 08:53:19 -0700 Round 1 video_played.patch text/plain 2266 scherkus ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNTEzOGZiLi41ODQzZmE4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAt MjEgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdmlkZW8tcGxheWVkLmpz IHRvIHVzZSBhbiBlcnJvciB0aW1lb3V0IGJhc2VkIG9uIHRpbWUgcmF0aGVyIHRoYW4gZnVuY3Rp b24gY2FsbCBjb3VudC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzA2NTcKKworICAgICAgICAqIG1lZGlhL3ZpZGVvLXBsYXllZC5qczoKKyAgICAg ICAgKG5vd0luU2Vjcyk6IFJldHVybnMgdGhlIGN1cnJlbnQgdGltZSBpbiBzZWNvbmRzLgorICAg ICAgICAocGxheUZvck1pbGxpc2Vjcy5jYWxsUGF1c2VJZlRpbWVJc1JlYWNoZWQpOiBDaGFuZ2Ug ZnJvbSBjYWxsIGNvdW50cyB0byB1c2luZyBlbGFwc2VkIHRpbWUuCisgICAgICAgIChwbGF5Rm9y TWlsbGlzZWNzKTogRGl0dG8uCisKIDIwMDktMTAtMjAgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2Fs aWEuY29tPgogCiAgICAgICAgIEFub3RoZXIgYmF0Y2ggb2Ygc2tpcHBlZCB0ZXN0cyB3aXRoIGxp bmtzIHRvIHRoZWlyIGJ1Z3MuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1w bGF5ZWQuanMgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5ZWQuanMKaW5kZXggNTc3NDk2 OC4uYTZhMmU4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGxheWVkLmpz CisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXllZC5qcwpAQCAtOTYsNiArOTYsMTEg QEAgZnVuY3Rpb24gbWlsbGlUb1NlY3MobWlsbGlzZWNvbmRzKQogICAgIHJldHVybiBtaWxsaXNl Y29uZHMgLyAxMDAwOwogfQogCitmdW5jdGlvbiBub3dJblNlY3MoKQoreworICAgIHJldHVybiBt aWxsaVRvU2VjcygobmV3IERhdGUoKSkuZ2V0VGltZSgpKTsKK30KKwogZnVuY3Rpb24gcGxheUZv ck1pbGxpc2VjcyhtaWxsaXNlY29uZHMpCiB7CiAgICAgaWYgKG1pbGxpVG9TZWNzKG1pbGxpc2Vj b25kcykgPiB2aWRlby5kdXJhdGlvbikgewpAQCAtMTA1LDggKzExMCw4IEBAIGZ1bmN0aW9uIHBs YXlGb3JNaWxsaXNlY3MobWlsbGlzZWNvbmRzKQogCiAgICAgcnVuKCJ2aWRlby5wbGF5KCkiKTsK IAorICAgIHZhciBzdGFydFRpbWUgPSBub3dJblNlY3MoKTsKICAgICB2YXIgcGxheWVkRnJvbVRp bWUgPSB2aWRlby5jdXJyZW50VGltZTsKLSAgICB2YXIgY2FsbENvdW50ID0gMDsKICAgICB2YXIg cGxheUR1cmF0aW9uID0gbWlsbGlUb1NlY3MobWlsbGlzZWNvbmRzKTsKICAgICB2YXIgY2FsbFBh dXNlSWZUaW1lSXNSZWFjaGVkID0gZnVuY3Rpb24gKCkKICAgICB7CkBAIC0xMTcsMTEgKzEyMiwx MSBAQCBmdW5jdGlvbiBwbGF5Rm9yTWlsbGlzZWNzKG1pbGxpc2Vjb25kcykKICAgICAgICAgICAg IC8vIEF0IHRoZSBiZWdpbmluZyBvZiBwbGF5Rm9yTWlsbGlzZWNzKCkKICAgICAgICAgICAgIHBs YXllZFRpbWUgPSB2aWRlby5kdXJhdGlvbiAtIHBsYXllZEZyb21UaW1lICsgdmlkZW8uY3VycmVu dFRpbWU7CiAgICAgICAgIH0KLSAgICAgICAgCi0gICAgICAgIGlmIChjYWxsQ291bnQrKyA+IDEw KSB7CisKKyAgICAgICAgdmFyIGVsYXBzZWQgPSBub3dJblNlY3MoKSAtIHN0YXJ0VGltZTsKKyAg ICAgICAgaWYgKGVsYXBzZWQgPiAyKSB7CiAgICAgICAgICAgICAvLyBKdXN0IGluIGNhc2Ugc29t ZXRoaW5nIGdvZXMgd3JvbmcuCi0gICAgICAgICAgICB2YXIgZWxhcHNlZCA9IG1pbGxpVG9TZWNz KGNhbGxDb3VudCAqIG1pbGxpc2Vjb25kcyk7Ci0gICAgICAgICAgICBmYWlsVGVzdCgiRVJST1I6 IHRlc3Qgc3RhbGxlZCwgd2FpdGVkICIgKyBtaWxsaVRvU2VjcyhlbGFwc2VkKSArICJzZWNvbmRz IGZvciBtb3ZpZSB0byBwbGF5ICIgKyBwbGF5ZWRUaW1lICsgIiBzZWNvbmRzIik7CisgICAgICAg ICAgICBmYWlsVGVzdCgiRVJST1I6IHRlc3Qgc3RhbGxlZCwgd2FpdGVkICIgKyBlbGFwc2VkICsg IiBzZWNvbmRzIGZvciBtb3ZpZSB0byBwbGF5ICIgKyBwbGF5ZWRUaW1lICsgIiBzZWNvbmRzIik7 CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgCg==