30656 2009-10-21 18:42:45 -0700 Fix calculation of length in WebSocketChannel.cpp 2009-10-22 01:32:12 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned commit-queue oldest_to_newest 156747 0 ukai 2009-10-21 18:42:45 -0700 length = length * 128 + *p & 0x7f; is wrong, because & is less precedence than +. 156748 1 41627 ukai 2009-10-21 18:45:59 -0700 Created attachment 41627 Fix calculation of length in WebSocketChannel.cpp 156807 2 41627 ap 2009-10-21 23:57:04 -0700 Comment on attachment 41627 Fix calculation of length in WebSocketChannel.cpp r=me Will this covered by layout tests once we have them? 156814 3 ukai 2009-10-22 00:05:46 -0700 (In reply to comment #2) > (From update of attachment 41627 [details]) > r=me > > Will this covered by layout tests once we have them? Well, how about the following data sequence? 0x81 0x81 0xCC 0x00 "unexpected data" 0xFF It must skip 129 bytes after second 0x81, but wrong code gets 1 as length, so it would receive "unexpected data" unexpectedly. 156816 4 41627 commit-queue 2009-10-22 00:11:31 -0700 Comment on attachment 41627 Fix calculation of length in WebSocketChannel.cpp Clearing flags on attachment: 41627 Committed r49932: <http://trac.webkit.org/changeset/49932> 156818 5 commit-queue 2009-10-22 00:11:35 -0700 All reviewed patches have been landed. Closing bug. 156834 6 ukai 2009-10-22 01:32:12 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 41627 [details] [details]) > > r=me > > > > Will this covered by layout tests once we have them? > > Well, how about the following data sequence? > 0x81 0x81 0xCC 0x00 "unexpected data" 0xFF Oops. should be 0x80 0x81 0x81 0xCC 0x00 "unexpected data" 0xFF > > It must skip 129 bytes after second 0x81, but wrong code gets 1 as length, so > it would receive "unexpected data" unexpectedly. 41627 2009-10-21 18:45:59 -0700 2009-10-22 00:11:31 -0700 Fix calculation of length in WebSocketChannel.cpp bug-30656-20091022104557.patch text/plain 1126 ukai ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGY2M2NmNS4uNzczZjliOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0yMSAgRnVtaXRvc2hpIFVr YWkgIDx1a2FpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY2FsY3VsYXRpb24gb2YgbGVuZ3RoIGluIFdlYlNvY2tldENo YW5uZWwuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMDY1NgorCisgICAgICAgICogd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVEYXRhKToKKwogMjAw OS0xMC0yMSAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvd2Vic29j a2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcCBiL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRD aGFubmVsLmNwcAppbmRleCAxNDVjZDM0Li41Y2JiZDI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dl YnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAKKysrIGIvV2ViQ29yZS93ZWJzb2NrZXRzL1dl YlNvY2tldENoYW5uZWwuY3BwCkBAIC0xODQsNyArMTg0LDcgQEAgdm9pZCBXZWJTb2NrZXRDaGFu bmVsOjpkaWRSZWNlaXZlRGF0YShTb2NrZXRTdHJlYW1IYW5kbGUqIGhhbmRsZSwgY29uc3QgY2hh ciogZGEKICAgICAgICAgICAgICAgICAgICAgaGFuZGxlLT5jbG9zZSgpOwogICAgICAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIGxlbmd0 aCA9IGxlbmd0aCAqIDEyOCArICpwICYgMHg3ZjsKKyAgICAgICAgICAgICAgICBsZW5ndGggPSBs ZW5ndGggKiAxMjggKyAoKnAgJiAweDdmKTsKICAgICAgICAgICAgICAgICArK3A7CiAgICAgICAg ICAgICB9CiAgICAgICAgICAgICBpZiAocCArIGxlbmd0aCA8IGVuZCkgew==