30650 2009-10-21 16:21:46 -0700 Need a way to enable/disable functions in V8 at runtime 2009-10-21 17:04:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi atwilson dglazkov oldest_to_newest 156698 0 dumi 2009-10-21 16:21:46 -0700 We need a way to enable/disable functions in V8 at runtime, just like we do it for properties (bug 30240). 156706 1 41619 dumi 2009-10-21 16:34:44 -0700 Created attachment 41619 patch 156708 2 41619 eric 2009-10-21 16:37:21 -0700 Comment on attachment 41619 patch Indent looks wrong. 156709 3 41619 dglazkov 2009-10-21 16:39:45 -0700 Comment on attachment 41619 patch r=me. 156719 4 41622 dumi 2009-10-21 16:50:56 -0700 Created attachment 41622 patch Fixed the indent issue. 156722 5 41622 eric 2009-10-21 16:53:03 -0700 Comment on attachment 41622 patch r+ based mostly on dglazkov's previous r+ 156730 6 dumi 2009-10-21 17:04:42 -0700 Landed as r49929. 41619 2009-10-21 16:34:44 -0700 2009-10-21 16:50:56 -0700 patch patch text/plain 2020 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTkyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMjEgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRpbmcgdGhlIGFiaWxpdHkgdG8gZW5hYmxlL2Rpc2FibGUgZnVuY3Rpb25zIGluIFY4IGF0 IHJ1bnRpbWUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwNjUwCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bToKKwogMjAwOS0xMC0yMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgU3dlZGlzaCBzZWFyY2ggKGFuZCBvdGhlciBsYW5ndWFnZXMgYXMgd2VsbCkgaXMgYnJva2Vu IHdoaWxlIGZpeGluZyBKYXBhbmVzZSBzZWFyY2gKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNDk5MjQpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIy LDYgKzEzMjIsMTMgQEAgRU5ECiAgICAgICAgICAgICAkdGVtcGxhdGUgPSAiaW5zdGFuY2UiOwog ICAgICAgICB9CiAKKyAgICAgICAgbXkgJGNvbmRpdGlvbmFsID0gIiI7CisgICAgICAgIGlmICgk YXR0ckV4dC0+eyJFbmFibGVkQXRSdW50aW1lIn0pIHsKKyAgICAgICAgICAjIE9ubHkgY2FsbCBT ZXQoKS9TZXRBY2Nlc3NvcigpIGlmIHRoaXMgbWV0aG9kIHNob3VsZCBiZSBlbmFibGVkCisgICAg ICAgICAgJGVuYWJsZV9mdW5jdGlvbiA9ICRpbnRlcmZhY2VOYW1lIC4gJGNvZGVHZW5lcmF0b3It PldLX3VjZmlyc3QoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUpOworICAgICAgICAgICRjb25k aXRpb25hbCA9ICJpZiAoVjhDdXN0b206OnY4JHtlbmFibGVfZnVuY3Rpb259RW5hYmxlZCgpKVxu IjsKKyAgICAgICAgfQorCiAgICAgICAgIGlmICgkYXR0ckV4dC0+eyJEb05vdENoZWNrRG9tYWlu U2VjdXJpdHkifSAmJgogICAgICAgICAgICAgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IkNoZWNrRG9tYWluU2VjdXJpdHkifSB8fCAkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93 IikpIHsKICAgICAgICAgICAgICMgTWFyayB0aGUgYWNjZXNzb3IgYXMgUmVhZE9ubHkgYW5kIHNl dCBpdCBvbiB0aGUgcHJvdG8gb2JqZWN0IHNvCkBAIC0xMzQyLDcgKzEzNDksNyBAQCBFTkQKICAg ICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CiAKICAgLy8gJGNvbW1lbnRJbmZv Ci0gICR0ZW1wbGF0ZS0+U2V0QWNjZXNzb3IoCisgICRjb25kaXRpb25hbCAkdGVtcGxhdGUtPlNl dEFjY2Vzc29yKAogICAgICAgdjg6OlN0cmluZzo6TmV3KCIkbmFtZSIpLAogICAgICAgJHtpbnRl cmZhY2VOYW1lfUludGVybmFsOjoke25hbWV9QXR0ckdldHRlciwKICAgICAgIDAsCkBAIC0xMzcw LDcgKzEzNzcsNyBAQCBFTkQKICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CiAKICAg Ly8gJGNvbW1lbnRJbmZvCi0gICR7dGVtcGxhdGV9LT5TZXQoCisgICRjb25kaXRpb25hbCAke3Rl bXBsYXRlfS0+U2V0KAogICAgICAgdjg6OlN0cmluZzo6TmV3KCIkbmFtZSIpLAogICAgICAgJHRl bXBsYXRlRnVuY3Rpb24sCiAgICAgICBzdGF0aWNfY2FzdDx2ODo6UHJvcGVydHlBdHRyaWJ1dGU+ KCRwcm9wZXJ0eV9hdHRyaWJ1dGVzKSk7Cg== 41622 2009-10-21 16:50:56 -0700 2009-10-21 16:53:03 -0700 patch patch text/plain 2026 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTkyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMjEgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRpbmcgdGhlIGFiaWxpdHkgdG8gZW5hYmxlL2Rpc2FibGUgZnVuY3Rpb25zIGluIFY4IGF0 IHJ1bnRpbWUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwNjUwCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bToKKwogMjAwOS0xMC0yMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgU3dlZGlzaCBzZWFyY2ggKGFuZCBvdGhlciBsYW5ndWFnZXMgYXMgd2VsbCkgaXMgYnJva2Vu IHdoaWxlIGZpeGluZyBKYXBhbmVzZSBzZWFyY2gKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNDk5MjQpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIy LDYgKzEzMjIsMTMgQEAgRU5ECiAgICAgICAgICAgICAkdGVtcGxhdGUgPSAiaW5zdGFuY2UiOwog ICAgICAgICB9CiAKKyAgICAgICAgbXkgJGNvbmRpdGlvbmFsID0gIiI7CisgICAgICAgIGlmICgk YXR0ckV4dC0+eyJFbmFibGVkQXRSdW50aW1lIn0pIHsKKyAgICAgICAgICAgICMgT25seSBjYWxs IFNldCgpL1NldEFjY2Vzc29yKCkgaWYgdGhpcyBtZXRob2Qgc2hvdWxkIGJlIGVuYWJsZWQKKyAg ICAgICAgICAgICRlbmFibGVfZnVuY3Rpb24gPSAkaW50ZXJmYWNlTmFtZSAuICRjb2RlR2VuZXJh dG9yLT5XS191Y2ZpcnN0KCRmdW5jdGlvbi0+c2lnbmF0dXJlLT5uYW1lKTsKKyAgICAgICAgICAg ICRjb25kaXRpb25hbCA9ICJpZiAoVjhDdXN0b206OnY4JHtlbmFibGVfZnVuY3Rpb259RW5hYmxl ZCgpKVxuIjsKKyAgICAgICAgfQorCiAgICAgICAgIGlmICgkYXR0ckV4dC0+eyJEb05vdENoZWNr RG9tYWluU2VjdXJpdHkifSAmJgogICAgICAgICAgICAgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57IkNoZWNrRG9tYWluU2VjdXJpdHkifSB8fCAkaW50ZXJmYWNlTmFtZSBlcSAiRE9N V2luZG93IikpIHsKICAgICAgICAgICAgICMgTWFyayB0aGUgYWNjZXNzb3IgYXMgUmVhZE9ubHkg YW5kIHNldCBpdCBvbiB0aGUgcHJvdG8gb2JqZWN0IHNvCkBAIC0xMzQyLDcgKzEzNDksNyBAQCBF TkQKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CiAKICAgLy8gJGNvbW1l bnRJbmZvCi0gICR0ZW1wbGF0ZS0+U2V0QWNjZXNzb3IoCisgICRjb25kaXRpb25hbCAkdGVtcGxh dGUtPlNldEFjY2Vzc29yKAogICAgICAgdjg6OlN0cmluZzo6TmV3KCIkbmFtZSIpLAogICAgICAg JHtpbnRlcmZhY2VOYW1lfUludGVybmFsOjoke25hbWV9QXR0ckdldHRlciwKICAgICAgIDAsCkBA IC0xMzcwLDcgKzEzNzcsNyBAQCBFTkQKICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7 CiAKICAgLy8gJGNvbW1lbnRJbmZvCi0gICR7dGVtcGxhdGV9LT5TZXQoCisgICRjb25kaXRpb25h bCAke3RlbXBsYXRlfS0+U2V0KAogICAgICAgdjg6OlN0cmluZzo6TmV3KCIkbmFtZSIpLAogICAg ICAgJHRlbXBsYXRlRnVuY3Rpb24sCiAgICAgICBzdGF0aWNfY2FzdDx2ODo6UHJvcGVydHlBdHRy aWJ1dGU+KCRwcm9wZXJ0eV9hdHRyaWJ1dGVzKSk7Cg==