30639 2009-10-21 11:24:31 -0700 "Paste and Match Style" doesn't fire the dom paste event 2010-01-11 01:21:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony abarth commit-queue daniel.danilatos darin eric ian jparent ojan oldest_to_newest 156569 0 tony 2009-10-21 11:24:31 -0700 If I paste into a text field using Paste and Match Style, a paste event isn't fired. It looks like Editor::pasteAsPlainText doesn't fire the dom event. In Editor::paste, the event is fired by tryDHTMLPaste. Anyway, patch coming up. 156605 1 41598 tony 2009-10-21 12:19:55 -0700 Created attachment 41598 Patch v1 156606 2 41599 tony 2009-10-21 12:25:56 -0700 Created attachment 41599 Patch v1 156657 3 41599 darin 2009-10-21 14:59:44 -0700 Comment on attachment 41599 Patch v1 In this case, how would the DHTML paste handler know that this is a plain-text paste? 156671 4 tony 2009-10-21 15:47:12 -0700 (In reply to comment #3) > (From update of attachment 41599 [details]) > In this case, how would the DHTML paste handler know that this is a plain-text > paste? You're right, the paste handler wouldn't know. To provide some context, this was requested by people working on Google Wave and other rich text editors. Normally you want to watch for paste events so you can know when to start an autosave of editable text. Not firing an event at all can cause data to not be saved at all. I suppose you could fire a different event or add a variable to the paste event so the caller can see what type of paste is happening. Neither of those sound like great solutions. I checked on Firefox on Mac, but it doesn't have a "Paste and Match Style". I'm not sure how to proceed here, maybe Hixie has some thoughts? 156674 5 darin 2009-10-21 15:51:42 -0700 (In reply to comment #4) > To provide some context, this was requested by people working on Google Wave > and other rich text editors. Normally you want to watch for paste events so > you can know when to start an autosave of editable text. Are there other ways of getting new text in besides typing and paste? For example: Dragging text in, dragging text out, correcting spelling, doing other transformations such as Make Upper Case in the Transformations submenu on Mac OS X 10.6’s context menu in Safari. Does Google Wave work properly with things like that? I ask because it might be better to come up with a solution that will work for those cases as well rather than making this change. Or in addition. 156704 6 eric 2009-10-21 16:31:56 -0700 Isn't that what DOMTextInput events are for? http://www.w3.org/TR/DOM-Level-3-Events/#event-type-textInput 156721 7 daniel.danilatos 2009-10-21 16:52:22 -0700 (In reply to comment #5) > (In reply to comment #4) > > To provide some context, this was requested by people working on Google Wave > > and other rich text editors. Normally you want to watch for paste events so > > you can know when to start an autosave of editable text. > > Are there other ways of getting new text in besides typing and paste? Heaps! These are a major source of problems. There have been many discussions about this, but the main ideal is that the browser should NEVER change the DOM without giving the javascript app some kind of cancellable event. (Mutation events are a nasty, uncancellable, non-user-intent-conveying catchall). > > For example: Dragging text in, dragging text out, correcting spelling, doing > other transformations such as Make Upper Case in the Transformations submenu on > Mac OS X 10.6’s context menu in Safari. Does Google Wave work properly with > things like that? > If there are no events given, then not. Undo/Redo are also major sore points (if done via the edit menu) > I ask because it might be better to come up with a solution that will work for > those cases as well rather than making this change. Or in addition. I think it's good to fix plain text paste now one way or another, since it's so similar to paste. 156723 8 daniel.danilatos 2009-10-21 16:54:34 -0700 (In reply to comment #6) > Isn't that what DOMTextInput events are for? > http://www.w3.org/TR/DOM-Level-3-Events/#event-type-textInput I personally don't mind what event we get - but it seems we don't get either paste or textInput for ctrl+shift+v, and we dont get textInput for regular ctrl+v either http://www.danilatos.com/event-test/ExperimentTest.html Does textInput contain any field that defines the subtype of input? 167323 9 abarth 2009-11-30 12:19:42 -0800 Attachment 41599 passed the style-queue 171530 10 41599 eric 2009-12-14 13:10:21 -0800 Comment on attachment 41599 Patch v1 This makes sense to me. 179300 11 41599 commit-queue 2010-01-11 01:21:08 -0800 Comment on attachment 41599 Patch v1 Clearing flags on attachment: 41599 Committed r53068: <http://trac.webkit.org/changeset/53068> 179301 12 commit-queue 2010-01-11 01:21:20 -0800 All reviewed patches have been landed. Closing bug. 41598 2009-10-21 12:19:55 -0700 2009-10-21 12:25:54 -0700 Patch v1 bug-30639-20091021121954.patch text/plain 2343 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmYjJmNmRjLi5iZGIzOTY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MjEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlICJQYXN0ZSBhbmQgTWF0Y2ggU3R5bGUi IGZpcmUgdGhlIGRvbSBwYXN0ZSBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwNjM5CisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5k L3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sOiBBZGRlZC4KKwogMjAwOS0xMC0yMSAg RG1pdHJ5IFRpdG92ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvcGFzdGUtYW5kLW1hdGNoLXN0eWxlLWV2ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmQyNzVjYWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5o dG1sCkBAIC0wLDAgKzEsMjIgQEAKKzxodG1sPgorPHNjcmlwdCBzcmM9Ii4uL2VkaXRpbmcuanMi Pjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIG9ucGFzdGVoYW5kbGVyKGV2ZW50KSB7Cisg ICAgdmFyIGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0Jyk7CisgICAgZS5pbm5l ckhUTUwgPSAiU1VDQ0VTUyI7Cit9CisKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgZXhlY0NvcHlD b21tYW5kKCk7CisgICAgLy8gVGVzdCB0byBtYWtlIHN1cmUgdGhhdCBQYXN0ZUFuZE1hdGNoU3R5 bGUgZmlyZXMgdGhlIG9ucGFzdGUgZXZlbnQuCisgICAgZXhlY1Bhc3RlQW5kTWF0Y2hTdHlsZUNv bW1hbmQoKTsKKyAgICAKKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9CisKKzwvc2NyaXB0Pgor PGJvZHkgb25sb2FkPSd0ZXN0KCknIG9ucGFzdGU9J29ucGFzdGVoYW5kbGVyKGV2ZW50KSc+Cis8 ZGl2IGlkPSdyZXN1bHQnPkZBSUxVUkU8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEzMThiMy4u MGE4ZGI0MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0yMSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEhhdmUgIlBhc3RlIGFuZCBNYXRjaCBTdHlsZSIgZmlyZSB0aGUgZG9tIHBhc3RlIGV2ZW50 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2MzkK KworICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHls ZS1ldmVudC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpFZGl0b3I6OnBhc3RlQXNQbGFpblRleHQpOgorCiAyMDA5LTEwLTIxICBEbWl0cnkg VGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAgYi9XZWJDb3Jl L2VkaXRpbmcvRWRpdG9yLmNwcAppbmRleCAzZjNmNzM2Li43MTUwMGJiIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAorKysgYi9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNw cApAQCAtMTA1OSw2ICsxMDU5LDggQEAgdm9pZCBFZGl0b3I6OnBhc3RlKCkKIAogdm9pZCBFZGl0 b3I6OnBhc3RlQXNQbGFpblRleHQoKQogeworICAgIGlmICh0cnlESFRNTFBhc3RlKCkpCisgICAg ICAgIHJldHVybjsKICAgICBpZiAoIWNhblBhc3RlKCkpCiAgICAgICAgIHJldHVybjsKICAgICBw YXN0ZUFzUGxhaW5UZXh0V2l0aFBhc3RlYm9hcmQoUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3RlYm9h cmQoKSk7 41599 2009-10-21 12:25:56 -0700 2010-01-11 01:21:08 -0800 Patch v1 bug-30639-20091021122555.patch text/plain 2664 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmYjJmNmRjLi5iZGIzOTY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MjEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlICJQYXN0ZSBhbmQgTWF0Y2ggU3R5bGUi IGZpcmUgdGhlIGRvbSBwYXN0ZSBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwNjM5CisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5k L3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sOiBBZGRlZC4KKwogMjAwOS0xMC0yMSAg RG1pdHJ5IFRpdG92ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvcGFzdGUtYW5kLW1hdGNoLXN0eWxlLWV2ZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0eWxlLWV2ZW50LWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mZjQzY2E0Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9wYXN0ZS1hbmQtbWF0 Y2gtc3R5bGUtZXZlbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1NVQ0NFU1MKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0 eWxlLWV2ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFu ZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLmQyNzVjYWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWND b21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sCkBAIC0wLDAgKzEsMjIgQEAK KzxodG1sPgorPHNjcmlwdCBzcmM9Ii4uL2VkaXRpbmcuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4K K2Z1bmN0aW9uIG9ucGFzdGVoYW5kbGVyKGV2ZW50KSB7CisgICAgdmFyIGUgPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncmVzdWx0Jyk7CisgICAgZS5pbm5lckhUTUwgPSAiU1VDQ0VTUyI7Cit9 CisKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgZXhlY0NvcHlDb21tYW5kKCk7CisgICAgLy8gVGVz dCB0byBtYWtlIHN1cmUgdGhhdCBQYXN0ZUFuZE1hdGNoU3R5bGUgZmlyZXMgdGhlIG9ucGFzdGUg ZXZlbnQuCisgICAgZXhlY1Bhc3RlQW5kTWF0Y2hTdHlsZUNvbW1hbmQoKTsKKyAgICAKKyAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7Cit9CisKKzwvc2NyaXB0PgorPGJvZHkgb25sb2FkPSd0ZXN0KCkn IG9ucGFzdGU9J29ucGFzdGVoYW5kbGVyKGV2ZW50KSc+Cis8ZGl2IGlkPSdyZXN1bHQnPkZBSUxV UkU8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEzMThiMy4uMGE4ZGI0MCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAwOS0xMC0yMSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgIlBhc3RlIGFuZCBN YXRjaCBTdHlsZSIgZmlyZSB0aGUgZG9tIHBhc3RlIGV2ZW50LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2MzkKKworICAgICAgICBUZXN0OiBlZGl0 aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sCisKKyAgICAg ICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OnBhc3Rl QXNQbGFpblRleHQpOgorCiAyMDA5LTEwLTIxICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApp bmRleCAzZjNmNzM2Li43MTUwMGJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9y LmNwcAorKysgYi9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApAQCAtMTA1OSw2ICsxMDU5LDgg QEAgdm9pZCBFZGl0b3I6OnBhc3RlKCkKIAogdm9pZCBFZGl0b3I6OnBhc3RlQXNQbGFpblRleHQo KQogeworICAgIGlmICh0cnlESFRNTFBhc3RlKCkpCisgICAgICAgIHJldHVybjsKICAgICBpZiAo IWNhblBhc3RlKCkpCiAgICAgICAgIHJldHVybjsKICAgICBwYXN0ZUFzUGxhaW5UZXh0V2l0aFBh c3RlYm9hcmQoUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3RlYm9hcmQoKSk7