30636 2009-10-21 10:57:10 -0700 [GTK] Double click detection in EventSender DRT is not correct 2009-10-21 12:03:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 alex webkit-unassigned commit-queue oldest_to_newest 156543 0 alex 2009-10-21 10:57:10 -0700 It is something like this: if (lastClickPositionX != lastMousePositionX && lastClickPositionY != lastMousePositionY) In my opinioin it should be something like this: if (lastClickPositionX != lastMousePositionX || lastClickPositionY != lastMousePositionY) 156549 1 41578 alex 2009-10-21 11:07:08 -0700 Created attachment 41578 First patch proposal 156561 2 41585 alex 2009-10-21 11:18:00 -0700 Created attachment 41585 Fixed Changelog comment 156562 3 41585 xan.lopez 2009-10-21 11:19:33 -0700 Comment on attachment 41585 Fixed Changelog comment Yep. 156594 4 41585 commit-queue 2009-10-21 12:03:37 -0700 Comment on attachment 41585 Fixed Changelog comment Clearing flags on attachment: 41585 Committed r49913: <http://trac.webkit.org/changeset/49913> 156595 5 commit-queue 2009-10-21 12:03:40 -0700 All reviewed patches have been landed. Closing bug. 41578 2009-10-21 11:07:08 -0700 2009-10-21 11:18:00 -0700 First patch proposal EventSender_double_click_cond.patch text/plain 1307 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMTQ4MjJlLi43M2IzMDIyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MjEgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRml4ZWQgdGhlIGRvdWJs ZSBjbGljayBjb25kaXRpb24sIGl0IGlzIGRvdWJsZSBjbGljayBpZiB3ZQorICAgICAgICBtb3Zl IGluIGp1c3QgaW4gb25lIGRpcmVjdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwNjM2CisKKyAgICAgICAgKiBXZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwOgorCiAyMDA5LTEwLTIwICBBbnRvbiBNdWhpbiAg PGFudG9ubUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5j cHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCmluZGV4 IGEzNjU1NWUuLmM4OTU4ZTcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9FdmVudFNlbmRlci5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0V2ZW50U2VuZGVyLmNwcApAQCAtMTIyLDcgKzEyMiw3IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIGNv bnRleHRDbGlja0NhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5j dGlvCiBzdGF0aWMgdm9pZCB1cGRhdGVDbGlja0NvdW50KGludCAvKiBidXR0b24gKi8pCiB7CiAg ICAgLy8gRklYTUU6IHRha2UgdGhlIGxhc3QgY2xpY2tlZCBidXR0b24gbnVtYmVyIGFuZCB0aGUg dGltZSBvZiBsYXN0IGNsaWNrIGludG8gYWNjb3VudC4KLSAgICBpZiAobGFzdENsaWNrUG9zaXRp b25YICE9IGxhc3RNb3VzZVBvc2l0aW9uWCAmJiBsYXN0Q2xpY2tQb3NpdGlvblkgIT0gbGFzdE1v dXNlUG9zaXRpb25ZKQorICAgIGlmIChsYXN0Q2xpY2tQb3NpdGlvblggIT0gbGFzdE1vdXNlUG9z aXRpb25YIHx8IGxhc3RDbGlja1Bvc2l0aW9uWSAhPSBsYXN0TW91c2VQb3NpdGlvblkpCiAgICAg ICAgIGNsaWNrQ291bnQgPSAxOwogICAgIGVsc2UKICAgICAgICAgY2xpY2tDb3VudCsrOwo= 41585 2009-10-21 11:18:00 -0700 2009-10-21 12:03:37 -0700 Fixed Changelog comment EventSender_double_click_cond.patch text/plain 1311 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMTQ4MjJlLi42MTUyM2EzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MjEgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRml4ZWQgdGhlIGRvdWJs ZSBjbGljayBjb25kaXRpb24sIGl0IGlzIG5vdCBkb3VibGUgY2xpY2sgaWYKKyAgICAgICAgd2Ug bW92ZSBpbiBqdXN0IGluIG9uZSBkaXJlY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDYzNgorCisgICAgICAgICogV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcDoKKwogMjAwOS0xMC0yMCAgQW50b24gTXVo aW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5k ZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcApp bmRleCBhMzY1NTVlLi5jODk1OGU3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9FdmVudFNlbmRlci5jcHAKQEAgLTEyMiw3ICsxMjIsNyBAQCBzdGF0aWMgSlNWYWx1ZVJl ZiBjb250ZXh0Q2xpY2tDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYg ZnVuY3Rpbwogc3RhdGljIHZvaWQgdXBkYXRlQ2xpY2tDb3VudChpbnQgLyogYnV0dG9uICovKQog ewogICAgIC8vIEZJWE1FOiB0YWtlIHRoZSBsYXN0IGNsaWNrZWQgYnV0dG9uIG51bWJlciBhbmQg dGhlIHRpbWUgb2YgbGFzdCBjbGljayBpbnRvIGFjY291bnQuCi0gICAgaWYgKGxhc3RDbGlja1Bv c2l0aW9uWCAhPSBsYXN0TW91c2VQb3NpdGlvblggJiYgbGFzdENsaWNrUG9zaXRpb25ZICE9IGxh c3RNb3VzZVBvc2l0aW9uWSkKKyAgICBpZiAobGFzdENsaWNrUG9zaXRpb25YICE9IGxhc3RNb3Vz ZVBvc2l0aW9uWCB8fCBsYXN0Q2xpY2tQb3NpdGlvblkgIT0gbGFzdE1vdXNlUG9zaXRpb25ZKQog ICAgICAgICBjbGlja0NvdW50ID0gMTsKICAgICBlbHNlCiAgICAgICAgIGNsaWNrQ291bnQrKzsK