<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>30634</bug_id>
          
          <creation_ts>2009-10-21 10:48:26 -0700</creation_ts>
          <short_desc>commit-queue will get stuck on patches if land-patches terminates unexpectedly</short_desc>
          <delta_ts>2009-10-26 15:32:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>30683</dependson>
          <blocked>30084</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          <cc>abarth</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>156539</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-21 10:48:26 -0700</bug_when>
    <thetext>commit-queue will get stuck on patches if land-patches terminates unexpectedly

If &quot;bugzilla-tool land-patches&quot; exit&apos;s early, we just spin.  This is bad.  We really should record that failure on the bug and mark the patch cq- if land-patches exits unexpectedly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156563</commentid>
    <comment_count>1</comment_count>
      <attachid>41586</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-21 11:22:48 -0700</bug_when>
    <thetext>Created attachment 41586
post unknown errors to the bug instead of spinning</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156578</commentid>
    <comment_count>2</comment_count>
      <attachid>41593</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-21 11:40:48 -0700</bug_when>
    <thetext>Created attachment 41593
post unknown errors to the bug instead of spinning</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156581</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-21 11:48:30 -0700</bug_when>
    <thetext>bug 30084&apos;s patch is based on the same branch as this one, so currently this one needs to be landed first.  the commit-queue doesn&apos;t know how to deal with dependencies, so I guess I&apos;ll remove the cq? from the other one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156792</commentid>
    <comment_count>4</comment_count>
      <attachid>41593</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-10-21 23:04:32 -0700</bug_when>
    <thetext>Comment on attachment 41593
post unknown errors to the bug instead of spinning

I don&apos;t really like the exit code 2 business, but I don&apos;t see a better design.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156803</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-21 23:50:56 -0700</bug_when>
    <thetext>Agreed.  It gets even more skanky with the whole re-exec nonsense.  But this seemed the cleanest way to indicate to the calling process that it should keep going.  I could have it exit(0) in --commit-queue mode instead, but that seemed more confusing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156804</commentid>
    <comment_count>6</comment_count>
      <attachid>41593</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-21 23:51:21 -0700</bug_when>
    <thetext>Comment on attachment 41593
post unknown errors to the bug instead of spinning

I&apos;m certainly open to other opinions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156810</commentid>
    <comment_count>7</comment_count>
      <attachid>41593</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-22 00:03:25 -0700</bug_when>
    <thetext>Comment on attachment 41593
post unknown errors to the bug instead of spinning

Rejecting patch 41593 from commit-queue.

Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;]&quot; exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
A repository hook failed: MERGE request failed on &apos;/repository/webkit/trunk&apos;: Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can&apos;t write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebKitTools/ChangeLog

    Please don&apos;t ever say &quot;OOPS&quot; in a ChangeLog file.
 at /usr/local/libexec/git-core//git-svn line 469</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156812</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-22 00:04:39 -0700</bug_when>
    <thetext>Sigh.  Clearly I need to build a smarter commit queue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156938</commentid>
    <comment_count>9</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-22 10:57:30 -0700</bug_when>
    <thetext>Going to see if I can&apos;t fix svn-apply (And thus the commit-queue) first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>157966</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-26 15:31:13 -0700</bug_when>
    <thetext>I&apos;ve fixed svn-apply, but it is faster to just land this by hand.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>157968</commentid>
    <comment_count>11</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-26 15:32:10 -0700</bug_when>
    <thetext>Committed r50104: &lt;http://trac.webkit.org/changeset/50104&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>41586</attachid>
            <date>2009-10-21 11:22:48 -0700</date>
            <delta_ts>2009-10-21 11:40:45 -0700</delta_ts>
            <desc>post unknown errors to the bug instead of spinning</desc>
            <filename>bug-30634-20091021112246.patch</filename>
            <type>text/plain</type>
            <size>4016</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA0MWMwYjZkLi4wODk1MDY3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTcgQEAKIAogICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBjb21taXQtcXVldWUgd2ls
bCBnZXQgc3R1Y2sgb24gcGF0Y2hlcyBpZiBsYW5kLXBhdGNoZXMgdGVybWluYXRlcyB1bmV4cGVj
dGVkbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMw
NjM0CisKKyAgICAgICAgKiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisgICAgICAgICAtIEFkZCBh
IHdheSBmb3IgbGFuZC1wYXRjaGVzIHRvIGV4aXQoMikgdG8gaW5kaWNhdGUgYW4gZXJyb3IsIGJ1
dCBvbmUgaXQgaGFzIGhhbmRsZWQuCisgICAgICAgICAtIE1ha2UgY29tbWl0LXF1ZXVlIGF1dG8g
Y3EtIGFueSBwYXRjaCB3aGVyZSBsYW5kLXBhdGNoZXMgZXhpdGVkIGFueXRoaW5nIG90aGVyIHRo
YW4gJzAnIG9yICcyJy4KKworMjAwOS0xMC0yMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v
cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgYnVn
emlsbGEtdG9vbCdzICJwYXRjaCBmYWlsZWQgdG8gZG93bmxvYWQgYW4gYXBwbHkiIGVycm9yIHNo
b3VsZCBnaXZlIG1vcmUgaW5mb3JtYXRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTMwNjMyCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw
dHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRl
eCA2ZjBhYWY0Li5jYzFkOTg2IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3pp
bGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC03Myw3
ICs3Myw3IEBAIGRlZiBjb21taXRfbWVzc2FnZV9mb3JfdGhpc19jb21taXQoc2NtKToKICAgICAg
ICAgbG9nKCJQYXJzaW5nIENoYW5nZUxvZzogJXMiICUgY2hhbmdlbG9nX3BhdGgpCiAgICAgICAg
IGNoYW5nZWxvZ19lbnRyeSA9IENoYW5nZUxvZyhjaGFuZ2Vsb2dfcGF0aCkubGF0ZXN0X2VudHJ5
KCkKICAgICAgICAgaWYgbm90IGNoYW5nZWxvZ19lbnRyeToKLSAgICAgICAgICAgIGVycm9yKCJG
YWlsZWQgdG8gcGFyc2UgQ2hhbmdlTG9nOiAiICsgb3MucGF0aC5hYnNwYXRoKGNoYW5nZWxvZ19w
YXRoKSkKKyAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9IkZhaWxlZCB0byBw
YXJzZSBDaGFuZ2VMb2c6ICIgKyBvcy5wYXRoLmFic3BhdGgoY2hhbmdlbG9nX3BhdGgpKQogICAg
ICAgICBjaGFuZ2Vsb2dfbWVzc2FnZXMuYXBwZW5kKGNoYW5nZWxvZ19lbnRyeSkKIAogICAgICMg
RklYTUU6IFdlIHNob3VsZCBzb3J0IGFuZCBsYWJlbCB0aGUgQ2hhbmdlTG9nIG1lc3NhZ2VzIGxp
a2UgY29tbWl0LWxvZy1lZGl0b3IgZG9lcy4KQEAgLTMyNSw2ICszMjUsMTAgQEAgY2xhc3MgTGFu
ZFBhdGNoZXNGcm9tQnVncyhDb21tYW5kKToKICAgICAgICAgb3B0aW9ucyArPSBXZWJLaXRMYW5k
aW5nU2NyaXB0cy5sYW5kX29wdGlvbnMoKQogICAgICAgICBDb21tYW5kLl9faW5pdF9fKHNlbGYs
ICdMYW5kcyBhbGwgcGF0Y2hlcyBvbiBhIGJ1ZyBvcHRpb25hbGx5IHRlc3RpbmcgdGhlbSBmaXJz
dCcsICdCVUdJRCcsIG9wdGlvbnM9b3B0aW9ucykKIAorICAgIGRlZiBoYW5kbGVkX2Vycm9yKGVy
cm9yKToKKyAgICAgICAgbG9nKGVycm9yKQorICAgICAgICBleGl0KDIpICMgRXhpdCAyIGluc3Rl
ZCBvZiAxIHRvIGluZGljYXRlIHRvIHRoZSBjb21taXQtcXVldWUgdG8gaW5kaWNhdGUgd2UgaGFu
ZGxlZCB0aGUgZXJyb3IsIGFuZCB0aGF0IHRoZSBxdWV1ZSBzaG91bGQga2VlcCBsb29waW5nLgor
CiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIGxhbmRfcGF0Y2hlcyhjbHMsIGJ1Z19pZCwgcGF0
Y2hlcywgb3B0aW9ucywgdG9vbCk6CiAgICAgICAgIHRyeToKQEAgLTM0NCwxMSArMzQ4LDExIEBA
IGNsYXNzIExhbmRQYXRjaGVzRnJvbUJ1Z3MoQ29tbWFuZCk6CiAgICAgICAgIGV4Y2VwdCBDaGVj
a291dE5lZWRzVXBkYXRlLCBlOgogICAgICAgICAgICAgbG9nKCJDb21taXQgd2FzIHJlamVjdGVk
IGJlY2F1c2UgdGhlIGNoZWNrb3V0IGlzIG91dCBvZiBkYXRlLiAgUGxlYXNlIHVwZGF0ZSBhbmQg
dHJ5IGFnYWluLiIpCiAgICAgICAgICAgICBsb2coIllvdSBjYW4gcGFzcyAtLW5vLWJ1aWxkIHRv
IHNraXAgYnVpbGRpbmcvdGVzdGluZyBhZnRlciB1cGRhdGUgaWYgeW91IGJlbGlldmUgdGhlIG5l
dyBjb21taXRzIGRpZCBub3QgYWZmZWN0IHRoZSByZXN1bHRzLiIpCi0gICAgICAgICAgICBlcnJv
cihlKQorICAgICAgICAgICAgc2VsZi5oYW5kbGVkX2Vycm9yKGUpCiAgICAgICAgIGV4Y2VwdCBT
Y3JpcHRFcnJvciwgZToKICAgICAgICAgICAgICMgTWFyayB0aGUgcGF0Y2ggYXMgY29tbWl0LXF1
ZXVlLSBhbmQgY29tbWVudCBpbiB0aGUgYnVnLgogICAgICAgICAgICAgdG9vbC5idWdzLnJlamVj
dF9wYXRjaF9mcm9tX2NvbW1pdF9xdWV1ZShwYXRjaFsnaWQnXSwgZS5tZXNzYWdlX3dpdGhfb3V0
cHV0KCkpCi0gICAgICAgICAgICBlcnJvcihlKQorICAgICAgICAgICAgc2VsZi5oYW5kbGVkX2Vy
cm9yKGUpCiAKICAgICBAc3RhdGljbWV0aG9kCiAgICAgZGVmIF9mZXRjaF9saXN0X29mX3BhdGNo
ZXNfdG9fbGFuZChvcHRpb25zLCBhcmdzLCB0b29sKToKQEAgLTc0Niw3ICs3NTAsMTMgQEAgY2xh
c3MgTGFuZFBhdGNoZXNGcm9tQ29tbWl0UXVldWUoQ29tbWFuZCk6CiAgICAgICAgICAgICBidWdf
bG9nID0gc2VsZi5fYWRkX2xvZ190b19vdXRwdXRfdGVlKGJ1Z19sb2dfcGF0aCkKICAgICAgICAg
ICAgIGJ1Z3ppbGxhX3Rvb2xfcGF0aCA9IF9fZmlsZV9fICMgcmUtZXhlY3V0ZSB0aGlzIHNjcmlw
dAogICAgICAgICAgICAgYnVnemlsbGFfdG9vbF9hcmdzID0gW2J1Z3ppbGxhX3Rvb2xfcGF0aCwg
J2xhbmQtcGF0Y2hlcycsICctLWZvcmNlLWNsZWFuJywgJy0tY29tbWl0LXF1ZXVlJywgJy0tcXVp
ZXQnLCBmaXJzdF9idWdfaWRdCi0gICAgICAgICAgICBXZWJLaXRMYW5kaW5nU2NyaXB0cy5ydW5f
Y29tbWFuZF93aXRoX3RlZWRfb3V0cHV0KGJ1Z3ppbGxhX3Rvb2xfYXJncywgc3lzLnN0ZG91dCkK
KyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICBXZWJLaXRMYW5kaW5nU2NyaXB0cy5y
dW5fYW5kX3Rocm93X2lmX2ZhaWwoYnVnemlsbGFfdG9vbF9hcmdzKQorICAgICAgICAgICAgZXhj
ZXB0IFNjcmlwdEVycm9yLCBlOgorICAgICAgICAgICAgICAgICMgVW5leHBlY3RlZCBmYWlsdXJl
ISAgTWFyayB0aGUgcGF0Y2ggYXMgY29tbWl0LXF1ZXVlLSBhbmQgY29tbWVudCBpbiB0aGUgYnVn
LgorICAgICAgICAgICAgICAgICMgZXhpdCgyKSBpcyBhIHNwZWNpYWwgZXhpdCBjb2RlIHdlIHVz
ZSB0byBpbmRpY2F0ZSB0aGF0IHRoZSBlcnJvciB3YXMgYWxyZWFkeSBoYW5kbGVkIGJ5IGxhbmQt
cGF0Y2hlcyBhbmQgd2Ugc2hvdWxkIGtlZXAgbG9vcGluZyBhbnl3YXkuCisgICAgICAgICAgICAg
ICAgaWYgZS5leGl0X2NvZGUoKSAhPSAyOgorICAgICAgICAgICAgICAgICAgICB0b29sLmJ1Z3Mu
cmVqZWN0X3BhdGNoX2Zyb21fY29tbWl0X3F1ZXVlKHBhdGNoWydpZCddLCAiVW5leHBlY3RlZCBm
YWlsdXJlIHdoZW4gbGFuZGluZyBwYXRjaCEgIFBsZWFzZSBmaWxlIGEgYnVnIGFnYWluc3QgYnVn
emlsbGEtdG9vbC5cbiVzIiAlIGUubWVzc2FnZV93aXRoX291dHB1dCgpKQogICAgICAgICAgICAg
c2VsZi5fcmVtb3ZlX2xvZ19mcm9tX291dHB1dF90ZWUoYnVnX2xvZykKIAogICAgICAgICBsb2co
IkZpbmlzaGVkIFdlYktpdCBDb21taXQgUXVldWUuICVzIiAlIGRhdGV0aW1lLm5vdygpLnN0cmZ0
aW1lKHNlbGYubG9nX2RhdGVfZm9ybWF0KSk=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>41593</attachid>
            <date>2009-10-21 11:40:48 -0700</date>
            <delta_ts>2009-10-22 00:03:25 -0700</delta_ts>
            <desc>post unknown errors to the bug instead of spinning</desc>
            <filename>bug-30634-20091021114047.patch</filename>
            <type>text/plain</type>
            <size>4031</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA0MWMwYjZkLi4wODk1MDY3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTcgQEAKIAogICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBjb21taXQtcXVldWUgd2ls
bCBnZXQgc3R1Y2sgb24gcGF0Y2hlcyBpZiBsYW5kLXBhdGNoZXMgdGVybWluYXRlcyB1bmV4cGVj
dGVkbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMw
NjM0CisKKyAgICAgICAgKiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisgICAgICAgICAtIEFkZCBh
IHdheSBmb3IgbGFuZC1wYXRjaGVzIHRvIGV4aXQoMikgdG8gaW5kaWNhdGUgYW4gZXJyb3IsIGJ1
dCBvbmUgaXQgaGFzIGhhbmRsZWQuCisgICAgICAgICAtIE1ha2UgY29tbWl0LXF1ZXVlIGF1dG8g
Y3EtIGFueSBwYXRjaCB3aGVyZSBsYW5kLXBhdGNoZXMgZXhpdGVkIGFueXRoaW5nIG90aGVyIHRo
YW4gJzAnIG9yICcyJy4KKworMjAwOS0xMC0yMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v
cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgYnVn
emlsbGEtdG9vbCdzICJwYXRjaCBmYWlsZWQgdG8gZG93bmxvYWQgYW4gYXBwbHkiIGVycm9yIHNo
b3VsZCBnaXZlIG1vcmUgaW5mb3JtYXRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTMwNjMyCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw
dHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRl
eCA2ZjBhYWY0Li5iYjRlNzZmIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3pp
bGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC03Myw3
ICs3Myw3IEBAIGRlZiBjb21taXRfbWVzc2FnZV9mb3JfdGhpc19jb21taXQoc2NtKToKICAgICAg
ICAgbG9nKCJQYXJzaW5nIENoYW5nZUxvZzogJXMiICUgY2hhbmdlbG9nX3BhdGgpCiAgICAgICAg
IGNoYW5nZWxvZ19lbnRyeSA9IENoYW5nZUxvZyhjaGFuZ2Vsb2dfcGF0aCkubGF0ZXN0X2VudHJ5
KCkKICAgICAgICAgaWYgbm90IGNoYW5nZWxvZ19lbnRyeToKLSAgICAgICAgICAgIGVycm9yKCJG
YWlsZWQgdG8gcGFyc2UgQ2hhbmdlTG9nOiAiICsgb3MucGF0aC5hYnNwYXRoKGNoYW5nZWxvZ19w
YXRoKSkKKyAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9IkZhaWxlZCB0byBw
YXJzZSBDaGFuZ2VMb2c6ICIgKyBvcy5wYXRoLmFic3BhdGgoY2hhbmdlbG9nX3BhdGgpKQogICAg
ICAgICBjaGFuZ2Vsb2dfbWVzc2FnZXMuYXBwZW5kKGNoYW5nZWxvZ19lbnRyeSkKIAogICAgICMg
RklYTUU6IFdlIHNob3VsZCBzb3J0IGFuZCBsYWJlbCB0aGUgQ2hhbmdlTG9nIG1lc3NhZ2VzIGxp
a2UgY29tbWl0LWxvZy1lZGl0b3IgZG9lcy4KQEAgLTMyNSw2ICszMjUsMTEgQEAgY2xhc3MgTGFu
ZFBhdGNoZXNGcm9tQnVncyhDb21tYW5kKToKICAgICAgICAgb3B0aW9ucyArPSBXZWJLaXRMYW5k
aW5nU2NyaXB0cy5sYW5kX29wdGlvbnMoKQogICAgICAgICBDb21tYW5kLl9faW5pdF9fKHNlbGYs
ICdMYW5kcyBhbGwgcGF0Y2hlcyBvbiBhIGJ1ZyBvcHRpb25hbGx5IHRlc3RpbmcgdGhlbSBmaXJz
dCcsICdCVUdJRCcsIG9wdGlvbnM9b3B0aW9ucykKIAorICAgIEBzdGF0aWNtZXRob2QKKyAgICBk
ZWYgaGFuZGxlZF9lcnJvcihlcnJvcik6CisgICAgICAgIGxvZyhlcnJvcikKKyAgICAgICAgZXhp
dCgyKSAjIEV4aXQgMiBpbnN0ZWQgb2YgMSB0byBpbmRpY2F0ZSB0byB0aGUgY29tbWl0LXF1ZXVl
IHRvIGluZGljYXRlIHdlIGhhbmRsZWQgdGhlIGVycm9yLCBhbmQgdGhhdCB0aGUgcXVldWUgc2hv
dWxkIGtlZXAgbG9vcGluZy4KKwogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBsYW5kX3BhdGNo
ZXMoY2xzLCBidWdfaWQsIHBhdGNoZXMsIG9wdGlvbnMsIHRvb2wpOgogICAgICAgICB0cnk6CkBA
IC0zNDQsMTEgKzM0OSwxMSBAQCBjbGFzcyBMYW5kUGF0Y2hlc0Zyb21CdWdzKENvbW1hbmQpOgog
ICAgICAgICBleGNlcHQgQ2hlY2tvdXROZWVkc1VwZGF0ZSwgZToKICAgICAgICAgICAgIGxvZygi
Q29tbWl0IHdhcyByZWplY3RlZCBiZWNhdXNlIHRoZSBjaGVja291dCBpcyBvdXQgb2YgZGF0ZS4g
IFBsZWFzZSB1cGRhdGUgYW5kIHRyeSBhZ2Fpbi4iKQogICAgICAgICAgICAgbG9nKCJZb3UgY2Fu
IHBhc3MgLS1uby1idWlsZCB0byBza2lwIGJ1aWxkaW5nL3Rlc3RpbmcgYWZ0ZXIgdXBkYXRlIGlm
IHlvdSBiZWxpZXZlIHRoZSBuZXcgY29tbWl0cyBkaWQgbm90IGFmZmVjdCB0aGUgcmVzdWx0cy4i
KQotICAgICAgICAgICAgZXJyb3IoZSkKKyAgICAgICAgICAgIGNscy5oYW5kbGVkX2Vycm9yKGUp
CiAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgICMgTWFyayB0aGUg
cGF0Y2ggYXMgY29tbWl0LXF1ZXVlLSBhbmQgY29tbWVudCBpbiB0aGUgYnVnLgogICAgICAgICAg
ICAgdG9vbC5idWdzLnJlamVjdF9wYXRjaF9mcm9tX2NvbW1pdF9xdWV1ZShwYXRjaFsnaWQnXSwg
ZS5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCi0gICAgICAgICAgICBlcnJvcihlKQorICAgICAgICAg
ICAgY2xzLmhhbmRsZWRfZXJyb3IoZSkKIAogICAgIEBzdGF0aWNtZXRob2QKICAgICBkZWYgX2Zl
dGNoX2xpc3Rfb2ZfcGF0Y2hlc190b19sYW5kKG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgpAQCAtNzQ2
LDcgKzc1MSwxMyBAQCBjbGFzcyBMYW5kUGF0Y2hlc0Zyb21Db21taXRRdWV1ZShDb21tYW5kKToK
ICAgICAgICAgICAgIGJ1Z19sb2cgPSBzZWxmLl9hZGRfbG9nX3RvX291dHB1dF90ZWUoYnVnX2xv
Z19wYXRoKQogICAgICAgICAgICAgYnVnemlsbGFfdG9vbF9wYXRoID0gX19maWxlX18gIyByZS1l
eGVjdXRlIHRoaXMgc2NyaXB0CiAgICAgICAgICAgICBidWd6aWxsYV90b29sX2FyZ3MgPSBbYnVn
emlsbGFfdG9vbF9wYXRoLCAnbGFuZC1wYXRjaGVzJywgJy0tZm9yY2UtY2xlYW4nLCAnLS1jb21t
aXQtcXVldWUnLCAnLS1xdWlldCcsIGZpcnN0X2J1Z19pZF0KLSAgICAgICAgICAgIFdlYktpdExh
bmRpbmdTY3JpcHRzLnJ1bl9jb21tYW5kX3dpdGhfdGVlZF9vdXRwdXQoYnVnemlsbGFfdG9vbF9h
cmdzLCBzeXMuc3Rkb3V0KQorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIFdlYktp
dExhbmRpbmdTY3JpcHRzLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChidWd6aWxsYV90b29sX2FyZ3Mp
CisgICAgICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6CisgICAgICAgICAgICAgICAgIyBV
bmV4cGVjdGVkIGZhaWx1cmUhICBNYXJrIHRoZSBwYXRjaCBhcyBjb21taXQtcXVldWUtIGFuZCBj
b21tZW50IGluIHRoZSBidWcuCisgICAgICAgICAgICAgICAgIyBleGl0KDIpIGlzIGEgc3BlY2lh
bCBleGl0IGNvZGUgd2UgdXNlIHRvIGluZGljYXRlIHRoYXQgdGhlIGVycm9yIHdhcyBhbHJlYWR5
IGhhbmRsZWQgYnkgbGFuZC1wYXRjaGVzIGFuZCB3ZSBzaG91bGQga2VlcCBsb29waW5nIGFueXdh
eS4KKyAgICAgICAgICAgICAgICBpZiBlLmV4aXRfY29kZSAhPSAyOgorICAgICAgICAgICAgICAg
ICAgICB0b29sLmJ1Z3MucmVqZWN0X3BhdGNoX2Zyb21fY29tbWl0X3F1ZXVlKHBhdGNoWydpZCdd
LCAiVW5leHBlY3RlZCBmYWlsdXJlIHdoZW4gbGFuZGluZyBwYXRjaCEgIFBsZWFzZSBmaWxlIGEg
YnVnIGFnYWluc3QgYnVnemlsbGEtdG9vbC5cbiVzIiAlIGUubWVzc2FnZV93aXRoX291dHB1dCgp
KQogICAgICAgICAgICAgc2VsZi5fcmVtb3ZlX2xvZ19mcm9tX291dHB1dF90ZWUoYnVnX2xvZykK
IAogICAgICAgICBsb2coIkZpbmlzaGVkIFdlYktpdCBDb21taXQgUXVldWUuICVzIiAlIGRhdGV0
aW1lLm5vdygpLnN0cmZ0aW1lKHNlbGYubG9nX2RhdGVfZm9ybWF0KSk=
</data>
<flag name="review"
          id="23011"
          type_id="1"
          status="+"
          setter="abarth"
    />
    <flag name="commit-queue"
          id="23012"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>