30629 2009-10-21 07:16:12 -0700 [Haiku] Issue with accented letters 2009-10-22 05:06:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 simon.maxime webkit-unassigned commit-queue leavengood oldest_to_newest 156479 0 41563 simon.maxime 2009-10-21 07:16:12 -0700 Created attachment 41563 Patch Accented letters have a twice to big width (problem with unicode). The function SimpleFontData::platformWidthForGlyph(Glyph) is wrongly implemented. So I reused charUnicodeToUTF8HACK(unsigned short, char*) from WebCore/platform/graphics/haiku/FontHaiku.cpp . Regards, Maxime 156521 1 41563 eric 2009-10-21 10:28:44 -0700 Comment on attachment 41563 Patch This needs a ChangeLog with explanation of what this is doing. 156607 2 41600 simon.maxime 2009-10-21 12:26:06 -0700 Created attachment 41600 Patch v1 156853 3 41600 zecke 2009-10-22 04:44:02 -0700 Comment on attachment 41600 Patch v1 Have you considered using the UTF8 Encoder of WebCore instead of your custom conversion routine? "hack" somehow indicates that this is an interim solution? 156856 4 41600 commit-queue 2009-10-22 04:52:59 -0700 Comment on attachment 41600 Patch v1 Clearing flags on attachment: 41600 Committed r49937: <http://trac.webkit.org/changeset/49937> 156857 5 commit-queue 2009-10-22 04:53:02 -0700 All reviewed patches have been landed. Closing bug. 156861 6 simon.maxime 2009-10-22 05:06:05 -0700 (In reply to comment #3) > (From update of attachment 41600 [details]) > Have you considered using the UTF8 Encoder of WebCore instead of your custom > conversion routine? "hack" somehow indicates that this is an interim solution? Actually we use this "hack" function in two different places of our code. But indeed I should investigate on using UTF8 Encoder. Thanks. 41563 2009-10-21 07:16:12 -0700 2009-10-21 12:25:40 -0700 Patch SimpleFontDataHaiku.diff text/plain 1155 simon.maxime ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFpa3UvU2ltcGxlRm9udERh dGFIYWlrdS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhaWt1L1NpbXBsZUZvbnRE YXRhSGFpa3UuY3BwCmluZGV4IDM0OTQxYzAuLmFkYjc1NzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvaGFpa3UvU2ltcGxlRm9udERhdGFIYWlrdS5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYWlrdS9TaW1wbGVGb250RGF0YUhhaWt1LmNwcApAQCAt MzksNiArMzksOCBAQAogI2luY2x1ZGUgPHVuaWNvZGUvdW5vcm0uaD4KIAogCitleHRlcm4gaW50 IGNoYXJVbmljb2RlVG9VVEY4SEFDSyh1bnNpZ25lZCBzaG9ydCwgY2hhciopOworCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIHZvaWQgU2ltcGxlRm9udERhdGE6OnBsYXRmb3JtSW5pdCgpCkBAIC05 MywxNSArOTUsMTUgQEAgdm9pZCBTaW1wbGVGb250RGF0YTo6ZGV0ZXJtaW5lUGl0Y2goKQogCiBm bG9hdCBTaW1wbGVGb250RGF0YTo6cGxhdGZvcm1XaWR0aEZvckdseXBoKEdseXBoIGdseXBoKSBj b25zdAogewotICAgIGNvbnN0IGNoYXIgY2hhckFycmF5WzFdID0geyBnbHlwaCB9OwotICAgIGZs b2F0IGVzY2FwZW1lbnRzWzFdOworICAgIGlmICghbV9wbGF0Zm9ybURhdGEuZm9udCgpKQorICAg ICAgICByZXR1cm4gMDsKIAotICAgIGlmIChtX3BsYXRmb3JtRGF0YS5mb250KCkpIHsKLSAgICAg ICAgbV9wbGF0Zm9ybURhdGEuZm9udCgpLT5HZXRFc2NhcGVtZW50cyhjaGFyQXJyYXksIDEsIGVz Y2FwZW1lbnRzKTsKLSAgICAgICAgcmV0dXJuIGVzY2FwZW1lbnRzWzBdICogbV9wbGF0Zm9ybURh dGEuZm9udCgpLT5TaXplKCk7Ci0gICAgfQorICAgIGNoYXIgY2hhckFycmF5WzRdOworICAgIGZs b2F0IGVzY2FwZW1lbnRzWzFdOwogCi0gICAgcmV0dXJuIDA7CisgICAgY2hhclVuaWNvZGVUb1VU RjhIQUNLKGdseXBoLCBjaGFyQXJyYXkpOworICAgIG1fcGxhdGZvcm1EYXRhLmZvbnQoKS0+R2V0 RXNjYXBlbWVudHMoY2hhckFycmF5LCAxLCBlc2NhcGVtZW50cyk7CisgICAgcmV0dXJuIGVzY2Fw ZW1lbnRzWzBdICogbV9wbGF0Zm9ybURhdGEuZm9udCgpLT5TaXplKCk7CiB9CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK 41600 2009-10-21 12:26:06 -0700 2009-10-22 04:52:59 -0700 Patch v1 bug-30629-20091021212604.patch text/plain 1814 simon.maxime ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGEyMGRkMy4uMmNiOGI2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0yMSAgTWF4aW1lIFNpbW9u ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbSGFpa3VdIENvcnJlY3Rpb24gb2YgdGhlIGFjY2VudGVkIGxl dHRlciB3aWR0aCAodGhleSB3ZXJlIDIgY2hhcmFjdGVycyBsb25nKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjI5CisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9oYWlrdS9TaW1wbGVGb250RGF0YUhhaWt1LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybVdpZHRoRm9yR2x5cGgpOgorCiAyMDA5LTEw LTIxICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAg IHd4TWFjIDEwLjQgYnVpbGQgZml4LCBtYWtlIHN1cmUgd2Ugc3BlY2lmeSB0aGUgU3FsaXRlMyBk ZXBlbmRlbmN5IGNvcnJlY3RseSBhcyBvdGhlcndpc2UKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvaGFpa3UvU2ltcGxlRm9udERhdGFIYWlrdS5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2hhaWt1L1NpbXBsZUZvbnREYXRhSGFpa3UuY3BwCmluZGV4IDM0OTQx YzAuLmFkYjc1NzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFpa3Uv U2ltcGxlRm9udERhdGFIYWlrdS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9o YWlrdS9TaW1wbGVGb250RGF0YUhhaWt1LmNwcApAQCAtMzksNiArMzksOCBAQAogI2luY2x1ZGUg PHVuaWNvZGUvdW5vcm0uaD4KIAogCitleHRlcm4gaW50IGNoYXJVbmljb2RlVG9VVEY4SEFDSyh1 bnNpZ25lZCBzaG9ydCwgY2hhciopOworCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgU2lt cGxlRm9udERhdGE6OnBsYXRmb3JtSW5pdCgpCkBAIC05MywxNSArOTUsMTUgQEAgdm9pZCBTaW1w bGVGb250RGF0YTo6ZGV0ZXJtaW5lUGl0Y2goKQogCiBmbG9hdCBTaW1wbGVGb250RGF0YTo6cGxh dGZvcm1XaWR0aEZvckdseXBoKEdseXBoIGdseXBoKSBjb25zdAogewotICAgIGNvbnN0IGNoYXIg Y2hhckFycmF5WzFdID0geyBnbHlwaCB9OwotICAgIGZsb2F0IGVzY2FwZW1lbnRzWzFdOworICAg IGlmICghbV9wbGF0Zm9ybURhdGEuZm9udCgpKQorICAgICAgICByZXR1cm4gMDsKIAotICAgIGlm IChtX3BsYXRmb3JtRGF0YS5mb250KCkpIHsKLSAgICAgICAgbV9wbGF0Zm9ybURhdGEuZm9udCgp LT5HZXRFc2NhcGVtZW50cyhjaGFyQXJyYXksIDEsIGVzY2FwZW1lbnRzKTsKLSAgICAgICAgcmV0 dXJuIGVzY2FwZW1lbnRzWzBdICogbV9wbGF0Zm9ybURhdGEuZm9udCgpLT5TaXplKCk7Ci0gICAg fQorICAgIGNoYXIgY2hhckFycmF5WzRdOworICAgIGZsb2F0IGVzY2FwZW1lbnRzWzFdOwogCi0g ICAgcmV0dXJuIDA7CisgICAgY2hhclVuaWNvZGVUb1VURjhIQUNLKGdseXBoLCBjaGFyQXJyYXkp OworICAgIG1fcGxhdGZvcm1EYXRhLmZvbnQoKS0+R2V0RXNjYXBlbWVudHMoY2hhckFycmF5LCAx LCBlc2NhcGVtZW50cyk7CisgICAgcmV0dXJuIGVzY2FwZW1lbnRzWzBdICogbV9wbGF0Zm9ybURh dGEuZm9udCgpLT5TaXplKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmU=