306244 2026-01-25 19:50:49 -0800 Fix -Wlifetime-safety-permissive warning in FontRanges::glyphDataForCharacter() 2026-01-26 13:51:30 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=306226 InRadar P2 Normal --- 1 ddkilzer ddkilzer fantasai.bugs vitor.roriz webkit-bug-importer oldest_to_newest 2174988 0 ddkilzer 2026-01-25 19:50:49 -0800 Clang's lifetime safety warning detected a potential issue in FontRanges::glyphDataForCharacter(): ``` OpenSource/Source/WebCore/platform/graphics/FontRanges.cpp:94:38: error: object whose reference is captured may not live long enough [-Werror,-Wlifetime-safety-strict] 94 | resultFont = font.get(); | ^~~~ OpenSource/Source/WebCore/platform/graphics/FontRanges.cpp:104:13: note: destroyed here 104 | } | ^ OpenSource/Source/WebCore/platform/graphics/FontRanges.cpp:93:26: note: later used here 93 | if (\!resultFont) | ^~~~~~~~~~ ``` Even though the code was safe (the Font is kept alive by the FontAccessor), the analyzer couldn't prove the lifetime relationship. 2174989 1 ddkilzer 2026-01-25 19:50:51 -0800 The fix changes `resultFont` from `const Font*` to `RefPtr<const Font>` to make the lifetime relationship explicit and eliminate the warning. Also uses `WTF::move(font)` to avoid ref count churn since `font` isn't used after that point in the `isInterstitial()` branch. No change in behavior, only compiler warning elimination. 2174990 2 webkit-bug-importer 2026-01-25 19:50:55 -0800 <rdar://problem/168892583> 2174991 3 webkit-bug-importer 2026-01-25 19:50:56 -0800 <rdar://problem/168892499> 2174999 4 ddkilzer 2026-01-25 20:15:34 -0800 Pull request: https://github.com/WebKit/WebKit/pull/57231 2175246 5 ews-feeder 2026-01-26 13:51:27 -0800 Committed 306238@main (3118028cc9ac): <https://commits.webkit.org/306238@main> Reviewed commits have been landed. Closing PR #57231 and removing active labels.