<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>306214</bug_id>
          
          <creation_ts>2026-01-25 09:37:54 -0800</creation_ts>
          <short_desc>build-and-analyze: WebKit checker lists diverged between --enable-webkit-checkers and --only-smart-pointers</short_desc>
          <delta_ts>2026-01-26 15:01:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2174894</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-01-25 09:37:54 -0800</bug_when>
    <thetext>The WebKit checker list in build-and-analyze has diverged between two command-line options:

- --enable-webkit-checkers: only enables 6 WebKit-specific checkers
- --only-smart-pointers: enables 15 WebKit-specific checkers (including the same 6)

The lists should be identical since they both claim to enable &quot;WebKit checkers&quot;. The --enable-webkit-checkers option is missing 9 checkers that are available in --only-smart-pointers.

This can be verified with --dry-run:

```
cd OpenSource
Tools/Scripts/build-and-analyze --output-dir /tmp/test --enable-webkit-checkers --dry-run
Tools/Scripts/build-and-analyze --output-dir /tmp/test --only-smart-pointers --dry-run
```

The ANALYZER_FLAGS output shows different numbers of webkit.* and alpha.webkit.* checkers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2174895</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-01-25 09:37:55 -0800</bug_when>
    <thetext>Fixed by extracting the complete list of 15 WebKit checkers into a global WEBKIT_CHECKERS constant and using it in both code paths.

The fix involved:

1. Creating a global constant with all 15 checkers:

```
WEBKIT_CHECKERS = [
    &apos;alpha.webkit.ForwardDeclChecker&apos;,
    &apos;alpha.webkit.MemoryUnsafeCastChecker&apos;,
    &apos;alpha.webkit.NoUncheckedPtrMemberChecker&apos;,
    &apos;alpha.webkit.NoUnretainedMemberChecker&apos;,
    &apos;alpha.webkit.RetainPtrCtorAdoptChecker&apos;,
    &apos;alpha.webkit.UncheckedCallArgsChecker&apos;,
    &apos;alpha.webkit.UncheckedLocalVarsChecker&apos;,
    &apos;alpha.webkit.UncountedCallArgsChecker&apos;,
    &apos;alpha.webkit.UncountedLocalVarsChecker&apos;,
    &apos;alpha.webkit.UnretainedCallArgsChecker&apos;,
    &apos;alpha.webkit.UnretainedLambdaCapturesChecker&apos;,
    &apos;alpha.webkit.UnretainedLocalVarsChecker&apos;,
    &apos;webkit.NoUncountedMemberChecker&apos;,
    &apos;webkit.RefCntblBaseVirtualDtor&apos;,
    &apos;webkit.UncountedLambdaCapturesChecker&apos;,
]
```

2. Updating both code paths to use the constant:

```
if args.enable_webkit_checkers:
    additional_checkers.extend(WEBKIT_CHECKERS)

if args.only_smart_pointers:
    additional_checkers.extend(WEBKIT_CHECKERS)
```

This ensures both options use the same complete list of WebKit checkers and eliminates future divergence.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2174896</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-01-25 09:38:01 -0800</bug_when>
    <thetext>&lt;rdar://problem/168872496&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2174897</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-01-25 09:58:17 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/57208</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2175269</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-01-26 15:01:04 -0800</bug_when>
    <thetext>Committed 306247@main (7e19925f7d5a): &lt;https://commits.webkit.org/306247@main&gt;

Reviewed commits have been landed. Closing PR #57208 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>