30619 2009-10-21 00:24:29 -0700 [Linux] Menu key doesn't work 2009-10-26 03:29:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 kinuko webkit-unassigned commit-queue estade evan hbono jmalonzo tony oldest_to_newest 156425 0 kinuko 2009-10-21 00:24:29 -0700 The menu key (this one: http://en.wikipedia.org/wiki/Menu_key) doesn't work in Linux. Shift+F10 also doesn't. Both should emulate right click. * If focus is in a text field, it should be the same as right clicking where the text cursor is (this currently DOES work in the omnibox, but not other text fields) * If focus is on another element (like a link) it should bring up the context menu for that next to it. * If text is selected, Firefox brings up the context menu for that text in the upper right hand corner of the page, but I think it would be better for it to appear next to the selected text. But that might be hard. * If focus is not on anything else, it should bring up the page's context menu in the upper left hand corner of the page Original chromium bug tracker: http://code.google.com/p/chromium/issues/detail?id=18232 bug #28247 also partly refers this bug. 156438 1 41557 kinuko 2009-10-21 02:11:24 -0700 Created attachment 41557 Fix for bug 30619: Menu key doesn't work on Linux 156491 2 evan 2009-10-21 07:54:38 -0700 The change looks good to me, but I'm not a WebKit reviewer so I can't give you an official review. It would be nice if we could have tests for this. 156509 3 tony 2009-10-21 10:01:22 -0700 You might be able to add a layout test for this by extending eventSender.keyDown() to know about the menu key. Note that this still wouldn't show up in a pixel test result because context menus are a different window, so perhaps it's not worth the effort. 156523 4 41557 eric 2009-10-21 10:31:47 -0700 Comment on attachment 41557 Fix for bug 30619: Menu key doesn't work on Linux We could definitely have a manual-test for this. WebCore/manual-tests/ Otherwise this looks fine. 156844 5 jmalonzo 2009-10-22 02:49:59 -0700 (In reply to comment #1) > Created an attachment (id=41557) [details] > Fix for bug 30619: Menu key doesn't work on Linux Would be nice if we can update WebCore/platform/gtk/KeyEventGtk.cpp as well. 156845 6 41651 kinuko 2009-10-22 03:39:36 -0700 Created attachment 41651 Added manual test for Menu key event. 156862 7 41655 kinuko 2009-10-22 05:07:49 -0700 Created attachment 41655 Hi, I added a manual test and also updated platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended eventSender.keyDown() for now. 157441 8 41655 jmalonzo 2009-10-24 03:45:20 -0700 Comment on attachment 41655 Hi, I added a manual test and also updated platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended eventSender.keyDown() for now. > + No new tests: testing this will require changes in the test > + controller in a platform-specific way. (Mac doesn't have Menu key) Would be nice to mention that there's a manual test for this. Regardles, LGTM. r=me. 157679 9 kinuko 2009-10-25 22:37:30 -0700 (In reply to comment #8) > (From update of attachment 41655 [details]) > > + No new tests: testing this will require changes in the test > > + controller in a platform-specific way. (Mac doesn't have Menu key) > > Would be nice to mention that there's a manual test for this. > > Regardles, LGTM. r=me. Thanks for reviewing! I'm updating the ChangeLog in the following patch. Could you review it one more time? (Hope it'll be the last one.) Thanks, 157680 10 41844 kinuko 2009-10-25 22:38:39 -0700 Created attachment 41844 Fix for bug 30619: Menu key doesn't work on Linux 157719 11 41844 commit-queue 2009-10-26 03:29:29 -0700 Comment on attachment 41844 Fix for bug 30619: Menu key doesn't work on Linux Clearing flags on attachment: 41844 Committed r50051: <http://trac.webkit.org/changeset/50051> 157720 12 commit-queue 2009-10-26 03:29:33 -0700 All reviewed patches have been landed. Closing bug. 41557 2009-10-21 02:11:24 -0700 2009-10-22 03:39:31 -0700 Fix for bug 30619: Menu key doesn't work on Linux bug-30619-20091021181122.patch text/plain 1319 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGVjNWEwOS4uM2FkYmZlYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0yMSAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1ZyAzMDYxOTogW0xpbnV4XSBNZW51IGtleSBkb2Vzbid0IHdvcmsK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjE5CisK KyAgICAgICAgTm8gbmV3IHRlc3RzOiB0ZXN0aW5nIHRoaXMgd2lsbCByZXF1aXJlIGNoYW5nZXMg aW4gdGhlIHRlc3QKKyAgICAgICAgY29udHJvbGxlciBpbiBhIHBsYXRmb3JtLXNwZWNpZmljIHdh eS4gKE1hYyBkb2Vzbid0IGhhdmUgTWVudSBrZXkpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3aW5kb3dz S2V5Q29kZUZvcktleUV2ZW50KTogY2hhbmdlZCBzd2l0Y2gtY2FzZSBjb2RlIGZvcgorICAgICAg ICBHREtfTWVudSB0byByZXR1cm4gVktFWV9BUFBTIGluc3RlYWQgb2YgVktFWV9NRU5VLgorCiAy MDA5LTEwLTIxICBTYXRvc2hpIE5ha2FnYXdhICA8cHN5Y2hzQGxpbWVjaGF0Lm5ldD4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0ay5jcHAKaW5kZXggNTk1MGRlMS4uMWQ3ZDJkZiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0 ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0 ay5jcHAKQEAgLTkxLDYgKzkxLDcgQEAgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5z aWduZWQga2V5Y29kZSkKICAgICBjYXNlIEdES19Db250cm9sX1I6CiAgICAgICAgIHJldHVybiBW S0VZX0NPTlRST0w7IC8vICgxMSkgQ1RSTCBrZXkKICAgICBjYXNlIEdES19NZW51OgorICAgICAg ICByZXR1cm4gVktFWV9BUFBTOyAgLy8gKDVEKSBNZW51IGtleQogICAgIGNhc2UgR0RLX0FsdF9M OgogICAgIGNhc2UgR0RLX0FsdF9SOgogICAgICAgICByZXR1cm4gVktFWV9NRU5VOyAvLyAoMTIp IEFMVCBrZXk= 41651 2009-10-22 03:39:36 -0700 2009-10-22 04:25:15 -0700 Added manual test for Menu key event. bug-30619-20091022193934.patch text/plain 1486 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRlc3RzL2tleWJvYXJkLW1lbnVrZXktZXZlbnQu aHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2tleWJvYXJkLW1lbnVrZXktZXZlbnQuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42NTJmYTRkCi0tLSAvZGV2L251bGwK KysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMva2V5Ym9hcmQtbWVudWtleS1ldmVudC5odG1sCkBA IC0wLDAgKzEsMzUgQEAKKzwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0 LjAxIFRyYW5zaXRpb25hbC8vRU4iCisgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9v c2UuZHRkIj4KKworPGh0bWwgbGFuZz0iZW4iPgorICA8aGVhZD4KKyAgICA8TUVUQSBIVFRQLUVR VUlWPSJDT05URU5ULVRZUEUiIENPTlRFTlQ9InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+Cisg ICAgPHRpdGxlPk1lbnUga2V5IHRlc3Rpbmc8L3RpdGxlPgorICAgIDxzY3JpcHQgbGFuZ3VhZ2U9 ImphdmFzY3JpcHQiIHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgICBmdW5jdGlvbiBsb2co c3RyKSB7CisgICAgICAgIHZhciBsaSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImxpIik7Cisg ICAgICAgIGxpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHN0cikpOworICAg ICAgICB2YXIgcmVzdWx0cyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHRzIik7Cisg ICAgICAgIHJlc3VsdHMuYXBwZW5kQ2hpbGQobGkpOworICAgICAgfQorICAgIDwvc2NyaXB0Pgor ICA8L2hlYWQ+CisgIDxib2R5PgorICAgIFNlZSBidWc6IDxhIGhyZWY9Imh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDYxOSI+MzA2MTk8L2E+LgorICAgIDxiciAvPgor ICAgIE5vdGU6IHRoaXMgdGVzdCBpcyBvbmx5IGFwcGxpY2FibGUgZm9yIExpbnV4IGFuZCBXaW5k b3dzLgorICAgIDxvbCBpZD0idGVzdHMiPgorICAgICAgPGxpPiBDbGljayB0aGUgdGV4dCBpbnB1 dCBib3ggYmVsb3cgYW5kIHByZXNzIE1lbnUga2V5LgorICAgICAgICAgIFRoZSB0ZXN0IHBhc3Nl cyBpZiB5b3Ugc2VlICdQQVNTJyBiZWxvdy4KKyAgICAgICAgPGZvcm0+CisgICAgICAgICAgPGlu cHV0IHR5cGU9InRleHQiIG9uY29udGV4dG1lbnU9ImxvZygnUEFTUycpO3JldHVybiBmYWxzZTsi PjwvaW5wdXQ+CisgICAgICAgIDwvZm9ybT4KKyAgICAgIDwvbGk+CisgICAgICA8bGkgb25jb250 ZXh0bWVudT0ibG9nKCdQQVNTJyk7cmV0dXJuIGZhbHNlOyI+Q2xpY2sgb3Igc2VsZWN0IHNvbWV3 aGVyZQorICAgICAgaW4gdGhpcyB0ZXh0IGFuZCBwcmVzcyBNZW51IGtleS4KKyAgICAgIFRoZSB0 ZXN0IHBhc3NlcyBpZiB5b3Ugc2VlIGFkZGl0aW9uYWwgJ1BBU1MnIGJlbG93LgorICAgICAgPC9s aT4KKyAgICA8L29sPgorICAgIDx1bCBpZD0icmVzdWx0cyI+PC91bD4KKyAgPC9ib2R5PgorPC9o dG1sPg== 41655 2009-10-22 05:07:49 -0700 2009-10-25 22:38:33 -0700 Hi, I added a manual test and also updated platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended eventSender.keyDown() for now. bug-30619-20091022210747.patch text/plain 4291 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGVjNWEwOS4uY2JlZGJlZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0xMC0yMSAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1ZyAzMDYxOTogW0xpbnV4XSBNZW51IGtleSBkb2Vzbid0IHdvcmsK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjE5CisK KyAgICAgICAgTm8gbmV3IHRlc3RzOiB0ZXN0aW5nIHRoaXMgd2lsbCByZXF1aXJlIGNoYW5nZXMg aW4gdGhlIHRlc3QKKyAgICAgICAgY29udHJvbGxlciBpbiBhIHBsYXRmb3JtLXNwZWNpZmljIHdh eS4gKE1hYyBkb2Vzbid0IGhhdmUgTWVudSBrZXkpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3aW5kb3dz S2V5Q29kZUZvcktleUV2ZW50KTogY2hhbmdlZCBzd2l0Y2gtY2FzZSBjb2RlIGZvcgorICAgICAg ICBHREtfTWVudSB0byByZXR1cm4gVktFWV9BUFBTIGluc3RlYWQgb2YgVktFWV9NRU5VLgorICAg ICAgICAqIHBsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3 aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KTogY2hhbmdlZCBzd2l0Y2gtY2FzZSBjb2RlIGZvcgor ICAgICAgICBHREtfTWVudSB0byByZXR1cm4gVl9BUFBTIGluc3RlYWQgb2YgVktfTUVOVS4KKwog MjAwOS0xMC0yMSAgU2F0b3NoaSBOYWthZ2F3YSAgPHBzeWNoc0BsaW1lY2hhdC5uZXQ+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL21hbnVh bC10ZXN0cy9rZXlib2FyZC1tZW51a2V5LWV2ZW50Lmh0bWwgYi9XZWJDb3JlL21hbnVhbC10ZXN0 cy9rZXlib2FyZC1tZW51a2V5LWV2ZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uYmQyYzhlNwotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3Rz L2tleWJvYXJkLW1lbnVrZXktZXZlbnQuaHRtbApAQCAtMCwwICsxLDMxIEBACis8aHRtbCBsYW5n PSJlbiI+CisgIDxoZWFkPgorICAgIDxNRVRBIEhUVFAtRVFVSVY9IkNPTlRFTlQtVFlQRSIgQ09O VEVOVD0idGV4dC9odG1sOyBjaGFyc2V0PVVURi04Ij4KKyAgICA8dGl0bGU+TWVudSBrZXkgdGVz dGluZzwvdGl0bGU+CisgICAgPHNjcmlwdCBsYW5ndWFnZT0iamF2YXNjcmlwdCIgdHlwZT0idGV4 dC9qYXZhc2NyaXB0Ij4KKyAgICAgIGZ1bmN0aW9uIGxvZyhzdHIpIHsKKyAgICAgICAgdmFyIGxp ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGkiKTsKKyAgICAgICAgbGkuYXBwZW5kQ2hpbGQo ZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoc3RyKSk7CisgICAgICAgIHZhciByZXN1bHRzID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdHMiKTsKKyAgICAgICAgcmVzdWx0cy5hcHBlbmRD aGlsZChsaSk7CisgICAgICB9CisgICAgPC9zY3JpcHQ+CisgIDwvaGVhZD4KKyAgPGJvZHk+Cisg ICAgPHA+CisgICAgU2VlIGJ1ZzogPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMwNjE5Ij4zMDYxOTwvYT4uCisgICAgTm90ZTogdGhpcyB0ZXN0IGlzIG9u bHkgYXBwbGljYWJsZSBmb3IgTGludXggYW5kIFdpbmRvd3MuCisgICAgPC9wPgorICAgIDxvbD4K KyAgICAgIDxsaT5DbGljayB0aGUgdGV4dCBpbnB1dCBib3ggYmVsb3cgYW5kIHByZXNzIE1lbnUg a2V5LgorICAgICAgICAgIFRoZSB0ZXN0IHBhc3NlcyBpZiB5b3Ugc2VlICdQQVNTJyBiZWxvdy4K KyAgICAgICAgPGlucHV0IHR5cGU9InRleHQiIG9uY29udGV4dG1lbnU9ImxvZygnUEFTUycpOyIg Lz4KKyAgICAgIDwvbGk+CisgICAgICA8bGkgb25jb250ZXh0bWVudT0ibG9nKCdQQVNTJyk7Ij5D bGljayBvciBzZWxlY3Qgc29tZXdoZXJlCisgICAgICBpbiB0aGlzIHRleHQgYW5kIHByZXNzIE1l bnUga2V5LgorICAgICAgVGhlIHRlc3QgcGFzc2VzIGlmIHlvdSBzZWUgYWRkaXRpb25hbCAnUEFT UycgYmVsb3cuCisgICAgICA8L2xpPgorICAgIDwvb2w+CisgICAgPHVsIGlkPSJyZXN1bHRzIj48 L3VsPgorICA8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL0tleUNvZGVDb252ZXJzaW9uR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCmluZGV4IDU5NTBkZTEuLmUzZDVmNjEgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3Bw CkBAIC05MSw2ICs5MSw3IEBAIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2lnbmVk IGtleWNvZGUpCiAgICAgY2FzZSBHREtfQ29udHJvbF9SOgogICAgICAgICByZXR1cm4gVktFWV9D T05UUk9MOyAvLyAoMTEpIENUUkwga2V5CiAgICAgY2FzZSBHREtfTWVudToKKyAgICAgICAgcmV0 dXJuIFZLRVlfQVBQUzsgIC8vICg1RCkgQXBwbGljYXRpb25zIGtleSAoTmF0dXJhbCBrZXlib2Fy ZCkKICAgICBjYXNlIEdES19BbHRfTDoKICAgICBjYXNlIEdES19BbHRfUjoKICAgICAgICAgcmV0 dXJuIFZLRVlfTUVOVTsgLy8gKDEyKSBBTFQga2V5CkBAIC0yNjEsNyArMjYyLDYgQEAgaW50IHdp bmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQga2V5Y29kZSkKICAgICAgICAgcmV0dXJu IFZLRVlfTFdJTjsgLy8gKDVCKSBMZWZ0IFdpbmRvd3Mga2V5IChNaWNyb3NvZnQgTmF0dXJhbCBr ZXlib2FyZCkKICAgICBjYXNlIEdES19NZXRhX1I6CiAgICAgICAgIHJldHVybiBWS0VZX1JXSU47 IC8vICg1QykgUmlnaHQgV2luZG93cyBrZXkgKE5hdHVyYWwga2V5Ym9hcmQpCi0gICAgICAgIC8v IFZLRVlfQVBQUyAoNUQpIEFwcGxpY2F0aW9ucyBrZXkgKE5hdHVyYWwga2V5Ym9hcmQpCiAgICAg ICAgIC8vIFZLRVlfU0xFRVAgKDVGKSBDb21wdXRlciBTbGVlcCBrZXkKICAgICAgICAgLy8gVktF WV9TRVBBUkFUT1IgKDZDKSBTZXBhcmF0b3Iga2V5CiAgICAgICAgIC8vIFZLRVlfU1VCVFJBQ1Qg KDZEKSBTdWJ0cmFjdCBrZXkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2 ZW50R3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAppbmRleCA0 MTg2YzJmLi4zOTMxZWZmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVu dEd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCkBAIC0y MDAsNiArMjAwLDcgQEAgc3RhdGljIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2ln bmVkIGludCBrZXljb2RlKQogICAgICAgICBjYXNlIEdES19Db250cm9sX1I6CiAgICAgICAgICAg ICByZXR1cm4gVktfQ09OVFJPTDsgLy8gKDExKSBDVFJMIGtleQogICAgICAgICBjYXNlIEdES19N ZW51OgorICAgICAgICAgICAgcmV0dXJuIFZLX0FQUFM7ICAvLyAoNUQpIEFwcGxpY2F0aW9ucyBr ZXkgKE5hdHVyYWwga2V5Ym9hcmQpCiAgICAgICAgIGNhc2UgR0RLX0FsdF9MOgogICAgICAgICBj YXNlIEdES19BbHRfUjoKICAgICAgICAgICAgIHJldHVybiBWS19NRU5VOyAvLyAoMTIpIEFMVCBr ZXkKQEAgLTM3MCw3ICszNzEsNiBAQCBzdGF0aWMgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZl bnQodW5zaWduZWQgaW50IGtleWNvZGUpCiAgICAgICAgICAgICByZXR1cm4gVktfTFdJTjsgLy8g KDVCKSBMZWZ0IFdpbmRvd3Mga2V5IChNaWNyb3NvZnQgTmF0dXJhbCBrZXlib2FyZCkKICAgICAg ICAgY2FzZSBHREtfTWV0YV9SOgogICAgICAgICAgICAgcmV0dXJuIFZLX1JXSU47IC8vICg1Qykg UmlnaHQgV2luZG93cyBrZXkgKE5hdHVyYWwga2V5Ym9hcmQpCi0gICAgICAgICAgICAvLyBWS19B UFBTICg1RCkgQXBwbGljYXRpb25zIGtleSAoTmF0dXJhbCBrZXlib2FyZCkKICAgICAgICAgICAg IC8vIFZLX1NMRUVQICg1RikgQ29tcHV0ZXIgU2xlZXAga2V5CiAgICAgICAgICAgICAvLyBWS19T RVBBUkFUT1IgKDZDKSBTZXBhcmF0b3Iga2V5CiAgICAgICAgICAgICAvLyBWS19TVUJUUkFDVCAo NkQpIFN1YnRyYWN0IGtleQ== 41844 2009-10-25 22:38:39 -0700 2009-10-26 03:29:28 -0700 Fix for bug 30619: Menu key doesn't work on Linux bug-30619-20091026143837.patch text/plain 4326 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGVjNWEwOS4uNTkxOTQxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMC0yMSAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1ZyAzMDYxOTogW0xpbnV4XSBNZW51IGtleSBkb2Vzbid0IHdvcmsK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjE5CisK KyAgICAgICAgVGVzdDogbWFudWFsLXRlc3RzL2tleWJvYXJkLW1lbnVrZXktZXZlbnQuaHRtbAor ICAgICAgICBObyBuZXcgbGF5b3V0IHRlc3RzOiB0ZXN0aW5nIHRoaXMgd2lsbCByZXF1aXJlIGNo YW5nZXMgaW4gdGhlIHRlc3QKKyAgICAgICAgY29udHJvbGxlciBpbiBhIHBsYXRmb3JtLXNwZWNp ZmljIHdheS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252ZXJzaW9u R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQpOiBj aGFuZ2VkIHN3aXRjaC1jYXNlIGNvZGUgZm9yCisgICAgICAgIEdES19NZW51IHRvIHJldHVybiBW S0VZX0FQUFMgaW5zdGVhZCBvZiBWS0VZX01FTlUuCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0tl eUV2ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndpbmRvd3NLZXlDb2RlRm9yS2V5RXZl bnQpOiBjaGFuZ2VkIHN3aXRjaC1jYXNlIGNvZGUgZm9yCisgICAgICAgIEdES19NZW51IHRvIHJl dHVybiBWX0FQUFMgaW5zdGVhZCBvZiBWS19NRU5VLgorCiAyMDA5LTEwLTIxICBTYXRvc2hpIE5h a2FnYXdhICA8cHN5Y2hzQGxpbWVjaGF0Lm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRlc3RzL2tleWJvYXJkLW1lbnVr ZXktZXZlbnQuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2tleWJvYXJkLW1lbnVrZXktZXZl bnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5iZDJjOGU3Ci0tLSAv ZGV2L251bGwKKysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMva2V5Ym9hcmQtbWVudWtleS1ldmVu dC5odG1sCkBAIC0wLDAgKzEsMzEgQEAKKzxodG1sIGxhbmc9ImVuIj4KKyAgPGhlYWQ+CisgICAg PE1FVEEgSFRUUC1FUVVJVj0iQ09OVEVOVC1UWVBFIiBDT05URU5UPSJ0ZXh0L2h0bWw7IGNoYXJz ZXQ9VVRGLTgiPgorICAgIDx0aXRsZT5NZW51IGtleSB0ZXN0aW5nPC90aXRsZT4KKyAgICA8c2Ny aXB0IGxhbmd1YWdlPSJqYXZhc2NyaXB0IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAg ZnVuY3Rpb24gbG9nKHN0cikgeworICAgICAgICB2YXIgbGkgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCJsaSIpOworICAgICAgICBsaS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9k ZShzdHIpKTsKKyAgICAgICAgdmFyIHJlc3VsdHMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi cmVzdWx0cyIpOworICAgICAgICByZXN1bHRzLmFwcGVuZENoaWxkKGxpKTsKKyAgICAgIH0KKyAg ICA8L3NjcmlwdD4KKyAgPC9oZWFkPgorICA8Ym9keT4KKyAgICA8cD4KKyAgICBTZWUgYnVnOiA8 YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2MTkiPjMw NjE5PC9hPi4KKyAgICBOb3RlOiB0aGlzIHRlc3QgaXMgb25seSBhcHBsaWNhYmxlIGZvciBMaW51 eCBhbmQgV2luZG93cy4KKyAgICA8L3A+CisgICAgPG9sPgorICAgICAgPGxpPkNsaWNrIHRoZSB0 ZXh0IGlucHV0IGJveCBiZWxvdyBhbmQgcHJlc3MgTWVudSBrZXkuCisgICAgICAgICAgVGhlIHRl c3QgcGFzc2VzIGlmIHlvdSBzZWUgJ1BBU1MnIGJlbG93LgorICAgICAgICA8aW5wdXQgdHlwZT0i dGV4dCIgb25jb250ZXh0bWVudT0ibG9nKCdQQVNTJyk7IiAvPgorICAgICAgPC9saT4KKyAgICAg IDxsaSBvbmNvbnRleHRtZW51PSJsb2coJ1BBU1MnKTsiPkNsaWNrIG9yIHNlbGVjdCBzb21ld2hl cmUKKyAgICAgIGluIHRoaXMgdGV4dCBhbmQgcHJlc3MgTWVudSBrZXkuCisgICAgICBUaGUgdGVz dCBwYXNzZXMgaWYgeW91IHNlZSBhZGRpdGlvbmFsICdQQVNTJyBiZWxvdy4KKyAgICAgIDwvbGk+ CisgICAgPC9vbD4KKyAgICA8dWwgaWQ9InJlc3VsdHMiPjwvdWw+CisgIDwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNp b25HdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0 ay5jcHAKaW5kZXggNTk1MGRlMS4uZTNkNWY2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0ay5jcHAKQEAgLTkxLDYgKzkxLDcgQEAgaW50 IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQga2V5Y29kZSkKICAgICBjYXNlIEdE S19Db250cm9sX1I6CiAgICAgICAgIHJldHVybiBWS0VZX0NPTlRST0w7IC8vICgxMSkgQ1RSTCBr ZXkKICAgICBjYXNlIEdES19NZW51OgorICAgICAgICByZXR1cm4gVktFWV9BUFBTOyAgLy8gKDVE KSBBcHBsaWNhdGlvbnMga2V5IChOYXR1cmFsIGtleWJvYXJkKQogICAgIGNhc2UgR0RLX0FsdF9M OgogICAgIGNhc2UgR0RLX0FsdF9SOgogICAgICAgICByZXR1cm4gVktFWV9NRU5VOyAvLyAoMTIp IEFMVCBrZXkKQEAgLTI2MSw3ICsyNjIsNiBAQCBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVu dCh1bnNpZ25lZCBrZXljb2RlKQogICAgICAgICByZXR1cm4gVktFWV9MV0lOOyAvLyAoNUIpIExl ZnQgV2luZG93cyBrZXkgKE1pY3Jvc29mdCBOYXR1cmFsIGtleWJvYXJkKQogICAgIGNhc2UgR0RL X01ldGFfUjoKICAgICAgICAgcmV0dXJuIFZLRVlfUldJTjsgLy8gKDVDKSBSaWdodCBXaW5kb3dz IGtleSAoTmF0dXJhbCBrZXlib2FyZCkKLSAgICAgICAgLy8gVktFWV9BUFBTICg1RCkgQXBwbGlj YXRpb25zIGtleSAoTmF0dXJhbCBrZXlib2FyZCkKICAgICAgICAgLy8gVktFWV9TTEVFUCAoNUYp IENvbXB1dGVyIFNsZWVwIGtleQogICAgICAgICAvLyBWS0VZX1NFUEFSQVRPUiAoNkMpIFNlcGFy YXRvciBrZXkKICAgICAgICAgLy8gVktFWV9TVUJUUkFDVCAoNkQpIFN1YnRyYWN0IGtleQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCmluZGV4IDQxODZjMmYuLjM5MzFlZmYgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKQEAgLTIwMCw2ICsyMDAsNyBAQCBzdGF0aWMg aW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQgaW50IGtleWNvZGUpCiAgICAg ICAgIGNhc2UgR0RLX0NvbnRyb2xfUjoKICAgICAgICAgICAgIHJldHVybiBWS19DT05UUk9MOyAv LyAoMTEpIENUUkwga2V5CiAgICAgICAgIGNhc2UgR0RLX01lbnU6CisgICAgICAgICAgICByZXR1 cm4gVktfQVBQUzsgIC8vICg1RCkgQXBwbGljYXRpb25zIGtleSAoTmF0dXJhbCBrZXlib2FyZCkK ICAgICAgICAgY2FzZSBHREtfQWx0X0w6CiAgICAgICAgIGNhc2UgR0RLX0FsdF9SOgogICAgICAg ICAgICAgcmV0dXJuIFZLX01FTlU7IC8vICgxMikgQUxUIGtleQpAQCAtMzcwLDcgKzM3MSw2IEBA IHN0YXRpYyBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQga2V5Y29k ZSkKICAgICAgICAgICAgIHJldHVybiBWS19MV0lOOyAvLyAoNUIpIExlZnQgV2luZG93cyBrZXkg KE1pY3Jvc29mdCBOYXR1cmFsIGtleWJvYXJkKQogICAgICAgICBjYXNlIEdES19NZXRhX1I6CiAg ICAgICAgICAgICByZXR1cm4gVktfUldJTjsgLy8gKDVDKSBSaWdodCBXaW5kb3dzIGtleSAoTmF0 dXJhbCBrZXlib2FyZCkKLSAgICAgICAgICAgIC8vIFZLX0FQUFMgKDVEKSBBcHBsaWNhdGlvbnMg a2V5IChOYXR1cmFsIGtleWJvYXJkKQogICAgICAgICAgICAgLy8gVktfU0xFRVAgKDVGKSBDb21w dXRlciBTbGVlcCBrZXkKICAgICAgICAgICAgIC8vIFZLX1NFUEFSQVRPUiAoNkMpIFNlcGFyYXRv ciBrZXkKICAgICAgICAgICAgIC8vIFZLX1NVQlRSQUNUICg2RCkgU3VidHJhY3Qga2V5