30611 2009-10-20 17:36:06 -0700 Fix the crash when a node not in a document receives dispatchEvent. 2009-10-21 11:35:08 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned ap oldest_to_newest 156364 0 dimich 2009-10-20 17:36:06 -0700 The node that doesn't have a document (easy to repro with documentType node which is just created) crashes while trying to dispatchEvent. FireFox in similar scenario simply treats dispatchEvent() as noop. We should do the same. Patch is coming. 156368 1 41539 dimich 2009-10-20 17:52:55 -0700 Created attachment 41539 Proposed patch. 156420 2 41539 darin 2009-10-20 23:53:47 -0700 Comment on attachment 41539 Proposed patch. r=me 156574 3 dimich 2009-10-21 11:35:08 -0700 Landed: http://trac.webkit.org/changeset/49911 41539 2009-10-20 17:52:55 -0700 2009-10-20 23:53:47 -0700 Proposed patch. patch.txt text/plain 3677 dimich ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NTI4NDZkLi43Mjk1MGE4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MjAgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBjcmFzaCB3aGVuIGEgbm9k ZSBub3QgaW4gYSBkb2N1bWVudCByZWNlaXZlcyBkaXNwYXRjaEV2ZW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2MTEKKworICAgICAgICAqIGZh c3QvZXZlbnRzL2Rpc3BhdGNoLWV2ZW50LW5vLWRvY3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogZmFzdC9ldmVudHMvZGlzcGF0Y2gtZXZlbnQtbm8tZG9jdW1lbnQuaHRtbDog QWRkZWQuCisKIDIwMDktMTAtMTkgIEphc29uIFlhbiAgPHRhaWxvZnRoZXN1bkBnbWFpbC5jb20+ CiAgCiAgICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLWV2ZW50LW5vLWRvY3VtZW50LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLWV2ZW50LW5vLWRvY3VtZW50LWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hYzZiZDdhCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZGlzcGF0Y2gtZXZlbnQt bm8tZG9jdW1lbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorVGhlIHRlc3QgdmVyaWZp ZXMgdGhhdCBFdmVudFRhcmdldCB3aXRoIGFuIGV2ZW50IGxpc3RlbmVyIGJ1dCB3aXRob3V0IFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQgKG5vdCBpbnNlcnRlZCBpbnRvIERvY3VtZW50KSBkb2VzIG5v dCBjcmFzaCBkdXJpbmcgYW4gYXR0ZW1wdCB0byBkaXNwYXRjaCBhbiBldmVudC4gSXQgc2hvdWxk IGp1c3Qgbm90IGNhbGwgdGhlIGhhbmRsZXIuIFRoaXMgaXMgd2hhdCBGRiAzLjUgaXMgYWxzbyBk b2luZy4KKworVGVzdCBwYXNzZXMgaWYgdGhlcmUgaXMgbm8gY3Jhc2gsIGFuZCBldmVudCBpcyBu b3QgZGlzcGF0Y2hlZC4KKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvZGlzcGF0Y2gtZXZlbnQtbm8tZG9jdW1lbnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZl bnRzL2Rpc3BhdGNoLWV2ZW50LW5vLWRvY3VtZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uZDNlODQ4MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2Rpc3BhdGNoLWV2ZW50LW5vLWRvY3VtZW50Lmh0bWwKQEAgLTAsMCArMSwyNiBA QAorPHNjcmlwdD4KK2Z1bmN0aW9uIGhhbmRsZUV2ZW50KG1lc3NhZ2UpIHsKKyAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgibG9nIikuaW5uZXJIVE1MID0gIkZBSUw6ICIgKyBtZXNzYWdlICsg IiBoYW5kbGVkLjxicj4iOworfQorCitmdW5jdGlvbiB0ZXN0KCkgeworICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworICAgIH0KKworICAgIHZhciBkb2N0eXBlID0gZG9jdW1lbnQuaW1wbGVtZW50 YXRpb24uY3JlYXRlRG9jdW1lbnRUeXBlKAorICAgICAgICAnaHRtbCcsCisgICAgICAgICctLy9X M0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTicsCisgICAgICAgICdodHRwOi8vd3d3LnczLm9y Zy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkJworICAgICk7CisKKyAgICB2YXIgZXZ0 ID0gZG9jdW1lbnQuY3JlYXRlRXZlbnQoIkV2ZW50Iik7CisgICAgZXZ0LmluaXRFdmVudCgiZ2Vu ZXJpYyIsIHRydWUsIHRydWUpOworICAgIGRvY3R5cGUuYWRkRXZlbnRMaXN0ZW5lcigiZ2VuZXJp YyIsIGZ1bmN0aW9uICgpIHsgaGFuZGxlRXZlbnQoImdlbmVyaWMiKX0sIGZhbHNlKTsKKyAgICBk b2N0eXBlLmRpc3BhdGNoRXZlbnQoZXZ0KTsKK30KKzwvc2NyaXB0PgorPGJvZHkgb25sb2FkPSJ0 ZXN0KCkiPgorPHA+VGhlIHRlc3QgdmVyaWZpZXMgdGhhdCBFdmVudFRhcmdldCB3aXRoIGFuIGV2 ZW50IGxpc3RlbmVyIGJ1dCB3aXRob3V0IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgKG5vdCBpbnNl cnRlZCBpbnRvIERvY3VtZW50KSBkb2VzIG5vdCBjcmFzaCBkdXJpbmcgYW4gYXR0ZW1wdCB0byBk aXNwYXRjaCBhbiBldmVudC4gSXQgc2hvdWxkIGp1c3Qgbm90IGNhbGwgdGhlIGhhbmRsZXIuIFRo aXMgaXMgd2hhdCBGRiAzLjUgaXMgYWxzbyBkb2luZy48L3A+Cis8cD5UZXN0IHBhc3NlcyBpZiB0 aGVyZSBpcyBubyBjcmFzaCwgYW5kIGV2ZW50IGlzIG5vdCBkaXNwYXRjaGVkLjwvcD4KKzxkaXYg aWQ9ImxvZyI+UEFTUzwvZGl2PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCAwMzYyMDFhLi5iMjBkODkwIDEwMDY0NAotLS0gYS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5 LTEwLTIwICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgY3Jhc2ggd2hlbiBh IG5vZGUgbm90IGluIGEgZG9jdW1lbnQgcmVjZWl2ZXMgZGlzcGF0Y2hFdmVudC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjExCisKKyAgICAgICAg VGVzdDogZmFzdC9ldmVudHMvZGlzcGF0Y2gtZXZlbnQtbm8tZG9jdW1lbnQuaHRtbAorCisgICAg ICAgICogZG9tL0V2ZW50VGFyZ2V0LmNwcDogQ2hlY2sgZm9yIHNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQoKSBhdCB0aGUgbW9tZW50IG9mIGRpc3BhdGNoRXZlbnQ7IGRvIG5vdGhpbmcgaWYgbm8gY29u dGV4dC4KKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50VGFyZ2V0OjpkaXNwYXRjaEV2ZW50KToKKwog MjAwOS0xMC0xOSAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRXZl bnRUYXJnZXQuY3BwIGIvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuY3BwCmluZGV4IGNlYjUyMjEu LjYyNTlhMGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmNwcAorKysgYi9X ZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAKQEAgLTIzMiw2ICsyMzIsMTAgQEAgYm9vbCBFdmVu dFRhcmdldDo6ZGlzcGF0Y2hFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBldmVudCwgRXhjZXB0aW9u Q29kZSYgZWMpCiAgICAgICAgIGVjID0gRXZlbnRFeGNlcHRpb246OlVOU1BFQ0lGSUVEX0VWRU5U X1RZUEVfRVJSOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQorCisgICAgaWYgKCFzY3Jp cHRFeGVjdXRpb25Db250ZXh0KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIHJldHVy biBkaXNwYXRjaEV2ZW50KGV2ZW50KTsKIH0KIAo=