30609 2009-10-20 16:59:31 -0700 [V8] ScriptString leaks ScriptStringImpls due to RefPtr fail 2009-10-20 17:09:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jamesr webkit-unassigned commit-queue oldest_to_newest 156343 0 41536 jamesr 2009-10-20 16:59:31 -0700 Created attachment 41536 Fix The initialization of ScriptString's m_impl RefPtr<ScriptStringImpl> member variable is wrong and initializes the refCount on the ScriptStringImpl to 2, so it never gets deleted. 156347 1 41536 commit-queue 2009-10-20 17:09:00 -0700 Comment on attachment 41536 Fix Clearing flags on attachment: 41536 Committed r49892: <http://trac.webkit.org/changeset/49892> 156348 2 commit-queue 2009-10-20 17:09:03 -0700 All reviewed patches have been landed. Closing bug. 41536 2009-10-20 16:59:31 -0700 2009-10-20 17:09:00 -0700 Fix fix_refptr.diff text/plain 2808 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2MwYWJhZC4uMjI5YzJmMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMC0yMCAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeGVzIFJlZlB0ciBpbml0aWFsaXphdGlvbiBpbiB0aGUgVjgg aW1wbGVtZW50YXRpb24gb2YgV2ViQ29yZTo6U2NyaXB0U3RyaW5nIHRvIHVzZSB0aGUgOjpjcmVh dGUoKSBpZGlvbSBhbmQKKyAgICAgICAgdXNlIGFkb3B0UmVmKCkgcHJvcGVybHkuICBJIGZhaWxl ZCB0byByZWFkIHRoZSBSZWZQdHIgZG9jcyB0aGUgZmlyc3QgdGltZSB0aHJvdWdoIDooCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBlcnJvciB3YXMgY2F1Z2h0IGJ5IHZhbGdyaW5kIG9uIHRoZSBD aHJvbWl1bSBidWlsZGVycy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFN0cmluZy5o OgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0U3RyaW5nOjpTY3JpcHRTdHJpbmcpOgorICAgICAg ICAoV2ViQ29yZTo6U2NyaXB0U3RyaW5nOjpvcGVyYXRvcj0pOgorICAgICAgICAqIGJpbmRpbmdz L3Y4L1NjcmlwdFN0cmluZ0ltcGwuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFN0cmluZ0lt cGw6OmNyZWF0ZSk6CisKIDIwMDktMTAtMjAgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRTdHJpbmcuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2Ny aXB0U3RyaW5nLmgKaW5kZXggYjAxN2EwYy4uNDE0ODE4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRTdHJpbmcuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Njcmlw dFN0cmluZy5oCkBAIC00MCw4ICs0MCw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFNj cmlwdFN0cmluZyB7CiBwdWJsaWM6CiAgICAgU2NyaXB0U3RyaW5nKCkgOiBtX2ltcGwoMCkge30K LSAgICBTY3JpcHRTdHJpbmcoY29uc3QgU3RyaW5nJiBzKSA6IG1faW1wbChuZXcgU2NyaXB0U3Ry aW5nSW1wbChzKSkge30KLSAgICBTY3JpcHRTdHJpbmcoY29uc3QgY2hhciogcykgOiBtX2ltcGwo bmV3IFNjcmlwdFN0cmluZ0ltcGwocykpIHt9CisgICAgU2NyaXB0U3RyaW5nKGNvbnN0IFN0cmlu ZyYgcykgOiBtX2ltcGwoU2NyaXB0U3RyaW5nSW1wbDo6Y3JlYXRlKHMpKSB7fQorICAgIFNjcmlw dFN0cmluZyhjb25zdCBjaGFyKiBzKSA6IG1faW1wbChTY3JpcHRTdHJpbmdJbXBsOjpjcmVhdGUo cykpIHt9CiAKICAgICBvcGVyYXRvciBTdHJpbmcoKSBjb25zdCB7IHJldHVybiBtX2ltcGwtPnRv U3RyaW5nKCk7IH0KIApAQCAtNTAsNyArNTAsNyBAQCBwdWJsaWM6CiAKICAgICBTY3JpcHRTdHJp bmcmIG9wZXJhdG9yPShjb25zdCBjaGFyKiBzKQogICAgIHsKLSAgICAgICAgbV9pbXBsID0gbmV3 IFNjcmlwdFN0cmluZ0ltcGwocyk7CisgICAgICAgIG1faW1wbCA9IFNjcmlwdFN0cmluZ0ltcGw6 OmNyZWF0ZShzKTsKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTdHJpbmdJbXBsLmggYi9XZWJDb3JlL2JpbmRpbmdz L3Y4L1NjcmlwdFN0cmluZ0ltcGwuaAppbmRleCA1ZmFmMGJhLi44YTQ3YjRmIDEwMDY0NAotLS0g YS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFN0cmluZ0ltcGwuaAorKysgYi9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdFN0cmluZ0ltcGwuaApAQCAtNDYsOSArNDYsMTUgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogLy8gVGhpcyBpbXBsZW1lbnRhdGlvbiBvcHRpbWl6ZXMgZm9yIHRoZSBjb21t b24gY2FzZSB3aGVyZSB0aGUgcmVzcG9uc2VUZXh0IGlzIGJ1aWx0IHVwIHdpdGggbWFueSBjYWxs cyB0byBvcGVyYXRvcis9IGJlZm9yZSB0aGUgYWN0dWFsIHRleHQgaXMgcXVlcmllZC4KIGNsYXNz IFNjcmlwdFN0cmluZ0ltcGwgOiBwdWJsaWMgUmVmQ291bnRlZDxTY3JpcHRTdHJpbmdJbXBsPiB7 CiBwdWJsaWM6Ci0gICAgU2NyaXB0U3RyaW5nSW1wbCgpIHt9Ci0gICAgU2NyaXB0U3RyaW5nSW1w bChjb25zdCBTdHJpbmcmIHMpOwotICAgIFNjcmlwdFN0cmluZ0ltcGwoY29uc3QgY2hhciogcyk7 CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2NyaXB0U3RyaW5nSW1wbD4gY3JlYXRlKGNvbnN0IFN0 cmluZyYgcykKKyAgICB7CisgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2NyaXB0U3RyaW5n SW1wbChzKSk7CisgICAgfQorCisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2NyaXB0U3RyaW5nSW1w bD4gY3JlYXRlKGNvbnN0IGNoYXIqIHMpCisgICAgeworICAgICAgICByZXR1cm4gYWRvcHRSZWYo bmV3IFNjcmlwdFN0cmluZ0ltcGwocykpOworICAgIH0KIAogICAgIFN0cmluZyB0b1N0cmluZygp IGNvbnN0OwogCkBAIC02MCw2ICs2Niw5IEBAIHB1YmxpYzoKICAgICB2ODo6SGFuZGxlPHY4OjpT dHJpbmc+IHY4U3RyaW5nSGFuZGxlKCkgeyByZXR1cm4gbV9oYW5kbGUuZ2V0KCk7IH0KIAogcHJp dmF0ZToKKyAgICBTY3JpcHRTdHJpbmdJbXBsKGNvbnN0IFN0cmluZyYgcyk7CisgICAgU2NyaXB0 U3RyaW5nSW1wbChjb25zdCBjaGFyKiBzKTsKKwogICAgIE93bkhhbmRsZTx2ODo6U3RyaW5nPiBt X2hhbmRsZTsKIH07CiAK